minutes of ESC call ...

* Present:
    + Caolan, Christian, Heiko, Kendy, JanI, Olivier, Xisco, Michael M,
      Sophie, Stephan, Miklos, Bjoern, Bubli, Eike, Norbert

* Completed Action Items:
    + dig out online E-mail from Andras & put on-line (Cloph)
       [ re-built the package to mend it (Timar) ]
    + mass conversion of helpcontent (Cloph)
       [ Translations are done; one thing left the xmllang default attribute change ]

* Pending Action Items:

* Release Engineering update (Christian)
    + 5.4.0 Beta 1 May 16th
      + tagged and up-loaded the beta build to early testing.
      + late features
        + Windows support for gpg sign/encrypt (Thorsten)
           + merged & reverted – with some issues in Jenkins.
    + 5.4.0 Beta 2 – June 6th
      + no additional reviews necessary on the branch, can push yourself until June 20th
    + 5.3.4 RC1 – after next week – May 30th
      + looking forward to seeing the crash / gdi fixes (Michael)
    + Android & iOS Remote
    + online
      + Andras is preparing the branch
    + problems with replication to freedesktop
      + guillhelm looking at gerrit – leaking file-descriptors ?

* Documentation (Olivier)
    + lots of encouraging contributions this week.
    + Patches, patches patches in helpcontent (tdf#84675)
        + fixes from translators (HC)
        + Nice HC contributions by Gabor Kelemen, Laurent Balland-Poirier, Cloph

* UX Update (Heiko)
   + Bugzilla (topicUI) statistics
        256(256) (topicUI) bugs open, 465(465) (needsUXEval) needs to be evaluated by the UXteam
    + Updates:
        BZ changes 1 week 1 month 3 months 12 months
             added 5(1) 15(3) 37(4) 465(-2)
         commented 60(20) 209(44) 546(11) 3517(-7)
           removed 0(0) 3(0) 7(0) 41(-1)
          resolved 2(0) 11(-1) 49(-29) 230(0)
    + top 10 contributors:
          Philips, Yousuf made 198 changes in 1 month, and 1371 changes in 1 year
          Tietze, Heiko made 52 changes in 1 month, and 2013 changes in 1 year
          Buovjaga made 48 changes in 1 month, and 383 changes in 1 year
          Foote, V Stuart made 36 changes in 1 month, and 653 changes in 1 year
          Thomas Lendo made 25 changes in 1 month, and 110 changes in 1 year
          Iversen, Jan made 18 changes in 1 month, and 335 changes in 1 year
          Telesto made 14 changes in 1 month, and 58 changes in 1 year
          Faulí Tarazona, Xisco made 13 changes in 1 month, and 412 changes in 1 year
          Henschel, Regina made 13 changes in 1 month, and 129 changes in 1 year
          LibreTraining made 12 changes in 1 month, and 51 changes in 1 year

    + vacation is impossible
        + returning had – 1000 mails/w :wink:
    + heated discussion about image compression, when, how, what tdf#34133
       + made a proposal on the workflow; pro. user feedback
       + if people want to know how these are compressed – poke the ticket.
       + auto-compressing images etc.
    + planning survey on default page margins – 2cm currently
       + what default do people want ?
    + desire to have a commmon goal / strategy / headline for (major) releases
      in the design team, e.g. bugfixing, notebookbar, dialogs...
       + “we all work on XYZ topic”
          + doomed as an approach, unless it’s just marketing (Michael)
             + like post-rationalization eg. MUFFIN.
             + agreed (Bjoern)
                 + without power to commit resources, not wise to promise

* Crash Reporting (Caolan)
    + 2(+0) import failure, 0(+0) export failures
       + need to spend some time on crash testing to find these 2.
    + 49 coverity issues (down)
    + Google / ossfuzz: unchanged no fuzzers active now, ww6 added, ww8 smoketesting
       + fixed a local crasher in ww8 – to add to queue in next few days.
       + PPT has just one version, looking good. Excel pending.
       + docx, and ODF formats pending.
       + coming to the end here (hopefully)
    + results depend on the input ? (Xisco)
       + they find their own input (Caolan)
          + using minimal set of documents – that exercises most of LibreOffice
          + using the corpus minimiser from AFL – to get smallest set that maximises
            that space.
          + http://dev-www.libreoffice.org/corpus/

* Hackfests (Bjoern)
    + next venues / suggestions
    + Ladies who FOSS ? (Bubli)
    + Italian hack-fest coming up: 4 days May 27-30th
         + Expectation match on Presentations etc.
             + no idea wrt. Presentations (Eike)
AI: + ask Osvaldo for an agenda (Eike)
         + Perugia University
             + https://wiki.documentfoundation.org/Hackfest/Perugia2017
                + Eike, Miklos, Cloph signed up.
                + Bjoern can’t come sadly.
    + Berlin meeting (Bubli)
        + Hamburg meeting exploded so to Berlin.
        + German community event
        + Weekend of June 23 → 25 – Friday → Sun.
    + Open Tech Summit (Heiko)
        + May/25 Potsdam
        + http://opentechsummit.net/
        + Heiko presenting there, in open source
    + openExpo in Madrid June 1st
        + http://www.openexpo.es
        + jani participates – poke him to meet up there.

* mentoring/easyhack update
         committer... 1 week 1 month 3 months 12 months
                  open 80(5) 136(26) 141(-3) 147(-4)
               reviews 521(35) 1741(132) 4644(6) 17132(39)
                merged 178(-36) 823(-39) 2585(-41) 10215(-23)
             abandoned 10(5) 44(3) 150(-6) 626(1)
           own commits 367(22) 1425(23) 4842(-15) 16949(-47)
        review commits 87(8) 276(46) 1033(41) 3531(36)
        contributor... 1 week 1 month 3 months 12 months
                  open 49(34) 63(25) 64(10) 66(11)
               reviews 573(54) 1827(35) 5432(-64) 19795(49)
                merged 40(10) 119(19) 443(24) 1086(20)
             abandoned 8(8) 18(5) 70(0) 240(4)
           own commits 31(-5) 118(10) 374(18) 859(11)
        review commits 0(0) 0(0) 0(0) 0(0)
    + easyHack statistics:
       needsDevEval 24(24) needsUXEval 0(0) cleanup_comments 194(194)
       total 235(235) assigned 20(20) open 187(187)
    + top 5 contributors:
          Carl, Jens made 38 patches in 1 month, and 68 patches in 1 year
          Johnny_M made 9 patches in 1 month, and 26 patches in 1 year
          Gelmini, Andrea made 8 patches in 1 month, and 99 patches in 1 year
          Zu Ximeng made 8 patches in 1 month, and 11 patches in 1 year
          Kumar, Rohan made 5 patches in 1 month, and 20 patches in 1 year
    + top 5 reviewers:
          Holešovský, Jan made 251 review comments in 1 month, and 679 in 1 year
          Stahl, Michael made 240 review comments in 1 month, and 1351 in 1 year
          Mohrhard, Markus made 119 review comments in 1 month, and 1735 in 1 year
          Rathke, Eike made 106 review comments in 1 month, and 1357 in 1 year
          Behrens, Thorsten made 98 review comments in 1 month, and 457 in 1 year
    + big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
          Ilmari Lauhakangas ilmari.lauhakangas@libreoffice.org
          Olivier R olivier.dev@grammalecte.net
          AlexeyVlasov alexey.vlasov.work@gmail.com
          Piotr Drąg piotrdrag@gmail.com
          Catherine Vance catvance77@gmail.com
          Jim Raykowski raykowj@gmail.com
          Viscido Viscido marcoviscido@gmail.com
* GSoC update (Thorsten)
    + timeline:
         + Currently in community bonding period.
             + encourage people to write weekly reports from now, whatever the content.
         + May 29: last day to report inactive students
             + how to do that ? (Kendy)
                + talk to Thorsten / Markus / JanI (Thorsten)
                + if there are any problems.
         + May 30: coding begins
         + June 26-30: first eval
         + July 24 - second eval
         + August 21- 29: pens down, wrap up
         + August 29 - September 5: final evaluations of students
         + September 6: passing projects announced

* crash reporter news (Xisco)
    + http://crashreport.libreoffice.org/stats/?days=128
    + http://crashreport.libreoffice.org/stats/version/5.3.2.2
        + 3656(-516) (last 7 days)
        + need to update to 5.3.3 next week.
    + http://crashreport.libreoffice.org/stats/version/5.2.6.2
        + 2414(+86) (last 7 days)

    + GDI resource starvation
        + more fixes coming … VclPtr wake-up / refresher.
        + disposeAndClear() is your friend.

    + Crash in: SfxItemPool::Put(SfxPoolItem const &,unsigned short)
    + https://bugs.documentfoundation.org/show_bug.cgi?id=106424
   + Crash number #1 in 5.2.6.2 and #4 in 5.3.2.2
   + Jochen Nitschke submited a patch in gerrit
         https://gerrit.libreoffice.org/#/c/37499/
           + Thanks for reviews from Caolan, Michael S, Oliver

* Commit Access
    + Cosmetic change issues – churning code without much benefit
       + asked to avoid this, but this continues.
    + write a last warning ? (Michael)
       + always a balance between cosmetic and functional changes (Miklos)
          + might help.
       + ok with last warning (Stephan)
       => do that (Michael)

* Developer Certification (Stephan/Bjoern/Kendy/Thorsten)
    + 0 week sleep → ping ping ping …
AI: + do some work (Stephan/Bjoern/Kendy/Thorsten)

* Jenkins / CI update (Norbert)
    master linux rel jobs: 185 ok: 172 ko: 13 fail ratio: 7.03 % break: 3 broken duration: 7.25%
    master linux dbg jobs: 168 ok: 137 ko: 29 fail ratio: 17.26 % break: 5 broken duration: 8.82%
    master mac rel jobs: 146 ok: 142 ko: 4 fail ratio: 2.74 % break: 3 broken duration: 2.16%
    master mac dbg jobs: 142 ok: 138 ko: 3 fail ratio: 2.11 % break: 2 broken duration: 1.42%
    master win rel jobs: 146 ok: 110 ko: 36 fail ratio: 24.66 % break: 12 broken duration: 9.21%
    master win dbg jobs: 141 ok: 110 ko: 31 fail ratio: 21.99 % break: 4 broken duration: 3.85%
    master win64 dbg jobs: 149 ok: 122 ko: 27 fail ratio: 18.12 % break: 5 broken duration: 3.71%
    lo-5.2 mac jobs: 0 ok: 0 ko: 0 fail ratio: 0.00 % break: 0 broken duration: 0.00%
    lo-5.3 mac jobs: 12 ok: 12 ko: 0 fail ratio: 0.00 % break: 0 broken duration: 0.00%

* Gerrit down-time (Cloph)
    + midnight tonight planned to be down for 30mins or so, to re-boot.
    + Norbert triggered a garbage-collection too.

* l10n (Sophie)
   + lots of good work is ongoing, big string backlog, particularly in help.

* List of uno command (Heiko)
   + a request by the design team – what commands we have, and how they are organized
   + Xisco found a link to the wiki:
      + https://wiki.documentfoundation.org/Development/DispatchCommands
      + lacks info on tooltips / shortcuts etc.
      + want to see what keys are associated with what (Heiko)
         + would like to see what’s there & sort by what is used.
      + Q’ of how notebook bars are generated.
   + Generated by a script (Bubli)
      + used to be PHP, now python – parses xcs, sdi etc.
      + Samuel mentored work here, and knows the score:
         + he is back from parental leave in 2 weeks.
      + bin/list-dispatch-commands.py
         + can include keybindings from uiconfig/accelerators files.
   + Warning: can’t fix typos in commands (Bjoern)
      + part of the published ABI and API – so, beware of ‘fixes’
       that would ‘just rename’ something etc. scripts and config
       use these names a lot.
    + Editing it manually is not a great plan (Michael)
       + duplicating data in a different place etc.
       + already have api.libreoffice.org and docs.libreoffice.org (Bjoern)
          + put this together to generate things that go there.
          + host it outside the wiki ?
    + Just needs a bit more scripting (Michael)
       + add tool-tips from the source, and accelerators too (Heiko)
       + command scheme files have descriptions for the commands (Eike)
       + happy to work with Heiko (Olivier)

* Screenshots (Olivier)
    + talked on IRC with Bubli
    + would be nice to have screenshots generated at installation
      time on users’ desktops.
    + would spare lots of space wrt. Downloads, and spare translation, etc.
       + desktop integration / theming correct too.
    + thought about it (Bubli)
       + screenshots generated with cppunit
       + tries to open all the dialogs & saves these as a side-effect
       + run-time dependency on cppunittest is not ideal.
       + concern wrt. User seeing flashing windows on the screen.
    + could download them on demand from TDF infrastructure, matching
      users language & OS as an alternative (Bubli)
       + sounds no different to downloading ahead of time (Olivier)
       + not so work-able (Cloph)
          + needs a pack of the images for those not wanting network traffic.
    + why are we still flashing windows ? (Michael)
       + like the idea – but doesn’t blend so well with existing impl. (Thorsten)
       + going fwd. as people use on-line help. Is it urgent ?
    + have a look at this idly (Olivier)
AI: + quantify the potential size saving (Olivier)

* Proposals for 4.5 deprecated section (Eike)
    + paste the list to next week’s ESC and discuss (Thorsten)

* QA update (Xisco)

    + UNCONFIRMED: 459 (+9)
        + enhancements: 51 (+3)
        + needsUXEval: 4 (-1)
        + haveBackTrace: 11 (+0)
        + needsDevAdvice: 37 (+2)
        + documentation: 1 (+1)

    + Most Pressing Bugs: http://tdf.io/mostressingbugs

    + New:
          + CRASH: when opening Edit Style for a shape
               + https://bugs.documentfoundation.org/show_bug.cgi?id=107860
               + apparently windows specific, will provide a trace (vs. master)

    + Older:
           + MAILMERGE: Crash while saving new document
                + https://bugs.documentfoundation.org/show_bug.cgi?id=107729
      + Introduced in mailmerge refactoring – Kendy.

          + Crash in: SalFrame::SetCallback(vcl::Window *,bool (*)(...
               + https://bugs.documentfoundation.org/show_bug.cgi?id=107023
               + another gdi leak

           + MailMerge: Writer crashes using wizard 2nd time through
                + https://bugs.documentfoundation.org/show_bug.cgi?id=105002
      + Lifecycle issue in mail-merge (Noel?)
                    + C++ expert advice appreciated in the bug …
                    + can give some advice (Stephan)

    + Fixed:
          + Scrolling font list with previews enabled makes LO crash ( steps in comment 36 )
                + https://bugs.documentfoundation.org/show_bug.cgi?id=106265
                + thanks to Tomaz.

      + CRASH: Libreoffice crashes while inserting the header/footer in a document
                + https://bugs.documentfoundation.org/show_bug.cgi?id=107568
                + thanks to Michael S.
       + Fixed other crashes as well

      + Writer crashes immediately after opening this .docx in Windows 7
                + https://bugs.documentfoundation.org/show_bug.cgi?id=106161
                + thanks to Michael S.
       + Fixed by the same commit as https://bugs.documentfoundation.org/show_bug.cgi?id=107568

      + CRASH: Crash when closing Calc document
                + https://bugs.documentfoundation.org/show_bug.cgi?id=107706
                + thanks to Noel Grandin.

      + CRASH Opening macro tab of properties dialog (images, frames) causes crash
                + https://bugs.documentfoundation.org/show_bug.cgi?id=107847
                + thanks to Maxim Monastirsky.

* QA stats
    + https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
      +172 -16 (-112) overall)
      many thanks to the top bug squashers:
       Xisco Faulí 12
       Buovjaga 11
       Julien Nabet 6
       V Stuart Foote 6
       Maxim Monastirsky 5
       Yousuf Philips (jay) 5
       Alex Thurgood 5
       Justin L 4
       Markus Mohrhard 4
       Gabor Kelemen 3
       Cor Nouws 3
       Aron Budea 3
       Caolán McNamara 3
       Michael Stahl 3
       Laurie Lang 2

    + top 10 bugs reporters:
       Yousuf Philips (jay) 26
       Telesto 11
       Markus Mohrhard 4
       Christian Nieber 4
       Thomas Lendo 4
       Aron Budea 3
       Howard Johnson 3
       Regina Henschel 3
       Xisco Faulí 3
       Kevin 2
       V Stuart Foote 2
       Hamid 2
       Roland Illig 2
       Cor Nouws 2
       Darius Daniel Grigoras 2

    + top 10 bugs fixers:
       Yousuf Philips (jay) 26
       Telesto 11
       Markus Mohrhard 4
       Christian Nieber 4
       Thomas Lendo 4
       Aron Budea 3
       Howard Johnson 3
       Regina Henschel 3
       Xisco Faulí 3
       Kevin 2
       V Stuart Foote 2
       Hamid 2
       Roland Illig 2
       Cor Nouws 2
       Darius Daniel Grigoras 2

* Highest-Priority bugs (aka "MABs"):
   + http://bit.ly/2lJAAJI
     5.3 : 4/39 - 10 % (+0)
     5.2 : 3/34 - 8 % (-4)
     5.1 : 2/34 - 5 % (+0)
     5.0 : 2/60 - 3 % (+0)
     4.4 : 4/75 - 5 % (+0)
     4.3 : 5/72 - 6 % (+0)
     4.2 : 6/133 - 4 % (+0)
     4.1 : 4/81 - 4 % (+0)
     4.0 : 4/81 - 4 % (+0)
     old : 27/255 - 10 % (+0)

* Bisected bugs open: keyword 'bisected'
   + more accurate - down to a single commit.
   + http://bit.ly/2dyIfDy
   + 377/1395 371/1380 374/1374 373/1366 370/1360 371/1357 364/1347

     done by:
        Faulí Tarazona, Xisco 8
        Raal 3
        Justin L 2
        Terrence Enger 1

* Bibisected bugs open: keyword 'bibisected'
   + http://bit.ly/2cSCXlS
   + 466/1964 453/1941 455/1933 453/1921 449/1914 449/1910 440/1897

     done by:
        Faulí Tarazona, Xisco 10
        Terrence Enger 5
        Raal 4
        Justin L 2
        Monastirsky, Maxim 1

* all bugs tagged with 'regression'
   + 820(+10) bugs open of 5973(+25) total 11(-1) high prio.

     done by:
        Faulí Tarazona, Xisco 6
        tommy27 3
        Buovjaga 2
        Telesto 2
        Philips, Yousuf 2
        Justin L 2
        Jacques Guilleron 1
        Terrence Enger 1
        Holešovský, Jan 1
        Stahl, Michael 1

* ~Component count net * high severity regressions
   + http://bit.ly/1HWHb3E
     LibreOffice - 3(-1)
     Impress - 2(+0)
     Base - 2(+0)
     Writer - 2(+0)
     Extensions - 1(+0)
     Calc - 1(+0)

   by OS:
     All - 4(+1)
     Mac OS X - 5(+0)
     Windows - 1(-2)
     Linux - 1(+0)

* ~Component count net * all regressions
   + http://bit.ly/1BUdI8i
     Writer: other - 137(+0)
     Calc - 123(+2)
     Impress - 80(+1)
     Writer: docx filter - 73(+2)
     LibreOffice - 62(+2)
     UI - 50(+1)
     Writer: doc filter - 41(+0)
     graphics stack - 35(+0)
     Base - 32(+1)
     Draw - 31(-1)
     Borders - 30(+0)
     Writer: other filter - 27(+0)
     filters and storage - 24(+2)
     Writer: perf - 23(+0)
     Crashes - 21(+2)
     Chart - 20(+0)
     Printing and PDF export - 17(+0)
     BASIC - 13(-1)
     Extensions - 5(+0)
     framework - 3(-1)
     Installation - 2(+1)
     Linguistic - 1(+0)