ESC meeting minutes: 2024-07-11

[vmiklos]

• Present:

  • Caolan, Heiko, Hossein, Ilmari, Jonathan, Michael W, Olivier, Stephan, Cloph, Michael S, Xisco, Stephane, Miklos

• Completed Action Items:

• Pending Action Items:

• Release Engineering update (Cloph)

  • 24.8.0 rc1 is out and rc2 in 2 weeks
    • libreoffice-24-8 now needs 1 review
  • 24.2.5 rc2 accounced today
    • 24.2.6 rc1 in 5 weeks, as a current plan

• Documentation (Olivier)

  • Helpcontents2
    • Refactor pages on Styles (D, Maddern)
    • Housekeeping (ohallot, Pierre F, buovjaga, J. Nabet, A Gelmini)
    • New pages on VBA ( A. Romedenne)
  • Guides
    • Updates in Getting started 24.8, anticipating next release
    • Guides “SanityCheck.oxt” extension by @bantoniof
  • Bugzilla Documentation statistics
    247(247) bugs open
  • Updates:
    BZ changes 1 week 1 month 3 months 12 months
    created 8(7) 23(-2) 93(-1) 233(1)
    commented 13(12) 64(-9) 231(1) 900(10)
    resolved 4(3) 13(-2) 61(-1) 140(0)
  • top 10 contributors:
    Olivier Hallot made 30 changes in 1 month, and 267 changes in 1 year
    Raal made 12 changes in 1 month, and 16 changes in 1 year
    Kaganski, Mike made 11 changes in 1 month, and 76 changes in 1 year
    Justin Luth made 8 changes in 1 month, and 10 changes in 1 year
    Stéphane Guillou made 8 changes in 1 month, and 210 changes in 1 year
    Heiko Tietze made 6 changes in 1 month, and 88 changes in 1 year
    m.a.riosv made 6 changes in 1 month, and 23 changes in 1 year
    UNKNOWN made 5 changes in 1 month, and 5 changes in 1 year
    Rafael Lima made 5 changes in 1 month, and 80 changes in 1 year
    Ilmari Lauhakangas made 4 changes in 1 month, and 85 changes in 1 year

• UX Update (Heiko)

  • Bugzilla (topicUI) statistics
    238(238) (topicUI) bugs open, 29(29) (needsUXEval) needs to be evaluated by the UXteam
  • Updates:
    BZ changes 1 week 1 month 3 months 12 months
    added 4(2) 7(0) 10(-1) 17(-1)
    commented 52(17) 162(21) 464(15) 1760(8)
    removed 0(0) 2(0) 5(-1) 10(-1)
    resolved 4(2) 22(-7) 76(-1) 290(0)
  • top 10 contributors:
    Heiko Tietze made 93 changes in 1 month, and 968 changes in 1 year
    Vernon, Stuart Foote made 52 changes in 1 month, and 337 changes in 1 year
    Stéphane Guillou made 30 changes in 1 month, and 602 changes in 1 year
    Eyal Rozenberg made 27 changes in 1 month, and 165 changes in 1 year
    Dieter made 26 changes in 1 month, and 157 changes in 1 year
    Ady made 23 changes in 1 month, and 123 changes in 1 year
    Ilmari Lauhakangas made 13 changes in 1 month, and 138 changes in 1 year
    Kira Tubo made 11 changes in 1 month, and 28 changes in 1 year
    Kaganski, Mike made 9 changes in 1 month, and 75 changes in 1 year
    Cor Nouws made 6 changes in 1 month, and 25 changes in 1 year
  • [Bug 161934] “Top 10” item in Autofilter filter drop-down is ambiguous
  • [Bug 137879] LO should know not to try and recover temporary files
    → + [Bug 161978] Suppress editing of comments from other authors
    • also not deleting comment of others would be nice (Miklos)
  • [Bug 161956] Overhaul terminology on the “Text along Path” dialog
    → + [Bug 161950] Setting to add XY shift to pasted drawing etc. objects
  • [Bug 161949] When toggling an item in toolbar context menu > Visible Buttons
    - keep the menu open

• Crash Testing (Caolan)

  • 26(+0) import failure, 21(+0) export failures
    • Development/Crashtesting - The Document Foundation Wiki
  • 1770 coverity issues
  • 10 ossfuzz issues
    • 1 3rd party crash, 8 Timeouts, 1 OOM

• Crash Reporting (Xisco)

  • 24.2.1.2 18736(+429)
  • 24.2.2.2 17308(+649)
  • 24.2.3.2 14344(+840)
  • 24.2.4.2 7073(+1958)

• Mentoring (Hossein)

  • New EasyHack from Mike K. to drop Fraction class from tools
    161837 – Drop Fraction class from tools
  • tools → options, a sub-page there that opens an inner dialog?

    • Security → Macro security opens an inner dialog, for example (Miklos)

    • will ask on the dev mailing list (Hossein)

       committer...   1 week     1 month     3 months    12 months
               open     117(2)      201(-7)     205(-6)      205(-6)
            reviews     406(-96)   1774(24)    3554(96)    13034(36)
             merged     319(5)     1394(119)   3521(122)   12767(14)
          abandoned      25(5)       86(-2)     204(14)      723(22)
        own commits     226(60)     846(93)    2443(98)     9372(46)
      

      review commits 36(-21) 303(-5) 742(-12) 3084(-16)
      contributor… 1 week 1 month 3 months 12 months
      open 41(1) 100(8) 104(11) 104(11)
      reviews 944(-40) 3456(212) 7958(220) 29646(24)
      merged 12(-29) 124(-1) 280(-11) 1581(-8)
      abandoned 9(1) 26(-1) 87(-13) 715(-2)
      own commits 11(-24) 134(-3) 317(-18) 1204(-5)
      review commits 0(0) 0(0) 0(0) 0(0)

    • easyHack statistics:
      needsDevEval 9(9) needsUXEval 1(1) cleanup_comments 324(324)
      total 409(409) assigned 23(23) open 352(352)

    • top 10 contributors:
      Bogdan B made 65 patches in 1 month, and 84 patches in 1 year
      Weblate made 5 patches in 1 month, and 33 patches in 1 year
      Ritobroto Mukherjee made 5 patches in 1 month, and 22 patches in 1 year
      Srebotnjak, Martin made 4 patches in 1 month, and 21 patches in 1 year
      Pierre F made 4 patches in 1 month, and 28 patches in 1 year
      Theppitak Karoonboonyanan made 3 patches in 1 month, and 4 patches in 1 year
      Kira Tubo made 3 patches in 1 month, and 17 patches in 1 year
      Stéphane Guillou made 2 patches in 1 month, and 62 patches in 1 year
      Adam Seskunas made 2 patches in 1 month, and 16 patches in 1 year
      made 2 patches in 1 month, and 10 patches in 1 year

    • top 10 reviewers:
      Nabet, Julien made 232 review comments in 1 month, and 982 in 1 year
      Vajna, Miklos made 146 review comments in 1 month, and 1158 in 1 year
      Taichi Haradaguchi made 128 review comments in 1 month, and 326 in 1 year
      Xisco Fauli made 128 review comments in 1 month, and 742 in 1 year
      Christian Lohmaier made 118 review comments in 1 month, and 466 in 1 year
      Thorsten Behrens made 114 review comments in 1 month, and 688 in 1 year
      Ilmari Lauhakangas made 96 review comments in 1 month, and 602 in 1 year
      Caolán McNamara made 84 review comments in 1 month, and 1464 in 1 year
      Kaganski, Mike made 80 review comments in 1 month, and 500 in 1 year
      Adolfo Jayme Barrientos made 66 review comments in 1 month, and 592 in 1 year

    • Patches automatically abandoned:
      sal: osl::File allow to create files in sandbox ( Michael Meeks )
      - https://gerrit.libreoffice.org/#/c/160250
      tdf#155856 Added cmake to complextoolbarcontrols ( Konstantin Limarev )
      - https://gerrit.libreoffice.org/#/c/162396
      tdf#45904 Move Java SwViewSetting tests to C++ ( Luv Sharma )
      - https://gerrit.libreoffice.org/#/c/163551
      Revert “remove null checks for mpObj in UIObjectUnoObj” ( Stephan Bergmann )
      - https://gerrit.libreoffice.org/#/c/165034
      tdf#157129 ww8import: Add unit test ( Steven Casey )
      - https://gerrit.libreoffice.org/#/c/167027
      WIP: Fix automatic font color decision ( Gülşah Köse )
      - https://gerrit.libreoffice.org/#/c/167029
      implement tdf#121111 test ( Keldin Maldonado )
      - https://gerrit.libreoffice.org/#/c/167179
      WIP: change bindings autotimer to not use explicit timeout values ( Caolán McNamara )
      - https://gerrit.libreoffice.org/#/c/167342
      WIP: keep everything at lowest priority and defer if any input when fired ( Caolán McNamara )
      - https://gerrit.libreoffice.org/#/c/167343

    • big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
      Peter Hagen (willow-media.nl)

• GSoC (Ilmari)

  • Midterm evaluations deadline 12 July - all completed
    • some slightly delayed projects, too

• LiboCon

  • CfP is open: LibreOffice Conference 2024 :: pretalx
    • 15th Aug is the deadline

• Commit Access

• Developer Certification (Stephan/Miklos/László/Gabriel)

  • resting since: 11 weeks (limit: 20 weeks)

• Jenkins / CI update (Cloph)
  gerrit_android_aarch64 jobs: 200 ok: 190 ko: 10 fail ratio: 5.00% mean_ok: 13 ( 28) median_ok: 10 ( 20)
  gerrit_android_arm jobs: 201 ok: 191 ko: 8 fail ratio: 3.98% mean_ok: 13 ( 28) median_ok: 10 ( 20)
  gerrit_android_x86 jobs: 200 ok: 189 ko: 11 fail ratio: 5.50% mean_ok: 14 ( 29) median_ok: 11 ( 20)
  gerrit_android_x86_64 jobs: 201 ok: 189 ko: 8 fail ratio: 3.98% mean_ok: 14 ( 29) median_ok: 12 ( 21)
  gerrit_linux_clang_dbgutil jobs: 403 ok: 316 ko: 77 fail ratio: 19.11% mean_ok: 50 ( 66) median_ok: 48 ( 62)
  gerrit_linux_gcc_release jobs: 477 ok: 393 ko: 58 fail ratio: 12.16% mean_ok: 28 ( 44) median_ok: 22 ( 37)
  gerrit_mac jobs: 405 ok: 365 ko: 29 fail ratio: 7.16% mean_ok: 53 ( 66) median_ok: 46 ( 54)
  gerrit_windows jobs: 431 ok: 313 ko: 100 fail ratio: 23.20% mean_ok: 66 ( 97) median_ok: 70 ( 74)
  gerrit_master_ml jobs: 512 ok: 265 ko: 203 fail ratio: 39.65% mean_ok: 143 (150) median_ok: 127 (130)
  gerrit_master jobs: 61 ok: 36 ko: 20 fail ratio: 32.79% mean_ok: 95 (100) median_ok: 89 ( 97)
  gerrit_master_seq jobs: 454 ok: 232 ko: 183 fail ratio: 40.31% mean_ok: 143 (149) median_ok: 129 (133)

  • tests that failed more than twice in last seven days
    3 CppunitTest_writerperfect_writer gerrit_windows
    9 CppunitTest_sw_a11y gerrit_windows
    37 aborted by jenkins job timeout gerrit_windows
  • this week: some Windows bots still sometimes go into a state that all later builds fail, without a way to easily detect this state (Cloph)
  • experimenting with a cloud builder for the more busy hours
  • also one more server upcoming, will be used as a Windows builder

• What’s cooking (Miklos)

  • A11y update (Michael W)
    • looking into vertical tabpage a11y, related code cleanup
  • RTL/CTL/CJK update (Jonathan)
    • tdf#146081 Inconsistent proportional line spacing in Arabic
      • 146081 – Reducing line spacing of Arabic will cause inappropriate consequence
    • tdf#56408 Writer always breaks at direction change, leaving orphan bracket
      • 56408 – Writer always breaks lines at text direction change, leaving orphan bracket
      • Affects layout in certain cases (e.g. LTR wrapping Arabic word in quotes)
      • New behavior in line with other programs and BreakIterator rules
  • drawinglayer system-dependent primitive renderer (SDPR) for cairo (Armin)
  • python 3.10 upgrade (Xisco)

    • some knock-on problems, but think everything is sorted out for now

    • 3.10 is still not EOL till 2026

    • Status of Python versions (Hossein)

    • any plans for 3.12? (Hossein)

      • 161947 – python3: bundle setuptools has to be fixed first (Xisco)

      • was discussed on IRC (Ilmari)

      • would be a problem for Debian 12 backports, if we then modified the code and removed support for older versions

      • Xisco said he doesn’t plan to update to 3.11 for now

        • for 25.8, maybe
  • freedesktop git mirror is back (Miklos)
    • including cgit & emails on libreoffice-commits@

• QA update (Xisco)

  • UNCONFIRMED: 1215 (+30)

    • enhancements: 275 (+10)
    • needsUXEval: 5 (+1)
    • haveBackTrace: 9 (+0)
    • needsDevAdvice: 47 (+0)
    • documentation: 5 (+0)
    • android: 0 (+0)
    • iOS: 0 (+0)
    • Online: 9 (+0)

  • Most pressing bugs:
    New:

  None

  • New high severity bugs of the week:

    • Automatically assigned mnemonics not always set

      • 147762 – Automatically assigned mnemonics not always set
      • not tagged as a regression
      • gtk case for the “run out of letters” case (Caolan)
        • start assigning double letters perhaps
        • maybe you can use the same character at two places in dialogs but not in menus
      • would love to have automatic assignment for all menu items, no problem if the same character is assigned multiple times (Heiko)

    • Not all hyphenation separators (hyphens) are displayed in app, but are visible in blue in PDF export / print

      • 161421 – Not all hyphenation separators (hyphens) are displayed in app, but are visible in blue in PDF export / print
      • already fixed, thanks to Heiko

• QA stats (Stéphane)

  • Clarified / consolidated reports

    • (sd, regression) graphic export with transparency has modified aspect ratio (related to margins): 122155 – Export to formats that don't include margins (PNG and GIF with transparency; EMF; WMF; EPS) is distorted / stretched
      • Likely related to the inherited issue of margins left out of transparency export: 89828 – Image Export crops based on margins instead of page boundaries when Save transparency checked
    • (sc) crash after formula paste: https://bugs.documentfoundation.org
      /show_bug.cgi?id=161891

  • Weekly Bug Summary
    +100 -9 (-56) overall)
    many thanks to the top bug squashers:
    QA Administrators 10
    Buovjaga 7
    Heiko Tietze 7
    Stéphane Guillou (stragu) 4
    Rafael Lima 3
    Jonathan Clark 2
    Michael Weghorn 2
    Mike Kaganski 2
    Sarper Akdemir (allotropia) 2
    Hossein 1

  • top 10 bugs reporters:
    Eyal Rozenberg 9
    Gabor Kelemen (allotropia) 4
    Tuomas Hietala 4
    Moritz Duge 3
    Daniele 2
    Mike Kaganski 2
    Rafael Lima 2
    Regina Henschel 2
    intmail01 2
    peter josvai 2

  • top 10 bugs fixers:
    Heiko Tietze 2
    Jonathan Clark 2
    Sarper Akdemir 2
    Weghorn, Michael 2
    Caolán McNamara 1
    Grandin, Noel 1
    Ilmari Lauhakangas 1
    Juan C. Sanz 1
    Justin Luth 1
    Mamane, Lionel Elie 1

  • top 10 bugs confirmers:
    Stéphane Guillou 16
    m.a.riosv 9
    UNKNOWN 6
    Xisco Fauli 6
    Ilmari Lauhakangas 4
    Rafael Lima 3
    Ady 2
    Nabet, Julien 2
    1
    Dennis Roczek 1

• Bisected bugs open: keyword ‘bisected’

  • more accurate - down to a single commit.
  • Bug List: LibreOffice Bi-bisected

  done by:
     Stéphane Guillou       5
     Raal                   3
     Ilmari Lauhakangas     1
     Xisco Fauli            1
  

• Bibisected bugs open: keyword ‘bibisected’

  • Bug List: LibreOffice Bi-bisected

  done by:
     Stéphane Guillou       5
     Raal                   3
     gladys                 2
     Ilmari Lauhakangas     1
     Xisco Fauli            1
  

• all bugs tagged with ‘regression’

  • 1241(+7) bugs open of 13468(+14) total 28(+4) high prio.

    done by:
    Stéphane Guillou 5
    Ady 2
    m.a.riosv 2
    Heiko Tietze 1
    Ilmari Lauhakangas 1
    Alex Thurgood 1
    Balland-Poirier, Laurent 1
    Bielefeld, Rainer 1
    Xisco Fauli 1

• ~Component count net * high severity regressions

  • Bug List
    Writer - 14(+0)
    Calc - 6(+3)
    Impress - 2(+0)
    LibreOffice - 2(+0)
    UI - 2(+0)
    Base - 1(+1)

  by OS:
  All - 19(+3)
  Linux - 5(+0)
  Mac OS X - 0(+0)
  Windows - 4(+1)

• ~Component count net * all regressions

  • Bug List
    Writer: other - 426(+2)
    Calc - 233(+2)
    Impress - 124(+1)
    LibreOffice - 51(+0)
    Draw - 48(+0)
    Crashes - 46(+2)
    Writer: docx filter - 44(+0)
    Base - 42(+0)
    UI - 39(+0)
    Borders - 34(+0)
    Writer: perf - 34(+0)
    Writer: other filter - 32(+0)
    Printing and PDF export - 27(+0)
    Chart - 24(+0)
    RTL - 23(+0)
    filters and storage - 21(+0)
    BASIC - 19(+0)
    Writer: doc filter - 16(+0)
    graphics stack - 12(+0)
    Formula Editor - 10(+1)
    framework - 3(+0)
    Extensions - 2(+0)
    sdk - 2(+0)
    Linguistic - 1(+0)