ESC meeting minutes: 2024-05-30

vmiklos · May 30, 2024, 2:52pm

Present:
- Heiko, Olivier, Eike, Ilmari, Jonathan, Michael W, Regina, Stephan, sockseight, Xisco, Thorsten, Caolan, Hossein, Cloph, Stephane, Miklos
Completed Action Items:
Pending Action Items:
- MAR update: include OS info in the user agent or file a bug to do it (Cloph)
  - patch in gerrit pending CI
Release Engineering update (Cloph)
- 24.2: 24.2.4 RC2 this week, to be tagged tomorrow
- 24.8:
  - feature freeze (beta1) in 1 week
  - string / UI freeze 3 weeks after that
  - late features?
    - LET() Calc function (Thorsten)
- Also, any idea when WASM TB will be upgraded? (Julien)
  - previously think it was a compiler failure (Cloph)
  - probably need a patch for lode.git first
  - wasn’t aware of the tinderbox, doesn’t send mails (Stephan)
    - can probably look at that next week
    - any reason why failure mails are not sent out? (Stephan)
      - nobody wanted to work on this (Cloph)
      - will turn it on, then (Stephan)
  - tb platform status shows this as red as well (Miklos)
  - annoying vs useful ratio, probably useful to send mails failures for now (Thorsten)
Documentation (Olivier)
- Helpcontents2
  - Completion of new MS functions Help pages (ohallot)
    - XLOOKUP, RANDARRAY, SORTBY…
  - Updates and fixes (erack, S. Horacek, D. Maddern, A. Barrientos)
- Guides
  - Work in progress.
- Question1: Calc functions argument naming
  - Verbose? e.g. =FUNCTION (Argument one; Argument two,…)
  - Mnemonic? e.g. =FUNCTION (Arg1; Arg2;…)
  - no strong opinion (Thorsten)
  - tend to prefer the mnemonics, these have to fit into a tooltip (Eike)
  - the wizard & help pages should have the same name (Olivier)
  - prefer verbose (Heiko)
    - easier to understand that way
  - the one doing the work gets to decide (Cloph)
- Question2: New dialog layout
  - Stability/rendering among OS’s.
  - Screenshooting for documentation
  - see “Vertical tabpages state” below (Miklos)
- Bugzilla Documentation statistics
  245(245) bugs open
- Updates:
  BZ changes 1 week 1 month 3 months 12 months
  created 17(1) 47(3) 113(1) 224(3)
  commented 20(-17) 89(-2) 257(-19) 871(3)
  resolved 10(3) 30(3) 67(5) 131(7)
- top 10 contributors:
  Dione Maddern made 53 changes in 1 month, and 84 changes in 1 year
  Olivier Hallot made 51 changes in 1 month, and 247 changes in 1 year
  Stéphane Guillou made 17 changes in 1 month, and 247 changes in 1 year
  Dieter made 13 changes in 1 month, and 18 changes in 1 year
  Óvári made 10 changes in 1 month, and 13 changes in 1 year
  Heiko Tietze made 7 changes in 1 month, and 77 changes in 1 year
  Kaganski, Mike made 7 changes in 1 month, and 71 changes in 1 year
  Nabet, Julien made 6 changes in 1 month, and 59 changes in 1 year
  Bogdan B made 4 changes in 1 month, and 13 changes in 1 year
  Ilmari Lauhakangas made 4 changes in 1 month, and 69 changes in 1 year
UX Update (Heiko)
- Bugzilla (topicUI) statistics
  240(240) (topicUI) bugs open, 40(40) (needsUXEval) needs to be evaluated by the UXteam
- Updates:
  BZ changes 1 week 1 month 3 months 12 months
  added 7(4) 13(3) 18(4) 25(3)
  commented 92(63) 226(67) 553(41) 1757(47)
  removed 0(0) 1(-2) 5(0) 10(-1)
  resolved 6(1) 27(-1) 80(1) 293(3)
- top 10 contributors:
  Heiko Tietze made 109 changes in 1 month, and 965 changes in 1 year
  Stéphane Guillou made 97 changes in 1 month, and 671 changes in 1 year
  Vernon, Stuart Foote made 57 changes in 1 month, and 327 changes in 1 year
  Eyal Rozenberg made 53 changes in 1 month, and 166 changes in 1 year
  Dieter made 26 changes in 1 month, and 127 changes in 1 year
  Ady made 11 changes in 1 month, and 120 changes in 1 year
  m.a.riosv made 11 changes in 1 month, and 48 changes in 1 year
  Henschel, Regina made 11 changes in 1 month, and 38 changes in 1 year
  Jérôme made 10 changes in 1 month, and 14 changes in 1 year
  Rafael Lima made 10 changes in 1 month, and 59 changes in 1 year
- [Bug 157580] Allow notebookbar and groupedbarcompact groups sections to be
  shown/hidden based on available space instead of only their order
- [Bug 161304] context menu Column deletion duplicates Cut shortcut
- [Bug 160999] Find sidebar results presented with huge gratuitous spaces
- [Bug 161276] Add booklet option to print smaller format booklet
  → + [Bug 161032] Allow removing bundled extensions
  - dictionaries in particular
- [Bug 161271] enhacement: support excel new excel regex formulae
- [Bug 161255] Heuristically enable RTL-CTL and/or CJK language support
  when installing
- [Bug 161251] Support showing combinations of named style + direct formatting
  in style list
→ + basic HTML cell render
+ 161223 – basic HTML cell render
+ =IF(A1 = 1; “Lorem ipsum dolor”;"")
or evaluate autocorrection =IF(true; “Lorem ipsum dolor”)
+ no support for formatting the result of a formula cell, only at a cell level (Eike)
+ not thrilled by the idea
Vertical tabpages state (Samuel/Thorsten)
- review the state this week
- tdf#161006, tdf#161020, tdf#161047, tdf#161049
  *Fixed with https://gerrit.libreoffice.org/c/core/+/168081
- tdf#161026
  - Unclear problem, NEEDINFO
- tdf#161030
  - Fixed with https://gerrit.libreoffice.org/c/core/+/168251
- suspect these should fix ~all reported problems (Thorsten)
- looking forward to take screenshots for documentation (Olivier)
- let’s have it in, re-evaluate it next week how it’s going (Xisco)
Crash Testing (Caolan)
- 24(+1) import failure, 20(+2) export failures
  - Development/Crashtesting - The Document Foundation Wiki
- 0 coverity issues
- 8 ossfuzz issues
  - 7 timeouts, 0 OOM
Crash Reporting (Xisco)
- 7.6.6.3 6848(+798)
- 7.6.7.2 1117(+660)
- 24.2.0.3 19166(+555)
- 24.2.1.2 15782(+611)
- 24.2.2.2 12792(+1102)
- 24.2.3.2 5213(+2237)
- Reports for signature: GetUserCall(SdrObject const *)
  - https://gerrit.libreoffice.org/c/core/+/167940 should fix it ?
Mentoring (Hossein)
- Reviewed submissions from newcomers
- Finalized and published a blog post
  Porting Java tests to C++
  Porting Java tests to C++ - LibreOffice Development Blog
- Syncing odk/examples with Wiki
  - idea: Adding the commit hash + used line range to the Wiki
    committer… 1 week 1 month 3 months 12 months
    open 94(38) 183(37) 183(36) 183(36)
    reviews 300(-62) 1310(-12) 3386(-152) 12504(18)
    merged 217(-37) 1245(-59) 3239(-146) 12693(-25)
    abandoned 7(-3) 48(-5) 162(-13) 659(0)
    own commits 160(-17) 899(-47) 2328(-72) 9268(-5)
    review commits 52(-20) 229(-4) 795(-25) 3008(3)
    contributor… 1 week 1 month 3 months 12 months
    open 36(0) 100(5) 102(6) 102(6)
    reviews 696(-34) 3110(-22) 7580(-246) 29560(10)
    merged 16(-9) 82(-8) 347(-19) 1575(-14)
    abandoned 8(1) 27(-1) 140(-140) 710(6)
    own commits 17(-18) 101(-6) 397(-16) 1141(4)
    review commits 0(0) 0(0) 0(0) 0(0)
  - easyHack statistics:
    needsDevEval 9(9) needsUXEval 1(1) cleanup_comments 328(328)
    total 410(410) assigned 28(28) open 348(348)
  - top 10 contributors:
    Dione Maddern made 21 patches in 1 month, and 55 patches in 1 year
    Weblate made 5 patches in 1 month, and 27 patches in 1 year
    Jakub Kościelak made 4 patches in 1 month, and 7 patches in 1 year
    LeSasse made 4 patches in 1 month, and 23 patches in 1 year
    made 3 patches in 1 month, and 8 patches in 1 year
    Hubert Figuière made 3 patches in 1 month, and 8 patches in 1 year
    Printf Debugging made 3 patches in 1 month, and 4 patches in 1 year
    Marco Pinto made 2 patches in 1 month, and 6 patches in 1 year
    Bayram Çiçek made 2 patches in 1 month, and 3 patches in 1 year
    Kurt Nordback made 2 patches in 1 month, and 25 patches in 1 year
  - top 10 reviewers:
    Caolán McNamara made 144 review comments in 1 month, and 1512 in 1 year
    Ilmari Lauhakangas made 112 review comments in 1 month, and 570 in 1 year
    Grandin, Noel made 80 review comments in 1 month, and 716 in 1 year
    Michael Stahl made 80 review comments in 1 month, and 890 in 1 year
    Adolfo Jayme Barrientos made 78 review comments in 1 month, and 538 in 1 year
    Thorsten Behrens made 78 review comments in 1 month, and 614 in 1 year
    Hossein made 64 review comments in 1 month, and 322 in 1 year
    Vajna, Miklos made 62 review comments in 1 month, and 1084 in 1 year
    Christian Lohmaier made 48 review comments in 1 month, and 358 in 1 year
    Kaganski, Mike made 44 review comments in 1 month, and 466 in 1 year
  - Patches automatically abandoned:
    sal: initial osl::File sand-boxing commit for Unix. ( Michael Meeks )
    - https://gerrit.libreoffice.org/#/c/160036
GSoC (Ilmari)
- Lua UNO bridge (Stephan)
  - avoid a Lua dependency for now
  - feature branch is an option (Thorsten)
  - or combine the two (feature branch + gerrit) (Stephan)
Commit Access
LibreOffice Technology hackfest at Budapest (Miklos)
- 4th & 5th June (Tue-Wed), in 0,5 weeks
- details: LibreOffice Technology Budapest 2024 Hackfest - The Document Foundation Wiki
- on blog: Coming up: LibreOffice Technology Budapest 2024 Hackfest - The Document Foundation Blog
Developer Certification (Stephan/Miklos/László/Gabriel)
- resting since: 6 weeks (limit: 20 weeks)
Jenkins / CI update (Cloph)
gerrit_android_aarch64 jobs: 142 ok: 131 ko: 4 fail ratio: 2.82% mean_ok: 10 ( 14) median_ok: 7 ( 8)
gerrit_android_arm jobs: 141 ok: 137 ko: 4 fail ratio: 2.84% mean_ok: 9 ( 13) median_ok: 7 ( 9)
gerrit_android_x86 jobs: 142 ok: 132 ko: 5 fail ratio: 3.52% mean_ok: 9 ( 13) median_ok: 7 ( 9)
gerrit_android_x86_64 jobs: 141 ok: 135 ko: 5 fail ratio: 3.55% mean_ok: 11 ( 15) median_ok: 6 ( 8)
gerrit_linux_clang_dbgutil jobs: 293 ok: 231 ko: 50 fail ratio: 17.06% mean_ok: 42 ( 45) median_ok: 43 ( 45)
gerrit_linux_gcc_release jobs: 316 ok: 267 ko: 37 fail ratio: 11.71% mean_ok: 19 ( 21) median_ok: 15 ( 15)
gerrit_mac jobs: 368 ok: 242 ko: 112 fail ratio: 30.43% mean_ok: 54 ( 54) median_ok: 51 ( 51)
gerrit_windows jobs: 281 ok: 180 ko: 73 fail ratio: 25.98% mean_ok: 113 (159) median_ok: 106 (122)
gerrit_master_ml jobs: 337 ok: 167 ko: 129 fail ratio: 38.28% mean_ok: 159 (160) median_ok: 117 (118)
gerrit_master jobs: 54 ok: 25 ko: 23 fail ratio: 42.59% mean_ok: 126 (126) median_ok: 90 ( 90)
gerrit_master_seq jobs: 280 ok: 142 ko: 103 fail ratio: 36.79% mean_ok: 165 (165) median_ok: 122 (122)
- tests that failed more than twice in last seven days
  3 CppunitTest_sc_vba_macro_test gerrit_linux_gcc_release
  3 CppunitTest_sw_mailmerge gerrit_windows
  3 CppunitTest_sw_ooxmlexport12 gerrit_linux_gcc_release
  3 CppunitTest_sw_ooxmlexport5 gerrit_linux_gcc_release
  4 CppunitTest_sw_layoutwriter2 gerrit_windows
  6 CppunitTest_vcl_gtk3_a11y gerrit_linux_clang_dbgutil
  11 CppunitTest_sw_a11y gerrit_windows
  14 aborted by jenkins job timeout gerrit_windows
  14 UITest_writer_tests4 gerrit_linux_clang_dbgutil
- CppunitTest_vcl_gtk3_a11y: increased timeout for AT-SPI method calls (Michael W)
  - Diff - 87c41bbf04c361746bf9c2373aa144a02d971303^! - core - Gitiles
  - seems to have helped from what I can see
- this week: a bit rough on the Windows side (Cloph)
  - build times nearly doubled
  - is it before/after the analyzer addition on Windows? (Caolan)
  - Gerrit Windows Build time trend [Jenkins]
  - not affecting all builders? not exactly sure (Cloph)
  - other Windows problem: had to take down some bots due to a timeout
- plan to use cloud instances during peak hours for linux/clang (Cloph)
What’s cooking (Miklos)
- A11y update (Michael W)
  - improvements to Calc a11y memory usage by Patrick (tdf#158914)
  - improvements to editable combobox a11y (tdf#160971)
  - improvements to vertical tabpages a11y :
    - Diff - c61f6a78022de6b29f031f3ac6726520032de187^! - core - Gitiles
    - Diff - ceca4cde363154b0c7e276d65fc87ec94eb0bb9a^! - core - Gitiles
  - analysis for screen reader browse mode (related: tdf#137955, tdf#35652, tdf#91739, tdf#96492)
- RTL/CTL/CJK update (Jonathan)
  - tdf#81272: Slow CJK rendering due to font fallback
    - Per layout: O(nlogn) → O(n)
  - tdf#161145: CJK characters have extra spacing since LO 7
    - Regression causing CJK characters to overflow cells on certain docx
    - Currently investigating to compare behavior against MSO
  - results from the vcl-level text layout changes?
    - will check (Xisco)
    - what doc corpus do you use? (Miklos)
    - a subset (Xisco)
    - not sure about the size off the top of the head
- tdf#160984 Section-based continuous endnotes in Writer (Miklos)
  - slowly done for the feature freeze
invitation list for LibOCon (Michael W)
- 10 slots available (for development)
- ideally, ESC would provide a ranked list of up to 20 people to Sophie
- how to proceed?
- those people can be also outside the LO project (Cloph)
- makes sense (Thorsten)
  - deadline?
  - not sure (Michael W)
QA update (Xisco)
- UNCONFIRMED: 1141 (-20)
  - enhancements: 275 (-2)
  - needsUXEval: 10 (-2)
  - haveBackTrace: 10 (+0)
  - needsDevAdvice: 45 (-1)
  - documentation: 3 (+0)
  - android: 0 (+0)
  - iOS: 0 (+0)
  - Online: 9 (+0)
- Most pressing bugs:
  New:
None
- New high severity bugs of the week:
None
QA stats (Stéphane)
- Some consolidated / updated reports:
- (sw) same document in two windows are not independent, viewport glitches in many ways.
  - main report has 9 duplicates: 43253 – Zooming in "New Window" split view
  - related: shift doesn’t match ruler: 116372 – VIEWING: Page jumps relative to ruler when switching to another window of the same document
  - related: page view setting affects all windows: 129827 – "New Window" split windows, changing page view affects all open windows
- discussion on relevant language listing in Language menu (also related to
libexttextcat): 95274 – Wrong editing languages offered
- there is nothing wrong with it, it’s just used at a wrong place (Caolan)
  - it’s given a single word
  - the lib works when it’s given a longer piece of text
  - perhaps the menu should not do any kind of guessing, either
  - think this would nicely with multiple paragraphs of text
- bibisected regressions needing volunteers:
- (sw) cursor position not restored (now 14 dupes): 140147 – Position of cursor not saved correctly (see comment 46 for bibisect)
- (sw) image sticks to right margin when object to its left: 139232 – Image to the right of other object does not move freely, sticks to right margin
- Weekly Bug Summary
  +105 +21 (-117) overall)
  many thanks to the top bug squashers:
  Stéphane Guillou (stragu) 26
  QA Administrators 16
  Heiko Tietze 12
  Dione Maddern 6
  Buovjaga 5
  Hossein 4
  Jonathan Clark 3
  m_a_riosv 3
  Eike Rathke 2
  Gabor Kelemen (allotropia) 2
- top 10 bugs reporters:
  Gabor Kelemen (allotropia) 5
  Mihai Vasiliu 5
  Eyal Rozenberg 4
  Hossein 4
  Rafael Lima 3
  Ulrich Windl 3
  gopitzohlsen@gmail.com 3
  Callegar 2
  Stéphane Guillou (stragu) 2
  johnks 2
- top 10 bugs fixers:
  Dione Maddern 5
  Heiko Tietze 4
  Jonathan Clark 4
  Adolfo Jayme Barrientos 2
  Bogdan B 2
  Németh, László 2
  Vajna, Miklos 2
  Weghorn, Michael 2
  Andreas Heinisch 1
  Balland-Poirier, Laurent 1
- top 10 bugs confirmers:
  Stéphane Guillou 45
  m.a.riosv 11
  Heiko Tietze 10
  Dieter 4
  Robert Großkopf 4
  Ady 3
  Ilmari Lauhakangas 3
  Nabet, Julien 3
  Vernon, Stuart Foote 2
  Ahmed Hamed 1
Bisected bugs open: keyword ‘bisected’
- more accurate - down to a single commit.
- Bug List: LibreOffice Bi-bisected
```
done by:
   Stéphane Guillou       4
   Raal                   3
```
Bibisected bugs open: keyword ‘bibisected’
- Bug List: LibreOffice Bi-bisected
```
done by:
   Raal                   3
   Stéphane Guillou       3
```
all bugs tagged with ‘regression’
- 1251(+1) bugs open of 13390(+8) total 23(+0) high prio.
  
  done by:
  Robert Großkopf 2
  Stéphane Guillou 1
~Component count net * high severity regressions
- Bug List
  Writer - 13(+0)
  Calc - 3(+0)
  Impress - 2(+0)
  LibreOffice - 2(+0)
  UI - 2(+0)
by OS:
All - 16(+0)
Linux - 5(+0)
Mac OS X - 0(+0)
Windows - 2(+0)
~Component count net * all regressions
- Bug List
  Writer: other - 431(-1)
  Calc - 231(-1)
  Impress - 126(-1)
  LibreOffice - 53(+0)
  Draw - 52(+0)
  Writer: docx filter - 44(+0)
  UI - 43(-1)
  Base - 42(+1)
  Crashes - 41(+0)
  Borders - 35(+0)
  Writer: perf - 34(+0)
  Writer: other filter - 31(+0)
  Printing and PDF export - 26(+0)
  Chart - 24(+0)
  RTL - 23(+0)
  BASIC - 21(+0)
  filters and storage - 21(+0)
  Writer: doc filter - 16(+0)
  graphics stack - 13(+0)
  Formula Editor - 7(+0)
  framework - 3(+0)
  Extensions - 2(+0)
  sdk - 2(+0)
  Linguistic - 1(+0)