ESC meeting minutes: 2024-05-16

  • Present:

    • Heiko, Olivier, Thorsten, Cloph, Hossein, Ilmari, Jonathan, Michael W, Xisco, Michael S, Caolan, Stephane, Miklos
  • Completed Action Items:

    • tdf#99528 Vertical tabs: invite Samuel next week if there are still burning fires (Heiko)
      • Samuel says not needed
      • revert for 24.8 if needed
      • unfortunately couldn’t make it to the call (Thorsten)
      • the intention is to fix this, so it doesn’t look broken
      • suggest to have a week before UI freeze to see where we are
      • original idea came from UX
      • afraid to wait for too long (Heiko)
      • if the change is controversial, agree (Thorsten)
        • if desirable: try to fix it
        • committed to put some effort into this
        • no very strong opinion on this
      • 4 high severity bugs for this topic so far (Xisco)
        • feels broken in its current state (Heiko)
          • except on gtk3
      • suggest to review the state in 2 weeks and see the direction (Miklos)
      • like the idea + a recurring item (Xisco)
    • send welcome mail for Jonathan (Xisco)
    • enable the commit bit for Jonathan (Cloph)
  • Pending Action Items:

  • Release Engineering update (Cloph)

    • 24.2: 24.2.4 RC1 this week, today evening
    • 24.8: alpha was tagged earlier this week
      • feature freeze in 3 weeks
      • string / UI freeze 4 weeks after that
      • bug with Linux packaging: missing mapping, locally patched for now
      • if you have a late feature proposal, announce that here
      • MAR updater:
        • 2 channels?
        • keep on the old channel as long as possible?
        • update to the new channel as soon as possible?
        • stick to how the old update notification did it?
        • could also provide a dummy update to stop updates
        • context (Thorsten)
          • plan: 24.8 is enabled by default, without any user interaction
          • channel name is baked into the version
          • can tell people to edit some files
          • easiest is to decide on one policy and go with that
          • if we stop supporting a Windows version, there is no good option to do that
            • least bad: product is discontinued, then no obligation to have working LO there
            • perhaps update Windows requirement for 24.8, then we’re good for the next few years
        • last time an ICU update triggered the Windows bump (Cloph)
          • concern: we ship an update then the new version can’t be launched anymore
          • or only partially
          • if we stick to just 1 policy, then dummy update is a trick
            • if the update check sends OS info, it’s easier
        • if single channel, which variant to use? (Cloph)
          • switch later, sooner, something in-between?
          • play it safe and start with the in-branch update first and only do major updates in the next cycle?
        • what browsers do (Hossein)
          • Chrome has 3 channels: stable, dev, canary
          • Firefox: minor versions (automatic) and then a major version (manually)
            • and now just similar to Chrome (automatic for all)
          • look at if this is relevant for us
          • browers always try to get to the latest (Thorsten)
          • for us: when a major update the least distruptive
          • can decide later when to cross-update (Cloph)
            • mid-cycle or when EOL is reached?
          • care about: the expecation is that EOL version is automatically updated (Thorsten)
            • stop running unmaintained, insecure software
          • run update in the background, then user decides if update now or later? (Hossein)
            • strongly feel against the idea of keep running insecure version (Thorsten)
            • default should be to update (unless you go via tools → options)
            • agree, default to update is good (Hossein)
          • include OS info in the user agent? (Cloph)
            • like the idea (Thorsten)
              AI: do this or file a bug to do it (Cloph)
  • Documentation (Olivier)

    • Helpcontent2
      • Help for RANDARRAY (ohallot, fito, Balasz)
      • Updates and fixes (ohallot)
    • Extended tips
      • Calc option view page (D. Maddern)
    • Guides
      • Work in progress.
      • IMpress 24.2 soon to be announced
    • Bugzilla Documentation statistics
      257(257) bugs open
    • Updates:
      BZ changes 1 week 1 month 3 months 12 months
      created 12(-2) 46(7) 107(0) 220(-5)
      commented 12(-8) 70(9) 245(-10) 837(-17)
      resolved 6(-1) 28(5) 57(3) 123(2)
    • top 10 contributors:
      Olivier Hallot made 58 changes in 1 month, and 242 changes in 1 year
      Stéphane Guillou made 31 changes in 1 month, and 237 changes in 1 year
      Vernon, Stuart Foote made 22 changes in 1 month, and 106 changes in 1 year
      Ilmari Lauhakangas made 10 changes in 1 month, and 73 changes in 1 year
      Heiko Tietze made 7 changes in 1 month, and 77 changes in 1 year
      Kaganski, Mike made 7 changes in 1 month, and 74 changes in 1 year
      Nabet, Julien made 6 changes in 1 month, and 59 changes in 1 year
      Cor Nouws made 5 changes in 1 month, and 8 changes in 1 year
      nobu made 4 changes in 1 month, and 16 changes in 1 year
      Dieter made 3 changes in 1 month, and 8 changes in 1 year
  • UX Update (Heiko)

    • Bugzilla (topicUI) statistics
      240(240) (topicUI) bugs open, 39(39) (needsUXEval) needs to be evaluated by the UXteam

    • Updates:
      BZ changes 1 week 1 month 3 months 12 months
      added 7(3) 13(3) 18(3) 25(4)
      commented 60(-4) 206(20) 560(35) 1757(-4)
      removed 0(0) 4(0) 5(0) 11(-1)
      resolved 8(0) 32(1) 80(1) 297(-11)

    • top 10 contributors:
      Heiko Tietze made 111 changes in 1 month, and 986 changes in 1 year
      Vernon, Stuart Foote made 105 changes in 1 month, and 329 changes in 1 year
      Eyal Rozenberg made 45 changes in 1 month, and 160 changes in 1 year
      Stéphane Guillou made 40 changes in 1 month, and 612 changes in 1 year
      Dieter made 32 changes in 1 month, and 147 changes in 1 year
      Cor Nouws made 21 changes in 1 month, and 32 changes in 1 year
      Ilmari Lauhakangas made 12 changes in 1 month, and 129 changes in 1 year
      Roman Kuznetsov made 9 changes in 1 month, and 45 changes in 1 year
      Olivier Hallot made 8 changes in 1 month, and 22 changes in 1 year
      Aron Budea made 6 changes in 1 month, and 22 changes in 1 year

    • [Bug 161049] Vertical Tab dialogs–Format Cells dialog in recent 24.8 alpha
      is too small

    • [Bug 161047] Vertical Tab dialogs–Page style dialog is too small and not
      resizeable

    • [Bug 161030] Vertical Tab dialogs–width available for Tab name is too narrow
      with jumping view of Tab names

    • [Bug 161026] Vertical Tab dialogs–Mouse cursor over tab not activated until
      pointer touches bottom edge (Win)

    • [Bug 161020] Vertical Tab dialogs–initial size of the style dialog is too small

    • [Bug 160869] Forms: Listboxes, set as “readonly”, will be greyed out. Other
      controls, set “readonly”, won’t.

    • [Bug 161090] Allow specifying how many / which values are grouped in remainder
      of Pie-of-Pie or Bar-of-Pie chart
      → + [Bug 161082] Print dialog: Put initial focus to “Printer” combobox

      • focused spin edits will not change the value on scroll unless hovered
        (thanks Michael W)
    • [Bug 161078] Allow direct formatting for page sequences instead of editing
      the style
      → + [Bug 160834] Unclear meaning of “Ignore pieces of length”

      • Tools > Options > Writer > Comparision: seems to ignore n character/word
        but has no apparent effect → hide the control
        • sounds sensible (Miklos)
    • [Bug 158288] When you select part of a column with merged cells, all columns
      that are part of the merged cell are selected

    • [Bug 158874] Want MS-Word like auto-formatting of beginning of list item

    • [Bug 160951] Navigator: Present sort options per radio button

    • [Bug 161037] UNO Sidebar ‘Hide’ and ‘Show’ sidebar deck (splitwin) – a new
      function (available for assigning a shortcut key to it)

    • [Bug 161031] Form creating is too niche to merit a main menu item visible
      by default

    • [Bug 161029] Special Find&Replace presets with regular expression

    → + Right clicking on selected text unselects it if the cursor is on a
    misspelled word
    + 98902 – Right clicking on selected text unselects it if the cursor is on a misspelled word
    + feasible to implement in Writer; possible to deal with phrases?
    + spellchecking can’t deal with phrases, grammar check is for that (Cloph)
    + think Laszlo implemented phrase spellchecking half a year ago (Heiko)
    + thought this needs dictionary support as well (Cloph)
    + will look into this more, later (Heiko)

  • Vertical tabpages state (Samuel)

    • review the state in 2 weeks
  • Crash Testing (Caolan)

  • Crash Reporting (Xisco)

    • 24.2.0.3 17948(+579)
    • 24.2.1.2 14477(+739)
    • 24.2.2.2 10399(+1469)
    • 24.2.3.2 1437(+950)
    • 7.6.6.3 5113(+1045)
    • 7.6.7.2 103(+0)
    • checked the latest vs previous versions, seeing no new regressions (Xisco)
    • seeing a few fixes
  • Mentoring (Hossein)

    • Reviewed submissions from the newcomers
    • New blog post
      Crash fixes, part 4: assertion failure
      Crash fixes, part 4: assertion failure - LibreOffice Development Blog
    • Wiki page for code conventions
      Development/Code Conventions - The Document Foundation Wiki
    • odk examples build issues on 32 bit systems (fixed)
      https://gerrit.libreoffice.org/c/core/+/167739
      → Is Intel32/Arm32 CI possible?
      • for CI-as-in-gerrit, certainly not (Cloph)
      • if you host a builder, then a tinderbox / daily builder is OK
      • arm32 is probably not that relevant vs arm64 (Cloph)
        • arm32 for Android is built, though (Michael W)
      • Windows 32bit builds are still done as tinderbox (Cloph)
        • also the CI builds
        • won’t help with ODK-as-part-of-make-check
    • Extracted DPI dependent tests
      tdf#160992 - Fix DPI dependent tests
      160992 – Fix DPI dependent tests
      • Maximum 25 broken tests are found for now
      • tinderbox for this? (Xisco)
        • hard to test on CI because none of the machines have an actual display
        • not sure how to set it to a custom value in software
      • have a way to influence DPI from and env var? (Miklos)
        • e.g. Linux SAL_FORCEDPI has this, may be useful (Michael W)

          committer… 1 week 1 month 3 months 12 months
          open 89(8) 160(18) 160(-18) 160(-18)
          reviews 318(-132) 1250(44) 3594(-124) 12458(-4)
          merged 310(-40) 1244(104) 3423(54) 12714(121)
          abandoned 15(2) 61(6) 174(2) 661(5)
          own commits 227(-23) 913(86) 2380(77) 9274(45)
          review commits 38(-13) 218(-6) 839(-32) 2994(-18)
          contributor… 1 week 1 month 3 months 12 months
          open 55(18) 103(26) 103(0) 103(0)
          reviews 894(-68) 3050(276) 7930(24) 29574(52)
          merged 15(-8) 86(-12) 377(-8) 1583(-52)
          abandoned 0(-9) 33(-16) 279(-9) 699(-5)
          own commits 14(-11) 97(-8) 429(-20) 1114(-12)
          review commits 0(0) 0(0) 0(0) 0(0)

      • easyHack statistics:
        needsDevEval 8(8) needsUXEval 1(1) cleanup_comments 326(326)
        total 409(409) assigned 26(26) open 349(349)
      • top 10 contributors:
        Jakub Kościelak made 5 patches in 1 month, and 5 patches in 1 year
        made 4 patches in 1 month, and 7 patches in 1 year
        Kira Tubo made 4 patches in 1 month, and 14 patches in 1 year
        Armin Le Grand (allotropia) made 4 patches in 1 month, and 86 patches in 1 year
        colton Garrett made 4 patches in 1 month, and 4 patches in 1 year
        Stéphane Guillou made 3 patches in 1 month, and 7 patches in 1 year
        Stéphane Guillou made 3 patches in 1 month, and 58 patches in 1 year
        Sahil Gautam made 3 patches in 1 month, and 4 patches in 1 year
        Dione Maddern made 3 patches in 1 month, and 37 patches in 1 year
        Weblate made 2 patches in 1 month, and 23 patches in 1 year
      • top 10 reviewers:
        Caolán McNamara made 108 review comments in 1 month, and 1476 in 1 year
        Adolfo Jayme Barrientos made 96 review comments in 1 month, and 506 in 1 year
        Ilmari Lauhakangas made 94 review comments in 1 month, and 544 in 1 year
        Michael Stahl made 84 review comments in 1 month, and 920 in 1 year
        Grandin, Noel made 76 review comments in 1 month, and 712 in 1 year
        Hossein made 76 review comments in 1 month, and 328 in 1 year
        Thorsten Behrens made 72 review comments in 1 month, and 594 in 1 year
        Vajna, Miklos made 64 review comments in 1 month, and 1084 in 1 year
        Kaganski, Mike made 58 review comments in 1 month, and 468 in 1 year
        Christian Lohmaier made 50 review comments in 1 month, and 362 in 1 year
      • Patches automatically abandoned:
        xmlsecurity : searchFileURL expects a OUString so to use OUString literal ( Arnaud Versini )
        - https://gerrit.libreoffice.org/#/c/163008
  • GSoC (Ilmari)

    • next deadline: end of bonding period: 27th of May
  • Commit Access

  • LibreOffice Technology hackfest at Budapest (Miklos)

  • Developer Certification (Stephan/Miklos/László/Gabriel)

    • resting since: 4 weeks (limit: 20 weeks)
  • Jenkins / CI update (Cloph)
    gerrit_android_aarch64 jobs: 201 ok: 195 ko: 3 fail ratio: 1.49% mean_ok: 10 ( 14) median_ok: 7 ( 11)
    gerrit_android_arm jobs: 200 ok: 194 ko: 4 fail ratio: 2.00% mean_ok: 10 ( 14) median_ok: 8 ( 10)
    gerrit_android_x86 jobs: 200 ok: 192 ko: 6 fail ratio: 3.00% mean_ok: 10 ( 14) median_ok: 7 ( 9)
    gerrit_android_x86_64 jobs: 201 ok: 197 ko: 2 fail ratio: 1.00% mean_ok: 11 ( 15) median_ok: 7 ( 11)
    gerrit_linux_clang_dbgutil jobs: 408 ok: 352 ko: 47 fail ratio: 11.52% mean_ok: 43 ( 46) median_ok: 41 ( 45)
    gerrit_linux_gcc_release jobs: 455 ok: 395 ko: 37 fail ratio: 8.13% mean_ok: 19 ( 21) median_ok: 15 ( 16)
    gerrit_mac jobs: 467 ok: 368 ko: 87 fail ratio: 18.63% mean_ok: 55 ( 57) median_ok: 50 ( 52)
    gerrit_windows jobs: 453 ok: 321 ko: 121 fail ratio: 26.71% mean_ok: 68 ( 99) median_ok: 63 ( 80)
    gerrit_master_ml jobs: 529 ok: 287 ko: 209 fail ratio: 39.51% mean_ok: 116 (116) median_ok: 97 (100)
    gerrit_master jobs: 42 ok: 22 ko: 15 fail ratio: 35.71% mean_ok: 86 ( 86) median_ok: 71 ( 71)
    gerrit_master_seq jobs: 486 ok: 265 ko: 193 fail ratio: 39.71% mean_ok: 117 (118) median_ok: 100 (100)

    • tests that failed more than twice in last seven days
      3 CppunitTest_sw_uiwriter6 gerrit_linux_gcc_release
      3 UITest_sw_sidebar gerrit_linux_clang_dbgutil
      4 Killed by the kill-wrapper gerrit_linux_clang_dbgutil
      4 CppunitTest_vcl_gtk3_a11y gerrit_linux_clang_dbgutil
      7 CppunitTest_sw_a11y gerrit_windows
      8 CppunitTest_sw_ooxmlexport7 gerrit_linux_gcc_release
      59 aborted by jenkins job timeout gerrit_windows
    • this week was OK wrt code (Cloph)
      • 2 Windows builders had a timeout issue with no clear signs why they fail
      • no leftover processes
      • maybe a windows update
  • What’s cooking (Miklos)

    • A11y update (Michael W)
      • combobox a11y (tdf#160971), related GTK 3 and Orca changes
      • new Qt API to trigger a11y announcement merged now (QTBUG-75003)
      • planning to take a first look into Orca/NVDA browse mode (e.g. tdf#35652, tdf#91739)
      • vertical tabs, could you please check it from the a11y point of view? (Heiko)
        • will do (Michael W)
    • RTL/CTL/CJK update (Jonathan)
      • tdf#61444: Text layout broken across formatting changes
      • tdf#124116: Text shaping broken across formatting changes
      • tdf#71956: Style changes inside grapheme clusters
        • Significant Writer rendering changes will land soon
        • Notice: This will slightly change the behavior of existing documents, but will improve conformance.
        • intention is to be a bit closer to what Word does in these cases
    • tdf#160984 Section-based continuous endnotes in Writer (Miklos)
    • Development/External Libraries - The Document Foundation Wiki (Xisco)
      • do you check the versions manually? (Miklos)
        • have a script, but not too reliable (Xisco)
        • trying to distribute the work
  • QA update (Xisco)

    • UNCONFIRMED: 1208 (+0)

      • enhancements: 278 (-3)
      • needsUXEval: 12 (+7)
      • haveBackTrace: 11 (+1)
      • needsDevAdvice: 47 (+0)
      • documentation: 4 (-2)
      • android: 0 (+0)
      • iOS: 0 (+0)
      • Online: 9 (+0)
    • Most pressing bugs:
      New:

    None

  • QA stats (Stéphane)

  • Bisected bugs open: keyword ‘bisected’

    done by:
       Raal                   5
       Stéphane Guillou       5
       Ilmari Lauhakangas     3
       Xisco Fauli            2
    
  • Bibisected bugs open: keyword ‘bibisected’

    done by:
       Raal                   5
       Stéphane Guillou       5
       gladys7david           2
       Xisco Fauli            2
       Ilmari Lauhakangas     1
       Kaganski, Mike         1
    
  • all bugs tagged with ‘regression’

    • 1245(+9) bugs open of 13360(+19) total 24(+1) high prio.

      done by:
      Heiko Tietze 5
      Ady 3
      m.a.riosv 3
      Stéphane Guillou 3
      Aron Budea 1
      Cor Nouws 1
      Kelemen, Gabor 1
      Robert Großkopf 1
      Xisco Fauli 1

  • ~Component count net * high severity regressions

    • Bug List
      Writer - 14(-1)
      Calc - 3(+1)
      Impress - 2(+0)
      LibreOffice - 2(+1)
      UI - 2(+0)

    by OS:
    All - 17(+0)
    Linux - 5(+1)
    Mac OS X - 0(+0)
    Windows - 2(+0)

  • ~Component count net * all regressions

    • Bug List
      Writer: other - 429(-4)
      Calc - 230(+3)
      Impress - 128(+1)
      Draw - 52(+0)
      LibreOffice - 52(+1)
      Writer: docx filter - 45(+0)
      Base - 42(+2)
      UI - 42(+4)
      Crashes - 40(+1)
      Borders - 34(-1)
      Writer: perf - 34(+0)
      Writer: other filter - 31(+1)
      Printing and PDF export - 26(+1)
      Chart - 24(+0)
      RTL - 23(+0)
      BASIC - 21(+1)
      filters and storage - 21(-1)
      Writer: doc filter - 16(+0)
      graphics stack - 12(+0)
      Formula Editor - 7(+0)
      framework - 3(+0)
      Extensions - 2(+0)
      sdk - 2(+0)
      Linguistic - 1(+0)