ESC meeting minutes: 2024-02-29 [try 2]

[ Re-sending as the list of abandoned patches were so long that we hit
the limit. ]

  • Present:

    • Cloph, Olivier, Caolan, Heiko, Ilmari, Michael W, Stephan, Xisco, Regina, Michael S, Sanchu, Eike, Thorsten, Miklos
  • Completed Action Items:

    • add “Deprecating Windows 7 and 8/8.1” to the 24.8 release notes (Ilmari)
  • Pending Action Items:

  • Release Engineering update (Cloph)

    • 7.6: 7.6.6 RC1 in 1 week
    • 24.2.2 RC1 1 week
    • app store versions:
      • 7.6.5 published as an update
    • update checker is now also enabled for 7.5 → 7.6
    • Windows MAR updater status? (Thorsten)
      • not yet, but should happen next week (Cloph)
  • Documentation (Olivier)

    • Helpcontents2

      • Housekeeping and update + bug squash (D. Maddern, stragu, ohallot)
      • New pages for new MS functions (ohallot)
      • Scriptforge maintenance (A. Romedenne)
        Q: Does F1 works with toolbars?
        • F1 on Toolbars send a default bookmark (ohallot)
        • did this work in the past?
          • probably not: F1 works on the widget that has the focus (Miklos)
            • hovering over a mouse button doesn’t change the focus
          • one can also navigate to the toolbar with F6 (Regina)
            • possibly that works
              Guides
      • Online version for Draw Guide 7.6 (ohallot)
      • updtes in Calc (S. Fanning)
      • Updates in Draw & Impress guides (P. Schofield)
    • Bugzilla Documentation statistics
      279(279) bugs open

    • Updates:
      BZ changes 1 week 1 month 3 months 12 months
      created 18(10) 31(9) 52(8) 228(-14)
      commented 35(29) 73(22) 186(29) 901(-3)
      resolved 8(8) 13(8) 22(8) 113(-3)

    • top 10 contributors:
      Vernon, Stuart Foote made 44 changes in 1 month, and 63 changes in 1 year
      Olivier Hallot made 36 changes in 1 month, and 299 changes in 1 year
      Alain Romedenne made 10 changes in 1 month, and 13 changes in 1 year
      Kaganski, Mike made 9 changes in 1 month, and 61 changes in 1 year
      Dan Dascalescu made 7 changes in 1 month, and 7 changes in 1 year
      Heiko Tietze made 6 changes in 1 month, and 89 changes in 1 year
      Stéphane Guillou made 6 changes in 1 month, and 276 changes in 1 year
      Dione Maddern made 5 changes in 1 month, and 5 changes in 1 year
      UNKNOWN made 5 changes in 1 month, and 6 changes in 1 year
      Juan José González made 4 changes in 1 month, and 4 changes in 1 year

  • UX Update (Heiko)

    • Bugzilla (topicUI) statistics
      249(249) (topicUI) bugs open, 34(34) (needsUXEval) needs to be evaluated by the UXteam
    • Updates:
      BZ changes 1 week 1 month 3 months 12 months
      added 3(-2) 8(3) 10(3) 23(3)
      commented 60(-30) 235(21) 531(1) 2077(0)
      removed 0(0) 0(0) 2(0) 15(1)
      resolved 8(0) 36(-1) 87(5) 319(0)
    • top 10 contributors:
      Heiko Tietze made 132 changes in 1 month, and 1265 changes in 1 year
      Vernon, Stuart Foote made 56 changes in 1 month, and 284 changes in 1 year
      Ady made 43 changes in 1 month, and 148 changes in 1 year
      Stéphane Guillou made 30 changes in 1 month, and 602 changes in 1 year
      Rafael Lima made 21 changes in 1 month, and 83 changes in 1 year
      Ilmari Lauhakangas made 18 changes in 1 month, and 192 changes in 1 year
      Bob Harvey made 13 changes in 1 month, and 13 changes in 1 year
      Timur made 11 changes in 1 month, and 30 changes in 1 year
      Kaganski, Mike made 10 changes in 1 month, and 97 changes in 1 year
      Eyal Rozenberg made 8 changes in 1 month, and 172 changes in 1 year
    • Offer to download & install missing fonts from online sources
    • FILEOPEN When I say “lowriter foo.txt” and foo.txt does not exist,
      it should open a new empty document that saves to that name instead of dying
    • Table cells merge: some cells disappear
      • 159629 – Table cells merge: some cells disappear
      • no cell height, height is taken from row properties (Heiko)
      • would be nice to keep it simple
      • technically it’s probably not a bug (Regina)
        • good to solve it by setting the default to a better value (row height)
      • input in the bug is welcome
  • Crash Testing (Caolan)

  • Crash Reporting (Xisco)

    • 7.6.3.2 8219(+316)

    • 7.6.4.1 34187(+3182)

    • 7.6.5.2 212(+0)

    • 24.2.0.3 7530(+2385)

    • 7.6.5.2

    • void rtl::str::release<_rtl_uString>(_rtl_uString*)

    • Fixed after 7b46c77366fb3effd2de9bf5ba11ebd3c064974a

    • static bool cppu::idefaultConstructElements(struct _sal_Sequence * *, struct _typelib_TypeDescriptionReference *, long, long, long)

    • Not fixed after 6a0d4247b73d16d7e70ab146aadfbed75721f8bd

    • Fixed in 24.2. Armin’s work. Hard to backport

  • Mentoring (Hossein)

    • Reviewed submissions from the newcomers
    • Finalized and published a blog post on an EasyHack
      • Writer tables converted to plain text – difficultyInteresting EasyHack
        Writer tables converted to plain text - difficultyInteresting EasyHack - LibreOffice Development Blog
        committer… 1 week 1 month 3 months 12 months
        open 76(6) 161(22) 165(26) 165(26)
        reviews 464(42) 1486(-28) 3630(116) 12032(44)
        merged 333(38) 1219(51) 3344(102) 12493(6)
        abandoned 17(7) 54(9) 190(2) 654(4)
        own commits 219(52) 743(35) 2307(44) 9526(-33)
        review commits 81(-17) 303(14) 891(31) 3071(-19)
        contributor… 1 week 1 month 3 months 12 months
        open 53(34) 116(-131) 117(-130) 118(-130)
        reviews 940(142) 3070(190) 7976(256) 30240(54)
        merged 31(-7) 108(6) 358(10) 1991(-32)
        abandoned 149(138) 182(137) 266(134) 669(134)
        own commits 37(-12) 144(6) 359(27) 1048(-10)
        review commits 0(0) 0(0) 0(0) 0(0)
      • easyHack statistics:
        needsDevEval 8(8) needsUXEval 1(1) cleanup_comments 323(323)
        total 410(410) assigned 25(25) open 352(352)
      • top 10 contributors:
        Kurt Nordback made 20 patches in 1 month, and 21 patches in 1 year
        Dione Maddern made 12 patches in 1 month, and 22 patches in 1 year
        Armin Le Grand (allotropia) made 11 patches in 1 month, and 86 patches in 1 year
        Luv Sharma made 7 patches in 1 month, and 14 patches in 1 year
        Weblate made 4 patches in 1 month, and 20 patches in 1 year
        Stéphane Guillou made 4 patches in 1 month, and 56 patches in 1 year
        Hubert Figuière made 4 patches in 1 month, and 4 patches in 1 year
        vivek javiya made 3 patches in 1 month, and 5 patches in 1 year
        Devansh Varshney made 3 patches in 1 month, and 3 patches in 1 year
        Akshay Warrier made 3 patches in 1 month, and 6 patches in 1 year
      • top 10 reviewers:
        Caolán McNamara made 184 review comments in 1 month, and 1196 in 1 year
        Vajna, Miklos made 168 review comments in 1 month, and 1032 in 1 year
        Grandin, Noel made 98 review comments in 1 month, and 628 in 1 year
        Michael Stahl made 90 review comments in 1 month, and 1020 in 1 year
        Christian Lohmaier made 78 review comments in 1 month, and 372 in 1 year
        Thorsten Behrens made 78 review comments in 1 month, and 620 in 1 year
        Taichi Haradaguchi made 68 review comments in 1 month, and 142 in 1 year
        Ilmari Lauhakangas made 66 review comments in 1 month, and 472 in 1 year
        Xisco Fauli made 60 review comments in 1 month, and 782 in 1 year
        Nabet, Julien made 56 review comments in 1 month, and 956 in 1 year
      • big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
        Ahmed Hamed
        Anish Deshpande
        Po-Yen Huang (OSSII)
        Zeph Chai
  • Outreachy (Ilmari)

    • find in the sidebar for Writer: project time extended (5 weeks)
    • qt welding project: official project completed
  • GSoC (Ilmari)

  • Commit Access

  • Developer Certification (Stephan/Miklos/László/Gabriel)

    • resting since: 19 weeks (limit: 20 weeks)
  • Jenkins / CI update (Cloph)
    gerrit_android_aarch64 jobs: 219 ok: 204 ko: 13 fail ratio: 5.94% mean_ok: 8 ( 16) median_ok: 6 ( 11)
    gerrit_android_arm jobs: 221 ok: 209 ko: 9 fail ratio: 4.07% mean_ok: 8 ( 16) median_ok: 6 ( 11)
    gerrit_android_x86 jobs: 218 ok: 204 ko: 12 fail ratio: 5.50% mean_ok: 8 ( 16) median_ok: 6 ( 12)
    gerrit_android_x86_64 jobs: 222 ok: 206 ko: 12 fail ratio: 5.41% mean_ok: 8 ( 16) median_ok: 6 ( 12)
    gerrit_linux_clang_dbgutil jobs: 448 ok: 357 ko: 78 fail ratio: 17.41% mean_ok: 35 ( 43) median_ok: 32 ( 41)
    gerrit_linux_gcc_release jobs: 546 ok: 418 ko: 102 fail ratio: 18.68% mean_ok: 17 ( 22) median_ok: 14 ( 16)
    gerrit_mac jobs: 442 ok: 391 ko: 30 fail ratio: 6.79% mean_ok: 49 ( 51) median_ok: 48 ( 48)
    gerrit_windows jobs: 453 ok: 339 ko: 93 fail ratio: 20.53% mean_ok: 59 (102) median_ok: 48 ( 76)
    gerrit_master_ml jobs: 565 ok: 284 ko: 229 fail ratio: 40.53% mean_ok: 121 (122) median_ok: 94 ( 94)
    gerrit_master jobs: 61 ok: 30 ko: 25 fail ratio: 40.98% mean_ok: 86 ( 93) median_ok: 71 ( 71)
    gerrit_master_seq jobs: 511 ok: 258 ko: 206 fail ratio: 40.31% mean_ok: 122 (126) median_ok: 98 ( 98)

    • https://dev-www.libreoffice.org/tmp/gerrit_240229.html
    • tests that failed more than twice in last seven days
      3 CppunitTest_sw_layoutwriter2 gerrit_windows
      4 aborted by jenkins job timeout gerrit_windows
      4 CppunitTest_sw_ooxmlexport12 gerrit_windows
      5 JunitTest_chart2_unoapi gerrit_linux_clang_dbgutil
      6 JunitTest_sw_complex gerrit_linux_clang_dbgutil
      8 UITest_writer_tests8 gerrit_linux_clang_dbgutil
      15 CppunitTest_sw_a11y gerrit_linux_gcc_release
      17 CppunitTest_sw_a11y gerrit_windows
      22 CppunitTest_toolkit_a11y gerrit_linux_gcc_release
    • this week was OK in terms of bot failures (Cloph)
    • last week the ML job put ~all changes to the risky category
    • the queue was larger than usual, mostly the PDF import patches
    • hope this settled down now
    • seeing lots of a11y test failures? (Michael W)
  • What’s cooking (Miklos)

    • A11y update (Michael W)

      • gtk4: new GtkAtspiSocket API in Gtk 4.14, could potentially be used to

        do own AT-SPI implementation + bridge that to the Gtk widget hierarchy,

        discussion at Can Gtk 4 support the AtspiDocument interface? (#6197) · Issues · GNOME / gtk · GitLab

      • qt6: API for reporting a11y object attributes (QAccessibleAttributesInterface)

        merged upstream + implemented in LO

      • new keyboard shortcut for jumping to foot-/endnote, thanks Heiko! (tdf#159863)

      • improvements to Writer Navigator a11y (tdf#159910)

      • some crash fixes

    + still working on importing 3D scenes from MSO (Regina)
    
       + currently thinking about lighting
    
       + current ODF is not able to describe these lights from MSO
    
       + see discussion on the libreoffice@ list, also has input from Armin
    
    • pdf import improvements (David)
    • cmake find modules for SDK examples (Hossein)
      • Set of patches from Konstantin (WIP)
        https://gerrit.libreoffice.org/c/core/+/162978
      • Similar structure is needed for qmake
      • would this mean duplicated build systems for each example? (Miklos)
        • for each example, the maintenance would be low, hopefully (Hossein)
      • would be the goal to have old/cmake/qmake, 3 parallel build systems? (Miklos)
        • yes, for now (Hossein)
        • the cmake part for each example is small
      • smells like explosion of combinatorics (Stephan)
        • would be careful before going down that road
      • if the end goal is to settle down on cmake, love it (Thorsten)
        • but 3 in the long run is far from ideal.
      • cmake is not that exotic, we require it already for doxygen (Miklos)
        • which makes it supported on CI already (Thorsten)
      • if interested in doing the work + update the docs, then why not, as long as it’s a single build system (Stephan)
        • but then do avoid qmake, and do switch over from gmake at the end
        • avoids the exploson
    • Excel 2021 functions (Balazs Varga)
      • XLOOKUP, XMATCH, FILTER etc
      • also ironically some functions came from google sheets originally,
        then → excel → Calc
      • Help pages ready to be filled (ohallot).
      • we also try to submit suitable ODF TC enhancement requests (Thorsten)
      • parallel computation has some special-cases for LOOKUP (Caolan)
        • keep that in mind for XLOOKUP
  • COOL Days 2024 (Miklos)

  • QA update (Xisco)

  • QA stats (Stéphane)

  • Bisected bugs open: keyword ‘bisected’

    done by:
       Kevin Suo              5
       Raal                   4
       Stéphane Guillou       3
       Xisco Fauli            2
       Aron Budea             1
       Ilmari Lauhakangas     1
       Kelemen, Gabor         1
       Michael Stahl          1
    
  • Bibisected bugs open: keyword ‘bibisected’

    done by:
       Raal                   4
       Michael Warner         3
       Stéphane Guillou       3
       Aron Budea             2
       Ilmari Lauhakangas     2
       Xisco Fauli            2
       Kelemen, Gabor         1
    
  • all bugs tagged with ‘regression’

    • 1255(-3) bugs open of 13216(+16) total 22(+0) high prio.

      done by:
      Stéphane Guillou 5
      Raal 3
      Ilmari Lauhakangas 2
      Ady 1
      Kelemen, Gabor 1
      Michael Warner 1
      Michael Stahl 1
      OfficeUser 1
      Xisco Fauli 1

  • ~Component count net * high severity regressions

    • Bug List
      Writer - 14(-1)
      LibreOffice - 2(+0)
      Calc - 1(+0)
      Draw - 1(+1)
      Impress - 1(+0)
      Printing and PDF export - 1(+0)
      UI - 1(+0)

    by OS:
    All - 15(-1)
    Linux - 6(+1)
    Mac OS X - 0(+0)
    Windows - 1(+0)

  • ~Component count net * all regressions

    • Bug List
      Writer: other - 452(-3)
      Calc - 231(+1)
      Impress - 125(-3)
      LibreOffice - 54(-2)
      Crashes - 51(-1)
      Draw - 51(+1)
      Writer: docx filter - 45(+0)
      Base - 38(+0)
      Borders - 36(+1)
      UI - 35(+0)
      Writer: perf - 34(+0)
      Writer: other filter - 31(+0)
      Printing and PDF export - 26(+0)
      Chart - 23(+0)
      RTL - 23(+0)
      filters and storage - 23(+0)
      BASIC - 19(+0)
      Writer: doc filter - 16(+0)
      graphics stack - 12(+1)
      Formula Editor - 7(+0)
      framework - 3(+0)
      Extensions - 2(+0)
      sdk - 2(+0)
      Linguistic - 1(+0)