ESC meeting minutes: 2024-02-22

[vmiklos]

• Present:

  • Hossein, Oliver, Stephan, Xisco, Caolan, Cloph, Eike, Gokay, Heiko, Ilmari, Michael S, Michael W, Stephan, Miklos

• Completed Action Items:

  • atticize gnu-make-lo.git, finish this (Thorsten)

• Pending Action Items:

• Release Engineering update (Cloph)

  • 7.6.5 announced as final today
  • 7.6: 7.6.6 RC1 in 2 weeks
  • 24.2.1: RC2 this week
  • app store versions:
    • 7.6.5 will be published as an update soon

• Revert Shortcut modifications in German UI (Xisco)

  • 7 commits: 159743 – German UI: Many not plausible Keyboard Shortcut Changes

  • Bring compatibility with MSO. Gökay Şatır

  • Some german speaking users already complaining. 4 reports so far.

  • First approach: change Search shortcut: https://gerrit.libreoffice.org/c/core/+/163441

  • Revert proposal: https://gerrit.libreoffice.org/c/core/+/163484

  • nothing against these changes, but (Xisco)

    • 7 commits, goal is to be compatible with MSO

    • 24.2 is out, German speaking users complain about the change

    • e.g. the search shortcut is used a lot and is changed

    • but there were complaints about others as well

    • proposal: revert in 24.2 to have time to discuss it for 24.8

    • not feeling comfortable with pushing the button before reaching agreement

    • wanted to attract people from MSO side to feel comfortable in LO as well (Gokay)

      • of course the existing LO user’s point of view is also reasonable

      • didn’t expect a pushback

      • can live with a revert and then hope to put some of this back over time step by step?

    • Stuart’s comment (Ilmari)

      • see 159743 – German UI: Many not plausible Keyboard Shortcut Changes

      • idea would be to have an opt-in checkbox to have MSO-compatible defaults

      • and leave the actual default unchanged

      • maybe going this way is needed (Gokay)

    • the commit message didn’t really specify what was research was done (Cloph)

      • tried to research this, have a German MSO + German keyboard (Gokay)

      • hoped to be a general change, but the focus is on MSO

    • example with the navigator (Heiko)

      • F5 to open it, then Ctrl-F opens it

      • believe F5 needs to stay at the navigator

      • local shortcuts area ideally discussed by the local community

    • also the help pages need updating (Cloph)

  => go ahead with the revert for now (all)

  • hope to find a way that works for everyone in the future (Xisco)

• Documentation (Olivier)

  • Helpcontent2

    • Help pages no Calc XMATCH and XLOOKUP (ohallot)
    • Scriptforge updates (A. Romedenne)
    • Typos (A. Gelmini)
    • Review of terminolgy changes (7.6 & 24.2) reflected in Help

  • Guides

    • Work in progress.

  • Bugzilla Documentation statistics
    285(285) bugs open

  • Updates:
    BZ changes 1 week 1 month 3 months 12 months
    created 8(-1) 22(0) 44(2) 242(-7)
    commented 6(-14) 51(-6) 157(-2) 904(-32)
    resolved 0(-3) 5(0) 14(-1) 116(-8)

  • top 10 contributors:
    Vernon, Stuart Foote made 22 changes in 1 month, and 42 changes in 1 year
    Olivier Hallot made 19 changes in 1 month, and 327 changes in 1 year
    Alain Romedenne made 10 changes in 1 month, and 13 changes in 1 year
    Stéphane Guillou made 10 changes in 1 month, and 274 changes in 1 year
    Kaganski, Mike made 9 changes in 1 month, and 64 changes in 1 year
    Dan Dascalescu made 7 changes in 1 month, and 7 changes in 1 year
    Heiko Tietze made 5 changes in 1 month, and 88 changes in 1 year
    UNKNOWN made 5 changes in 1 month, and 6 changes in 1 year
    Juan José González made 4 changes in 1 month, and 4 changes in 1 year
    Kelemen, Gabor made 4 changes in 1 month, and 4 changes in 1 year

• UX Update (Heiko)

  • Bugzilla (topicUI) statistics
    250(250) (topicUI) bugs open, 33(33) (needsUXEval) needs to be evaluated by the UXteam
  • Updates:
    BZ changes 1 week 1 month 3 months 12 months
    added 5(3) 5(0) 7(-2) 20(-1)
    commented 90(64) 214(39) 530(12) 2077(31)
    removed 0(0) 0(0) 2(0) 14(1)
    resolved 8(4) 37(0) 82(5) 319(0)
  • top 10 contributors:
    Heiko Tietze made 131 changes in 1 month, and 1257 changes in 1 year
    Vernon, Stuart Foote made 48 changes in 1 month, and 281 changes in 1 year
    Ady made 39 changes in 1 month, and 144 changes in 1 year
    Stéphane Guillou made 34 changes in 1 month, and 601 changes in 1 year
    Rafael Lima made 17 changes in 1 month, and 93 changes in 1 year
    Ilmari Lauhakangas made 14 changes in 1 month, and 195 changes in 1 year
    Eyal Rozenberg made 11 changes in 1 month, and 177 changes in 1 year
    Timur made 11 changes in 1 month, and 30 changes in 1 year
    Bob Harvey made 10 changes in 1 month, and 10 changes in 1 year
    Németh, László made 9 changes in 1 month, and 23 changes in 1 year
  • [Bug 159738] CALC UI: Menu item “View headers” in menu “View” named wrong
  • [Bug 159748] UI: Cell protection dialog reference menu that don’t exist
  • [Bug 159543] Cannot resize graphical objects that overlap header/footer
  • [Bug 159737] Lowercase “a” and uppercase “A” wrongly shows as one “a” in
    Autofilter dropdown

• Crash Testing (Caolan)

  • 8(+3) import failure, 5(+2) export failures
    - think the last ItemSet problems are now sorted out, will see in the next run
    - Development/Crashtesting - The Document Foundation Wiki
  • 2 coverity issues
  • 5 ossfuzz issues
    - 1 crash, expected fix committed

• Crash Reporting (Xisco)

  • 7.6.2.1 47221(+1551)
  • 7.6.3.2 7903(+403)
  • 7.6.4.1 31005(+3359)
  • 24.2.0.3 5145(+2030)

• Mentoring (Hossein)

  • Reviewed submissions from the newcomers
  • Finalized and published a blog post for a difficultyInteresting EasyHack
    Make Impress master slides copyable – difficulty interesting EasyHack
    Make Impress master slides copyable - difficulty interesting EasyHack - LibreOffice Development Blog
    committer… 1 week 1 month 3 months 12 months
    open 70(-13) 139(1) 139(-2) 139(-2)
    reviews 422(8) 1514(20) 3514(-20) 11988(34)
    merged 295(34) 1168(24) 3242(47) 12487(24)
    abandoned 10(-2) 45(-7) 188(-28) 650(-4)
    own commits 167(18) 708(-12) 2263(-34) 9559(-93)
    review commits 98(40) 289(18) 860(50) 3090(29)
    contributor… 1 week 1 month 3 months 12 months
    open 19(-21) 247(-20) 247(-27) 248(-27)
    reviews 798(-4) 2880(16) 7720(-32) 30186(-194)
    merged 38(16) 102(13) 348(15) 2023(-69)
    abandoned 11(7) 45(6) 132(-16) 535(4)
    own commits 49(23) 138(16) 332(39) 1058(28)
    review commits 0(0) 0(0) 0(0) 0(0)
    • easyHack statistics:
      needsDevEval 8(8) needsUXEval 1(1) cleanup_comments 325(325)
      total 411(411) assigned 26(26) open 352(352)
    • top 10 contributors:
      Kurt Nordback made 20 patches in 1 month, and 21 patches in 1 year
      Dione Maddern made 14 patches in 1 month, and 22 patches in 1 year
      Armin Le Grand (allotropia) made 11 patches in 1 month, and 85 patches in 1 year
      Luv Sharma made 6 patches in 1 month, and 12 patches in 1 year
      Eli Schwartz made 5 patches in 1 month, and 5 patches in 1 year
      Akshay Warrier made 4 patches in 1 month, and 6 patches in 1 year
      Hubert Figuière made 4 patches in 1 month, and 4 patches in 1 year
      Weblate made 3 patches in 1 month, and 18 patches in 1 year
      vivek javiya made 3 patches in 1 month, and 5 patches in 1 year
      Devansh Varshney made 3 patches in 1 month, and 3 patches in 1 year
    • top 10 reviewers:
      Caolán McNamara made 188 review comments in 1 month, and 1170 in 1 year
      Vajna, Miklos made 116 review comments in 1 month, and 968 in 1 year
      Michael Stahl made 110 review comments in 1 month, and 1036 in 1 year
      Grandin, Noel made 106 review comments in 1 month, and 630 in 1 year
      Thorsten Behrens made 88 review comments in 1 month, and 618 in 1 year
      Ilmari Lauhakangas made 80 review comments in 1 month, and 458 in 1 year
      Nabet, Julien made 68 review comments in 1 month, and 980 in 1 year
      Christian Lohmaier made 66 review comments in 1 month, and 356 in 1 year
      Xisco Fauli made 66 review comments in 1 month, and 782 in 1 year
      Taichi Haradaguchi made 58 review comments in 1 month, and 122 in 1 year
    • Patches automatically abandoned:
      Simplify long if statements ( Hannah Meeks )
      - https://gerrit.libreoffice.org/#/c/155868
      tdf#156776 Base Table Design Save As For Dummies… ( Pierre Vacher )
      - https://gerrit.libreoffice.org/#/c/155950
      Ensure BarOfPie has ScaleData::ShiftedCategoryPosition == false ( Kurt Nordback )
      - https://gerrit.libreoffice.org/#/c/156367
      Restructuring to support reasonably code-efficient design for of-pie charts ( Kurt Nordback )
      - https://gerrit.libreoffice.org/#/c/156460
      Some rejiggering of of-pie code, plus implementing subpie chart ( Kurt Nordback )
      - https://gerrit.libreoffice.org/#/c/157302
      vcl: const parameters of local functions in outdev/text.cxx ( Chris Sherlock )
      - https://gerrit.libreoffice.org/#/c/159656
      vcl: move textlineinfo.hxx to inc/text and move classes to vcl::text namespace ( Chris Sherlock )
      - https://gerrit.libreoffice.org/#/c/159971
    • big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
      Kevin Ottens

• Outreachy (Ilmari)

  • find in the sidebar for Writer – patch is pending review
  • several patches for the qt welding project

• GSoC (Ilmari)

  • Google Summer of Code
  • Development/GSoC/2024 - The Document Foundation Wiki
  • till March 18: Potential participants discuss application ideas

• Deprecating Windows 7 and 8/8.1? (Ilmari)

  • Firefox 115 ESR is the last release supporting anything older than Windows 10
    • EOL of that is September 2024, FWIW (Miklos)
  • Chrome 110 (released a year ago) requires Windows 10
  • Market share looks like 5% of Windows.
  • What does “deprecating” mean? (Hossein)
    • deprecating means: announcement of the intention (Ilmari)
  • Amend wording to make clear that OS versions no longer supported by the OS Vendor are only compatible on a best-effort basis, no explicit testing is done, and while we don’t intentionally break functionality some things might not work without us realizing (Cloph)
  • If the release notes say so, the website will also need updating (Stephane)
    • that can be done, but it comes in 2025
      AI: add this to the 24.8 release notes (Ilmari)

• Commit Access

• Developer Certification (Stephan/Miklos/László/Gabriel)

  • resting since: 18 weeks (limit: 20 weeks)

• Jenkins / CI update (Cloph)
  gerrit_android_aarch64 jobs: 207 ok: 195 ko: 4 fail ratio: 1.93% mean_ok: 9 ( 21) median_ok: 7 ( 17)
  gerrit_android_arm jobs: 207 ok: 201 ko: 2 fail ratio: 0.97% mean_ok: 9 ( 20) median_ok: 7 ( 14)
  gerrit_android_x86 jobs: 206 ok: 197 ko: 3 fail ratio: 1.46% mean_ok: 8 ( 20) median_ok: 7 ( 15)
  gerrit_android_x86_64 jobs: 207 ok: 199 ko: 3 fail ratio: 1.45% mean_ok: 10 ( 21) median_ok: 7 ( 15)
  gerrit_linux_clang_dbgutil jobs: 428 ok: 262 ko: 146 fail ratio: 34.11% mean_ok: 39 ( 45) median_ok: 32 ( 42)
  gerrit_linux_gcc_release jobs: 488 ok: 407 ko: 54 fail ratio: 11.07% mean_ok: 17 ( 26) median_ok: 15 ( 22)
  gerrit_mac jobs: 420 ok: 316 ko: 85 fail ratio: 20.24% mean_ok: 51 ( 52) median_ok: 48 ( 48)
  gerrit_windows jobs: 438 ok: 293 ko: 118 fail ratio: 26.94% mean_ok: 61 ( 87) median_ok: 47 ( 72)
  gerrit_master_ml jobs: 521 ok: 233 ko: 235 fail ratio: 45.11% mean_ok: 107 (107) median_ok: 87 ( 88)
  gerrit_master jobs: 58 ok: 28 ko: 27 fail ratio: 46.55% mean_ok: 76 ( 76) median_ok: 69 ( 69)
  gerrit_master_seq jobs: 460 ok: 206 ko: 204 fail ratio: 44.35% mean_ok: 108 (110) median_ok: 90 ( 91)

  • https://dev-www.libreoffice.org/tmp/gerrit_240222.html
  • tests that failed more than twice in last seven days
    3 aborted by jenkins job timeout gerrit_windows
    3 CppunitTest_sc_subsequent_filters_test3 gerrit_windows
    3 CppunitTest_sw_layoutwriter2 gerrit_windows
    3 UITest_writer_tests7 gerrit_linux_clang_dbgutil
    4 CppunitTest_sc_filters_test gerrit_linux_gcc_release
    4 CppunitTest_toolkit_a11y gerrit_linux_gcc_release
    4 JunitTest_sw_complex gerrit_linux_clang_dbgutil
    4 UITest_writer_tests8 gerrit_linux_clang_dbgutil
    5 CppunitTest_sw_a11y gerrit_windows
    5 CppunitTest_test_a11y gerrit_windows
    10 CppunitTest_sw_pdf_test gerrit_linux_clang_dbgutil
    • this week was OK in terms of Windows builds (Cloph)
    • CppunitTest_sw_pdf_test might be a dependency issue, but didn’t look closely
    • there is also a long change chain in the queue (Cloph)
      • possibly this chain produced the pdf failures
    • CppunitTest_test_a11y failures, was that a bot related failure or not? (Michael W)
      • possibly was an attempt to just keep the build more stable, probably not bot related (Cloph)

• What’s cooking (Miklos)

  • A11y update (Michael W)
    • gtk4: Implement new GtkAccessibleTextInterface, related Gtk upstream fixes
    • Accerciser: submitted MR to make “Select object under mouse pointer” work for
      Gtk 4 apps on X11, related Gtk fixes
  • JJ’s work on crash report website (Stéphane)
    • repo is now on gerrit, under infra, open for contributions

• COOL Days 2024 (Miklos)

  • COOL Days 2024 - 8-10 April - Cambridge, UK - Collabora Office and Collabora Online 8th → 10th April
  • contributors can submit 5 mins talk proposals at https://eventyay.com/e/0512424d/cfs
  • LibreOffice Technology hackfest as part of it

• QA update (Xisco)

  • UNCONFIRMED: 1120 (-7)

    • enhancements: 265 (+4)
    • needsUXEval: 2 (-3)
    • haveBackTrace: 9 (+0)
    • needsDevAdvice: 45 (+0)
    • documentation: 10 (+1)
    • android: 0 (+0)
    • iOS: 0 (+0)
    • Online: 9 (-1)

  • Most pressing bugs:
    New:

    • Crash at undo of RTF Paste
      • 159385 – Crash at undo of RTF Paste
      • bisected to Tomaz

  • New high severity bugs of the week:

    • Libreoffice unusable with different scale factors used for different screens in multimonitor setup (on kf5/qt5/qt6 vcl + wayland)

      • 141578 – Libreoffice unusable with different scale factors used for different screens in multimonitor setup (on kf5/qt5/qt6 vcl + wayland)
      • not tagged as a regression

    • LibreOffice Calc ODS files saved with passwords under 7.6.4 (X86_64) cannot be opened in 24.2.0.3 (X86_64) (Windows 7)

      • 159512 – LibreOffice Calc ODS files saved with passwords under 7.6.4 (X86_64) cannot be opened in 24.2.0.3 (X86_64) (Windows 7)
      • Fixed. Thanks to M. Stahl

    • Manual line break forces automatic Wrap Text

      • 159690 – Manual line break forces automatic Wrap Text
      • bisected to Paris

• QA stats (Stéphane)

  • Weekly Bug Summary
    +97 +6 (-88) overall)
    many thanks to the top bug squashers:
    QA Administrators 11
    Buovjaga 9
    Gabor Kelemen (allotropia) 5
    Stéphane Guillou (stragu) 5
    Heiko Tietze 4
    Julien Nabet 4
    Laurent Balland 4
    Michael Stahl (allotropia) 4
    Mike Kaganski 3
    V Stuart Foote 3

  • top 10 bugs reporters:
    Gabor Kelemen (allotropia) 4
    lvm 4
    Adalbert Hanßen 3
    Oliver Specht (CIB) 3
    Olivier Hallot 3
    Aron Budea 2
    Buovjaga 2
    Mukul Gupta 2
    Stéphane Guillou (stragu) 2
    Telesto 2

  • top 10 bugs fixers:
    Kelemen, Gabor 5
    Balland-Poirier, Laurent 4
    Kaganski, Mike 3
    Michael Stahl 3
    Balazs Varga 1
    Baole Fang 1
    Caolán McNamara 1
    Grandin, Noel 1
    Henschel, Regina 1
    Ilmari Lauhakangas 1

  • top 10 bugs confirmers:
    Ilmari Lauhakangas 20
    Stéphane Guillou 11
    m.a.riosv 5
    UNKNOWN 4
    Aron Budea 3
    Heiko Tietze 3
    Kaganski, Mike 3
    Raal 3
    Xisco Fauli 3
    Ady 2

• Bisected bugs open: keyword ‘bisected’

  • more accurate - down to a single commit.
  • Bug List: LibreOffice Bi-bisected

  done by:
     Stéphane Guillou       4
     Aron Budea             3
     Xisco Fauli            3
     Ilmari Lauhakangas     2
     Kevin Suo              2
     Justin Luth            1
     Kaganski, Mike         1
     Telesto                1
  

• Bibisected bugs open: keyword ‘bibisected’

  • Bug List: LibreOffice Bi-bisected

  done by:
     Stéphane Guillou       5
     Aron Budea             3
     Xisco Fauli            3
     Ilmari Lauhakangas     2
     Bogdan B               1
     Justin Luth            1
     Telesto                1
  

• all bugs tagged with ‘regression’

  • 1258(+1) bugs open of 13200(+6) total 22(+0) high prio.

    done by:
    Stéphane Guillou 3
    Ilmari Lauhakangas 2
    Ady 1
    Bogdan B 1
    Gerald Pfeifer 1
    Justin Luth 1
    Raal 1
    Nabet, Julien 1
    Telesto 1
    Vernon, Stuart Foote 1

• ~Component count net * high severity regressions

  • Bug List
    Writer - 15(+1)
    LibreOffice - 2(+0)
    Calc - 1(-1)
    Impress - 1(+0)
    Printing and PDF export - 1(+0)
    UI - 1(+0)

  by OS:
  All - 16(+0)
  Linux - 5(+0)
  Mac OS X - 0(+0)
  Windows - 1(+0)

• ~Component count net * all regressions

  • Bug List
    Writer: other - 455(+0)
    Calc - 230(-1)
    Impress - 128(-2)
    LibreOffice - 56(+2)
    Crashes - 52(+0)
    Draw - 50(+0)
    Writer: docx filter - 45(+0)
    Base - 38(+0)
    Borders - 35(+0)
    UI - 35(-1)
    Writer: perf - 34(+0)
    Writer: other filter - 31(+0)
    Printing and PDF export - 26(+0)
    Chart - 23(+0)
    RTL - 23(+0)
    filters and storage - 23(+2)
    BASIC - 19(+0)
    Writer: doc filter - 16(+0)
    graphics stack - 11(+0)
    Formula Editor - 7(+0)
    framework - 3(+0)
    Extensions - 2(+0)
    sdk - 2(+0)
    Linguistic - 1(+0)