ESC meeting minutes: 2024-02-08

  • Present:

    • Cloph, Xisco, Caolan, Eike, Heiko, Hossein, Ilmari, Michael W, Michael S, Miklos, Thorsten, Regina
  • Completed Action Items:

  • Pending Action Items:

  • Release Engineering update (Cloph)

    • 7.6: 7.6.5 RC2 in 1 week
    • 24.2.1: RC 1 this week: later today (tag + branch)
  • Documentation (Olivier)

    • Missing Olivier
    • Bugzilla Documentation statistics
      280(280) bugs open
    • Updates:
      BZ changes 1 week 1 month 3 months 12 months
      created 8(7) 15(4) 37(5) 245(2)
      commented 12(7) 44(-8) 155(9) 938(2)
      resolved 2(2) 3(-1) 13(-1) 125(-2)
    • top 10 contributors:
      Stéphane Guillou made 10 changes in 1 month, and 274 changes in 1 year
      Kaganski, Mike made 8 changes in 1 month, and 60 changes in 1 year
      Olivier Hallot made 8 changes in 1 month, and 366 changes in 1 year
      UNKNOWN made 6 changes in 1 month, and 6 changes in 1 year
      Heiko Tietze made 5 changes in 1 month, and 99 changes in 1 year
      Ilmari Lauhakangas made 5 changes in 1 month, and 90 changes in 1 year
      Kelemen, Gabor made 4 changes in 1 month, and 4 changes in 1 year
      Nabet, Julien made 4 changes in 1 month, and 46 changes in 1 year
      Telesto made 4 changes in 1 month, and 9 changes in 1 year
      Robert Großkopf made 3 changes in 1 month, and 10 changes in 1 year
  • UX Update (Heiko)

    • Bugzilla (topicUI) statistics
      248(248) (topicUI) bugs open, 43(43) (needsUXEval) needs to be evaluated by the UXteam
    • Updates:
      BZ changes 1 week 1 month 3 months 12 months
      added 2(-4) 5(-9) 12(-15) 25(-14)
      commented 77(24) 183(18) 534(15) 2119(-13)
      removed 0(0) 0(0) 2(-1) 13(0)
      resolved 15(5) 35(11) 77(10) 326(6)
    • top 10 contributors:
      Heiko Tietze made 127 changes in 1 month, and 1270 changes in 1 year
      Stéphane Guillou made 70 changes in 1 month, and 635 changes in 1 year
      Vernon, Stuart Foote made 39 changes in 1 month, and 281 changes in 1 year
      Rafael Lima made 17 changes in 1 month, and 112 changes in 1 year
      Ady made 12 changes in 1 month, and 125 changes in 1 year
      Eyal Rozenberg made 10 changes in 1 month, and 197 changes in 1 year
      Justin Luth made 10 changes in 1 month, and 124 changes in 1 year
      Samuel Mehrbrodt made 8 changes in 1 month, and 18 changes in 1 year
      Akshay Warrier made 7 changes in 1 month, and 7 changes in 1 year
      Ilmari Lauhakangas made 7 changes in 1 month, and 191 changes in 1 year
    • [Bug 159409] Dialog Properties bigger then screen
      → + [Bug 159573] Show most important changes for new releases in a dialog
      • get rid of one (potentially stacked) infobar
    • [Bug 159470] Spelling and Language support in LibreOffice Writer unusable

    → + [Bug 159537] Bootstrap in Writer
    + resurrect html capabilitties?

  • Crash Testing (Caolan)

    • 12(+1) import failure, 2(+2) export failures
    • 8 coverity issues
      • possible improvements to itemholder warnings merged, build underway
    • 4 ossfuzz issues, no crashes
  • Crash Reporting (Xisco)

    • 7.6.3.2 7037(+497)
    • 7.6.4.1 24274(+3763)
    • 24.2.0.3 1173(+0)
    • Regressions in 24.2.0
  • Mentoring (Hossein)

    • Reviewed submissions from the newcomers
    • Finalized and published a new blog post on gbuild
      gbuild for Java tests – LibreOffice build system part 3
      gbuild for Java tests – LibreOffice build system part 3 - LibreOffice Development Blog
    • Contacted 2 new volunteers via VolunteerMatch
      • 1 call
    • Build issues with Cygwin 3.5.0
      • For now, downgrade to 3.4.10 is suggested

      • did we try to file a bugreport towards them? (Miklos)

        • the issue is visible to Stephan and Mike K as well.
        • might be specific to windows 11 (Ilmari)

        committer… 1 week 1 month 3 months 12 months
        open 88(26) 147(21) 149(15) 149(15)
        reviews 408(-40) 1580(98) 3504(100) 11962(124)
        merged 236(-44) 1163(13) 3237(28) 12400(87)
        abandoned 12(3) 52(-2) 215(9) 649(3)
        own commits 139(-53) 755(-26) 2408(-58) 9674(9)
        review commits 39(-23) 300(-32) 812(5) 3052(16)
        contributor… 1 week 1 month 3 months 12 months
        open 101(-72) 282(65) 283(-4) 284(-4)
        reviews 818(46) 3012(142) 7918(44) 30428(106)
        merged 17(3) 90(-13) 338(-41) 2153(-62)
        abandoned 17(5) 52(7) 146(11) 544(12)
        own commits 18(-7) 122(-5) 273(7) 1017(8)
        review commits 0(0) 0(0) 0(0) 0(0)

    • easyHack statistics:
      needsDevEval 8(8) needsUXEval 1(1) cleanup_comments 326(326)
      total 414(414) assigned 25(25) open 356(356)
    • top 10 contributors:
      Dione Maddern made 14 patches in 1 month, and 16 patches in 1 year
      Armin Le Grand (allotropia) made 14 patches in 1 month, and 82 patches in 1 year
      Kira Tubo made 8 patches in 1 month, and 10 patches in 1 year
      Eli Schwartz made 5 patches in 1 month, and 5 patches in 1 year
      Srebotnjak, Martin made 4 patches in 1 month, and 19 patches in 1 year
      Weblate made 4 patches in 1 month, and 17 patches in 1 year
      Luv Sharma made 4 patches in 1 month, and 9 patches in 1 year
      Kurt Nordback made 3 patches in 1 month, and 3 patches in 1 year
      Juan José González made 3 patches in 1 month, and 7 patches in 1 year
      vivek javiya made 3 patches in 1 month, and 4 patches in 1 year
    • top 10 reviewers:
      Caolán McNamara made 162 review comments in 1 month, and 1068 in 1 year
      Michael Stahl made 146 review comments in 1 month, and 1074 in 1 year
      Vajna, Miklos made 126 review comments in 1 month, and 962 in 1 year
      Xisco Fauli made 98 review comments in 1 month, and 800 in 1 year
      Ilmari Lauhakangas made 84 review comments in 1 month, and 460 in 1 year
      Thorsten Behrens made 78 review comments in 1 month, and 614 in 1 year
      Adolfo Jayme Barrientos made 64 review comments in 1 month, and 546 in 1 year
      Hossein made 64 review comments in 1 month, and 290 in 1 year
      Vajngerl, Tomaž made 60 review comments in 1 month, and 402 in 1 year
      Olivier Hallot made 60 review comments in 1 month, and 348 in 1 year
    • Patches automatically abandoned:
      tdf#153709 Partially revert previous fix ( Laurent Balland )
      - https://gerrit.libreoffice.org/#/c/152468
      vcl: flatten OutputDevice::DrawDeviceBitmapEx() ( Chris Sherlock )
      - https://gerrit.libreoffice.org/#/c/157192
      i18npool: split up one line breaking test into seperate tests ( Chris Sherlock )
      - https://gerrit.libreoffice.org/#/c/157417
      i18npool: test line breaking when start pos is greater than the string length ( Chris Sherlock )
      - https://gerrit.libreoffice.org/#/c/157418
      i18npool: test for break pos when string is empty ( Chris Sherlock )
      - https://gerrit.libreoffice.org/#/c/157419
      i18npool: test for break pos when a single space ( Chris Sherlock )
      - https://gerrit.libreoffice.org/#/c/157420
      i18npool: test for break pos when there is a solidus ( Chris Sherlock )
      - https://gerrit.libreoffice.org/#/c/157421
      i18npool: test for linebreak pos when there is a file path ( Chris Sherlock )
      - https://gerrit.libreoffice.org/#/c/157422
      i18npool: test for linebreak pos when there is a hyphen ( Chris Sherlock )
      - https://gerrit.libreoffice.org/#/c/157423
      vcl: assert in GetTextArray() when encountering buggy caller ( Chris Sherlock )
      - https://gerrit.libreoffice.org/#/c/157441
      vcl: move vcllayout.hxx to vcl/text/SalTextLayout.hxx ( Chris Sherlock )
      - https://gerrit.libreoffice.org/#/c/158601
      vcl: move sallayout.hxx to vcl/inc/text ( Chris Sherlock )
      - https://gerrit.libreoffice.org/#/c/158602
      WIP: notes child window ( Sarper Akdemir )
      - https://gerrit.libreoffice.org/#/c/159288
      tdf#122587 Add uno command to set layer of object(s) ( Jim Raykowski )
      - https://gerrit.libreoffice.org/#/c/159982
    • big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
      Heiko Becker
      Tuukka Orava
  • Outreachy (Ilmari)

    • work is ongoing & is on track.
  • GSoC (Ilmari)

  • Commit Access

  • Developer Certification (Stephan/Miklos/László/Gabriel)

    • resting since: 16 weeks (limit: 20 weeks)
  • Jenkins / CI update (Cloph)
    gerrit_android_aarch64 jobs: 149 ok: 140 ko: 6 fail ratio: 4.03% mean_ok: 7 ( 11) median_ok: 4 ( 7)
    gerrit_android_arm jobs: 149 ok: 143 ko: 5 fail ratio: 3.36% mean_ok: 6 ( 10) median_ok: 5 ( 6)
    gerrit_android_x86 jobs: 149 ok: 139 ko: 5 fail ratio: 3.36% mean_ok: 7 ( 10) median_ok: 4 ( 6)
    gerrit_android_x86_64 jobs: 149 ok: 143 ko: 5 fail ratio: 3.36% mean_ok: 7 ( 11) median_ok: 5 ( 6)
    gerrit_linux_clang_dbgutil jobs: 300 ok: 241 ko: 47 fail ratio: 15.67% mean_ok: 31 ( 34) median_ok: 27 ( 30)
    gerrit_linux_gcc_release jobs: 388 ok: 287 ko: 87 fail ratio: 22.42% mean_ok: 14 ( 17) median_ok: 13 ( 14)
    gerrit_mac jobs: 312 ok: 246 ko: 44 fail ratio: 14.10% mean_ok: 50 ( 51) median_ok: 48 ( 48)
    gerrit_windows jobs: 341 ok: 196 ko: 117 fail ratio: 34.31% mean_ok: 56 ( 79) median_ok: 45 ( 57)
    gerrit_master_ml jobs: 484 ok: 162 ko: 282 fail ratio: 58.26% mean_ok: 95 ( 95) median_ok: 72 ( 72)
    gerrit_master jobs: 40 ok: 12 ko: 19 fail ratio: 47.50% mean_ok: 123 (123) median_ok: 114 (114)
    gerrit_master_seq jobs: 406 ok: 150 ko: 225 fail ratio: 55.42% mean_ok: 92 ( 92) median_ok: 72 ( 72)

    • https://dev-www.libreoffice.org/tmp/gerrit_240208.html
    • tests that failed more than twice in last seven days
      3 CppunitTest_drawinglayer_processors gerrit_linux_gcc_release
      3 CppunitTest_sw_layoutwriter2 gerrit_windows
      4 CppunitTest_sc_subsequent_filters_test3 gerrit_windows
      4 CppunitTest_sd_svg_export_tests gerrit_linux_gcc_release
      4 CppunitTest_sw_macros_test gerrit_linux_gcc_release
      4 CppunitTest_vcl_pdfexport2 gerrit_linux_gcc_release
      4 JunitTest_sw_complex gerrit_linux_clang_dbgutil
      5 CppunitTest_test_a11y gerrit_windows
      18 CppunitTest_sw_a11y gerrit_windows
      22 CppunitTest_sw_core_objectpositioning gerrit_mac
      71 aborted by jenkins job timeout gerrit_windows
      • not sure about the cause, but Windows had quite some issues this week (Cloph)
        • also a bit of macOS
      • might be related to a larger patch set
      • CppunitTest_sw_core_objectpositioning problem should be done by now (Xisco)
      • CppunitTest_sw_a11y had some dependency problem, Noel fixed it (Caolan)
      • Will investigate the windows timeouts (Cloph)
  • What’s cooking (Miklos)

    • A11y update (Michael W)
    • tdf#70039 WIP convert 3D effects to extrusion (Regina)
      https://gerrit.libreoffice.org/c/core/+/162594
      • patch is now in a state that it can import geometry of the 3D objects
      • question is: would we prefer to do the other parts in separate commits or want it in one big change
        • material + light + export is still to be done
        • probably better to do it in smaller steps (Miklos)
        • would like a review on this, the geometry is ready.
        • agree, good to have reviewers + get it in soon (Thorsten)
  • FOSDEM 2024 - Hackfest Feb. 5/6 at ICAB Incubator

    • Events/2024/FOSDEM - The Document Foundation Wiki
    • TDF/New-Era Manifesto - The Document Foundation Wiki was mentioned there (Thorsten)
    • got lots of questions about AI, but it’s too fuzzy right now (Thorsten)
    • went to the CI room (Caolan)
      • lots of discussion about flaky tests
      • no actual answer, though
      • heard about a policy: run a test 5 times before require it passing
        • an idea that could be considered
        • any Jenkins tool to do this? (Thorsten)
          • no, it’s all manually controlled (Caolan)
    • previously we had some request for some test that would fail, but not fail the build (Hossein)
  • COOL Days 2024 (Miklos)

  • QA update (Xisco)

    • UNCONFIRMED: 1103 (+20)

      • enhancements: 261 (+0)
      • needsUXEval: 3 (-5)
      • haveBackTrace: 10 (+0)
      • needsDevAdvice: 45 (+0)
      • documentation: 9 (+4)
      • android: 0 (+0)
      • iOS: 0 (+0)
      • Online: 10 (+0)
    • Most pressing bugs:
      New:

      None

    • New high severity bugs of the week:
      None

  • QA stats (Stéphane)

    • Weekly Bug Summary
      +143 -28 (-122) overall)
      many thanks to the top bug squashers:
      Heiko Tietze 18
      Stéphane Guillou (stragu) 18
      Buovjaga 11
      Mike Kaganski 8
      Rafael Lima 7
      QA Administrators 5
      V Stuart Foote 5
      Julien Nabet 4
      Patrick Luby 4
      Miklos Vajna 3

    • top 10 bugs reporters:
      Mike Kaganski 7
      Gabor Kelemen (allotropia) 6
      Jeff Fortin Tam 4
      Rafael Lima 4
      Heiko Tietze 3
      Jimmy 3
      Miklos Vajna 3
      Oliver Specht (CIB) 3
      Xisco Faulí 3
      Felix Rudolphi 2

    • top 10 bugs fixers:
      Kaganski, Mike 5
      Rafael Lima 4
      Heiko Tietze 3
      Vajna, Miklos 3
      Xisco Fauli 3
      Aron Budea 2
      Grandin, Noel 2
      Justin Luth 2
      Matt K 2
      Michael Stahl 2

    • top 10 bugs confirmers:
      Stéphane Guillou 20
      Nabet, Julien 7
      Xisco Fauli 7
      UNKNOWN 6
      Heiko Tietze 6
      Ady 4
      Rafael Lima 4
      Telesto 4
      Ilmari Lauhakangas 3
      Kaganski, Mike 3

  • Bisected bugs open: keyword ‘bisected’

    done by:
       Raal                   6
       Stéphane Guillou       3
       Xisco Fauli            3
       Kelemen, Gabor         1
       Telesto                1
    
  • Bibisected bugs open: keyword ‘bibisected’

    done by:
       Raal                   6
       Stéphane Guillou       3
       Xisco Fauli            3
       Aron Budea             1
       Kelemen, Gabor         1
       Nabet, Julien          1
       Telesto                1
    
  • all bugs tagged with ‘regression’

    • 1265(+6) bugs open of 13182(+21) total 24(+3) high prio.

      done by:
      Stéphane Guillou 8
      Xisco Fauli 3
      Nabet, Julien 2
      Telesto 2
      Username 1
      Kelemen, Gabor 1
      m.a.riosv 1
      Raal 1
      Henschel, Regina 1

  • ~Component count net * high severity regressions

    • Bug List
      Writer - 15(+1)
      Calc - 2(+1)
      LibreOffice - 2(+0)
      Formula Editor - 1(+1)
      Impress - 1(+0)
      Printing and PDF export - 1(+0)
      UI - 1(+0)

    by OS:
    All - 17(+2)
    Linux - 6(+1)
    Mac OS X - 0(+0)
    Windows - 1(+0)

  • ~Component count net * all regressions

    • Bug List
      Writer: other - 455(+4)
      Calc - 233(+4)
      Impress - 130(+1)
      LibreOffice - 56(+0)
      Crashes - 54(+3)
      Draw - 50(-1)
      Writer: docx filter - 44(+1)
      Base - 38(+0)
      UI - 36(-2)
      Borders - 35(+0)
      Writer: perf - 35(+0)
      Writer: other filter - 31(-1)
      Printing and PDF export - 26(+0)
      Chart - 23(+0)
      RTL - 23(-1)
      filters and storage - 21(+0)
      BASIC - 19(+0)
      Writer: doc filter - 16(+0)
      graphics stack - 11(+0)
      Formula Editor - 8(+1)
      framework - 4(+0)
      Extensions - 2(+0)
      sdk - 2(+0)
      Linguistic - 1(-1)