ESC meeting minutes: 2023-11-09

  • Present:

    • Caolan, Heiko, Hossein, Ilmari, Michael W, Regina, Stephan, Stephane, Thorsten, Cloph, Miklos, Michael S, Eike
  • Completed Action Items:

  • Pending Action Items:

    • Set up a daily tinderbox for the python-based windows installer (Cloph)
      [ in progress, .NET 3.5 install is harder than expected ]
  • Release Engineering update (Cloph)

    • 7.5.8 release on Linux:
      • no https access, planning an additional release (RC3) just for that problem, for Linux
      • also for the mac app store version
      • thanks Michael S for fixing
      • affects also the update check service, but no easy solution to that
      • expect people upgrade to 7.6 anyway.
      • or a whole release for all platforms? (Cloph)
        • fine to keep going unchanged (Caolan)
    • 7.6 status: 7.6.3 rc2 next week, as planned
    • 24.2: first alpha in 2 weeks, from master
    • Android version in the play store (Michael W)
      • in progress, addressing the play console warnings
  • Documentation (Olivier)

    • Missing Olivier, LatAm conf is in progress.
    • Bugzilla Documentation statistics
      272(272) bugs open
    • Updates:
      BZ changes 1 week 1 month 3 months 12 months
      created 2(-5) 16(-3) 49(-4) 284(-7)
      commented 12(-1) 50(6) 159(-3) 1068(-8)
      resolved 1(-2) 6(1) 17(-4) 153(-4)
    • top 10 contributors:
      Ilmari Lauhakangas made 13 changes in 1 month, and 131 changes in 1 year
      Heiko Tietze made 10 changes in 1 month, and 112 changes in 1 year
      Seth Chaiklin made 10 changes in 1 month, and 316 changes in 1 year
      Kaganski, Mike made 9 changes in 1 month, and 77 changes in 1 year
      Olivier Hallot made 9 changes in 1 month, and 431 changes in 1 year
      Stéphane Guillou made 8 changes in 1 month, and 359 changes in 1 year
      Jérôme made 6 changes in 1 month, and 6 changes in 1 year
      Adolfo Jayme Barrientos made 1 changes in 1 month, and 22 changes in 1 year
      m.a.riosv made 1 changes in 1 month, and 11 changes in 1 year
      MISY Nyias made 1 changes in 1 month, and 1 changes in 1 year
  • UX Update (Heiko)

    • Bugzilla (topicUI) statistics
      254(254) (topicUI) bugs open, 67(67) (needsUXEval) needs to be evaluated by the UXteam
    • Updates:
      BZ changes 1 week 1 month 3 months 12 months
      added 12(4) 24(8) 29(10) 50(10)
      commented 68(12) 246(51) 490(40) 2264(24)
      removed 1(1) 2(0) 4(1) 18(-2)
      resolved 5(-3) 31(1) 89(1) 332(-4)
    • top 10 contributors:
      Heiko Tietze made 138 changes in 1 month, and 1380 changes in 1 year
      Stéphane Guillou made 130 changes in 1 month, and 612 changes in 1 year
      Eyal Rozenberg made 32 changes in 1 month, and 258 changes in 1 year
      m.a.riosv made 31 changes in 1 month, and 103 changes in 1 year
      Vernon, Stuart Foote made 30 changes in 1 month, and 349 changes in 1 year
      Justin Luth made 25 changes in 1 month, and 118 changes in 1 year
      Ilmari Lauhakangas made 22 changes in 1 month, and 246 changes in 1 year
      Dieter made 20 changes in 1 month, and 245 changes in 1 year
      Amin Irgaliev made 14 changes in 1 month, and 17 changes in 1 year
      Henschel, Regina made 12 changes in 1 month, and 43 changes in 1 year
    • [Bug 158126] UI: Scalable buttons for Impress navigation bar
    • [Bug 158123] Overflow the tabbed interface to scroll/flip instead of a popup
    • [Bug 156915] Cannot access document themes option using tabbed UI
      → + [Bug 137272] Make it less likely that user unwillingly loses footnote and
      endnote font size inheritance from paragraph
      + additional footnote char style adds some flexibility but make things inconsistent
      + no special style in Word, but then can’t change all footnotes at once
      + an option is to hardcode how the footnote is derived from the current char style
      + would leave towards not having a dedicated char style for the footnote portion (Miklos)
      → + [Bug 158069] Scroll through font selection listbox using arrow keys and
      preview change on document canvas
      + sounds nice if it can work fast enough (Miklos)
    • [Bug 158084] Start Center: hover highlight color is inconsistent
    • [Bug 143340] Undo/redo for checking/unchecking KeepRatio in Image Properties
      Dialog not properly handled
    • [Bug 158077] “double bracket” callout name is a misnomer
    • [Bug 157972] Don’t shorten “Relative size” to “Rel. Size” in
      Bullets & Numbering dialog
    • [Bug 158034] Feature request: Editing, Formatting, UI. Option to add linebreaks
      when merging cells into one.
    • [Bug 157945] UI: Resizing of a selection of columns/rows should correspond to
      the mouse position
    • [Bug 158017] Impress Freshes Template using wrong font color in some slides
  • Crash Testing (Caolan)

    • 17(+8) import failure, 10(+10) export failures
      • one calc parallel problem is fixed
      • styleref problem is still to be addressed
      • same for the new content control changes
    • 1 coverity issues
    • 10 ossfuzz issues
      • 4 new leaks (ItemPool?)
      • 1 new OOM in svmfuzzer
      • 2 new TimeOuts
  • Crash Reporting (Xisco)

    • 7.6.0.2 113(+2)
    • 7.6.0.3 15662(+872)
    • 7.6.1.2 7885(+503)
    • 7.6.2.1 13877(+3380)
  • Mentoring (Hossein)

    • New draft blog post on dev blog
    • Used Volunteermatch to attract new contributors for Python
    • Project: Porting LibreOffice SDK Java examples to Python
    • Already received 2 volunteering offers, contacted them
    • Created LibreOffice SDK Programming Guide (SDKGuide) on TDF Wiki
      • Based on JLOP (Java LibreOffice Programming) book by Andrew Davison
      • Imported 6 chapters (text, code, images, etc.)
      • Edited the 6 chapters to update the contents
        LibreOffice SDK Programming Guide - The Document Foundation Wiki
      • plan is to provide C++ implementation for the helper classes, so it’s available to all UNO-using languages
        Utility classes
        https://github.com/hosseinn/jlop-code/tree/main/Utils
        • should we port such code, or just keep java-only?

        • see it as a trade-off: then somebody has to maintain this (Miklos)

        • if it’s real c++ classes, then skeptical (Stephan)

        • An example wrapper is the one that provide an easy way to bootstrap (Hossein)

        • think the current DevGuide already provides simple bootstrap way in C++/Java/Python (Stephan)

          • best to look at this offline.
            • Utils/Lo.java contains this wrapper class
        • next step: write to the dev list and expand on the details (Hossein)

          committer… 1 week 1 month 3 months 12 months
          open 88(-35) 220(19) 220(18) 220(18)
          reviews 302(-146) 1258(-44) 3202(-118) 11800(-22)
          merged 246(-26) 1112(25) 2971(-19) 12833(9)
          abandoned 3(-20) 64(0) 171(-5) 647(-12)
          own commits 192(-3) 843(43) 2130(25) 9670(-13)
          review commits 49(-13) 239(3) 630(13) 2987(-32)
          contributor… 1 week 1 month 3 months 12 months
          open 128(8) 219(48) 219(46) 220(46)
          reviews 760(-178) 3016(76) 7214(12) 30592(-46)
          merged 14(2) 63(1) 181(6) 1951(-44)
          abandoned 5(2) 20(1) 217(3) 610(0)
          own commits 13(-1) 69(-7) 208(0) 1072(-27)
          review commits 0(0) 0(0) 0(0) 0(0)

      • easyHack statistics:
        needsDevEval 8(8) needsUXEval 2(2) cleanup_comments 321(321)
        total 408(408) assigned 22(22) open 359(359)
      • top 10 contributors:
        Sahil Gautam made 5 patches in 1 month, and 15 patches in 1 year
        Omkar Acharekar made 4 patches in 1 month, and 6 patches in 1 year
        Ankit Kumar Jaipuriar made 4 patches in 1 month, and 7 patches in 1 year
        Khushi Gautam made 4 patches in 1 month, and 4 patches in 1 year
        Marco Pinto made 2 patches in 1 month, and 4 patches in 1 year
        Bogdan B made 2 patches in 1 month, and 89 patches in 1 year
        Stéphane Guillou made 2 patches in 1 month, and 39 patches in 1 year
        Venetia Furtado made 2 patches in 1 month, and 7 patches in 1 year
        Martin Gube made 2 patches in 1 month, and 2 patches in 1 year
        Darshan Upadhyay made 2 patches in 1 month, and 3 patches in 1 year
      • top 10 reviewers:
        Caolán McNamara made 174 review comments in 1 month, and 750 in 1 year
        Michael Stahl made 116 review comments in 1 month, and 1180 in 1 year
        Ilmari Lauhakangas made 108 review comments in 1 month, and 430 in 1 year
        Vajna, Miklos made 86 review comments in 1 month, and 902 in 1 year
        Xisco Fauli made 78 review comments in 1 month, and 770 in 1 year
        Nabet, Julien made 72 review comments in 1 month, and 972 in 1 year
        Kaganski, Mike made 68 review comments in 1 month, and 394 in 1 year
        Grandin, Noel made 58 review comments in 1 month, and 608 in 1 year
        Hossein made 52 review comments in 1 month, and 264 in 1 year
        Vajngerl, Tomaž made 34 review comments in 1 month, and 396 in 1 year
  • Commit Access

    • None
  • Developer Certification (Stephan/Miklos/Thorsten/László)

    • resting since: 6 weeks (limit: 20 weeks)
  • Jenkins / CI update (Cloph)
    gerrit_android_aarch64 jobs: 193 ok: 188 ko: 4 fail ratio: 2.07% mean_ok: 7 ( 12) median_ok: 5 ( 8)
    gerrit_android_arm jobs: 194 ok: 184 ko: 9 fail ratio: 4.64% mean_ok: 7 ( 11) median_ok: 5 ( 8)
    gerrit_android_x86 jobs: 192 ok: 186 ko: 4 fail ratio: 2.08% mean_ok: 8 ( 11) median_ok: 6 ( 7)
    gerrit_android_x86_64 jobs: 192 ok: 184 ko: 6 fail ratio: 3.12% mean_ok: 8 ( 12) median_ok: 5 ( 8)
    gerrit_linux_clang_dbgutil jobs: 417 ok: 324 ko: 87 fail ratio: 20.86% mean_ok: 38 ( 42) median_ok: 35 ( 37)
    gerrit_linux_gcc_release jobs: 424 ok: 382 ko: 30 fail ratio: 7.08% mean_ok: 16 ( 18) median_ok: 13 ( 14)
    gerrit_mac jobs: 401 ok: 357 ko: 33 fail ratio: 8.23% mean_ok: 45 ( 66) median_ok: 42 ( 44)
    gerrit_windows jobs: 458 ok: 334 ko: 112 fail ratio: 24.45% mean_ok: 67 (107) median_ok: 67 ( 83)
    gerrit_master_ml jobs: 513 ok: 292 ko: 194 fail ratio: 37.82% mean_ok: 130 (142) median_ok: 100 (103)
    gerrit_master jobs: 50 ok: 28 ko: 20 fail ratio: 40.00% mean_ok: 93 ( 93) median_ok: 61 ( 61)
    gerrit_master_seq jobs: 463 ok: 264 ko: 174 fail ratio: 37.58% mean_ok: 126 (133) median_ok: 103 (104)

    • https://dev-www.libreoffice.org/tmp/gerrit_231109.html
    • tests that failed more than twice in last seven days
      3 Killed by the kill-wrapper gerrit_linux_clang_dbgutil_branch
      3 CppunitTest_sw_mailmerge gerrit_windows
      3 JunitTest_chart2_unoapi gerrit_linux_clang_dbgutil
      4 CppunitTest_sw_ooxmlexport17 gerrit_mac
      5 UITest_calc_tests8 gerrit_linux_clang_dbgutil
      24 Killed by the kill-wrapper gerrit_linux_clang_dbgutil
      • in terms of code failures, not too bad
      • quite some kill-wrapper problems, though
      • had a problem with one of the macOS builders
      • also a Windows builder broke and was not auto-detected
  • FTP UCP removal (Michael S)

    • patch in gerrit to remove this:
      https://gerrit.libreoffice.org/c/core/+/159065
    • think we already decided to remove this at some stage, LO 7.4 release note already deprecated this.
    • configuration setting to set an ftp proxy
      • some java client may still use it.
      • OK to remove this, still?
        • just drop it (Thorsten, Michael W, Stephan)
    • don’t forget to add that to the RelNotes
      ReleaseNotes/24.2 - The Document Foundation Wiki (Cloph)
    • re deprecating old protocols (Hossein)
      • also watch for new protocols
      • warn on unencrypted http?
        • not interested in investigating this, though

        • currently implementing a new setting “allow insecure protocols” (Michael S)

          https://gerrit.libreoffice.org/c/core/+/159011

          • still enabled by default
          • can disable it
          • then only https will be allowed
          • and only newer TLS versions
          • auditing the python mail merge / wiki publisher to cope with this
      • also interested in securing our URP listener (Hossein)
      • while defaulting to “no warn on http” for now, consider switching that in the future (Thorsten)
        • may make sense to release-note this.
  • What’s cooking (Miklos)

    • Multi-page floating tables in Writer, see tdf#157119 for details (Miklos)

      • focusing on the UI now
    • A11y update (Michael W)

    • Import of Word drawing canvas (Regina)

      https://gerrit.libreoffice.org/c/core/+/156629

      • WIP patch for Writer, 2 problems:

        • the curve connectors don’t work

        • same problem as in Impress

        • ignore curve connectors for now?

          • probably OK to get it in without it being perfect (Miklos)

          • if it’s a net improvement

        • 2nd problem:

          • current state: could be committed, but would appreciate a review

          • no unit tests yet.

          • not sure it’ll be in time for 24.2 feature freeze

          • at least one unit test would be nice before asking for review, to see the improvements.

        • Xisco can also help with adding tests (Cloph)

  • QA update (Xisco)

  • QA stats (Stéphane)

    • As Xisco mentioned last week, below 1000 unconfirmed

    • Dashboard data updated: https://stragu.shinyapps.io/lo_qa_dashboard/

    • QA Weekly Focus started last week on SVG: QA weekly focus: SVG - LibreOffice QA Blog

      • Of 176 listed reports, 66 have been touched so far
      • Contributions from at least: Kira Tubo, Bogdan Buzea, Roland Baudin, Stéphane Quenson, Régis Perdreau, Timur, Ilmari
    • Weekly Bug Summary
      +91 +15 (-113) overall)
      many thanks to the top bug squashers:
      Stéphane Guillou (stragu) 18
      QA Administrators 14
      Balázs Varga (allotropia) 7
      Buovjaga 7
      Gabor Kelemen (allotropia) 6
      Mike Kaganski 6
      Timur 6
      Michael Weghorn 4
      BogdanB 3
      Dieter 3

    • top 10 bugs reporters:
      Gabor Kelemen (allotropia) 5
      Mike Kaganski 5
      Eyal Rozenberg 4
      Joanmarie Diggs 2
      Lakshmi 2
      intmail01 2
      zarifahnaf 2
      zzz 2
      Camaleón 1
      Jeff Fortin Tam 1

    • top 10 bugs fixers:
      Balazs Varga 7
      Justin Luth 3
      Patrick Luby 3
      Stéphane Guillou 3
      Timur 3
      Weghorn, Michael 3
      Balland-Poirier, Laurent 2
      Ilmari Lauhakangas 2
      Melenchuk, Vasily 2
      Németh, László 2

    • top 10 bugs confirmers:
      Ilmari Lauhakangas 18
      Stéphane Guillou 11
      Heiko Tietze 8
      m.a.riosv 7
      Dieter 6
      Xisco Fauli 5
      UNKNOWN 3
      Henschel, Regina 2
      Kelemen, Gabor 2
      Nabet, Julien 2

  • Bisected bugs open: keyword ‘bisected’

    done by:
       Xisco Fauli            3
       Ilmari Lauhakangas     1
       Kira Tubo              1
       Stéphane Guillou       1
    
  • Bibisected bugs open: keyword ‘bibisected’

    done by:
       Xisco Fauli            3
       Ilmari Lauhakangas     1
       Kelemen, Gabor         1
       Kira Tubo              1
       Stéphane Guillou       1
    
  • all bugs tagged with ‘regression’

    • 1219(+1) bugs open of 12950(+12) total 17(+0) high prio.

      done by:
      Stéphane Guillou 3
      Xisco Fauli 3
      Kira Tubo 2
      ady 1
      Ilmari Lauhakangas 1
      Kelemen, Gabor 1

  • ~Component count net * high severity regressions

    • Bug List
      Writer - 11(+0)
      Calc - 3(+0)
      LibreOffice - 2(+0)
      UI - 1(+0)

    by OS:
    All - 12(+0)
    Linux - 3(+0)
    Mac OS X - 0(+0)
    Windows - 2(+0)

  • ~Component count net * all regressions

    • Bug List
      Writer: other - 425(+1)
      Calc - 222(+0)
      Impress - 136(+1)
      LibreOffice - 52(+0)
      Draw - 50(+0)
      Crashes - 44(+0)
      Base - 42(+1)
      Writer: docx filter - 40(+0)
      Borders - 36(+1)
      UI - 36(+0)
      Writer: other filter - 34(-1)
      Writer: perf - 33(+0)
      Printing and PDF export - 24(-2)
      RTL - 24(+0)
      Chart - 22(+0)
      BASIC - 19(+1)
      filters and storage - 18(-1)
      Writer: doc filter - 15(+0)
      graphics stack - 12(+1)
      Formula Editor - 5(+0)
      framework - 3(+0)
      Extensions - 2(+0)
      sdk - 2(+0)
      Linguistic - 1(+0)