ESC meeting minutes: 2023-10-05

  • Present:

    • Heiko, Olivier, Stephane, Caolan, Cloph, Eike, Hossein, Ilmari, Michael W, Regina, Stephan, Thorsten, Xisco, Michael S, Miklos, Gabriel
  • Completed Action Items:

    • Try gtk4 local builds, Qt6 local builds (Cloph)
      [ not done, but will happen later ]
    • review bot: ignore distro branches when adding reviewers (Xisco)
      [ master-only now ]
    • Send the welcome mail + point out the restricted scope for Skyler (Miklos)
    • Enable the commit bit for Skyler (Cloph)
  • Pending Action Items:

    • Set up a daily tinderbox for the python-based windows installer (Cloph)
  • Release Engineering update (Cloph)

    • 7.6 status: 7.6.3 rc1 in 4 weeks
    • 7.5 status: 7.5.8 rc1 in 1 weeks
    • maybe bump the VS baseline on Windows?
      • not opposed to that, but it requires some work, needs time (Cloph)
      • ran into this C++20 compiler problem with managed C++ (Stephan)
        • turns out it uses C++17
        • see the mailing list thread
        • also std::source_location change from Noel, failed in CLR
          • failed due to the same problem
        • so whenever we use C++20 featues, that may not work
        • for now we didn’t ran into problems that we could not work around, though
      • prefer deploying Windows 11 CI builders first (Cloph)
  • Documentation (Olivier)
    + Helpcontents2
    + more updates in menus vs UI modes (ohallot)
    + add target for UNO commands when using F1
    + that is, avoid 404 error.
    + any way to help for unclear commands? (Miklos)
    + working with the user interface (Oliver)
    + focusing on commands which are in the default UI for now
    + based on the generated wiki page: https://wiki.documentfoundation.org/Development/DispatchCommands
    + housekeeping after translations (ohallot)
    + Linguistics and unecesssary translations.
    + Guides
    + support for review by community members (ohallot)

    • Bugzilla Documentation statistics
      269(269) bugs open
    • Updates:
      BZ changes 1 week 1 month 3 months 12 months
      created 10(4) 19(0) 72(2) 298(0)
      commented 18(12) 49(1) 236(11) 1090(11)
      resolved 3(3) 6(2) 32(2) 166(3)
    • top 10 contributors:
      Stéphane Guillou made 19 changes in 1 month, and 348 changes in 1 year
      Ilmari Lauhakangas made 18 changes in 1 month, and 124 changes in 1 year
      Olivier Hallot made 12 changes in 1 month, and 443 changes in 1 year
      Nabet, Julien made 8 changes in 1 month, and 39 changes in 1 year
      aswath t made 7 changes in 1 month, and 7 changes in 1 year
      steve made 4 changes in 1 month, and 18 changes in 1 year
      Judi made 2 changes in 1 month, and 2 changes in 1 year
      Dennis Roczek made 1 changes in 1 month, and 1 changes in 1 year
      Elisabeth Dapper made 1 changes in 1 month, and 1 changes in 1 year
      David Liontooth made 1 changes in 1 month, and 1 changes in 1 year
  • UX Update (Heiko)

    • Bugzilla (topicUI) statistics
      258(258) (topicUI) bugs open, 58(58) (needsUXEval) needs to be evaluated by the UXteam
    • Updates:
      BZ changes 1 week 1 month 3 months 12 months
      added 10(7) 13(-1) 20(0) 44(-1)
      commented 73(46) 196(15) 485(24) 2323(-1)
      removed 0(0) 0(0) 1(0) 19(-1)
      resolved 6(-4) 33(-2) 88(2) 330(0)
    • top 10 contributors:
      Heiko Tietze made 118 changes in 1 month, and 1395 changes in 1 year
      Stéphane Guillou made 66 changes in 1 month, and 507 changes in 1 year
      Eyal Rozenberg made 44 changes in 1 month, and 335 changes in 1 year
      Kaganski, Mike made 28 changes in 1 month, and 143 changes in 1 year
      Bogdan B made 16 changes in 1 month, and 111 changes in 1 year
      Ilmari Lauhakangas made 14 changes in 1 month, and 216 changes in 1 year
      Vernon, Stuart Foote made 14 changes in 1 month, and 413 changes in 1 year
      ady made 13 changes in 1 month, and 107 changes in 1 year
      Fortin Tam, Jean-François made 11 changes in 1 month, and 16 changes in 1 year
      Dieter made 9 changes in 1 month, and 240 changes in 1 year
    • [Bug 156182] FORMATTING Automatic text color can be unreadable with
      darker cell colors
    • [Bug 55848] FormControls : Can’t modify the size of a check box
      → + [Bug 155675] Accessibility Request – Whisper OpenAI
      • resolved as wontfix for now, prefer it as an extension instead
    • [Bug 157522] As we now have a Comment style, remove/redirect
      “Format all comments…”
    • [Bug 157518] Improve password security UX
    • [Bug 157501] Presentation Minimizer wizard dialog needs Help button

    → + Cursor goes beyond margins when typing spaces at the end of a line
    + 155494 – Cursor goes beyond margins when typing spaces at the end of a line
    + proposing an option to wrap break for spaces
    + compatible with Word, but otherwise poor UX
    + would e.g. indenting a single line
    + it was possible to do this in Word in the past
    + comments are welcome
    + would this be a per-document setting? (Miklos)
    + would store it in the user profile (Heiko)
    + no concerns (Michael S)

  • Crash Testing (Caolan)

    • 13(-9) import failure, 0(+0) export failures
      • now on Debian 12 for newer toolchain
      • various old crashes are now fixed
      • some new issues
      • common crash on exit from embedded chart seems to be an old issue newly reproducible with newer toolchain/os
        → fix submitted to gerrit
    • 6 coverity issues
      • not sure what “double_initialization” is trying to tell me in cid#1546386 “API usage error”
    • 2 ossfuzz issues, no crashes
  • Crash Reporting (Xisco)

  • Mentoring (Hossein)

    • Updated some of the LibOCon 2023 workshop presentation files

    • Added a new blog post for publishing the workshop slides
      LibOCon 2023 workshop presentation slides
      LibOCon 2023 workshop presentation slides - LibreOffice Development Blog

    • Outreachy applicants coming

         committer...   1 week     1 month      3 months     12 months
                 open      62(17)      99(2)       152(-4)       210(1)
              reviews     216(-10)   1036(-200)   3300(-108)   11558(56)
               merged     206(37)     891(-98)    2952(-128)   12662(53)
            abandoned       8(4)       40(-20)     144(2)        641(7)
          own commits     159(60)     612(-45)    2032(-30)     9702(14)
       review commits      45(10)     172(-7)      614(-14)     3041(16)
       contributor...   1 week    1 month      3 months     12 months
                 open      20(-6)     61(5)        95(4)        123(6)
              reviews     574(76)   2088(-202)   6850(-280)   30522(-24)
               merged       9(-4)     47(-15)     210(-10)     2121(-44)
            abandoned       7(-7)     32(-1)      204(-1)       618(-7)
          own commits      11(-7)     60(-2)      211(-10)     1102(3)
       review commits       0(0)       0(0)         0(0)          0(0)
      
      • easyHack statistics:
        needsDevEval 8(8) needsUXEval 1(1) cleanup_comments 319(319)
        total 395(395) assigned 20(20) open 350(350)

      • top 10 contributors:
        Stéphane Guillou made 8 patches in 1 month, and 37 patches in 1 year
        Srebotnjak, Martin made 4 patches in 1 month, and 20 patches in 1 year
        Sahil Gautam made 4 patches in 1 month, and 10 patches in 1 year
        Dan Horák made 4 patches in 1 month, and 4 patches in 1 year
        Bogdan B made 3 patches in 1 month, and 97 patches in 1 year
        Adam Seskunas made 3 patches in 1 month, and 4 patches in 1 year
        Ankit Kumar Jaipuriar made 3 patches in 1 month, and 3 patches in 1 year
        Armin Le Grand (allotropia) made 3 patches in 1 month, and 70 patches in 1 year
        Priyadarshi, Apurva made 2 patches in 1 month, and 2 patches in 1 year
        Montane, Joan made 2 patches in 1 month, and 2 patches in 1 year

      • top 10 reviewers:
        Caolán McNamara made 118 review comments in 1 month, and 566 in 1 year
        Thorsten Behrens made 86 review comments in 1 month, and 468 in 1 year
        Xisco Fauli made 86 review comments in 1 month, and 764 in 1 year
        Ilmari Lauhakangas made 78 review comments in 1 month, and 406 in 1 year
        Michael Stahl made 72 review comments in 1 month, and 1152 in 1 year
        Vajna, Miklos made 68 review comments in 1 month, and 894 in 1 year
        Hossein made 60 review comments in 1 month, and 278 in 1 year
        Nabet, Julien made 58 review comments in 1 month, and 966 in 1 year
        Grandin, Noel made 50 review comments in 1 month, and 570 in 1 year
        Kelemen, Gabor made 38 review comments in 1 month, and 92 in 1 year

      • Patches automatically abandoned:
        tdf#127293 Add Excel2021 function XLOOKUP to Calc [WIP] ( Winfried Donkers )
        - https://gerrit.libreoffice.org/#/c/131905

        tdf#127293 Prepare for Excel function XLOOKUP in Calc ( Winfried Donkers )
        - https://gerrit.libreoffice.org/#/c/148124

  • Commit Access

    • None
  • Developer Certification (Stephan/Miklos/Thorsten/László)

    • resting since: 1 weeks (limit: 20 weeks)
  • Jenkins / CI update (Cloph)
    gerrit_android_aarch64 jobs: 118 ok: 117 ko: 0 fail ratio: 0.00% mean_ok: 9 ( 11) median_ok: 6 ( 7)
    gerrit_android_arm jobs: 118 ok: 114 ko: 2 fail ratio: 1.69% mean_ok: 7 ( 9) median_ok: 5 ( 5)
    gerrit_android_x86 jobs: 118 ok: 116 ko: 0 fail ratio: 0.00% mean_ok: 7 ( 9) median_ok: 4 ( 6)
    gerrit_android_x86_64 jobs: 118 ok: 112 ko: 3 fail ratio: 2.54% mean_ok: 7 ( 9) median_ok: 4 ( 5)
    gerrit_linux_clang_dbgutil jobs: 239 ok: 195 ko: 36 fail ratio: 15.06% mean_ok: 36 ( 37) median_ok: 40 ( 40)
    gerrit_linux_gcc_release jobs: 280 ok: 232 ko: 32 fail ratio: 11.43% mean_ok: 17 ( 17) median_ok: 14 ( 14)
    gerrit_mac jobs: 239 ok: 216 ko: 8 fail ratio: 3.35% mean_ok: 47 ( 47) median_ok: 42 ( 42)
    gerrit_windows jobs: 251 ok: 168 ko: 65 fail ratio: 25.90% mean_ok: 65 ( 68) median_ok: 50 ( 50)
    gerrit_master_ml jobs: 301 ok: 148 ko: 122 fail ratio: 40.53% mean_ok: 82 ( 82) median_ok: 66 ( 67)
    gerrit_master jobs: 34 ok: 18 ko: 11 fail ratio: 32.35% mean_ok: 61 ( 61) median_ok: 51 ( 51)
    gerrit_master_seq jobs: 266 ok: 130 ko: 110 fail ratio: 41.35% mean_ok: 85 ( 85) median_ok: 69 ( 69)

    • https://dev-www.libreoffice.org/tmp/gerrit_231005.html

    • tests that failed more than twice in last seven days
      3 Killed by the kill-wrapper gerrit_linux_clang_dbgutil_branch
      3 CppunitTest_sfx2_misc gerrit_linux_gcc_release
      3 CppunitTest_starmath_qa_cppunit gerrit_windows
      4 UITest_sw_navigator gerrit_linux_clang_dbgutil
      5 CppunitTest_sw_ooxmlexport17 gerrit_mac
      7 Killed by the kill-wrapper gerrit_linux_clang_dbgutil
      35 CppunitTest_sc_subsequent_filters_test3 gerrit_windows

      -> Recent regression. First failure https://gerrit.libreoffice.org/c/core/+/157430 ?
      
    • or was it cea900fe9864bbc5314415cb369fc7b6111cd050 ?

    • CppunitTest_sc_subsequent_filters_test3 failure is new, but otherwise looks good

  • What’s cooking (Miklos)

    • multi-page floating tables in Writer, see tdf#157119 for details (Miklos)
    • JDK bump to 17 (Michael W)
    • a11y update (Michael W)
      • did some NVDA and Accerciser improvements, helps libreoffice indirectly
    • ItemSet rework (Thorsten)
      • crashtesting problems are now addressed
      • more work in progress, see gerrit
  • QA update (Xisco)

    Old:
    Fixed:
       + FILESAVE: DOCX: Text is converted to RTL when open with MSO
           + https://bugs.documentfoundation.org/show_bug.cgi?id=157598
           + Commit reverted
         + Re-opened: tdf#155470 - Numbers in RTL document change to Latin after saving to docx
           + Inherited from OOo and annoying for RTL users
    
  • libcmis – new release? (Caolan)

    • who is able to do that?
    • original maintainer is inactive
    • if you talk about the github project, then have permission (Cloph)
    • do we have the capacity to cut a release? (Caolan)
      • yes, have the permissions (Cloph)
      • wonder if the new Fedora maintainer would be interested in stepping up as a maintainer there (Caolan)
      • Cloph to grant permission for Caolan to cut a release, then take care of one release at least?
        AI: do this, so Caolan can merge PRs, etc. (Cloph)
  • QA stats (Stéphane)

  • Bisected bugs open: keyword ‘bisected’

    done by:
       Stéphane Guillou       7
       Xisco Fauli            7
       Bogdan B               3
       Raal                   3
       Ilmari Lauhakangas     2
       Kelemen, Gabor         2
       Kira Tubo              1
       Sophie Sipasseuth      1
    
  • Bibisected bugs open: keyword ‘bibisected’

    done by:
       Stéphane Guillou       8
       Xisco Fauli            7
       Bogdan B               3
       Raal                   3
       Ilmari Lauhakangas     2
       Kelemen, Gabor         2
       Kira Tubo              1
       Sophie Sipasseuth      1
    
  • all bugs tagged with ‘regression’

    • 1224(+17) bugs open of 12858(+34) total 15(+2) high prio.

      done by:
      Stéphane Guillou 10
      Xisco Fauli 7
      Ilmari Lauhakangas 3
      Raal 3
      m.a.riosv 2
      ady 1
      Bogdan B 1
      Dennis Roczek 1
      greg.diehl.gtd 1
      Kelemen, Gabor 1

  • ~Component count net * high severity regressions

    • Bug List
      Writer - 8(+0)
      Calc - 3(+0)
      LibreOffice - 2(+1)
      Printing and PDF export - 1(+0)
      UI - 1(+1)

    by OS:
    All - 10(+1)
    Linux - 3(+1)
    Mac OS X - 0(+0)
    Windows - 2(+0)

  • ~Component count net * all regressions

    • Bug List
      Writer: other - 428(+10)
      Calc - 228(+2)
      Impress - 137(+3)
      LibreOffice - 50(+1)
      Draw - 47(+0)
      Crashes - 46(+1)
      Writer: docx filter - 41(+0)
      Base - 40(-2)
      Borders - 36(+0)
      UI - 36(+1)
      Writer: perf - 33(+0)
      Writer: other filter - 31(+0)
      Printing and PDF export - 26(+1)
      RTL - 23(+0)
      Chart - 22(+0)
      filters and storage - 18(+1)
      BASIC - 17(+0)
      Writer: doc filter - 15(+0)
      graphics stack - 12(+0)
      Formula Editor - 5(+0)
      framework - 4(+0)
      Extensions - 2(+0)
      sdk - 2(+0)
      Linguistic - 1(+0)