ESC meeting minutes: 2023-08-24

vmiklos · August 24, 2023, 2:38pm

Present:
- Eike, Caolan, Heiko, Justin, Olivier, Hossein, Michael W, Michael S, Regina, Stephan, Thorsten, Xisco, Khaled, Ilmari, Miklos
Completed Action Items:
- Split ticket about icon theme depending on light/dark appearance
  into gtk3/gtk4 (tdf#127138) and kf5/qt6 (tdf#156894) (Heiko)
Pending Action Items:
- Try gtk4 local builds, Qt6 local builds (Cloph)
- Fix gdb pretty-printers on tb99 (Cloph)
Release Engineering update (Xisco)
- 7.6 status: 7.6.1 rc1 this week: already tagged
- 7.5 status: 7.5.6 rc2 next week
Documentation (Olivier)
- New Help, no news.
- Helpcontents2
  - review of all menus and UNO commands (ohallot)
  - Need info on “Graphic Size Check”
    - Graphic Size Check
  - ScriptForge help pages (R. Lima)
  - NOTE: Python script help pages available since ages.
- Guides
  - Work in progress
  - Bookshelf updated with last guides.
- Bugzilla Documentation statistics
  269(269) bugs open
- Updates:
  BZ changes 1 week 1 month 3 months 12 months
  created 4(-1) 36(-9) 78(-1) 308(1)
  commented 11(-4) 93(-34) 245(6) 1096(7)
  resolved 3(3) 17(-4) 34(2) 173(2)
- top 10 contributors:
  Rafael Lima made 36 changes in 1 month, and 163 changes in 1 year
  Stéphane Guillou made 27 changes in 1 month, and 325 changes in 1 year
  Olivier Hallot made 24 changes in 1 month, and 454 changes in 1 year
  Nabet, Julien made 11 changes in 1 month, and 31 changes in 1 year
  Heiko Tietze made 6 changes in 1 month, and 115 changes in 1 year
  Wolfgang Jäger made 6 changes in 1 month, and 6 changes in 1 year
  Ilmari Lauhakangas made 5 changes in 1 month, and 113 changes in 1 year
  Bogdan B made 4 changes in 1 month, and 225 changes in 1 year
  خالد حسني made 4 changes in 1 month, and 4 changes in 1 year
  m.a.riosv made 4 changes in 1 month, and 15 changes in 1 year
UX Update (Heiko)
- Bugzilla (topicUI) statistics
  267(267) (topicUI) bugs open, 60(60) (needsUXEval) needs to be evaluated by the UXteam
- Updates:
  BZ changes 1 week 1 month 3 months 12 months
  added 0(-4) 14(-16) 23(-16) 54(-17)
  commented 44(4) 182(-64) 510(-56) 2414(-82)
  removed 1(1) 1(0) 5(0) 27(-1)
  resolved 9(2) 30(1) 77(2) 329(0)
- top 10 contributors:
  Heiko Tietze made 98 changes in 1 month, and 1466 changes in 1 year
  Eyal Rozenberg made 54 changes in 1 month, and 322 changes in 1 year
  Stéphane Guillou made 43 changes in 1 month, and 446 changes in 1 year
  ady made 26 changes in 1 month, and 98 changes in 1 year
  خالد حسني made 21 changes in 1 month, and 35 changes in 1 year
  Roman Kuznetsov made 20 changes in 1 month, and 171 changes in 1 year
  Dieter made 17 changes in 1 month, and 256 changes in 1 year
  Leroy made 16 changes in 1 month, and 19 changes in 1 year
  Colin made 16 changes in 1 month, and 16 changes in 1 year
  Bogdan B made 14 changes in 1 month, and 97 changes in 1 year
- [Bug 149625] FORMATTING: Pasting a table cell, pastes the source cell
  in the upper/actual cell as an inner table cell
- [Bug 156840] Add source path as property to embedded image file
- [Bug 156817] Calc: selection automatic sum/average broken with error cells
- reviewing lots of menus (Olivier)
  - also the tabbed interface → lots of commands missing
  - perhaps should review that later
  - feels like people dump every command on the canvas, and it’s not how it works (Heiko)
  - if there is a need for a new commands which are frequent, that has to be added
    - everything else has to be in menus
- bugzilla has a lot of easy hacks related to the notebookbar (Justin)
Crash Testing (Caolan)
- 14(-16) import failure, 0(+0) export failures
  - one more calc parallelization fix merged since
- 2 coverity issues
  - fixes for those merged
- 1 ossfuzz issue
  - a single doc timeout
Crash Reporting (Xisco)
- https://crashreport.libreoffice.org/stats/version/7.4.7.2
  + (+45) 717 674 664 485 472 471 380 318 250 251 118 0
- https://crashreport.libreoffice.org/stats/version/7.5.4.2
  + (-40) 628 668 706 981 969 717 365 0
- https://crashreport.libreoffice.org/stats/version/7.5.5.2
  + (+497) 1349 852 1012 0
- https://crashreport.libreoffice.org/stats/version/7.6.0.3
  + (+440) 440 0
- Regressions in 7.6
- https://crashreport.libreoffice.org/stats/signature/comphelper::AccessibleEventNotifier::revokeClientNotifyDisposing(unsigned%20int,%20com::sun::star::uno::Reference<com::sun::star::uno::XInterface>%20const&)
- Noel submitted a fix for 7.6.0 RC3
- Michael W. submitted a second fix
- https://crashreport.libreoffice.org/stats/signature/static%20bool%20cppu::idefaultConstructElements(struct%20_sal_Sequence%20*%20*,%20struct%20_typelib_TypeDescriptionReference%20*,%20long,%20long,%20long)
- Related to gradients
Mentoring (Hossein)
- New draft blog post for EasyHacks
  Warning for low disk space - difficulty interesting EasyHack
  Warning for low disk space - difficulty interesting EasyHack - LibreOffice Development Blog
- Reviewed all the EasyHacks with last comment < 2019
  Reviewing Older EasyHacks - The Document Foundation Wiki
  committer… 1 week 1 month 3 months 12 months
  open 74(10) 137(-2) 191(-2) 231(12)
  reviews 242(-76) 1280(-38) 3124(-54) 11144(-10)
  merged 191(-31) 1012(-67) 3300(-65) 12728(-56)
  abandoned 8(-15) 51(2) 134(-8) 635(-1)
  own commits 139(22) 667(-48) 2113(-4) 10104(-132)
  review commits 30(-1) 178(-27) 613(-26) 3044(-14)
  contributor… 1 week 1 month 3 months 12 months
  open 34(2) 62(9) 86(10) 106(11)
  reviews 606(-356) 2764(-96) 7642(-84) 31542(-350)
  merged 6(0) 44(-13) 175(-8) 2434(-130)
  abandoned 2(-153) 160(1) 179(2) 615(-4)
  own commits 8(-3) 53(-9) 196(-5) 1068(5)
  review commits 0(0) 0(0) 0(0) 0(0)
  - easyHack statistics:
    needsDevEval 8(8) needsUXEval 1(1) cleanup_comments 328(328)
    total 404(404) assigned 17(17) open 359(359)
  - top 10 contributors:
    Stéphane Guillou made 10 patches in 1 month, and 29 patches in 1 year
    Dipam Turkar made 4 patches in 1 month, and 26 patches in 1 year
    Armin Le Grand (allotropia) made 4 patches in 1 month, and 77 patches in 1 year
    Colomban Wendling made 3 patches in 1 month, and 21 patches in 1 year
    Czeber László made 3 patches in 1 month, and 18 patches in 1 year
    Sahil Gautam made 3 patches in 1 month, and 5 patches in 1 year
    Ahmed Eltokhy made 2 patches in 1 month, and 9 patches in 1 year
    Venetia Furtado made 2 patches in 1 month, and 5 patches in 1 year
    jucasaca made 2 patches in 1 month, and 4 patches in 1 year
    Stéphane Guillou made 1 patches in 1 month, and 9 patches in 1 year
  - top 10 reviewers:
    Caolán McNamara made 154 review comments in 1 month, and 368 in 1 year
    Michael Stahl made 132 review comments in 1 month, and 1118 in 1 year
    Thorsten Behrens made 98 review comments in 1 month, and 440 in 1 year
    Vajna, Miklos made 96 review comments in 1 month, and 840 in 1 year
    Nabet, Julien made 90 review comments in 1 month, and 952 in 1 year
    Grandin, Noel made 68 review comments in 1 month, and 612 in 1 year
    Vajngerl, Tomaž made 54 review comments in 1 month, and 402 in 1 year
    Xisco Fauli made 54 review comments in 1 month, and 752 in 1 year
    Kaganski, Mike made 50 review comments in 1 month, and 354 in 1 year
    Christian Lohmaier made 34 review comments in 1 month, and 402 in 1 year
  - Patches automatically abandoned:
    tdf#138302: support for list overrides in DOC export ( Vasily Melenchuk )
    - https://gerrit.libreoffice.org/#/c/116516
  - big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
    Denis Sorotnik
    Deepika Goyal
GSoC (Ilmari/Thorsten)
- work is ongoing, see weekly reports
- this week: Contributors submit their code, project summaries, and final evaluations of their mentors
- next week: Mentors submit final contributor evaluations (standard coding period)
Outreachy (Ilmari)
- https://www.outreachy.org/
- Applied with two intern slots
- Mentor sign up deadline September 29
  - looking for mentors
- Project timeline is Dec → March
Commit Access
Developer Certification (Stephan/Miklos/Thorsten/László)
- resting since: 19 weeks (limit: 20 weeks)
Jenkins / CI update (Cloph)
- seemed to work OK this week (Miklos)
- tests that failed more than twice in last seven days
  1 CppunitTest_sd_misc_tests gerrit_windows
  1 CppunitTest_starmath_qa_cppunit gerrit_linux_clang_dbgutil
  1 CppunitTest_starmath_qa_cppunit gerrit_linux_gcc_release
  1 CppunitTest_svgio gerrit_linux_clang_dbgutil_branch
  1 CppunitTest_svgio gerrit_mac
  1 CppunitTest_svx_styles gerrit_windows
  1 CppunitTest_vcl_svm_test gerrit_windows
  1 JunitTest_ridl_remote gerrit_linux_gcc_release_branch
  1 UITest_calc_tests8 gerrit_linux_clang_dbgutil
  1 UITest_inputLine gerrit_linux_clang_dbgutil
  1 UITest_sw_fieldDialog gerrit_linux_clang_dbgutil
  2 CppunitTest_framework_dispatch gerrit_windows
  2 CppunitTest_starmath_qa_cppunit gerrit_mac
  2 CppunitTest_svgio gerrit_windows
  2 CppunitTest_sw_ooxmlexport17 gerrit_mac
  3 CppunitTest_starmath_qa_cppunit gerrit_windows
  5 Killed by the kill-wrapper gerrit_linux_clang_dbgutil_branch
  6 Killed by the kill-wrapper gerrit_linux_clang_dbgutil
  7 Killed by the kill-wrapper gerrit_mac
What’s cooking (Miklos)
- C++20 (Stephan)
- multi-page floating tables in Writer, see tdf#155118 for details (Miklos)
- JDK bump to 17 (Michael W)
  - https://gerrit.libreoffice.org/c/core/+/155377
  - https://gerrit.libreoffice.org/c/core/+/155827
  - waiting for JDK 17 to be installed on builders (for Cloph)
- Right-to-left math layout and other Math improvements (Khaled)
  - https://gerrit.libreoffice.org/q/topic:math-rtl-layout (4 patches)
  - https://gerrit.libreoffice.org/c/core/+/156053
  - Looking at MathML3 and/or required ODF changes
  - Also the ability to use different math font other than OpenSymbol, beacuse of the extensions needed for RTL
- Smallcaps in Impress (Caolan)
  - Caolán McNamara: Small Caps in Impress
LibreOffice conference Bucharest 2023 (Gabriel)
+ For those planning to join the conference, please REGISTER as we need this information for organizational reasons: Bucharest, Romania 2023 » LibreOffice Conference 2023
+ Registration for the workshop has been stopped and removed from the registration form because the number of registered participants is high and an increase could create major logistical problems.
+ That’s a massive success, congrats, great work there (Thorsten)
+ Maybe split to 2 groups?
+ Think we don’t have people to do 2 sessions (Hossein)
+ Perhaps can manage to have place for 60-70 people
+ Already discussed with the university
+ Will double-check with people if they indeed plan to attend
+ Some people may attend only some of the sessions
QA update (Xisco)
- UNCONFIRMED: 1180 (+13)
  - enhancements: 275 (-4)
  - needsUXEval: 7 (-13)
  - haveBackTrace: 14 (+1)
  - needsDevAdvice: 35 (+1)
  - documentation: 4 (-1)
  - android: 3 (+0)
  - iOS: 0 (+0)
  - Online: 12 (-1)
- Most pressing bugs:
  New:
None
- New high severity bugs of the week:
  - FIREBIRD: Copying a table from one database file to another gives wrong decimal numbers.
    - 156530 – FIREBIRD: Copying a table from one database file to another gives wrong decimal numbers.
    - Julien is working on it
  - Default font color in tables is white over white background (font color should be black)
    - 156685 – Default font color in tables is white over white background (font color should be black)
    - bisected to Heiko (isDark() calculation)
      - default tables in Impress/Draw have a white font color now
    - in discussion on the ticket
  - Add “Fit page size to drawing” functionality (e.g. to Page Properties dialog)
    - 81118 – Add "Fit page size to drawing" functionality (e.g. to Page Properties dialog)
    - not a regression
    - set to high because 4 dup, 16 cc; GSoC project? (Heiko)
    - add it to the GSoC page? (Xisco)
      - not sure about the size, perhaps easy-hackable (Heiko)
QA stats (Stéphane)
- Weekly Bug Summary
  +91 +19 (-175) overall)
  many thanks to the top bug squashers:
  QA Administrators 69
  Justin L 14
  Buovjaga 9
  Heiko Tietze 7
  Mike Kaganski 7
  Xisco Faulí 6
  Michael Stahl (allotropia) 5
  m.a.riosv 4
  steve 4
  Balázs Varga (allotropia) 3
- top 10 bugs reporters:
  Gerald Pfeifer 5
  Davide 4
  Rafael Lima 4
  Gabor Kelemen (allotropia) 3
  NISZ LibreOffice Team 3
  Telesto 3
  Hossein 2
  Roman Kuznetsov 2
  Suminda Dharmasena 2
  Xisco Faulí 2
- top 10 bugs fixers:
  Justin Luth 9
  Michael Stahl 5
  Caolán McNamara 4
  Xisco Fauli 4
  Balazs Varga 3
  Grandin, Noel 3
  Heiko Tietze 3
  Samuel Mehrbrodt 3
  Weghorn, Michael 3
  Ilmari Lauhakangas 2
- top 10 bugs confirmers:
  m.a.riosv 8
  Ilmari Lauhakangas 6
  Heiko Tietze 5
  Nabet, Julien 3
  Németh, László 3
  UNKNOWN 2
  Dieter 2
  Kaganski, Mike 2
  Kelemen, Gabor 2
  Rafael Lima 2

Bisected bugs open: keyword ‘bisected’

more accurate - down to a single commit.
Bug List: LibreOffice Bi-bisected

done by:
   Ilmari Lauhakangas     4
   Kelemen, Gabor         3
   Raal                   2
   Aron Budea             1

Bibisected bugs open: keyword ‘bibisected’

Bug List: LibreOffice Bi-bisected

done by:
   Ilmari Lauhakangas     4
   Kelemen, Gabor         3
   Raal                   2
   Aron Budea             1
   خالد حسني              1

all bugs tagged with ‘regression’
- 1183(-5) bugs open of 12736(+19) total 11(+0) high prio.
  
  done by:
  Ilmari Lauhakangas 4
  Roman Kuznetsov 2
  خالد حسني 2
  Aron Budea 1
  Kelemen, Gabor 1
  luca.manganelli 1
~Component count net * high severity regressions
- Bug List
  Writer - 7(+0)
  Calc - 3(+0)
  LibreOffice - 1(+0)
by OS:
All - 7(+0)
Linux - 2(+0)
Mac OS X - 0(+0)
Windows - 2(+0)
~Component count net * all regressions
- Bug List
  Writer: other - 413(-7)
  Calc - 216(+1)
  Impress - 133(+0)
  LibreOffice - 50(+1)
  Draw - 44(+0)
  Base - 42(+0)
  Crashes - 42(+0)
  Writer: docx filter - 40(-2)
  Borders - 34(+0)
  UI - 33(+1)
  Writer: other filter - 31(+0)
  Writer: perf - 31(+0)
  Printing and PDF export - 23(+0)
  RTL - 23(+0)
  Chart - 22(+0)
  BASIC - 18(+0)
  filters and storage - 16(-2)
  Writer: doc filter - 14(+1)
  graphics stack - 14(+2)
  Formula Editor - 4(+0)
  framework - 4(+0)
  Extensions - 2(+0)
  sdk - 2(+0)
  Linguistic - 1(+0)