ESC meeting minutes: 2024-09-12

vmiklos · September 12, 2024, 2:45pm

Present:
- Olivier, Caolan, Heiko, Ilmari, Jonathan, Michael W, Regina, Stephan, Cloph, Hossein, Xisco, Thorsten, Michael S, Miklos
Completed Action Items:
Pending Action Items:
Release Engineering update (Cloph)
- 24.8.2 rc1 in 1 week
  - no rc2 is planned here, due to the upcoming crash fix, see below in the crashporting section (Xisco)
- 24.2.7 rc1 in 4 weeks
Documentation (Olivier)
- Helpcontents2
  - special compliments to Sahil for adding a feature + its Help page, very rare.
  - update and fixes (Pierre F, Dione Maddern, Ohallot)
  - Disambiguate bookmarks (ohallot)
    - 1 dialog - 2 diffferent functions (Ttest dialog and Ftest dialog)
    - Can we replace HID_* by dialog widgets url ?
      - DBACCESS_HID*
      - the dialog case seems to be easy to fix
        
        also easier to maintain
      - easy hack for this? (Miklos)
      - AI: Hossein to follow-up on this
- Guides
  - Work in progress
- Bugzilla Documentation statistics
  225(225) bugs open
- Updates:
  BZ changes 1 week 1 month 3 months 12 months
  created 14(3) 63(-6) 117(2) 262(2)
  commented 35(1) 189(4) 350(20) 980(17)
  resolved 5(-1) 33(-2) 74(3) 174(5)
- top 10 contributors:
  Pierre F made 112 changes in 1 month, and 211 changes in 1 year
  Olivier Hallot made 56 changes in 1 month, and 332 changes in 1 year
  Ilmari Lauhakangas made 44 changes in 1 month, and 133 changes in 1 year
  Vernon, Stuart Foote made 34 changes in 1 month, and 156 changes in 1 year
  Dione Maddern made 33 changes in 1 month, and 94 changes in 1 year
  Heiko Tietze made 13 changes in 1 month, and 83 changes in 1 year
  Ady made 11 changes in 1 month, and 13 changes in 1 year
  Alain Romedenne made 10 changes in 1 month, and 26 changes in 1 year
  Dieter made 10 changes in 1 month, and 26 changes in 1 year
  UNKNOWN made 5 changes in 1 month, and 5 changes in 1 year
UX Update (Heiko)
- Bugzilla (topicUI) statistics
  231(231) (topicUI) bugs open, 29(29) (needsUXEval) needs to be evaluated by the UXteam
- Updates:
  BZ changes 1 week 1 month 3 months 12 months
  added 8(3) 14(6) 14(6) 23(6)
  commented 63(13) 155(43) 411(42) 1710(27)
  removed 1(1) 1(1) 3(1) 11(1)
  resolved 7(3) 21(4) 68(2) 268(-3)
- top 10 contributors:
  Heiko Tietze made 76 changes in 1 month, and 923 changes in 1 year
  Ilmari Lauhakangas made 54 changes in 1 month, and 180 changes in 1 year
  Vernon, Stuart Foote made 34 changes in 1 month, and 344 changes in 1 year
  steve made 18 changes in 1 month, and 25 changes in 1 year
  Henschel, Regina made 15 changes in 1 month, and 50 changes in 1 year
  Ademas made 12 changes in 1 month, and 12 changes in 1 year
  Cor Nouws made 11 changes in 1 month, and 36 changes in 1 year
  Bogdan B made 8 changes in 1 month, and 38 changes in 1 year
  Kaganski, Mike made 7 changes in 1 month, and 66 changes in 1 year
  Ady made 6 changes in 1 month, and 105 changes in 1 year
- [Bug 162904] Add font filename and version to character format dialog
  → + [Bug 162919] Suggest adding feature to Calc to improve ease of updating
  data plotted in charts
  + Excel seem to have a better UI here
  + OTOH Calc has working drag&drop
- [Bug 162354] Request Formatting cells in calc ( transfering / coppying formats )
  from one to another
- [Bug 162870] Character spacing doesn’t function with used-defined format code
  OR formulas
- [Bug 162878] Reworked localized Impress templates look ugly in RU
- [Bug 162160] Poor data label rendering strategy with high number of slices
  in pie chart
- [Bug 162110] LibreOffice Calc scrolling speed problem when dragging image
- [Bug 153991] Sidebar panel character deck/tab doesn’t allow switching
  language groups
- [Bug 153992] Sidebar character deck/tab doesn’t indicate the current
  language/language group
Crash Testing (Caolan)
- 15(+0) import failure, 13(+0) export failures
  - Development/Crashtesting - The Document Foundation Wiki
- 424 coverity issues
- 2 ossfuzz issues
  - 1 hang, 1 crash
  - upsteam autoclosing bug fix now
Crash Reporting (Xisco)
- 24.2.4.2 16085(+740)
- 24.2.5.2 18776(+2638)
- 24.2.6.2 82(+0)
- 24.8.0.3 7942(+3720)
- Reports for signature: SwTextINetFormat::GetCharFormat()
- 162911 – Inserting multiple Hyperlinks and undoing an insertion (Ctrl-Z) crashes Writer
- Patch in gerrit: https://gerrit.libreoffice.org/c/core/+/173267
- ~30% reports in 24.8.0.3. 2480 out of 8150 reports
- 24.8/master-only problem
- ship this to users faster than usual? (Xisco)
- could do just 1 RC for 24.8.2, then release in 2 weeks (Cloph)
- does the bug have many duplicates or many crashreports?
  - it’s the crashreports (Xisco)
Mentoring (Hossein)
- Window WSL / mingw issues
  - git-bash should be used instead of mingw git (Hossein)
  - wsl-as-helper is meant to work with git-bash from the Visual Studio installer (Cloph)
    - otherwise the build will fail in e.g. liblangtag
  - follow the wiki, it’s documented like this (Hossein)
    Development/BuildingOnWSLWindows - The Document Foundation Wiki
    
    committer… 1 week 1 month 3 months 12 months
    open 64(-7) 137(-14) 152(-12) 152(-12)
    reviews 570(144) 1442(156) 3942(136) 13072(112)
    merged 298(-47) 1272(75) 3755(65) 13219(46)
    abandoned 6(0) 46(-23) 212(-22) 748(-13)
    own commits 176(-54) 905(10) 2537(24) 9612(-5)
    review commits 59(2) 246(9) 765(6) 3116(16)
    contributor… 1 week 1 month 3 months 12 months
    open 36(-2) 95(3) 104(-1) 104(-1)
    reviews 768(-86) 3044(104) 8390(78) 29928(90)
    merged 26(5) 117(4) 323(16) 1467(5)
    abandoned 5(0) 16(-1) 76(-5) 588(4)
    own commits 19(-9) 98(-4) 338(2) 1272(11)
    review commits 0(0) 0(0) 0(0) 0(0)
- easyHack statistics:
  needsDevEval 8(8) needsUXEval 1(1) cleanup_comments 327(327)
  total 412(412) assigned 26(26) open 351(351)
- top 10 contributors:
  Pierre F made 26 patches in 1 month, and 84 patches in 1 year
  Adam Seskunas made 10 patches in 1 month, and 28 patches in 1 year
  Dione Maddern made 7 patches in 1 month, and 80 patches in 1 year
  Bogdan B made 5 patches in 1 month, and 93 patches in 1 year
  made 5 patches in 1 month, and 29 patches in 1 year
  Kira Tubo made 5 patches in 1 month, and 25 patches in 1 year
  Hubert Figuière made 5 patches in 1 month, and 14 patches in 1 year
  Ahmed Hamed made 3 patches in 1 month, and 12 patches in 1 year
  Tzschichholz, Rico made 2 patches in 1 month, and 3 patches in 1 year
  Weblate made 2 patches in 1 month, and 38 patches in 1 year
- top 10 reviewers:
  Michael Stahl made 152 review comments in 1 month, and 898 in 1 year
  Caolán McNamara made 132 review comments in 1 month, and 1436 in 1 year
  Ilmari Lauhakangas made 110 review comments in 1 month, and 638 in 1 year
  Adolfo Jayme Barrientos made 104 review comments in 1 month, and 814 in 1 year
  Christian Lohmaier made 104 review comments in 1 month, and 520 in 1 year
  Thorsten Behrens made 102 review comments in 1 month, and 640 in 1 year
  Kaganski, Mike made 84 review comments in 1 month, and 502 in 1 year
  Xisco Fauli made 80 review comments in 1 month, and 774 in 1 year
  Heiko Tietze made 66 review comments in 1 month, and 294 in 1 year
  Vajngerl, Tomaž made 50 review comments in 1 month, and 324 in 1 year
- Patches automatically abandoned:
  tdf#148192 Create new option External Firebird under create new database ( Juan C. Sanz )
  - https://gerrit.libreoffice.org/#/c/143902
  WIP: tdf#51779 - Support for SQL datatype INTERVAL ( Devansh Varshney )
  - https://gerrit.libreoffice.org/#/c/165012
- big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
  Eloi Montañés
GSoC (Ilmari)
- 4 projects with extensions, to be finished till the end of Sept
LiboCon (Cloph)
- Development workshop (planned for 11th and 12th of October; Hossein)
  Workshop: Introduction to LibreOffice Development » LibreOffice Conference
  Register to workshop » LibreOffice Conference
  - program is slightly modified
  - website will be updated
  - then a blogpost will go out
- all attendees, whether speaker or not, please also register:
  conference: Luxembourg, 2024 » LibreOffice Conference
- when to expect feedback on talks? accepted or not (Thorsten)
  - not sure (Cloph)
  - AI: Hossein to sync with Italo, and figure out the ETA
Commit Access
Developer Certification (Stephan/Miklos/László/Gabriel)
- resting since: 16 weeks (limit: 20 weeks)
Jenkins / CI update (Cloph)
gerrit_android_aarch64 jobs: 161 ok: 155 ko: 2 fail ratio: 1.24% mean_ok: 13 ( 24) median_ok: 9 ( 17)
gerrit_android_arm jobs: 161 ok: 155 ko: 3 fail ratio: 1.86% mean_ok: 12 ( 23) median_ok: 9 ( 13)
gerrit_android_x86 jobs: 161 ok: 157 ko: 1 fail ratio: 0.62% mean_ok: 13 ( 23) median_ok: 8 ( 17)
gerrit_android_x86_64 jobs: 161 ok: 157 ko: 2 fail ratio: 1.24% mean_ok: 12 ( 23) median_ok: 8 ( 17)
gerrit_linux_clang_dbgutil jobs: 327 ok: 258 ko: 57 fail ratio: 17.43% mean_ok: 59 ( 70) median_ok: 55 ( 62)
gerrit_linux_gcc_release jobs: 370 ok: 313 ko: 34 fail ratio: 9.19% mean_ok: 27 ( 36) median_ok: 20 ( 25)
gerrit_mac jobs: 325 ok: 292 ko: 17 fail ratio: 5.23% mean_ok: 63 ( 77) median_ok: 56 ( 65)
gerrit_windows jobs: 353 ok: 253 ko: 80 fail ratio: 22.66% mean_ok: 70 (111) median_ok: 65 ( 79)
gerrit_master_ml jobs: 412 ok: 215 ko: 152 fail ratio: 36.89% mean_ok: 145 (145) median_ok: 119 (119)
gerrit_master jobs: 59 ok: 24 ko: 28 fail ratio: 47.46% mean_ok: 106 (106) median_ok: 90 ( 90)
gerrit_master_seq jobs: 350 ok: 192 ko: 121 fail ratio: 34.57% mean_ok: 148 (149) median_ok: 121 (121)
- tests that failed more than twice in last seven days
  3 CppunitTest_sd_tiledrendering gerrit_linux_gcc_release
  3 CppunitTest_sw_layoutwriter3 gerrit_windows
  3 CppunitTest_sw_mailmerge gerrit_windows
  3 JunitTest_svx_unoapi gerrit_linux_clang_dbgutil
  4 Killed by the kill-wrapper gerrit_linux_clang_dbgutil
  33 aborted by jenkins job timeout gerrit_windows
- this week: wasn’t too bad (Cloph)
  - still a high number of builds aborting on Windows
  - perhaps it may be a test that triggers an interactive dialog, still investigating
What’s cooking (Miklos)
- A11y update (Michael W)
  - implement announcement of keyboard-triggered formatting changes in NVDA
    ( LibreOffice Writer: provide speech and braille feedback for common shortcut keys · Issue #6915 · nvaccess/nvda · GitHub )
  - misc smaller fixes + wina11y code cleanup, upstream Accerciser improvements
- RTL/CTL/CJK update (Jonathan)
  - tdf#162803 Invalid kashida array after text box layout
    - 162803 – Spurious kashida in text box after font change
    - Fixed
  - tdf#107184 “Group” feature for the Asian Phonetic Guide
    - 107184 – Furigana (ruby) should give option to treat entire selection as one base text
    - General APG implementation improvements
    - Feature implemented
  - tdf#156543: “Mono” feature for the Asian Phonetic Guide
    - 156543 – [Feature Request] "Mono" feature for the Asian Phonetic Guide
    - In progress
- CairoSDPR from Armin
  - ~done, behind experimental mode on master
- Playing with a new baseline with Windows (Cloph)
  - one cppunit test failing, due to too low resolution
  - have a good setup, winget + shell scripts
  - .vsconfig file to automate visual studio component installation
  - parallel builds perform badly, investigating
Remove hard-coded key combination shift+ctrl+f6 (Heiko)
Remove hard-coded key combination shift+ctrl+f6
- badly documented and maintaned function; likely not intended,
  no generic shortcut
- occupies precious shortcut, which could be used for uno:ToggleControlFocus
- drawback: no keyboard-only access to split window position
- propose to remove it, and leave the shortcut unassigned
- ask on the a11y list before removal (Michael W)
QA update (Xisco)
- UNCONFIRMED: 1248 (+13)
  - enhancements: 298 (+8)
  - needsUXEval: 7 (+3)
  - haveBackTrace: 9 (+0)
  - needsDevAdvice: 47 (+1)
  - documentation: 7 (-2)
  - android: 0 (+0)
  - iOS: 0 (+0)
  - Online: 9 (+0)
- Most pressing bugs:
  New:
  - Inserting multiple Hyperlinks and undoing an insertion (Ctrl-Z) crashes Writer
    - 162911 – Inserting multiple Hyperlinks and undoing an insertion (Ctrl-Z) crashes Writer
    - See Crash Reporting section
    - fix is already pending CI, thanks to Michael S
- New high severity bugs of the week:
  - Win11 dark theme support–Active selections have light blue background which makes white icons and text almost invisible
    - 152534 – Win11 dark theme support--Active selections have light blue background which makes white icons and text almost invisible
  - Opening “Export directly as PDF” dialog deletes text hidden via character formatting
    - 162298 – Opening "Export directly as PDF" dialog deletes text hidden via character formatting
    - Henry?
QA stats (Xisco)
- Weekly Bug Summary
  +134 -11 (-118) overall)
  many thanks to the top bug squashers:
  Buovjaga 12
  Mike Kaganski 11
  QA Administrators 11
  Xisco Faulí 8
  m_a_riosv 7
  Heiko Tietze 6
  V Stuart Foote 6
  Cor Nouws 4
  Julien Nabet 4
  Robert Großkopf 3
- top 10 bugs reporters:
  yoylasfpgas 7
  nobu 4
  Mike Kaganski 3
  Rafael Lima 3
  Telesto 3
  Buovjaga 2
  Caleb Meredith 2
  Gabor Kelemen (allotropia) 2
  Jonathan Clark 2
  Olivier Hallot 2
- top 10 bugs fixers:
  Xisco Fauli 5
  Nabet, Julien 4
  Heiko Tietze 3
  David Gilbert 2
  Jonathan Clark 2
  Justin Luth 2
  Kaganski, Mike 2
  Kira Tubo 2
  Timur Gadzo 2
  UNKNOWN 1
- top 10 bugs confirmers:
  Ilmari Lauhakangas 29
  m.a.riosv 10
  Heiko Tietze 7
  Xisco Fauli 5
  Robert Großkopf 4
  Vernon, Stuart Foote 4
  Kaganski, Mike 3
  Raal 3
  Rafael Lima 3
  Ady 2

Bisected bugs open: keyword ‘bisected’

more accurate - down to a single commit.
http://bit.ly/2dyIfDy

done by:
   Xisco Fauli            6
   Ilmari Lauhakangas     4
   Raal                   3
   Steve271               1
   Kaganski, Mike         1
   Timur Gadzo            1

Bibisected bugs open: keyword ‘bibisected’

Bug List: LibreOffice Bi-bisected

done by:
   Ilmari Lauhakangas     6
   Xisco Fauli            6
   Raal                   3
   Steve271               1
   Timur Gadzo            1

all bugs tagged with ‘regression’
- 1221(+8) bugs open of 13608(+23) total 24(+1) high prio.
  
  done by:
  Ilmari Lauhakangas 6
  Xisco Fauli 5
  m.a.riosv 3
  David Gilbert 1
  Wolfgang Jäger 1
  Kaganski, Mike 1
  Raal 1
  Henschel, Regina 1
  Nabet, Julien 1
  Telesto 1
~Component count net * high severity regressions
- Bug List
  Writer - 11(+1)
  Calc - 6(+0)
  Impress - 2(+0)
  LibreOffice - 2(+0)
  UI - 2(+0)
by OS:
All - 15(+1)
Linux - 6(+0)
Mac OS X - 0(+0)
Windows - 3(+0)
~Component count net * all regressions
- Bug List
  Writer: other - 394(+6)
  Calc - 246(+3)
  Impress - 121(-4)
  LibreOffice - 53(-1)
  Draw - 51(-1)
  Writer: docx filter - 45(+0)
  Crashes - 44(+3)
  Base - 41(+1)
  UI - 36(+0)
  Borders - 34(+0)
  Writer: other filter - 33(+2)
  Writer: perf - 33(+0)
  Printing and PDF export - 29(+2)
  Chart - 24(+0)
  RTL - 24(+1)
  BASIC - 21(+1)
  filters and storage - 21(+1)
  Writer: doc filter - 17(+0)
  graphics stack - 12(+0)
  Formula Editor - 11(+0)
  framework - 3(+0)
  sdk - 3(+1)
  Extensions - 2(+0)
  Linguistic - 1(+0)