ESC meeting minutes: 2024-09-05

[vmiklos]

• Present:

  • Cloph, Heiko, Olivier, Hossein, Ilmari, Jonathan, Thorsten, Caolan, Regina, Stephan, Xisco, Michael S, Miklos

• Completed Action Items:

  • perf.libreoffice.org: switch the default to the new data (Cloph)
  • Enable the commit bit for Vivek Javiya (Cloph)
  • Send the new committer mail for Vivek (Miklos)

• Pending Action Items:

• Release Engineering update (Cloph)

  • 24.8.1 rc2 this week

    • https://gerrit.libreoffice.org/q/branch:libreoffice-24-8-1+status:open

    • 24.8.2 rc1 in 2 weeks

      • Revert: https://gerrit.libreoffice.org/c/core/+/172895 ? (Xisco)

        • no objections for the short term

  • 24.2.7 rc1 in 5 weeks

• Documentation (Olivier)

  • Helpcontents2

    • Many updates for consistency (Pierre F, D. Maddern, ohallot)
    • Removing bookmark duplicity in pages (ohallot)
      • and obsolete HID’d

  • Guides

    • Calc Work in progress (Lisa Samy, Claire Woood, Ed Olson)

  • Bugzilla Documentation statistics
    227(227) bugs open

  • Updates:
    BZ changes 1 week 1 month 3 months 12 months
    created 11(-22) 69(-15) 115(5) 260(3)
    commented 34(-35) 185(4) 330(12) 963(20)
    resolved 6(-5) 35(-14) 71(5) 169(5)

  • top 10 contributors:
    Pierre F made 110 changes in 1 month, and 198 changes in 1 year
    Dione Maddern made 60 changes in 1 month, and 83 changes in 1 year
    Olivier Hallot made 51 changes in 1 month, and 318 changes in 1 year
    Ilmari Lauhakangas made 41 changes in 1 month, and 133 changes in 1 year
    Vernon, Stuart Foote made 32 changes in 1 month, and 154 changes in 1 year
    Ady made 11 changes in 1 month, and 13 changes in 1 year
    Alain Romedenne made 10 changes in 1 month, and 26 changes in 1 year
    Dieter made 10 changes in 1 month, and 26 changes in 1 year
    Heiko Tietze made 8 changes in 1 month, and 78 changes in 1 year
    Henschel, Regina made 6 changes in 1 month, and 18 changes in 1 year

• UX Update (Heiko)

  • Bugzilla (topicUI) statistics
    233(233) (topicUI) bugs open, 25(25) (needsUXEval) needs to be evaluated by the UXteam
  • Updates:
    BZ changes 1 week 1 month 3 months 12 months
    added 5(3) 8(3) 8(2) 17(3)
    commented 50(23) 112(22) 369(10) 1683(10)
    removed 0(0) 0(0) 2(0) 10(0)
    resolved 4(-2) 17(-7) 66(-6) 271(-3)
  • top 10 contributors:
    Heiko Tietze made 57 changes in 1 month, and 914 changes in 1 year
    Ilmari Lauhakangas made 33 changes in 1 month, and 159 changes in 1 year
    Vernon, Stuart Foote made 26 changes in 1 month, and 335 changes in 1 year
    steve made 14 changes in 1 month, and 16 changes in 1 year
    Ademas made 12 changes in 1 month, and 12 changes in 1 year
    Dieter made 7 changes in 1 month, and 133 changes in 1 year
    Roman Kuznetsov made 6 changes in 1 month, and 24 changes in 1 year
    Bogdan B made 6 changes in 1 month, and 39 changes in 1 year
    kolAflash made 6 changes in 1 month, and 12 changes in 1 year
    Rafael Lima made 6 changes in 1 month, and 75 changes in 1 year
  • [Bug 162753] Problem with ctrl-k and Insert/Hyperlink
  • [Bug 162759] make active cell highlight selection grid line a bright grey instead
    of white in dark mode or not use it at all?
  • [Bug 162738] Revert Changes to "File Properties / Description box
    → + [Bug 154568] Add a section “experimental features” in the Release Notes
    • page vs section? (Miklos)
    • suggest a page (Heiko)
    • Wiki page for different versions, like release notes? (Hossein)
    • the original request is a section in the release notes page (Ilmari)
    • 40 + 50 items
    • the more doc we have, the better, just let’s have it maintained
    • perhaps the list can be scripted (Heiko)
    • similar to https://wiki.documentfoundation.org/Development/DispatchCommands (Olivier)
    • create a stub section at ReleaseNotes/25.2 - The Document Foundation Wiki?
      • AI: Heiko to do this
        /done
      • also good to inform the doc team about the feature, so they have enough info (Olivier)
  • [Bug 162735] Basic IDE shouldn’t show scrollbars in Dialog creation mode if the
    dialog is small enough
  • [Bug 162709] PIVOTTABLE UI: improve field value list accessibility
  • [Bug 131235] Add help for trailing blanks gimmick and other missing compatibility
    options
  • [Bug 162660] Comment indicator size and color aesthetics and customization

• Crash Testing (Caolan)

  • 15(-3) import failure, 13(+0) export failures
    • Development/Crashtesting - The Document Foundation Wiki
    • most are 160862 – Converting a DOCX to ODT using command line export each frame twice
  • 424 coverity issues
    • downwards trend
  • 4 ossfuzz issues claimed to exist
    • but three seem to be fixed, issues "open" in bugs.chromium.org but "fixed" in oss-fuzz.com · Issue #12434 · google/oss-fuzz · GitHub for this failure to update

• Crash Reporting (Xisco)

  • 24.2.3.2 19224(+578)

  • 24.2.4.2 15345(+771)

  • 24.2.5.2 16138(+2591)

  • 24.8.0.3 4222(+2886)

  • New in 24.8:

    • Reports for signature: SwTextINetFormat::GetCharFormat()

  • Reports for signature: SwNode::GetNodes()

  • Reports for signature: SfxPoolItemHolder::~SfxPoolItemHolder()

  • https://crashreport.libreoffice.org/stats/signature/SwViewShell::VisPortChgd(SwRect const &)

  • may be related to multiple documents & item set rework

  • can’t reproduce so far

• Mentoring (Hossein)

  • Updated WSL documentation

    • Updated Wiki page based on the feedbacks
      Development/BuildingOnWSLWindows - The Document Foundation Wiki

    • Drafted a new blog post for WSL on dev blog:
      WSL for building LibreOffice
      WSL for building LibreOffice - LibreOffice Development Blog
      committer… 1 week 1 month 3 months 12 months
      open 71(6) 151(-17) 164(-13) 164(-13)
      reviews 426(98) 1286(2) 3806(74) 12960(10)
      merged 345(40) 1197(120) 3690(129) 13173(120)
      abandoned 6(-6) 69(-12) 234(-5) 761(-16)
      own commits 230(-17) 895(79) 2513(64) 9617(32)
      review commits 57(5) 237(-4) 759(13) 3100(5)
      contributor… 1 week 1 month 3 months 12 months
      open 38(2) 92(-11) 105(-7) 105(-7)
      reviews 854(32) 2940(22) 8312(116) 29838(12)
      merged 21(-11) 113(-15) 307(-7) 1462(-56)
      abandoned 5(3) 17(-17) 81(-2) 584(-4)
      own commits 28(11) 102(-4) 336(8) 1261(5)
      review commits 0(0) 0(0) 0(0) 0(0)

    • easyHack statistics:
      needsDevEval 8(8) needsUXEval 1(1) cleanup_comments 328(328)
      total 415(415) assigned 26(26) open 354(354)

    • top 10 contributors:
      Pierre F made 28 patches in 1 month, and 82 patches in 1 year
      made 12 patches in 1 month, and 29 patches in 1 year
      Adam Seskunas made 11 patches in 1 month, and 27 patches in 1 year
      Dione Maddern made 9 patches in 1 month, and 78 patches in 1 year
      Hubert Figuière made 5 patches in 1 month, and 14 patches in 1 year
      Bogdan B made 3 patches in 1 month, and 91 patches in 1 year
      Ahmed Hamed made 3 patches in 1 month, and 12 patches in 1 year
      Weblate made 2 patches in 1 month, and 38 patches in 1 year
      Kurt Nordback made 2 patches in 1 month, and 28 patches in 1 year
      Darshan Upadhyay made 2 patches in 1 month, and 13 patches in 1 year

    • top 10 reviewers:
      Michael Stahl made 134 review comments in 1 month, and 866 in 1 year
      Adolfo Jayme Barrientos made 112 review comments in 1 month, and 792 in 1 year
      Caolán McNamara made 112 review comments in 1 month, and 1400 in 1 year
      Thorsten Behrens made 88 review comments in 1 month, and 684 in 1 year
      Christian Lohmaier made 86 review comments in 1 month, and 508 in 1 year
      Kaganski, Mike made 68 review comments in 1 month, and 470 in 1 year
      Ilmari Lauhakangas made 68 review comments in 1 month, and 622 in 1 year
      Heiko Tietze made 66 review comments in 1 month, and 296 in 1 year
      Xisco Fauli made 66 review comments in 1 month, and 764 in 1 year
      Vajna, Miklos made 52 review comments in 1 month, and 1114 in 1 year

    • Patches automatically abandoned:
      tdf#157029 changed Korean Font priority for LibreOffice UI ( DaeHyun Sung )
      - https://gerrit.libreoffice.org/#/c/157494

      tdf#45904 : Remove Old SwXChapterNumbering Java Test ( Seturaj Matroja )
      - https://gerrit.libreoffice.org/#/c/164406

      tdf#45904 : Remove Old SwXHeadFootText Java Test ( Seturaj Matroja )
      - https://gerrit.libreoffice.org/#/c/164437

      tdf#97362 Rewrite PasswordContainer tests in python ( Ritobroto Mukherjee )
      - https://gerrit.libreoffice.org/#/c/165038

• GSoC (Ilmari)

  • 4 projects with extensions, to be finished till the end of Sept

• LiboCon (Cloph)

  • Development workshop (planned for 11th and 12th of October; Hossein)
    Workshop: Introduction to LibreOffice Development » LibreOffice Conference
    Register to workshop » LibreOffice Conference

• Commit Access

  • Kira Tubo https://gerrit.libreoffice.org/q/owner:kira.tubo@gmail.com (Heiko)

    • enjoying the current safety belt for now (Ilmari)

  • https://gerrit.libreoffice.org/admin/groups/70c36bd1bfcbef2d3bcfc25622e8aaf57d99bb7c,members is the list (Miklos)

  • Common gerrit queries - The Document Foundation Wiki can be used as well (Ilmari)

• Developer Certification (Stephan/Miklos/László/Gabriel)

  • resting since: 15 weeks (limit: 20 weeks)

• Jenkins / CI update (Cloph)
  gerrit_android_aarch64 jobs: 167 ok: 164 ko: 1 fail ratio: 0.60% mean_ok: 12 ( 24) median_ok: 9 ( 18)
  gerrit_android_arm jobs: 167 ok: 159 ko: 0 fail ratio: 0.00% mean_ok: 11 ( 23) median_ok: 9 ( 16)
  gerrit_android_x86 jobs: 167 ok: 166 ko: 0 fail ratio: 0.00% mean_ok: 11 ( 23) median_ok: 7 ( 17)
  gerrit_android_x86_64 jobs: 166 ok: 157 ko: 0 fail ratio: 0.00% mean_ok: 12 ( 25) median_ok: 9 ( 19)
  gerrit_linux_clang_dbgutil jobs: 340 ok: 269 ko: 60 fail ratio: 17.65% mean_ok: 56 ( 69) median_ok: 53 ( 64)
  gerrit_linux_gcc_release jobs: 383 ok: 322 ko: 31 fail ratio: 8.09% mean_ok: 26 ( 36) median_ok: 20 ( 27)
  gerrit_mac jobs: 335 ok: 310 ko: 11 fail ratio: 3.28% mean_ok: 54 ( 57) median_ok: 48 ( 49)
  gerrit_windows jobs: 356 ok: 269 ko: 70 fail ratio: 19.66% mean_ok: 68 (120) median_ok: 63 ( 90)
  gerrit_master_ml jobs: 414 ok: 230 ko: 145 fail ratio: 35.02% mean_ok: 156 (156) median_ok: 128 (129)
  gerrit_master jobs: 49 ok: 18 ko: 21 fail ratio: 42.86% mean_ok: 135 (136) median_ok: 127 (127)
  gerrit_master_seq jobs: 365 ok: 213 ko: 123 fail ratio: 33.70% mean_ok: 155 (157) median_ok: 128 (128)

  • tests that failed more than twice in last seven days
    3 CppunitTest_chart2_pivot_chart_test gerrit_linux_gcc_release
    3 CppunitTest_sw_layoutwriter3 gerrit_linux_gcc_release
    3 UITest_sw_navigator gerrit_linux_clang_dbgutil
    5 JunitTest_svx_unoapi gerrit_linux_clang_dbgutil
    6 JunitTest_sw_unoapi_3 gerrit_linux_clang_dbgutil
    9 Killed by the kill-wrapper gerrit_linux_clang_dbgutil
    43 aborted by jenkins job timeout gerrit_windows
  • this week: large number of builds were stuck on Windows, multiple bots (Cloph)
    • would need a kill-wrapper-like tool for Windows to know which test is hanging
    • maybe for one bot the timeout was too agressive
    • short gerrit downtime with HTTP 500, but not much impact

• What’s cooking (Miklos)

  • A11y update (Michael W)
  • RTL/CTL/CJK update (Jonathan)
    • tdf#151748: editeng: Bad kashida in text boxes
      • 151748 – Bad Horizontal lines (kashida) in Arabic/Persian text inside a text box
      • editeng was inserting kashida where there was not enough room
      • Behavior now similar to Writer
    • tdf#92064: LO unusable with Tibetan super long paragraphs
      • 92064 – LO unusable with Tibetan super long paragraphs
      • A further ~87% reduction, and long pauses during loading gone
      • Closed bug: still somewhat slow, but no longer unusable
      • thanks for the performance improvements (Hossein)
  • CairoSDPR from Armin
    • further small optimizations
  • Playing with a new baseline with Windows (Cloph)
    • there, 2 builds for the same user is slower than 2 separate users
    • some junit test is failing as well, maybe only on VMs
    • current: Windows 2012 → replace it with something newer

• QA update (Xisco)

  • UNCONFIRMED: 1235 (+7)

    • enhancements: 290 (+3)
    • needsUXEval: 4 (+1)
    • haveBackTrace: 9 (+0)
    • needsDevAdvice: 46 (+1)
    • documentation: 9 (+3)
    • android: 0 (+0)
    • iOS: 0 (+0)
    • Online: 9 (+0)

  • Most pressing bugs:
    New:
    None

  • New high severity bugs of the week:

    • Automatic font color should consider cell background instead of DefaultStyleSheet
      • 149571 – Automatic font color should consider cell background instead of DefaultStyleSheet
      • not tagged as a regression
      • maybe for interest for UX (Xisco)
      • comment 5 has his input (Heiko)

• QA stats (Xisco)

  • Weekly Bug Summary
    +123 +0 (-105) overall)
    many thanks to the top bug squashers:
    QA Administrators 13
    Mike Kaganski 7
    Xisco Faulí 7
    Buovjaga 6
    fpy 6
    m_a_riosv 6
    Caolán McNamara 4
    Gabor Kelemen (allotropia) 3
    Heiko Tietze 3
    Jonathan Clark 3

  • top 10 bugs reporters:
    Xisco Faulí 5
    Buovjaga 4
    Eyal Rozenberg 4
    Mike Kaganski 4
    Roman 4
    Albert Acer 3
    Gabor Kelemen (allotropia) 3
    rehierl 3
    Miklos Vajna 2
    Regina Henschel 2

  • top 10 bugs fixers:
    Kaganski, Mike 6
    Pierre F 6
    Caolán McNamara 4
    Jonathan Clark 4
    Kelemen, Gabor 3
    Vajna, Miklos 3
    Weghorn, Michael 3
    Xisco Fauli 3
    Balland-Poirier, Laurent 2
    David Gilbert 2

  • top 10 bugs confirmers:
    Ilmari Lauhakangas 22
    m.a.riosv 17
    Nabet, Julien 11
    Heiko Tietze 10
    Kaganski, Mike 7
    Xisco Fauli 5
    UNKNOWN 3
    Weghorn, Michael 3
    Ady 2
    Bogaboga Man 2

• Bisected bugs open: keyword ‘bisected’

  • more accurate - down to a single commit.
  • Bug List: LibreOffice Bi-bisected

  done by:
     Ilmari Lauhakangas     4
     Xisco Fauli            4
     Raal                   1
     Timur Gadzo            1
  

• Bibisected bugs open: keyword ‘bibisected’

  • Bug List: LibreOffice Bi-bisected

  done by:
     Ilmari Lauhakangas     5
     Xisco Fauli            4
     florimapaul202         1
     Raal                   1
  

• all bugs tagged with ‘regression’

  • 1213(+5) bugs open of 13585(+20) total 23(-1) high prio.

    done by:
    Ilmari Lauhakangas 6
    Ady 3
    m.a.riosv 3
    Xisco Fauli 2
    David 1
    Kaganski, Mike 1
    Robert Großkopf 1
    Telesto 1

• ~Component count net * high severity regressions

  • Bug List
    Writer - 10(-1)
    Calc - 6(+0)
    Impress - 2(+0)
    LibreOffice - 2(+0)
    UI - 2(+0)

  by OS:
  All - 14(-1)
  Linux - 6(+0)
  Mac OS X - 0(+0)
  Windows - 3(+0)

• ~Component count net * all regressions

  • Bug List
    Writer: other - 388(+3)
    Calc - 243(+2)
    Impress - 125(+0)
    LibreOffice - 54(+1)
    Draw - 52(+2)
    Writer: docx filter - 45(-1)
    Crashes - 41(-1)
    Base - 40(+1)
    UI - 36(-1)
    Borders - 34(+0)
    Writer: perf - 33(+0)
    Writer: other filter - 31(+0)
    Printing and PDF export - 27(+0)
    Chart - 24(+0)
    RTL - 23(+0)
    BASIC - 20(+0)
    filters and storage - 20(+0)
    Writer: doc filter - 17(+0)
    graphics stack - 12(+0)
    Formula Editor - 11(+0)
    framework - 3(+0)
    Extensions - 2(+0)
    sdk - 2(+0)
    Linguistic - 1(+0)