ESC meeting minutes: 2024-08-29

vmiklos · August 29, 2024, 2:42pm

Present:
- Hossein, Michael W, Thorsten, Caolan, Cloph, Heiko, Ilmari, Jonathan, Michael S, Regina, Stephan, Xisco, Olivier, Miklos
Completed Action Items:
- enable MAR updater by default (Stephan)
Pending Action Items:
- perf.libreoffice.org: switch the default to the new data (Cloph)
- Enable the commit bit for Vivek Javiya (Cloph)
- Send the new committer mail for Vivek (Miklos)
Release Engineering update (Cloph)
- 24.8.1 rc2 next week?
  - keep an eye on the NSS update, hopefully sorted out by Xisco
  - did anybody figure out why downgrading the NSS DLL version is a problem? (Michael S)
    - Mike K was commenting on that on IRC (Ilmari)
      - “that is likely our MSI check, which checks what to “upgrade”, and chooses not to upgrade some newer DLLs; but then doing a complete uninstall.”
    - not sure about the details, just updated to the latest version, then back to the ESR version (Xisco)
- 24.2.6 rc2 this week, later today
Cell indicator in 24.8 branch (Xisco)
- Summary: 162646 – macOS: active cell indicator is not symmetrical
- two topics: comment indicator and focus rectangle; no revert please (Heiko)
- the fear is that what’s there in 24.8 is half-done (Xisco)
- comments are mixed (Ilmari)
  - some people like what’s in master
  - just today 2 commits were backported
  - one more patch to merge to 24-8, would be ideal even on 24-8-1
- the issue is quite old, the focus rectangle of a cell was painted inside the cell (Heiko)
  - then tried outside the cell to not cover content
  - design team suggestion was: push it to the release, see what the wider community likes
  - meanwhile Rafael improved this, seems people are happy with the current state
  - hope the problem is fixed
  - would like to avoid adding more options for this
  - would be good to wait, collect input and not just revert quickly
- do you support backporting the relevant changes from master? (Ilmari)
  - like it (Heiko)
- fine with this, just good to not experiment on release branches (Xisco)+
Documentation (Olivier)
- Help
  - Updates and fixes (ohallot, Pierre F, buovjaga, Alain R.)
- Guides
  - Work on going.
- Bugzilla Documentation statistics
  234(234) bugs open
- Updates:
  BZ changes 1 week 1 month 3 months 12 months
  created 33(9) 84(12) 110(4) 257(12)
  commented 69(26) 181(48) 318(49) 943(38)
  resolved 11(2) 49(10) 66(0) 164(9)
- top 10 contributors:
  Pierre F made 134 changes in 1 month, and 178 changes in 1 year
  Olivier Hallot made 75 changes in 1 month, and 320 changes in 1 year
  Dione Maddern made 64 changes in 1 month, and 83 changes in 1 year
  Vernon, Stuart Foote made 32 changes in 1 month, and 153 changes in 1 year
  Ilmari Lauhakangas made 27 changes in 1 month, and 119 changes in 1 year
  Ady made 11 changes in 1 month, and 13 changes in 1 year
  Alain Romedenne made 10 changes in 1 month, and 26 changes in 1 year
  Dieter made 10 changes in 1 month, and 26 changes in 1 year
  Henschel, Regina made 8 changes in 1 month, and 18 changes in 1 year
  Kaganski, Mike made 7 changes in 1 month, and 83 changes in 1 year
UX Update (Heiko)
- Bugzilla (topicUI) statistics
  233(233) (topicUI) bugs open, 24(24) (needsUXEval) needs to be evaluated by the UXteam
- Updates:
  BZ changes 1 week 1 month 3 months 12 months
  added 2(-3) 5(-4) 6(-4) 14(-4)
  commented 27(-7) 90(-42) 359(-53) 1673(-74)
  removed 0(0) 0(0) 2(0) 10(0)
  resolved 6(5) 24(0) 72(-1) 274(-7)
- top 10 contributors:
  Heiko Tietze made 43 changes in 1 month, and 912 changes in 1 year
  Vernon, Stuart Foote made 32 changes in 1 month, and 337 changes in 1 year
  Ilmari Lauhakangas made 17 changes in 1 month, and 143 changes in 1 year
  Eyal Rozenberg made 14 changes in 1 month, and 151 changes in 1 year
  Dieter made 10 changes in 1 month, and 140 changes in 1 year
  steve made 8 changes in 1 month, and 10 changes in 1 year
  Kelemen, Gabor made 6 changes in 1 month, and 30 changes in 1 year
  kolAflash made 6 changes in 1 month, and 12 changes in 1 year
  Roman Kuznetsov made 5 changes in 1 month, and 22 changes in 1 year
  Bogdan B made 5 changes in 1 month, and 38 changes in 1 year
- [Bug 162005] in windows list (in panel) (LINUX) different icon for .ODT and
  .ODM document windows
- [Bug 154434] FILEOPEN HTML: Writer loses HTML layout
- [Bug 162031] Poor visiblity of line linking comment to text
- [Bug 161972] Inserting new comment in Calc disables the “show all comments”
  setting
- [Bug 162582] Find toolbar’s “Search key not found” error message has
  incompatible colors in dark mode, especially its icon (Sifr dark theme only)
  → + [Bug 162028] When a cell is protected and the language is changed for all text
  the language of that cell is changed too
  + think it’s not a big deal (Heiko)
  + all-text vs protection conflict
- [Bug 162615] too wide a left sidebar in Start Center for RU locale
→ + PIVOTTABLE: Warning does not show range when overwriting destination
range contents
+ 162417 – PIVOTTABLE: Warning does not show range when overwriting destination range contents
+ maybe just block overwrite, don’t ask
Crash Testing (Caolan)
- 18(+2) import failure, 13(+0) export failures
- 479 coverity issues
- 2 ossfuzz issues
  - 2 timeouts (2 other issues claimed fixed in oss-fuzz, but not auto-closed)
- special run for libreoffice-24-8
Crash Reporting (Xisco)
- 24.2.3.2 18646(+574)
- 24.2.4.2 14574(+756)
- 24.2.5.2 13547(+2739)
- 24.8.0.3 1336(+0)
- New in 24.8
  - Reports for signature: SwTextINetFormat::GetCharFormat()
  - Reports for signature: SwNode::GetNodes()
- DOCX export
- seems not on master, trying to see if crashtesting finds a sample (Xisco)
  - Reports for signature: SwViewShell::VisPortChgd(SwRect const &)
    - PDF export
Mentoring (Hossein)
```
+ Added a Wiki page for building LO for Windows with WSL

https://wiki.documentfoundation.org/Development/BuildingOnWSLWindows
+ WSL build for Linux was previously added
+ In the end, they may be merged in the build pages for relevant OS
     committer...   1 week     1 month      3 months    12 months
             open      65(-28)    168(-13)     177(-10)     177(-10)
          reviews     328(-38)   1284(-104)   3732(-8)    12950(-244)
           merged     305(53)    1077(28)     3561(75)    13053(34)
        abandoned      12(-5)      81(-8)      239(-1)      777(-3)
      own commits     247(63)     816(64)     2449(78)     9585(69)
   review commits      52(-7)     241(3)       746(-1)     3095(-36)
   contributor...   1 week     1 month     3 months   12 months
             open      36(-28)    103(-11)    112(-6)     112(-6)
          reviews     822(-50)   2918(-34)   8196(88)   29826(-66)
           merged      32(-9)     128(7)      314(16)    1518(-26)
        abandoned       2(-2)      34(-5)      83(-6)     588(-7)
      own commits      17(-8)     106(-5)     328(-2)    1256(-20)
   review commits       0(0)        0(0)        0(0)        0(0)
```
- easyHack statistics:
  needsDevEval 8(8) needsUXEval 1(1) cleanup_comments 328(328)
  total 412(412) assigned 24(24) open 353(353)
- top 10 contributors:
  Pierre F made 34 patches in 1 month, and 72 patches in 1 year
  made 11 patches in 1 month, and 28 patches in 1 year
  Dione Maddern made 11 patches in 1 month, and 78 patches in 1 year
  Adam Seskunas made 9 patches in 1 month, and 26 patches in 1 year
  Hubert Figuière made 5 patches in 1 month, and 14 patches in 1 year
  Ritobroto Mukherjee made 5 patches in 1 month, and 28 patches in 1 year
  Kurt Nordback made 3 patches in 1 month, and 28 patches in 1 year
  Weblate made 2 patches in 1 month, and 37 patches in 1 year
  Kira Tubo made 2 patches in 1 month, and 21 patches in 1 year
  Ahmed Hamed made 2 patches in 1 month, and 11 patches in 1 year
- top 10 reviewers:
  Thorsten Behrens made 122 review comments in 1 month, and 702 in 1 year
  Michael Stahl made 118 review comments in 1 month, and 846 in 1 year
  Caolán McNamara made 116 review comments in 1 month, and 1416 in 1 year
  Adolfo Jayme Barrientos made 106 review comments in 1 month, and 762 in 1 year
  Vajna, Miklos made 86 review comments in 1 month, and 1126 in 1 year
  Kaganski, Mike made 64 review comments in 1 month, and 464 in 1 year
  Nabet, Julien made 60 review comments in 1 month, and 900 in 1 year
  Christian Lohmaier made 60 review comments in 1 month, and 514 in 1 year
  Hossein made 56 review comments in 1 month, and 338 in 1 year
  Heiko Tietze made 54 review comments in 1 month, and 282 in 1 year
- big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
  Sohrab Kazak sohrab.kazak@gmail.com
GSoC (Ilmari)
- 26 August is the deadline for final code submissions in non-extended projects
  - then final eval from mentors
- 4 projects with extensions, to be finished till the end of Sept
- mentors can see the individual deadlines on the gsoc site
LiboCon (Cloph)
- CfP is open: LibreOffice Conference 2024 :: pretalx
  - 2024-08-31 11:52 (UTC) is the deadline (less than 2 days)
- Call re development workshop, working on it (Hossein)
- slot for the ESC call needs filing? (Miklos)
  - yes, and also done for the gsoc panel (Ilmari)
  - looking forward to see students in person (Thorsten)
- lightning talks slot? (Stephan)
  - not sure if that would be individual vs a placeholder slot
  - blocking out some time for this would be useful (Thorsten)
    - like the lightning talks catch-all slot idea (Cloph)
Commit Access
Developer Certification (Stephan/Miklos/László/Gabriel)
- resting since: 14 weeks (limit: 20 weeks)
Jenkins / CI update (Cloph)
gerrit_android_aarch64 jobs: 180 ok: 177 ko: 3 fail ratio: 1.67% mean_ok: 13 ( 23) median_ok: 9 ( 16)
gerrit_android_arm jobs: 181 ok: 174 ko: 7 fail ratio: 3.87% mean_ok: 12 ( 22) median_ok: 9 ( 14)
gerrit_android_x86 jobs: 179 ok: 176 ko: 3 fail ratio: 1.68% mean_ok: 14 ( 23) median_ok: 11 ( 16)
gerrit_android_x86_64 jobs: 180 ok: 179 ko: 1 fail ratio: 0.56% mean_ok: 12 ( 23) median_ok: 8 ( 15)
gerrit_linux_clang_dbgutil jobs: 373 ok: 292 ko: 76 fail ratio: 20.38% mean_ok: 53 ( 62) median_ok: 50 ( 54)
gerrit_linux_gcc_release jobs: 418 ok: 352 ko: 41 fail ratio: 9.81% mean_ok: 27 ( 36) median_ok: 19 ( 25)
gerrit_mac jobs: 365 ok: 335 ko: 28 fail ratio: 7.67% mean_ok: 53 ( 53) median_ok: 44 ( 45)
gerrit_windows jobs: 375 ok: 302 ko: 70 fail ratio: 18.67% mean_ok: 61 ( 63) median_ok: 57 ( 58)
gerrit_master_ml jobs: 447 ok: 241 ko: 173 fail ratio: 38.70% mean_ok: 106 (106) median_ok: 91 ( 92)
gerrit_master jobs: 46 ok: 21 ko: 25 fail ratio: 54.35% mean_ok: 83 ( 83) median_ok: 71 ( 71)
gerrit_master_seq jobs: 401 ok: 222 ko: 149 fail ratio: 37.16% mean_ok: 107 (107) median_ok: 92 ( 92)
- tests that failed more than twice in last seven days
  3 CppunitTest_chart2_import2 gerrit_linux_gcc_release
  3 JunitTest_chart2_unoapi gerrit_linux_clang_dbgutil
  3 UITest_impress_tests gerrit_linux_clang_dbgutil
  3 UITest_sw_ui_frmdlg gerrit_linux_clang_dbgutil
  4 JunitTest_toolkit_unoapi_4 gerrit_linux_clang_dbgutil
  5 UITest_sw_navigator gerrit_linux_clang_dbgutil
  9 Killed by the kill-wrapper gerrit_linux_clang_dbgutil
  36 aborted by jenkins job timeout gerrit_windows
- this week: 1 windows bot got locked into the failure state, otherwise OK (Cloph)
What’s cooking (Miklos)
- A11y update (Michael W)
  - looking into LibreOffice Writer: provide speech and braille feedback for common shortcut keys · Issue #6915 · nvaccess/nvda · GitHub ("LibreOffice Writer:
    provide speech and braille feedback for common shortcut keys), some related
    changes
  - wina11y: Report accessible ID as “id” object attribute, now part of official
    IAccessible2 spec: Add an "id" object attribute by michaelweghorn · Pull Request #31 · LinuxA11y/IAccessible2 · GitHub
  - Accerciser: improvements to highlighting feature, show process ID
- RTL/CTL/CJK update (Jonathan)
  - tdf#162639: sw: kashida justification layout was zoom-dependent
    - 162639 – Kashida character is placed slightly misplaced at low zoom levels
  - tdf#152142: sw: textboxes positioned incorrectly in RTL text
    - 152142 – RTL Text sometimes falls out of the text box
- CairoSDPR from Armin
- tdf#161941 add --with-docrepair-fonts option (Caolán)
QA update (Xisco)
- UNCONFIRMED: 1228 (-1)
  - enhancements: 287 (+4)
  - needsUXEval: 3 (-6)
  - haveBackTrace: 9 (+0)
  - needsDevAdvice: 45 (-2)
  - documentation: 6 (+1)
  - android: 0 (+0)
  - iOS: 0 (+0)
  - Online: 9 (+0)
- Most pressing bugs:
  New:
  None
  Fixed:
  - LibreOffice doesn’t start on Windows (erorr messages about nss3.dll and nspr4.dll)
    - 162589 – LibreOffice doesn't start on Windows (erorr messages about nss3.dll and nspr4.dll)
    - Problematic commit reverted (Xisco)
- New high severity bugs of the week:
  None
QA stats (Xisco)
- Weekly Bug Summary
  +123 -49 (-118) overall)
  many thanks to the top bug squashers:
  Buovjaga 13
  QA Administrators 10
  Heiko Tietze 7
  Justin L 6
  Caolán McNamara 5
  Olivier Hallot 5
  Michael Weghorn 4
  Mike Kaganski 4
  Rafael Lima 4
  Xisco Faulí 4
- top 10 bugs reporters:
  Jeff Fortin Tam 6
  Justin L 6
  Buovjaga 4
  Regina Henschel 4
  Bogaboga Man 3
  Cor Nouws 3
  Manu 3
  Olivier Hallot 3
  Hossein 2
  Mike Kaganski 2
- top 10 bugs fixers:
  Justin Luth 5
  Caolán McNamara 4
  Olivier Hallot 4
  Bogaboga Man 3
  Jim Raykowski 3
  Jonathan Clark 3
  Pierre F 3
  Weghorn, Michael 3
  Grandin, Noel 2
  Heiko Tietze 2
- top 10 bugs confirmers:
  Ilmari Lauhakangas 31
  m.a.riosv 9
  Ady 8
  Raal 7
  Justin Luth 5
  Xisco Fauli 5
  Weghorn, Michael 4
  Caolán McNamara 3
  Heiko Tietze 3
  Nabet, Julien 3

Bisected bugs open: keyword ‘bisected’

more accurate - down to a single commit.
http://bit.ly/2dyIfDy

done by:
   Ilmari Lauhakangas     9
   Raal                   5
   Xisco Fauli            2
   Steve271               1
   Justin Luth            1
   Németh, László         1

Bibisected bugs open: keyword ‘bibisected’

Bug List: LibreOffice Bi-bisected

done by:
   Ilmari Lauhakangas    10
   Raal                   5
   Xisco Fauli            2
   Aron Budea             1
   Steve271               1
   Justin Luth            1
   Németh, László         1

all bugs tagged with ‘regression’
- 1208(+6) bugs open of 13565(+20) total 24(+0) high prio.
  
  done by:
  Ilmari Lauhakangas 7
  Raal 3
  Xisco Fauli 2
  Ady 1
  David 1
  Justin Luth 1
  m.a.riosv 1
  Németh, László 1
  Henning 1
~Component count net * high severity regressions
- Bug List
  Writer - 11(+0)
  Calc - 6(+0)
  Impress - 2(+0)
  LibreOffice - 2(+0)
  UI - 2(+0)
by OS:
All - 15(+0)
Linux - 6(+0)
Mac OS X - 0(+0)
Windows - 3(+0)
~Component count net * all regressions
- Bug List
  Writer: other - 385(+2)
  Calc - 241(+0)
  Impress - 125(-2)
  LibreOffice - 53(+1)
  Draw - 50(+1)
  Writer: docx filter - 46(+2)
  Crashes - 42(-1)
  Base - 39(+0)
  UI - 37(+0)
  Borders - 34(+0)
  Writer: perf - 33(+0)
  Writer: other filter - 31(+0)
  Printing and PDF export - 27(+1)
  Chart - 24(+0)
  RTL - 23(+0)
  BASIC - 20(+0)
  filters and storage - 20(+0)
  Writer: doc filter - 17(+0)
  graphics stack - 12(+0)
  Formula Editor - 11(+1)
  framework - 3(+0)
  Extensions - 2(+0)
  sdk - 2(+0)
  Linguistic - 1(+0)