ESC meeting minutes: 2024-08-08

vmiklos · August 8, 2024, 2:45pm

Present:
- Olivier, Caolan, Cloph, Heiko, Hossein, Jonathan, Michael W, Michael S, Regina, Stephan, Miklos
Completed Action Items:
Pending Action Items:
Release Engineering update (Cloph)
- 24.8.0 rc3 this week?
  ~ 9 patches waiting in queue: https://gerrit.libreoffice.org/q/status:open+branch:libreoffice-24-8-0
- 24.2.6 rc1 in 1 week?
- 24.8 Windows arm status? (Stephan)
  - crashes on start when dictionaries are enabled
  - plan to have it in the platform selector (Cloph)
    - will get back to the Linaro on this
    - 24.8.0 is not meant to be available on the app stores
    - later: fix it, strip away lightproof, we’ll see
Documentation (Olivier)
- Helpcontent2
  - Bug fixes from Ask.LO (Pierre F, after M. Kaganski support)
  - Refactor for maintenance (ohallot)
  - New pages for Sidebar ( D. Maddern)
  - Typos and translations (A. Barrientos)
  - Database Tables referencing (Regina)
    - CalcTableRef - The Document Foundation Wiki
- Support needed for defining Help ID’s in many places (D. Maddern)
  - see ML.
  - Michael W is helping out here
- Suport needed for A11y in dialogs
  - Michael W is helping out here
- Guides
  - Finishing Getting Started
  - Stating Calc Guide
- Bugzilla Documentation statistics
  238(238) bugs open
- Updates:
  BZ changes 1 week 1 month 3 months 12 months
  created 30(30) 44(44) 95(95) 228(228)
  commented 28(28) 75(75) 247(247) 853(853)
  resolved 19(19) 26(26) 62(62) 143(143)
- top 10 contributors:
  Pierre F made 51 changes in 1 month, and 84 changes in 1 year
  Olivier Hallot made 40 changes in 1 month, and 288 changes in 1 year
  Ilmari Lauhakangas made 13 changes in 1 month, and 97 changes in 1 year
  Henschel, Regina made 8 changes in 1 month, and 16 changes in 1 year
  Dione Maddern made 7 changes in 1 month, and 105 changes in 1 year
  Heiko Tietze made 6 changes in 1 month, and 86 changes in 1 year
  Roman Kuznetsov made 5 changes in 1 month, and 10 changes in 1 year
  Cor Nouws made 5 changes in 1 month, and 15 changes in 1 year
  m.a.riosv made 5 changes in 1 month, and 24 changes in 1 year
  Kaganski, Mike made 5 changes in 1 month, and 80 changes in 1 year
Question from unnamed person:
Could we add some stats of AskLO ?
so far, there’s a very limited table in : https://ask.libreoffice.org/about
would be interesting to have some sort of push email to remind posters to mark their posts as “resolved” when it’s the case.
And more generally to get an idea of trend : few stats of page views for help / wiki / downloads … ?
- Ilmari: there are stats in GrimoireLab Analytics
- at least the dashboard seems to track contributions on the Ask site (Miklos)
UX Update (Heiko)
- Bugzilla (topicUI) statistics
  234(234) (topicUI) bugs open, 25(25) (needsUXEval) needs to be evaluated by the UXteam
- Updates:
  BZ changes 1 week 1 month 3 months 12 months
  added 2(2) 4(4) 5(5) 13(13)
  commented 28(28) 137(137) 431(431) 1728(1728)
  removed 0(0) 0(0) 2(2) 10(10)
  resolved 6(6) 25(25) 76(76) 282(282)
- top 10 contributors:
  Heiko Tietze made 63 changes in 1 month, and 953 changes in 1 year
  Stéphane Guillou made 37 changes in 1 month, and 604 changes in 1 year
  Eyal Rozenberg made 28 changes in 1 month, and 168 changes in 1 year
  Rafael Lima made 18 changes in 1 month, and 72 changes in 1 year
  Henschel, Regina made 13 changes in 1 month, and 49 changes in 1 year
  Vernon, Stuart Foote made 11 changes in 1 month, and 324 changes in 1 year
  Justin Luth made 10 changes in 1 month, and 76 changes in 1 year
  Ady made 8 changes in 1 month, and 115 changes in 1 year
  m.a.riosv made 8 changes in 1 month, and 46 changes in 1 year
  Ilmari Lauhakangas made 7 changes in 1 month, and 137 changes in 1 year
- [Bug 162388] Customizing drawing shape size with “Resize shape to fit text”
  option enabled
- [Bug 162362] Rename “Page Master” and “Slide Master”
- [Bug 139107] Availability of non-printing Unicode special characters should
  not depend upon the font
- [Bug 162305] When opening plain text files with LTR and RTL,
  paragraph directions and alignment are wrong
  → + [Bug 162296] Enable ‘Extended Tips’ on Tools → Options → General by default
Crash Testing (Caolan)
- 51(+0) import failure, 15(+0) export failures
  - Development/Crashtesting - The Document Foundation Wiki
  - most recent assert fixed, thanks to erack
- 840 coverity issues
  - now sub 1000
- 6 oss-fuzz issues
  - 1 (3rd party lib) crash, 5 timeouts
- CVE-2024-6472 Ability to trust not validated macro signatures removed in high security mode
Crash Reporting (Xisco)
- Missing Xisco
- 24.2.2.2 19108(+0)
- 24.2.3.2 16648(+0)
- 24.2.4.2 11924(+0)
- 24.2.5.2 4391(+0)
Mentoring (Hossein)
- Reviewed submissions from newcomers
- Added a new draft blog post for extending UNO API
  Extending UNO API
  Extending UNO API - LibreOffice Development Blog
  committer… 1 week 1 month 3 months 12 months
  open 84(84) 175(175) 178(178) 178(178)
  reviews 436(436) 1564(1564) 3880(3880) 13178(13178)
  merged 242(242) 1274(1274) 3676(3676) 12953(12953)
  abandoned 21(21) 78(78) 221(221) 755(755)
  own commits 159(159) 875(875) 2477(2477) 9433(9433)
  review commits 60(60) 221(221) 757(757) 3081(3081)
  contributor… 1 week 1 month 3 months 12 months
  open 47(47) 110(110) 110(110) 110(110)
  reviews 810(810) 3252(3252) 8326(8326) 29956(29956)
  merged 18(18) 75(75) 269(269) 1504(1504)
  abandoned 21(21) 43(43) 88(88) 739(739)
  own commits 28(28) 98(98) 329(329) 1232(1232)
  review commits 0(0) 0(0) 0(0) 0(0)
  - easyHack statistics:
    needsDevEval 9(9) needsUXEval 1(1) cleanup_comments 330(330)
    total 415(415) assigned 22(22) open 357(357)
  - top 10 contributors:
    Pierre F made 26 patches in 1 month, and 54 patches in 1 year
    Armin Le Grand (allotropia) made 5 patches in 1 month, and 81 patches in 1 year
    Weblate made 4 patches in 1 month, and 36 patches in 1 year
    Bogdan B made 4 patches in 1 month, and 88 patches in 1 year
    Dione Maddern made 4 patches in 1 month, and 69 patches in 1 year
    Adam Seskunas made 3 patches in 1 month, and 18 patches in 1 year
    Kira Tubo made 3 patches in 1 month, and 20 patches in 1 year
    Srebotnjak, Martin made 2 patches in 1 month, and 21 patches in 1 year
    Vladislav Tarakanov made 2 patches in 1 month, and 3 patches in 1 year
    Ahmed Hamed made 2 patches in 1 month, and 9 patches in 1 year
  - top 10 reviewers:
    Thorsten Behrens made 156 review comments in 1 month, and 716 in 1 year
    Adolfo Jayme Barrientos made 128 review comments in 1 month, and 700 in 1 year
    Caolán McNamara made 122 review comments in 1 month, and 1442 in 1 year
    Christian Lohmaier made 102 review comments in 1 month, and 498 in 1 year
    Xisco Fauli made 90 review comments in 1 month, and 766 in 1 year
    Michael Stahl made 84 review comments in 1 month, and 860 in 1 year
    Vajna, Miklos made 74 review comments in 1 month, and 1196 in 1 year
    Nabet, Julien made 70 review comments in 1 month, and 950 in 1 year
    Ilmari Lauhakangas made 68 review comments in 1 month, and 590 in 1 year
    Grandin, Noel made 66 review comments in 1 month, and 730 in 1 year
  - Patches automatically abandoned:
    tdf#38844 - Reduce XOR rendering (search RasterOp::Xor) ( Devansh Varshney )
    - https://gerrit.libreoffice.org/#/c/164949
    [WIP] tdf#50050: Sync charStyle of LE with LS ( Mohit Marathe )
    - https://gerrit.libreoffice.org/#/c/166569
    Disable tests that fail with scaling other than 1x ( Hossein )
    - https://gerrit.libreoffice.org/#/c/168045
    tdf#152299 ( Nima Mahanloo )
    - https://gerrit.libreoffice.org/#/c/168077
    sw: use SAL_RET_MAYBENULL in GetTextNode() ( Xisco Fauli )
    - https://gerrit.libreoffice.org/#/c/168108
    sw: use SAL_RET_MAYBENULL in GetView() ( Xisco Fauli )
    - https://gerrit.libreoffice.org/#/c/168111
    vcl: use SAL_RET_MAYBENULL in ImplGetFrameWindow(), GetFrameWeld()… ( Xisco Fauli )
    - https://gerrit.libreoffice.org/#/c/168117
    Remove now unused osl/diagnose.h from interfacecontainer.h ( Gabor Kelemen )
    - https://gerrit.libreoffice.org/#/c/168131
    sfx2: more SAL_RET_MAYBENULL in viewfrm.hxx ( Xisco Fauli )
    - https://gerrit.libreoffice.org/#/c/168140
    svx: warning C6011: Dereferencing NULL pointer ( Xisco Fauli )
    - https://gerrit.libreoffice.org/#/c/168143
    sw/qa: warning C6011: Dereferencing NULL pointer ( Xisco Fauli )
    - https://gerrit.libreoffice.org/#/c/168150
    sw: warning C6011: Dereferencing NULL pointer ( Xisco Fauli )
    - https://gerrit.libreoffice.org/#/c/168162
    sw: Use SAL_RET_MAYBENULL in GetContentIdx() ( Xisco Fauli )
    - https://gerrit.libreoffice.org/#/c/168265
  - big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
    Per99
GSoC (Ilmari)
- 26 August is the deadline for final code submissions in non-extended projects
LiboCon (Cloph)
- CfP is open: LibreOffice Conference 2024 :: pretalx
  - 2024-08-30 11:52 (UTC) is the deadline
- Planning to have a development workshop this year (Hossein)
  - in 2 days, shorter than last year
  - working on this, contacting persenters from last year
Commit Access
Developer Certification (Stephan/Miklos/László/Gabriel)
- resting since: 14 weeks (limit: 20 weeks)
Jenkins / CI update (Cloph)
gerrit_android_aarch64 jobs: 158 ok: 143 ko: 13 fail ratio: 8.23% mean_ok: 13 ( 23) median_ok: 10 ( 17)
gerrit_android_arm jobs: 159 ok: 152 ko: 6 fail ratio: 3.77% mean_ok: 13 ( 22) median_ok: 10 ( 15)
gerrit_android_x86 jobs: 158 ok: 143 ko: 13 fail ratio: 8.23% mean_ok: 14 ( 23) median_ok: 10 ( 15)
gerrit_android_x86_64 jobs: 159 ok: 152 ko: 6 fail ratio: 3.77% mean_ok: 12 ( 22) median_ok: 9 ( 14)
gerrit_linux_clang_dbgutil jobs: 325 ok: 242 ko: 74 fail ratio: 22.77% mean_ok: 54 ( 62) median_ok: 50 ( 56)
gerrit_linux_gcc_release jobs: 399 ok: 302 ko: 74 fail ratio: 18.55% mean_ok: 26 ( 35) median_ok: 20 ( 26)
gerrit_mac jobs: 330 ok: 283 ko: 36 fail ratio: 10.91% mean_ok: 54 ( 55) median_ok: 47 ( 48)
gerrit_windows jobs: 336 ok: 259 ko: 63 fail ratio: 18.75% mean_ok: 59 ( 62) median_ok: 57 ( 57)
gerrit_master_ml jobs: 434 ok: 213 ko: 183 fail ratio: 42.17% mean_ok: 100 (100) median_ok: 89 ( 89)
gerrit_master jobs: 74 ok: 36 ko: 34 fail ratio: 45.95% mean_ok: 70 ( 70) median_ok: 70 ( 70)
gerrit_master_seq jobs: 360 ok: 177 ko: 149 fail ratio: 41.39% mean_ok: 105 (105) median_ok: 96 ( 96)
- tests that failed more than twice in last seven days
  3 CppunitTest_sw_ooxmlexport13 gerrit_linux_gcc_release
  3 CppunitTest_sw_ooxmlexport15 gerrit_linux_gcc_release
  3 CppunitTest_sw_ooxmlexport21 gerrit_linux_gcc_release
  5 UITest_sw_navigator gerrit_linux_clang_dbgutil
  6 CppunitTest_sd_png_export_tests gerrit_windows
  6 UITest_impress_tests gerrit_linux_clang_dbgutil
  9 CppunitTest_sd_tiledrendering gerrit_linux_gcc_release
  24 aborted by jenkins job timeout gerrit_windows
- this week was OK (Cloph)
- 1 Windows builder hit a timeout problem
  - still an open issue to auto-detect this
- also a HW failure → longer build times
- new server: about to put that into the pool
  - expecting 4 builds on Windows in 1h
  - would make the Linux build the bottleneck
    - more tests there
    - easy to scale
Report builder as extension? (Ilmari)
- Development/Under-loved areas - The Document Foundation Wiki
- have a volunteer interested in this
- some Linux distros don’t include it at all
- propose: c++ extension to research the problem
  - couple of report libraries available
- any benefit?
  - currently an optional module
  - it used to be an extension (Michael S)
    - Oracle Report Builder | Apache OpenOffice Extensions
- having report designer built-in sounds useful, for example based on Writer (Hossein)
- good to get input from Lionel (Miklos)
  - also perhaps from Noel (Caolan)
    - Noel already commented in the wiki (Ilmari)
  - what distros dropped it?
    - ArchLinux (Ilmari)
    - big long chain of Java dependencies (Caolan)
- will continue researching (Ilmari)
What’s cooking (Miklos)
- A11y update (Michael W)
  - tdf#155447 Accessible IDs for spellcheck dialog: MR for Orca,
    discussion of potential approaches for reuse in other apps
  - tdf#35107 Hyperlink a11y
  - added a11y names for page background elements in Writer sidebar
  - Accerciser: implemented display of hyperlink infos
- RTL/CTL/CJK update (Jonathan)
  - tdf#162314: Hang while laying out bidi portions with underflow
    - 162314 – LibreOffice Writer hangs in a document with mixed RTL and LTR text in paragraphs
  - tdf#162358: Fallback for grapheme clusters split by start of run
    - 162358 – Font fallback for Fat7a diacritic fails in track changes, succeeds otherwise
  - tdf#36709: First line indent using Ch should change for font size
    - 36709 – For first line indent using Ch (Characters) as unit, the indent value should change when font-size changes
    - More generally: relative length unit support
    - Discussions ongoing
    - Current understanding:
      - Schema changes are needed, extension attribute for interim
  - keeping track of responsiveness of LO for different languages (Hossein)
    - currently testing this manually
    - would need perf regression testing suite (Jonathan)
    - https://perf.libreoffice.org/ is there (Miklos)
      - ${LODE_HOME}/bin/tb_slave_wrapper --branch=MASTER --os=Linux --real --perfsuite --distro-config=PerfSuite_Linux.conf --name=“Jenkins_Callgrind”
    - it uses callgrind, so should be consistent across hardware (Caolan)
    - trouble is nobody looks at the result, it requires time (Michael S)
    - 1 build is 16 hours (Cloph)
      - also have newer data at a different URL
        AI: switch the default to the new data (Cloph)
- drawinglayer system-dependent primitive renderer (SDPR) for cairo (Armin)
- tdf#61242 - Customization of comments background color (Heiko)
  - https://gerrit.libreoffice.org/c/core/+/171523
  - this was all hardcoded previously, now possible to customize it
QA update (Xisco)
- Missing Xisco
- unconfirmed is “1202 (+1202)”, is that correct? (Eyal)
  - perhaps fallout from the ruff changes (Ilmari)
- UNCONFIRMED: 1202 (+1202)
  - enhancements: 286 (+286)
  - needsUXEval: 4 (+4)
  - haveBackTrace: 9 (+9)
  - needsDevAdvice: 47 (+47)
  - documentation: 3 (+3)
  - android: 0 (+0)
  - iOS: 0 (+0)
  - Online: 9 (+9)
- Most pressing bugs:
  New:
  Old:
  Fixed:
- New high severity bugs of the week:
  - FILEOPEN XLSX “Author” information about notes is not read
    - 157851 – FILEOPEN XLSX "Author" information about notes is not read
    - not tagged as a regression
  - Range picker must not grab the focus
    - 162310 – Range picker must not grab the focus
    - not tagged as a regression
QA stats (Xisco)
- Missing Xisco
- Weekly Bug Summary
  +106 +0 (-115) overall)
  many thanks to the top bug squashers:
  QA Administrators 14
  Mike Kaganski 10
  fpy 9
  Stéphane Guillou (stragu) 8
  Michael Weghorn 7
  Olivier Hallot 7
  Heiko Tietze 5
  Telesto 5
  Björn Michaelsen 4
  m_a_riosv 4
- top 10 bugs reporters:
  Eyal Rozenberg 5
  Faisal 4
  Mike Kaganski 4
  Telesto 4
  Hossein 3
  Manu 3
  Olivier Hallot 3
  Regina Henschel 3
  Ahmed Hamed 2
  Heiko Tietze 2
- top 10 bugs fixers:
  Pierre F 9
  Kaganski, Mike 7
  Olivier Hallot 7
  Weghorn, Michael 5
  Michaelsen, Björn 4
  Kurt Nordback 3
  Vajna, Miklos 3
  Andreas Heinisch 2
  Caolán McNamara 2
  Grandin, Noel 2
- top 10 bugs confirmers:
  m.a.riosv 16
  Stéphane Guillou 7
  Heiko Tietze 6
  Ady 5
  Kaganski, Mike 4
  Raal 3
  Roman Kuznetsov 3
  Ahmed Hamed 2
  Nabet, Julien 2
  Olivier Hallot 2

Bisected bugs open: keyword ‘bisected’

more accurate - down to a single commit.
Bug List: LibreOffice Bi-bisected

done by:
   Stéphane Guillou       6
   Hossein                2
   Raal                   2
   Xisco Fauli            2
   Aron Budea             1
   Michaelsen, Björn      1
   gladys                 1
   Kaganski, Mike         1

Bibisected bugs open: keyword ‘bibisected’

Bug List: LibreOffice Bi-bisected

done by:
   Stéphane Guillou       6
   Raal                   2
   Xisco Fauli            2
   Aron Budea             1
   Michaelsen, Björn      1
   Dennis Roczek          1
   Nabet, Julien          1

all bugs tagged with ‘regression’
- 1234(+1234) bugs open of 13531(+13531) total 22(+0) high prio.
  
  done by:
  Stéphane Guillou 5
  Hossein 2
  Raal 2
  Xisco Fauli 2
  Ady 1
  Aron Budea 1
  Dennis Roczek 1
  m.a.riosv 1
  Robert Großkopf 1
~Component count net * high severity regressions
- Bug List
  Writer - 10(+0)
  Calc - 5(+0)
  Impress - 2(+0)
  LibreOffice - 2(+0)
  UI - 2(+0)
by OS:
All - 13(+0)
Linux - 6(+0)
Mac OS X - 0(+0)
Windows - 3(+0)
~Component count net * all regressions
- Bug List
  Writer: other - 412(+0)
  Calc - 237(+0)
  Impress - 127(+0)
  LibreOffice - 53(+0)
  Draw - 47(+0)
  Writer: docx filter - 47(+0)
  Crashes - 44(+0)
  Base - 39(+0)
  UI - 38(+0)
  Writer: perf - 35(+0)
  Borders - 34(+0)
  Writer: other filter - 31(+0)
  Printing and PDF export - 27(+0)
  Chart - 24(+0)
  RTL - 22(+0)
  filters and storage - 22(+0)
  BASIC - 20(+0)
  Writer: doc filter - 17(+0)
  graphics stack - 12(+0)
  Formula Editor - 10(+0)
  framework - 3(+0)
  Extensions - 2(+0)
  sdk - 2(+0)
  Linguistic - 1(+0)