ESC meeting minutes: 2024-08-01

  • Present:

    • Olivier, Cloph, Heiko, Hossein, Ilmari, Jonathan, Michael W, Michael S, Stephan, Caolan, Miklos
  • Completed Action Items:

  • Pending Action Items:

  • Release Engineering update (Cloph)

    • 24.8.0 rc3 in 1 week
      • rc2 is on the mirrors + local patch for the macOS binaries
    • 24.2.6 rc1 in 2 weeks
  • Documentation (Olivier)

    • Helpcontents2

      • Updates and fixes (Adolfo B, Pierre F, A Gelmini, ohallot))
      • Sidebar Help pages (D. Maddern)
      • VBA/Basic help pages (A. Romedenne)
      • Untangle contents tree (ohallot)
    • New Feature: Structured References ( tdf#162275 → tdf#162088)

    • Release notes: please illustrate (picture) your achievements!

    • Guides

      • Assembling GS 24.8
    • Bugzilla Documentation statistics
      252(252) bugs open

    • Updates:
      BZ changes 1 week 1 month 3 months 12 months
      created 17(12) 32(12) 92(3) 227(-1)
      commented 24(19) 62(22) 239(16) 859(3)
      resolved 4(3) 10(4) 52(-1) 132(-3)

    • top 10 contributors:
      Olivier Hallot made 28 changes in 1 month, and 287 changes in 1 year
      Pierre F made 17 changes in 1 month, and 48 changes in 1 year
      Ilmari Lauhakangas made 17 changes in 1 month, and 97 changes in 1 year
      Stéphane Guillou made 8 changes in 1 month, and 174 changes in 1 year
      Dione Maddern made 7 changes in 1 month, and 105 changes in 1 year
      Henschel, Regina made 7 changes in 1 month, and 15 changes in 1 year
      Heiko Tietze made 6 changes in 1 month, and 86 changes in 1 year
      UNKNOWN made 6 changes in 1 month, and 6 changes in 1 year
      Kaganski, Mike made 6 changes in 1 month, and 81 changes in 1 year
      Roman Kuznetsov made 5 changes in 1 month, and 10 changes in 1 year

  • UX Update (Heiko)

    • Bugzilla (topicUI) statistics
      235(235) (topicUI) bugs open, 29(29) (needsUXEval) needs to be evaluated by the UXteam
    • Updates:
      BZ changes 1 week 1 month 3 months 12 months
      added 5(2) 8(3) 9(0) 17(2)
      commented 53(8) 181(28) 461(18) 1774(16)
      removed 0(0) 0(0) 2(-2) 10(0)
      resolved 5(-6) 25(2) 77(-2) 283(-2)
    • top 10 contributors:
      Heiko Tietze made 76 changes in 1 month, and 959 changes in 1 year
      Stéphane Guillou made 47 changes in 1 month, and 622 changes in 1 year
      Eyal Rozenberg made 28 changes in 1 month, and 175 changes in 1 year
      Ilmari Lauhakangas made 26 changes in 1 month, and 149 changes in 1 year
      Vernon, Stuart Foote made 23 changes in 1 month, and 325 changes in 1 year
      Rafael Lima made 16 changes in 1 month, and 74 changes in 1 year
      Henschel, Regina made 13 changes in 1 month, and 49 changes in 1 year
      Justin Luth made 12 changes in 1 month, and 78 changes in 1 year
      Ady made 11 changes in 1 month, and 115 changes in 1 year
      Roman Kuznetsov made 9 changes in 1 month, and 32 changes in 1 year
    • [Bug 162185] [Request] Add some commands to the Basic-IDE context menu
      (Right-Click)
    • [Bug 162188] Display table’s outlines in Impress and Draw like in Writer
    • [Bug 162200] “Text direction” in page style dialog, with both Asian and RTL-CTL,
      is inconsistent and confusing
    • [Bug 162201] Table > Properties > Text Flow > Text Orientation is misphrased
      and confusing
  • Crash Testing (Caolan)

    • 54(+34) import failure, 19(+3) export failures
    • ??? coverity issues
    • Google / ossfuzz: ?? fuzzers active now
  • Crash Reporting (Xisco)

    • 24.2.2.2 18855(+493)
    • 24.2.3.2 16315(+608)
    • 24.2.4.2 11414(+1134)
    • 24.2.5.2 3381(+1594)
  • Mentoring (Hossein)

    • Finalized and published a blog posts on dev blog (Hossein)
      Fuzz testing to maintain LibreOffice code quality
      Fuzz testing to maintain LibreOffice code quality - LibreOffice Development Blog
    • Two EasyHacks around ODF 1.4 support from Regina
      • tdf#161948 - natural sort of data range is not written to file although a suitable attribute exists
        161948 – natural sort of data range is not written to file although a suitable attribute exists
      • tdf#131862 - ODF: Remove deprecated attribute table:cell-range-address from element chart:plot-area
        131862 – ODF: Remove deprecated attribute table:cell-range-address from element <chart:plot-area>
        committer… 1 week 1 month 3 months 12 months
        open 86(-14) 177(-19) 178(-19) 178(-19)
        reviews 448(-28) 1492(-184) 3784(22) 13160(-6)
        merged 283(-2) 1295(-18) 3686(3) 12989(64)
        abandoned 27(10) 87(6) 218(19) 753(18)
        own commits 202(-1) 910(65) 2507(-28) 9479(60)
        review commits 60(23) 206(-38) 741(14) 3073(18)
        contributor… 1 week 1 month 3 months 12 months
        open 42(-17) 102(0) 103(-1) 103(-1)
        reviews 926(-12) 3320(-88) 8362(48) 30074(132)
        merged 24(8) 74(-47) 269(5) 1516(-5)
        abandoned 21(15) 42(17) 86(9) 741(19)
        own commits 26(12) 88(-44) 321(3) 1218(11)
        review commits 0(0) 0(0) 0(0) 0(0)
      • easyHack statistics:
        needsDevEval 9(9) needsUXEval 1(1) cleanup_comments 331(331)
        total 414(414) assigned 22(22) open 356(356)
      • top 10 contributors:
        Pierre F made 12 patches in 1 month, and 40 patches in 1 year
        made 8 patches in 1 month, and 17 patches in 1 year
        Bogdan B made 7 patches in 1 month, and 88 patches in 1 year
        Armin Le Grand (allotropia) made 5 patches in 1 month, and 82 patches in 1 year
        Weblate made 4 patches in 1 month, and 36 patches in 1 year
        Dione Maddern made 4 patches in 1 month, and 69 patches in 1 year
        Adam Seskunas made 3 patches in 1 month, and 17 patches in 1 year
        Srebotnjak, Martin made 2 patches in 1 month, and 21 patches in 1 year
        Vladislav Tarakanov made 2 patches in 1 month, and 3 patches in 1 year
        Kira Tubo made 2 patches in 1 month, and 19 patches in 1 year
      • top 10 reviewers:
        Thorsten Behrens made 156 review comments in 1 month, and 724 in 1 year
        Adolfo Jayme Barrientos made 120 review comments in 1 month, and 690 in 1 year
        Christian Lohmaier made 108 review comments in 1 month, and 504 in 1 year
        Caolán McNamara made 104 review comments in 1 month, and 1442 in 1 year
        Xisco Fauli made 98 review comments in 1 month, and 778 in 1 year
        Nabet, Julien made 72 review comments in 1 month, and 948 in 1 year
        Ilmari Lauhakangas made 72 review comments in 1 month, and 592 in 1 year
        Grandin, Noel made 64 review comments in 1 month, and 734 in 1 year
        Michael Stahl made 62 review comments in 1 month, and 844 in 1 year
        Weghorn, Michael made 60 review comments in 1 month, and 386 in 1 year
      • Patches automatically abandoned:
        tdf#114441 sal_uLong to better integer type ( Rafał Dobrakowski )
        - https://gerrit.libreoffice.org/#/c/165681
        [WIP] tdf#50050: Sync charStyle of LE with LS ( Mohit Marathe )
        - https://gerrit.libreoffice.org/#/c/166569
        tdf#144902 MSI: Adds .msu files for KB3063858 for Windows 7 SP1 ( Jakub Kościelak )
        - https://gerrit.libreoffice.org/#/c/166637
        tdf#152299 ( Nima Mahanloo )
        - https://gerrit.libreoffice.org/#/c/168077
        sw: use SAL_RET_MAYBENULL in GetTextNode() ( Xisco Fauli )
        - https://gerrit.libreoffice.org/#/c/168108
        sw: use SAL_RET_MAYBENULL in GetView() ( Xisco Fauli )
        - https://gerrit.libreoffice.org/#/c/168111
        vcl: use SAL_RET_MAYBENULL in ImplGetFrameWindow(), GetFrameWeld()… ( Xisco Fauli )
        - https://gerrit.libreoffice.org/#/c/168117
        Remove now unused osl/diagnose.h from interfacecontainer.h ( Gabor Kelemen )
        - https://gerrit.libreoffice.org/#/c/168131
        sfx2: more SAL_RET_MAYBENULL in viewfrm.hxx ( Xisco Fauli )
        - https://gerrit.libreoffice.org/#/c/168140
        svx: warning C6011: Dereferencing NULL pointer ( Xisco Fauli )
        - https://gerrit.libreoffice.org/#/c/168143
        sw/qa: warning C6011: Dereferencing NULL pointer ( Xisco Fauli )
        - https://gerrit.libreoffice.org/#/c/168150
        sw: warning C6011: Dereferencing NULL pointer ( Xisco Fauli )
        - https://gerrit.libreoffice.org/#/c/168162
      • big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
        Ashok
  • GSoC (Ilmari)

    • reminder: if contributor would like to extend project time, do so ASAP
  • LiboCon (Cloph)

  • Commit Access

  • Developer Certification (Stephan/Miklos/László/Gabriel)

    • resting since: 13 weeks (limit: 20 weeks)
  • Jenkins / CI update (Cloph)
    gerrit_android_aarch64 jobs: 183 ok: 175 ko: 2 fail ratio: 1.09% mean_ok: 13 ( 19) median_ok: 10 ( 14)
    gerrit_android_arm jobs: 182 ok: 159 ko: 19 fail ratio: 10.44% mean_ok: 12 ( 16) median_ok: 9 ( 14)
    gerrit_android_x86 jobs: 181 ok: 166 ko: 8 fail ratio: 4.42% mean_ok: 12 ( 18) median_ok: 9 ( 12)
    gerrit_android_x86_64 jobs: 178 ok: 164 ko: 10 fail ratio: 5.62% mean_ok: 14 ( 19) median_ok: 10 ( 14)
    gerrit_linux_clang_dbgutil jobs: 364 ok: 280 ko: 65 fail ratio: 17.86% mean_ok: 53 ( 57) median_ok: 49 ( 51)
    gerrit_linux_gcc_release jobs: 454 ok: 331 ko: 78 fail ratio: 17.18% mean_ok: 28 ( 32) median_ok: 20 ( 23)
    gerrit_mac jobs: 355 ok: 307 ko: 23 fail ratio: 6.48% mean_ok: 58 ( 59) median_ok: 48 ( 48)
    gerrit_windows jobs: 373 ok: 277 ko: 75 fail ratio: 20.11% mean_ok: 68 ( 71) median_ok: 57 ( 57)
    gerrit_master_ml jobs: 488 ok: 234 ko: 187 fail ratio: 38.32% mean_ok: 104 (104) median_ok: 94 ( 94)
    gerrit_master jobs: 57 ok: 25 ko: 20 fail ratio: 35.09% mean_ok: 82 ( 82) median_ok: 74 ( 74)
    gerrit_master_seq jobs: 431 ok: 210 ko: 166 fail ratio: 38.52% mean_ok: 106 (106) median_ok: 94 ( 94)

    • tests that failed more than twice in last seven days
      3 CppunitTest_sd_tiledrendering gerrit_linux_gcc_release
      3 CppunitTest_sw_ww8export4 gerrit_linux_gcc_release
      3 CppunitTest_vcl_pdfexport2 gerrit_linux_gcc_release
      3 JunitTest_svx_unoapi gerrit_linux_clang_dbgutil
      4 CppunitTest_sd_import_tests2 gerrit_linux_gcc_release
      4 UITest_impress_tests gerrit_linux_clang_dbgutil
      4 UITest_sw_ui_frmdlg gerrit_linux_clang_dbgutil
      6 CppunitTest_sd_import_tests gerrit_linux_gcc_release
      7 CppunitTest_sw_ooxmlexport7 gerrit_linux_gcc_release
      9 CppunitTest_sw_a11y gerrit_windows
      33 aborted by jenkins job timeout gerrit_windows
    • this week: had one Windows bot turning into failed state (not recovering, not auto-disabling), trying to figure out how to detect this (Cloph)
      • one of the linux builders failed the Android builds
      • if you notice something like this, please report that on #tdf-infra
  • Python linting in CI at some point (Ilmari)

    • Notes on remaining linter complaints: User:Beluga - The Document Foundation Wiki
    • also contacted Laszlo about librelogo / lightproof
    • experimented with pyflakes, got suggestion to try flake8 (Hossein)
      • good to check the code with other tools as well
      • flake8 itself is a wrapper around multiple tools (–help lists installed plugins)
      • integrate into CI?
        • no strong opinion on which one to use (Ilmari)
        • does find syntax errors, but not interested in style issues
        • also finds deprecated API usages
    • if we ever enable this in CI, then good to have a configure switch for this to reproduce locally (Stephan)
      • or just make ‘make check’ include the checks as well
    • related issues (Hossein)
      • bundled python is falling behind
      • pyuno needs fixing for latest (external) python
      • checked deprecated API usages, the code seems to be in a good shape (Ilmari)
  • What’s cooking (Miklos)

    • A11y update (Michael W)
      • tdf#161765, tdf#115688: improvements to animation settings (Per99)
      • tdf#155447: Reporting of accessible ID to provide stable identifiers for
        spell check dialog, Orca upstream changes
      • make gtk3 a11y AT-SPI tests work on distros using dbus-broker by default
      • Accerciser improvements and related Qt and KWin changes
    • RTL/CTL/CJK update (Jonathan)
    • drawinglayer system-dependent primitive renderer (SDPR) for cairo (Armin)
    • tdf#162072 font fallback improvements (Miklos)
      • if a font is missing, we now take sans vs serif into account while finding a fallback on Linux
    • read-only srcdir should work again now, fixed the gpg uitest (Michael S)
  • QA update (Xisco)

    • UNCONFIRMED: 1191 (-2)

      • enhancements: 287 (+6)
      • needsUXEval: 7 (+2)
      • haveBackTrace: 9 (+0)
      • needsDevAdvice: 47 (+0)
      • documentation: 4 (-1)
      • android: 0 (+0)
      • iOS: 0 (+0)
      • Online: 9 (+0)
    • Most pressing bugs:
      New:
      Old:
      Fixed:

    • New high severity bugs of the week:

  • QA stats (Xisco)

    • Weekly Bug Summary
      +112 -10 (-110) overall)
      many thanks to the top bug squashers:
      Stéphane Guillou (stragu) 12
      Mike Kaganski 10
      QA Administrators 9
      Jonathan Clark 8
      Buovjaga 7
      m_a_riosv 6
      Justin L 5
      Telesto 5
      Gabor Kelemen (allotropia) 4
      Eike Rathke 3

    • top 10 bugs reporters:
      Faisal 6
      Stéphane Guillou (stragu) 5
      Telesto 4
      peter josvai 4
      Eyal Rozenberg 3
      Manu 3
      Olivier Hallot 3
      Regina Henschel 3
      Xisco Faulí 3
      nobu 3

    • top 10 bugs fixers:
      Justin Luth 5
      Kaganski, Mike 5
      Jonathan Clark 4
      Kelemen, Gabor 3
      Kurt Nordback 3
      Rathke, Eike 3
      Balazs Varga 2
      Jim Raykowski 2
      Nabet, Julien 2
      Olivier Hallot 2

    • top 10 bugs confirmers:
      m.a.riosv 18
      Stéphane Guillou 14
      Ilmari Lauhakangas 8
      Xisco Fauli 5
      Heiko Tietze 4
      Kaganski, Mike 4
      Ady 3
      Nabet, Julien 3
      Patrick Luby 3
      Raal 3

  • Bisected bugs open: keyword ‘bisected’

    done by:
       Xisco Fauli            5
       Raal                   3
       Stéphane Guillou       3
       Ilmari Lauhakangas     2
       Aron Budea             1
       Michaelsen, Björn      1
       Hossein                1
       Weghorn, Michael       1
       Timur Gadzo            1
    
  • Bibisected bugs open: keyword ‘bibisected’

    done by:
       Xisco Fauli            5
       Raal                   3
       Stéphane Guillou       3
       Aron Budea             1
       Michaelsen, Björn      1
       Dennis Roczek          1
       Ilmari Lauhakangas     1
       Weghorn, Michael       1
       matt.w.franzen         1
       Timur Gadzo            1
    
  • all bugs tagged with ‘regression’

    • 1244(+4) bugs open of 13523(+24) total 26(+1) high prio.

      done by:
      Stéphane Guillou 4
      Xisco Fauli 4
      Raal 3
      Ilmari Lauhakangas 2
      Kaganski, Mike 2
      Aron Budea 1
      Dennis Roczek 1
      Hossein 1
      Weghorn, Michael 1
      m.a.riosv 1

  • ~Component count net * high severity regressions

    • Bug List
      Writer - 14(+1)
      Calc - 5(+1)
      Impress - 2(+0)
      LibreOffice - 2(+0)
      UI - 2(+0)
      Base - 0(-1)

    by OS:
    All - 17(+1)
    Linux - 6(+1)
    Mac OS X - 0(+0)
    Windows - 3(-1)

  • ~Component count net * all regressions

    • Bug List
      Writer: other - 422(+3)
      Calc - 239(+1)
      Impress - 126(+2)
      LibreOffice - 52(+0)
      Crashes - 48(+2)
      Draw - 47(-1)
      Writer: docx filter - 47(+0)
      Base - 40(-1)
      UI - 38(+0)
      Writer: perf - 35(+0)
      Borders - 34(+0)
      Writer: other filter - 31(-1)
      Printing and PDF export - 27(+0)
      Chart - 24(+0)
      RTL - 22(-1)
      filters and storage - 22(+1)
      BASIC - 20(+0)
      Writer: doc filter - 17(+0)
      graphics stack - 12(+0)
      Formula Editor - 10(+0)
      framework - 3(+0)
      Extensions - 2(+0)
      sdk - 2(+0)
      Linguistic - 1(+0)