ESC meeting minutes: 2024-06-13

projects
#1

  • Present:

    • Cloph, Michael W, Olivier, Caolan, Heiko, Hossein, Xisco, Ilmari, Jonathan, Michael S, Eike, Stéphane, Regina, Stephan, Miklos

  • Completed Action Items:

    • Commit access: Heiko to send the welcome mail to Bayram
    • Commit access: Cloph to enable the commit bit for Bayram

  • Pending Action Items:

  • Release Engineering update (Cloph)

    • 24.2: 24.2.5 RC1 in 2 weeks
    • 24.8:
      • beta1 was tagged a bit later, python 3.8 was near EOL
        • now shipping 3.9
        • might break compat with Windows 7
        • depending on test results, may need to raise the Windows baseline
        • Windows 7 is deprecated already in the release notes
        • should update release notes when this is known (Ilmari)
        • ReleaseNotes/24.8 - The Document Foundation Wiki
        • is beta1 built already? (Xisco)
          • yes, the trick is to find a Windows 7 system (Cloph)
        • can announce it tomorrow in the qa blog (Xisco)
          • call for testing
          • explicitly mention we look for Windows 7 testers
        • in sync with the idea that we support OSes as long as supported by their vendors, only best effort after that (Cloph)
        • Minimum Python version policy (Ilmari)
          • Nothing is mentioned in any readme or system requirements page at the moment
          • no problem with the python ide integration anymore (Cloph)
            • given we have python 3.9 by now
          • would be ideal to update python further on master
            • Python release cycle (Hossein)
              Status of Python versions
            • like the idea, to update to 3.12 (Hossein)
            • around this time is a good time (Xisco)
          • what if removing old version checks? (Ilmari)
            • that’s mostly for enterprise distros that build rpm packages (Michael S)
            • need to ask Eike and the SUSE maintainer
              • they usually build new LO against old system baseline
              • Fedora 41 is heading for 3.13 at the moment
            • would be ideal to still lock down what is the needed baseline (Ilmari)
            • once known, good to document it in README.md (Miklos)
            • and just mention LTS distros are the intended baseline, OK to clean up the rest (Cloph)
      • beta2 in 1 week, if needed
        • no plans so far (Cloph)
      • string / UI freeze in 2 weeks
      • late features?
        • late addition to the notes page in Impress in the works (Thorsten)

  • Documentation (Olivier)

    • Helpcontents2

      • Updates and fixes (stragu, sberg)
      • improvements in contents (erack, A. Romedene)
      • New pages: LET function (ohallot)

    • Guides

      • work in progress.

    • Question from community

      • Do we have (visible) documentation for oovbaapi/ (VBA api)?
        • should it be published?
        • list of what works and what doens’nt
        • (purpose: advise to public, get people to contribute).
        • know that the full VBA API is documented on the Microsoft side (Olivier)
        • Noel had some concerns if this is published too widely, it makes later fixes / improvements harder (Miklos)
        • probably it’s not intentional that this is excluded in odk/, though (Miklos)
        • hard to document StarBasic vs .NET Basic differences (Hossein)

    • Bugzilla Documentation statistics
      250(250) bugs open

    • Updates:
      BZ changes 1 week 1 month 3 months 12 months
      created 7(-3) 48(-2) 103(-10) 233(2)
      commented 12(-10) 100(0) 233(-31) 898(7)
      resolved 2(-1) 26(-1) 62(-6) 134(1)

    • top 10 contributors:
      Dione Maddern made 67 changes in 1 month, and 98 changes in 1 year
      Olivier Hallot made 38 changes in 1 month, and 264 changes in 1 year
      Stéphane Guillou made 20 changes in 1 month, and 253 changes in 1 year
      Vernon, Stuart Foote made 16 changes in 1 month, and 121 changes in 1 year
      Heiko Tietze made 14 changes in 1 month, and 84 changes in 1 year
      Ilmari Lauhakangas made 12 changes in 1 month, and 81 changes in 1 year
      Dieter made 10 changes in 1 month, and 18 changes in 1 year
      Óvári made 10 changes in 1 month, and 13 changes in 1 year
      Timur made 6 changes in 1 month, and 8 changes in 1 year
      Bogdan B made 4 changes in 1 month, and 13 changes in 1 year

  • UX Update (Heiko)

    • Bugzilla (topicUI) statistics
      239(239) (topicUI) bugs open, 38(38) (needsUXEval) needs to be evaluated by the UXteam
    • Updates:
      BZ changes 1 week 1 month 3 months 12 months
      added 3(-2) 11(0) 16(0) 23(-1)
      commented 41(-10) 194(-16) 514(-32) 1731(2)
      removed 0(0) 0(0) 5(0) 10(0)
      resolved 3(-8) 28(-5) 79(-1) 289(1)
    • top 10 contributors:
      Heiko Tietze made 115 changes in 1 month, and 957 changes in 1 year
      Stéphane Guillou made 99 changes in 1 month, and 653 changes in 1 year
      Eyal Rozenberg made 43 changes in 1 month, and 162 changes in 1 year
      Vernon, Stuart Foote made 19 changes in 1 month, and 313 changes in 1 year
      Telesto made 13 changes in 1 month, and 34 changes in 1 year
      Dieter made 11 changes in 1 month, and 118 changes in 1 year
      Ilmari Lauhakangas made 9 changes in 1 month, and 130 changes in 1 year
      Henschel, Regina made 9 changes in 1 month, and 41 changes in 1 year
      Rafael Lima made 6 changes in 1 month, and 57 changes in 1 year
      Ady made 5 changes in 1 month, and 114 changes in 1 year
    • [Bug 161523] Ability to turn off support for Western languages
    • [Bug 161258] Default to enabling full RTL-CTL, CJK support (as in
      Tools>Options>Languages>General) when can’t confidently determine otherwise
    • [Bug 161516] Label “Compare Document…” menu (and toolbars menu items) action
      more clearly, to indicate comparison direction
    • [Bug 161515] Ability to cut image object in two pieces along a line
    • [Bug 161502] Calc: change Structure label of Function Wizard dialog
    • [Bug 161134] Pasting URLs and email addresses with “Values Only” preset from the
      Paste Special dialog will format values as hyperlinks

  • Vertical tabpages state (Samuel/Thorsten)

    • if going down this route, all the dialogs need changing (Heiko)
      • even with gtk3 the text gets abbreviated, which is terrible
      • happy to adjust .ui files later, but the core work needs to happen first
    • in short: not against improvements, but needs to be consistent (Heiko)
      • it’s not just a simple flag, more work is needed here, which is not yet happening
    • we had the vertical one in the past for a short period, then went back to double decker (Caolan)
      • And for the gtk double-decker case we automatically detect that we have too many tabs to fit in a normal row and do a switch to double-decker, maybe something similar is an option for vertical (Caolan)
      • maybe do this incrementally: default to horizontal double-checker, but do use a vertical tabs with an opt-in flag till we’re done
    • the current state is not nice, gen / X11 looks bad (Heiko)
      • having a lot of trouble at the moment
    • maybe a safe move would be to revert on 24-8 and keep working on master (Xisco)
      • perhaps prepare the revert and discuss on gerrit

  • Crash Testing (Caolan)

  • Crash Reporting (Xisco)

    • 7.6.6.3 7994(+514)
    • 7.6.7.2 2950(+1054)
    • 24.2.0.3 20242(+532)
    • 24.2.1.2 16928(+523)
    • 24.2.2.2 14680(+847)
    • 24.2.3.2 9801(+2091)
    • 24.2.4.2 501(+0)
    • Fixed in 24.2.4.2:

  • Mentoring (Hossein)

    • New EasyHack
      “View > Field Names” can trigger confusing mode, implement warning
      159444 – "View > Field Names" can trigger confusing mode, implement warning
    • Many abandoned patches, reviewed those from non-commiters
      committer… 1 week 1 month 3 months 12 months
      open 99(46) 189(19) 191(18) 191(18)
      reviews 396(70) 1222(-76) 3262(-50) 12538(28)
      merged 212(-17) 997(-154) 3134(-42) 12657(-3)
      abandoned 35(17) 70(13) 178(21) 688(20)
      own commits 148(-24) 732(-98) 2274(-22) 9278(2)
      review commits 40(-7) 225(-6) 721(-40) 2995(-11)
      contributor… 1 week 1 month 3 months 12 months
      open 37(4) 87(-11) 87(-11) 87(-11)
      reviews 744(110) 2650(-252) 7268(-92) 29450(-12)
      merged 9(-5) 66(-10) 295(-37) 1540(-23)
      abandoned 15(12) 33(10) 108(12) 717(5)
      own commits 13(-8) 90(-8) 342(-37) 1134(-6)
      review commits 0(0) 0(0) 0(0) 0(0)

      • easyHack statistics:
        needsDevEval 9(9) needsUXEval 1(1) cleanup_comments 329(329)
        total 412(412) assigned 29(29) open 349(349)

      • top 10 contributors:
        Dione Maddern made 27 patches in 1 month, and 63 patches in 1 year
        Weblate made 7 patches in 1 month, and 30 patches in 1 year
        LeSasse made 4 patches in 1 month, and 23 patches in 1 year
        Adam Seskunas made 3 patches in 1 month, and 14 patches in 1 year
        Srebotnjak, Martin made 2 patches in 1 month, and 17 patches in 1 year
        Marco Pinto made 2 patches in 1 month, and 6 patches in 1 year
        Bogdan B made 2 patches in 1 month, and 19 patches in 1 year
        Stéphane Guillou made 2 patches in 1 month, and 60 patches in 1 year
        Hubert Figuière made 2 patches in 1 month, and 9 patches in 1 year
        Amanda Quaresma made 2 patches in 1 month, and 4 patches in 1 year

      • top 10 reviewers:
        Caolán McNamara made 138 review comments in 1 month, and 1550 in 1 year
        Vajna, Miklos made 98 review comments in 1 month, and 1116 in 1 year
        Ilmari Lauhakangas made 80 review comments in 1 month, and 562 in 1 year
        Adolfo Jayme Barrientos made 70 review comments in 1 month, and 556 in 1 year
        Thorsten Behrens made 70 review comments in 1 month, and 632 in 1 year
        Michael Stahl made 66 review comments in 1 month, and 890 in 1 year
        Christian Lohmaier made 58 review comments in 1 month, and 388 in 1 year
        Hossein made 58 review comments in 1 month, and 308 in 1 year
        Heiko Tietze made 56 review comments in 1 month, and 258 in 1 year
        Grandin, Noel made 54 review comments in 1 month, and 708 in 1 year

      • Patches automatically abandoned: (Submissions from non-commiters are reviewed below, restored in case still useful)
        WIP try preserving current recipient names for gpg encryption ( Thorsten Behrens )
        - https://gerrit.libreoffice.org/#/c/117874
        WIP Provide gpg co-encryption for shared cloud storage docs ( Thorsten Behrens )
        - https://gerrit.libreoffice.org/#/c/117875
        tdf#148183 Fix dragging Uno controls in the Dialog editor ( Rafael Lima )
        - https://gerrit.libreoffice.org/#/c/163757
        NotoSansArabic: upgrade to v2.012 ( Xisco Fauli )
        - https://gerrit.libreoffice.org/#/c/163822
        sc: Imporve currency pop-up - single click select, more button ( Tomaž Vajngerl )
        - https://gerrit.libreoffice.org/#/c/163938
        sc: combine currency name and table index into CurrencyEntry ( Tomaž Vajngerl )
        - https://gerrit.libreoffice.org/#/c/163939
        sc: rework the currency pop-up entry names ( Tomaž Vajngerl )
        - https://gerrit.libreoffice.org/#/c/163940
        sc: convert SvxNumberFormatCategory to enum class ( Tomaž Vajngerl )
        - https://gerrit.libreoffice.org/#/c/163941
        Get at least some information out of coredumpctl ( Noel Grandin )
        - https://gerrit.libreoffice.org/#/c/163945
        tdf#158510 Launch GStreamer from a presentation dir path in a slideshow ( Vladislav Tarakanov )
        - https://gerrit.libreoffice.org/#/c/164023
        sc: filter legacy currencies out of currency pop-up ( Tomaž Vajngerl )
        - https://gerrit.libreoffice.org/#/c/164038
        tdf#48140: Replace CellRangeAddress with ScRange. ( Seturaj Matroja )
        → OK, no reaction for the review comment about the changes
        - https://gerrit.libreoffice.org/#/c/164229
        tdf#49602 : Remove deprecated OSL Profile functionality ( Seturaj Matroja )
        → OK, got -1 in review and no reaction to the review comment
        - https://gerrit.libreoffice.org/#/c/164323
        wip: toolbar tdf#159645 click/focus woes ( Caolán McNamara )
        - https://gerrit.libreoffice.org/#/c/164352
        tdf#45904 : Remove Old SwXChapterNumbering Java Test ( Seturaj Matroja )
        → Restored, no response to the review comment, removal of the test ported from Java to C++, needs better commit message.
        - https://gerrit.libreoffice.org/#/c/164406
        tdf#45904 : Remove Old SwXHeadFootText Java Test ( Seturaj Matroja )
        → Restored, no response to the review comment, removal of the test ported from Java to C++, needs better commit message.
        - https://gerrit.libreoffice.org/#/c/164437
        tdf#45904: Move _XTextSection Java test to C++ ( Seturaj Matroja )
        → Restored, no response to the review comment
        - https://gerrit.libreoffice.org/#/c/164641
        tdf#114441 Change sal_uLong to sal_uInt64 ( Teodora Balaj )
        → OK, one line change, no response to review comment
        - https://gerrit.libreoffice.org/#/c/164642
        Remove break after return ( Andrea Gelmini )
        → Restored, no reviewers were added
        - https://gerrit.libreoffice.org/#/c/164729
        SdNavigator: Improve the context menu ( Jim Raykowski )
        - https://gerrit.libreoffice.org/#/c/164750
        loplugins:dllprivate also check for SAL_DLLPUBLIC_RTTI ( Noel Grandin )
        - https://gerrit.libreoffice.org/#/c/164762
        tdf#111675: Make IFS & SWITCH short-cut evaluation ( Ahmed Hamed )
        → Not yet finished, marked as WIP
        - https://gerrit.libreoffice.org/#/c/164890
        ONLINE: Set automatic font color according to background color ( Gülşah Köse )
        - https://gerrit.libreoffice.org/#/c/165017
        tdf#120026 sw unit test ( Kira Tubo )

          -> Xisco was helping here?

  - https://gerrit.libreoffice.org/#/c/165046

        Use pragma once instead of include guards ( Yahia Alkawas )

          -> OK, trivial hack and no reaction to review comment

  - https://gerrit.libreoffice.org/#/c/165203

        tdf#143148 Replace include guards with pragma once ( Aaron Bourdeaux )

          -> OK, trivial hack

  - https://gerrit.libreoffice.org/#/c/165355

        Remove break after return ( Andrea Gelmini )
        → Restored, no reviewers were added
        - https://gerrit.libreoffice.org/#/c/165707
        tdf#147132 Flatten Basic function implementations ( Christopher Loi )

          -> OK, trivial hack and no reaction to review comment

  - https://gerrit.libreoffice.org/#/c/165897

        tdf#147906 Use hypot function for Pythagorean addition ( Christopher Loi )
        → OK, the change was not suitable
        - https://gerrit.libreoffice.org/#/c/165901

  • GSoC (Ilmari)

    • Midterm evaluations deadline 12 July
    • .NET and test project progress nicely
      • .NET: basic support / gbuild bits are in
      • if CI support is needed, then multi-platform lode bits are needed (Cloph)
        • i.e. aarch64 Windows
        • good to use native dependencies, not emulation / cross-compile

  • Commit Access

  • Developer Certification (Stephan/Miklos/László/Gabriel)

    • resting since: 8 weeks (limit: 20 weeks)

  • Jenkins / CI update (Cloph)
    gerrit_android_aarch64 jobs: 153 ok: 147 ko: 3 fail ratio: 1.96% mean_ok: 10 ( 16) median_ok: 6 ( 10)
    gerrit_android_arm jobs: 154 ok: 149 ko: 5 fail ratio: 3.25% mean_ok: 9 ( 15) median_ok: 7 ( 10)
    gerrit_android_x86 jobs: 153 ok: 147 ko: 3 fail ratio: 1.96% mean_ok: 10 ( 15) median_ok: 7 ( 10)
    gerrit_android_x86_64 jobs: 154 ok: 149 ko: 5 fail ratio: 3.25% mean_ok: 9 ( 15) median_ok: 6 ( 9)
    gerrit_linux_clang_dbgutil jobs: 306 ok: 237 ko: 59 fail ratio: 19.28% mean_ok: 43 ( 48) median_ok: 42 ( 46)
    gerrit_linux_gcc_release jobs: 384 ok: 295 ko: 70 fail ratio: 18.23% mean_ok: 18 ( 22) median_ok: 15 ( 17)
    gerrit_mac jobs: 343 ok: 257 ko: 70 fail ratio: 20.41% mean_ok: 55 ( 61) median_ok: 51 ( 53)
    gerrit_windows jobs: 303 ok: 240 ko: 45 fail ratio: 14.85% mean_ok: 68 ( 77) median_ok: 59 ( 59)
    gerrit_master_ml jobs: 381 ok: 200 ko: 146 fail ratio: 38.32% mean_ok: 103 (103) median_ok: 89 ( 89)
    gerrit_master jobs: 51 ok: 27 ko: 21 fail ratio: 41.18% mean_ok: 98 ( 98) median_ok: 72 ( 72)
    gerrit_master_seq jobs: 329 ok: 173 ko: 124 fail ratio: 37.69% mean_ok: 103 (103) median_ok: 91 ( 91)

    • tests that failed more than twice in last seven days
      3 aborted by jenkins job timeout gerrit_windows
      3 Killed by the kill-wrapper gerrit_linux_clang_dbgutil
      3 CppunitTest_basic_macros gerrit_linux_gcc_release
      3 CppunitTest_sw_uiwriter5 gerrit_linux_gcc_release
      4 CppunitTest_sw_uiwriter gerrit_linux_gcc_release
      5 CppunitTest_sw_a11y gerrit_windows
    • the Windows side, it was a good week (Cloph)
    • Intel macOS 12 machines again started to crash in clang
      • 2 builders short now, due to this
      • had previous workarounds, but master again fails
      • how much effort to put into working around old compiler bugs?
    • how does this intersect with release building? (Miklos)
      • app store is always cross-compile from arm (Cloph)
      • regular release: Xisco always cross-compiles, Cloph not
      • also doesn’t affect the runtime requirements
    • only affects developers on old HW, which is probably not a huge problem
      • but then these builders can only build branches, not master anymore
    • can document this in the README.md for the baseline (Cloph)

  • What’s cooking (Miklos)

    + std::unordered_map for SfxItemSet (Armin)

  • invitation list for LibOCon (Michael W)

    • sent link to formal ESC members by email
    • deadline for entering names was today before ESC call
    • have enough suggestions, thanks (Michael W)

  • QA update (Xisco)

    • UNCONFIRMED: 1167 (+6)

      • enhancements: 272 (+2)
      • needsUXEval: 10 (+0)
      • haveBackTrace: 10 (+0)
      • needsDevAdvice: 46 (+1)
      • documentation: 5 (+1)
      • android: 0 (+0)
      • iOS: 0 (+0)
      • Online: 9 (+0)

    • Most pressing bugs:
      New:

    None

  • QA stats (Stéphane)

    • Consolidated/reviewed bugs of interest:

    • Weekly Bug Summary
      +100 +11 (-115) overall)
      many thanks to the top bug squashers:
      Stéphane Guillou (stragu) 17
      QA Administrators 10
      Mike Kaganski 8
      Julien Nabet 7
      BogdanB 6
      Buovjaga 5
      Michael Stahl (allotropia) 5
      Heiko Tietze 4
      László Németh 4
      m_a_riosv 4

    • top 10 bugs reporters:
      Eyal Rozenberg 4
      Telesto 4
      Rafael Lima 3
      Regina Henschel 3
      David Huggins-Daines 2
      Gabor Kelemen (allotropia) 2
      Jürgen Kirsten 2
      Mike Kaganski 2
      Stéphane Guillou (stragu) 2
      Tuomas Hietala 2

    • top 10 bugs fixers:
      Kaganski, Mike 5
      Németh, László 4
      Balazs Varga 3
      Jonathan Clark 3
      Michael Stahl 3
      Nabet, Julien 3
      Caolán McNamara 2
      Justin Luth 2
      Nagy Tibor 2
      Vajna, Miklos 2

    • top 10 bugs confirmers:
      Stéphane Guillou 26
      Dieter 5
      Nabet, Julien 5
      m.a.riosv 5
      Vernon, Stuart Foote 4
      Heiko Tietze 3
      Kaganski, Mike 3
      Ady 2
      Balazs Varga 2
      Werner Tietz 2

  • Bisected bugs open: keyword ‘bisected’

    done by:
   Stéphane Guillou       3
   Kira Tubo              2
   Raal                   2
   Dennis Roczek          1
   Ilmari Lauhakangas     1
   Justin Luth            1

  • Bibisected bugs open: keyword ‘bibisected’

    done by:
   Stéphane Guillou       4
   Kira Tubo              2
   Raal                   2
   Ilmari Lauhakangas     1
   Justin Luth            1

  • all bugs tagged with ‘regression’

    • 1234(-10) bugs open of 13418(+13) total 24(+0) high prio.

      done by:
      Stéphane Guillou 5
      Ady 2
      Justin Luth 1
      m.a.riosv 1
      Robert Großkopf 1
      Telesto 1

  • ~Component count net * high severity regressions

    • Bug List
      Writer - 14(+0)
      Calc - 3(+0)
      Impress - 2(+0)
      LibreOffice - 2(+0)
      UI - 2(+0)

    by OS:
    All - 17(+0)
    Linux - 5(+0)
    Mac OS X - 0(+0)
    Windows - 2(+0)

  • ~Component count net * all regressions

    • Bug List
      Writer: other - 422(-7)
      Calc - 231(+1)
      Impress - 125(-1)
      LibreOffice - 53(+1)
      Draw - 51(+0)
      Writer: docx filter - 45(+1)
      Crashes - 42(+0)
      Base - 39(-3)
      UI - 39(+0)
      Writer: perf - 35(+1)
      Borders - 34(+0)
      Writer: other filter - 32(+0)
      Printing and PDF export - 26(+0)
      Chart - 24(+0)
      RTL - 23(+0)
      filters and storage - 21(+0)
      BASIC - 19(-2)
      Writer: doc filter - 16(+0)
      graphics stack - 13(+0)
      Formula Editor - 7(+0)
      framework - 3(+0)
      Extensions - 2(+0)
      sdk - 2(+0)
      Linguistic - 1(+0)

Impressum (Legal Info) | Datenschutzerklärung (Privacy Policy)   Content on this site is licensed under a Creative Commons Attribution Share Alike 3.0 license.