ESC meeting minutes: 2024-04-25

[vmiklos]

• Present:

  • Cloph, Heiko, Jonathan, Olivier, Caolan, Hossein, Ilmari, Michael W, Stephan, Xisco, Miklos, Eike

• Completed Action Items:

  • Update api.libreoffice.org from 7.4 (Cloph)

• Pending Action Items:

• Release Engineering update (Cloph)

  • 7.6: 7.6.7 RC2 next week
  • 24.2: 24.2.3 RC2 this week

• Documentation (Olivier)

  • Helpcontents2

    • updates and fixes (ohallot, fitoshido)

  • Guides

    • published Calc and Writer guides as web pages.

  • Bugzilla Documentation statistics
    264(264) bugs open

  • Updates:
    BZ changes 1 week 1 month 3 months 12 months
    created 15(7) 37(7) 98(9) 222(4)
    commented 26(23) 68(11) 246(11) 856(20)
    resolved 5(-1) 17(1) 46(3) 117(1)

  • top 10 contributors:
    Olivier Hallot made 43 changes in 1 month, and 263 changes in 1 year
    Stéphane Guillou made 25 changes in 1 month, and 255 changes in 1 year
    Dione Maddern made 16 changes in 1 month, and 31 changes in 1 year
    MeBugzilla made 7 changes in 1 month, and 7 changes in 1 year
    Weghorn, Michael made 7 changes in 1 month, and 8 changes in 1 year
    Nabet, Julien made 7 changes in 1 month, and 53 changes in 1 year
    Ilmari Lauhakangas made 6 changes in 1 month, and 71 changes in 1 year
    Kaganski, Mike made 4 changes in 1 month, and 68 changes in 1 year
    Adolfo Jayme Barrientos made 3 changes in 1 month, and 24 changes in 1 year
    Heiko Tietze made 3 changes in 1 month, and 82 changes in 1 year

• UX Update (Heiko)

  • Bugzilla (topicUI) statistics
    241(241) (topicUI) bugs open, 38(38) (needsUXEval) needs to be evaluated by the UXteam

  • Updates:
    BZ changes 1 week 1 month 3 months 12 months
    added 2(-2) 9(-10) 16(-7) 24(-7)
    commented 50(-21) 196(-35) 556(-8) 1894(-55)
    removed 1(0) 3(1) 3(1) 12(0)
    resolved 9(1) 32(4) 89(4) 314(-6)

  • top 10 contributors:
    Vernon, Stuart Foote made 109 changes in 1 month, and 309 changes in 1 year
    Heiko Tietze made 84 changes in 1 month, and 1079 changes in 1 year
    Stéphane Guillou made 79 changes in 1 month, and 644 changes in 1 year
    Ilmari Lauhakangas made 19 changes in 1 month, and 144 changes in 1 year
    Dieter made 15 changes in 1 month, and 148 changes in 1 year
    Eyal Rozenberg made 15 changes in 1 month, and 143 changes in 1 year
    Justin Luth made 15 changes in 1 month, and 140 changes in 1 year
    Petros Christopoulos made 7 changes in 1 month, and 7 changes in 1 year
    Robert Großkopf made 6 changes in 1 month, and 11 changes in 1 year
    UNKNOWN made 5 changes in 1 month, and 5 changes in 1 year

  • [Bug 158932] Icons for promote / demote outline level should be improved

  • [Bug 160353] List images in order of document appearance in Calc Navigator

  • [Bug 160764] Request: Set the Navigator viewport to default to Headings
    rather than Sections
    → + [Bug 160734] Support exporting to Markdown

    • we have a mediawiki export extension already (Olivier)
      • good to not base anything on this, it’s in Java (Heiko)
    • would this be extension vs inernal? (Hossein)
    • see ESC minutes from a few months ago, best to decide details when somebody would start on this (Ilmari)
      • ESC meeting minutes: 2024-01-18
    • markdown import/export may fit into a gsoc project (Hossein)
    • liked odpdown by Thorsten (Heiko)

  • [Bug 160732] Rename “Navigation” toolbar to clarify its role, avoid confusion,
    and relate to “Recency”

• Crash Testing (Caolan)

  • 24(+0) import failure, 19(+0) export failures
    - some new .odt export failures seen
    https://gerrit.libreoffice.org/c/core/+/166572
  • 16 (unchanged) coverity issues
  • 6 ossfuzz issues
    - seem to have developed a new msan error during build
    ==35384==WARNING: MemorySanitizer: use-of-uninitialized-value
    icu_73::readPackage(char const*) /work/workdir_for_build/UnpackedTarball/icu/source/tools/toolutil/package.cpp:638:19
    probably their side, as this hasn’t changed on our side(?)
  • workdir_for_build in a fuzzing build? (Miklos)
    • the all-static case is similar to the mobile build, hence the path (Caolan)

• Crash Reporting (Xisco)

  • 7.6.5.2 8995(+892)
  • 7.6.6.3 1928(+874)
  • 24.2.0.3 16125(+718)
  • 24.2.1.2 12036(+1143)
  • 24.2.2.2 4911(+1790)
  • just sent the current state to the list: 24.2.2.2 crashes

• Mentoring (Hossein)

  • this week: most time went for gsoc
  • reviewed submissions/ from candidates
    committer… 1 week 1 month 3 months 12 months
    open 92(46) 143(23) 171(28) 171(28)
    reviews 357(39) 1211(-165) 3695(-167) 12499(-19)
    merged 245(32) 964(-17) 3229(-48) 12441(-53)
    abandoned 21(12) 55(6) 171(4) 658(-7)
    own commits 183(54) 679(38) 2152(8) 9191(-1)
    review commits 67(24) 264(5) 873(1) 3068(13)
    contributor… 1 week 1 month 3 months 12 months
    open 44(8) 93(-6) 103(-2) 103(-2)
    reviews 745(163) 2605(-7) 7649(-41) 29453(-117)
    merged 29(12) 147(10) 373(17) 1734(10)
    abandoned 12(1) 51(6) 295(5) 698(8)
    own commits 31(15) 151(-2) 442(-4) 1122(5)
    review commits 0(0) 0(0) 0(0) 0(0)
    • easyHack statistics:
      needsDevEval 8(8) needsUXEval 1(1) cleanup_comments 331(331)
      total 413(413) assigned 28(28) open 351(351)
    • top 10 contributors:
      LeSasse made 19 patches in 1 month, and 19 patches in 1 year
      Armin Le Grand (allotropia) made 12 patches in 1 month, and 89 patches in 1 year
      Ritobroto Mukherjee made 10 patches in 1 month, and 14 patches in 1 year
      Rafał Dobrakowski made 8 patches in 1 month, and 16 patches in 1 year
      Dione Maddern made 8 patches in 1 month, and 34 patches in 1 year
      Bogdan B made 5 patches in 1 month, and 20 patches in 1 year
      Aaron Bourdeaux made 5 patches in 1 month, and 5 patches in 1 year
      Juan José González made 4 patches in 1 month, and 11 patches in 1 year
      Sahil Gautam made 4 patches in 1 month, and 4 patches in 1 year
      colton Garrett made 4 patches in 1 month, and 4 patches in 1 year
    • top 10 reviewers:
      Adolfo Jayme Barrientos made 104 review comments in 1 month, and 492 in 1 year
      Ilmari Lauhakangas made 92 review comments in 1 month, and 518 in 1 year
      Caolán McNamara made 88 review comments in 1 month, and 1394 in 1 year
      Hossein made 84 review comments in 1 month, and 332 in 1 year
      Thorsten Behrens made 84 review comments in 1 month, and 650 in 1 year
      Grandin, Noel made 76 review comments in 1 month, and 690 in 1 year
      Olivier Hallot made 68 review comments in 1 month, and 352 in 1 year
      Vajna, Miklos made 56 review comments in 1 month, and 1102 in 1 year
      Nabet, Julien made 52 review comments in 1 month, and 942 in 1 year
      Michael Stahl made 50 review comments in 1 month, and 914 in 1 year
    • Patches automatically abandoned:
      Make application color customizable ( Sahil Gautam )
      - https://gerrit.libreoffice.org/#/c/159363
      tdf#158454 Add Thai Autocorrect Support, coding part ( Theppitak Karoonboonyanan )
      - https://gerrit.libreoffice.org/#/c/160160
      tdf#130857 weld_message_dialog ( Omkar Acharekar )
      - https://gerrit.libreoffice.org/#/c/161831
      tdf#119745 Avoid scrolling too fast in the Basic IDE ( Rafael Lima )
      - https://gerrit.libreoffice.org/#/c/162134
      tdf#132354: sc: Add UItest ( Xisco Fauli )
      - https://gerrit.libreoffice.org/#/c/162315
      WIP make the AbstractSvxNameDialog async ( Noel Grandin )
      - https://gerrit.libreoffice.org/#/c/162562
      tdf#159610 Make applied frame styles appear ( Jim Raykowski )
      - https://gerrit.libreoffice.org/#/c/163220
      python3: update to 3.10.13 ( Aron Budea )
      - https://gerrit.libreoffice.org/#/c/163448
      Fix setting of entitlements in unsigned macOS sandbox builds ( Patrick Luby )
      - https://gerrit.libreoffice.org/#/c/163553
      Convert source file from Latin-1 to UTF-8 ( Andrea Gelmini )
      - https://gerrit.libreoffice.org/#/c/163645
    • big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
      Jonathan Clark (TDF)

• GSoC (Ilmari)

  • Google Summer of Code
  • Projects ranked yesterday
  • slot request sent to google, decision will be announced on 2024-05-01

• Commit Access

• Developer Certification (Stephan/Miklos/László/Gabriel)

  • resting since: 2 weeks (limit: 20 weeks)

• Jenkins / CI update (Cloph)
  gerrit_android_aarch64 jobs: 175 ok: 156 ko: 16 fail ratio: 9.14% mean_ok: 13 ( 19) median_ok: 11 ( 14)
  gerrit_android_arm jobs: 171 ok: 161 ko: 8 fail ratio: 4.68% mean_ok: 13 ( 19) median_ok: 10 ( 13)
  gerrit_android_x86 jobs: 175 ok: 162 ko: 12 fail ratio: 6.86% mean_ok: 13 ( 18) median_ok: 10 ( 14)
  gerrit_android_x86_64 jobs: 171 ok: 155 ko: 14 fail ratio: 8.19% mean_ok: 15 ( 21) median_ok: 13 ( 17)
  gerrit_linux_clang_dbgutil jobs: 351 ok: 295 ko: 50 fail ratio: 14.25% mean_ok: 39 ( 43) median_ok: 33 ( 38)
  gerrit_linux_gcc_release jobs: 440 ok: 329 ko: 98 fail ratio: 22.27% mean_ok: 21 ( 25) median_ok: 16 ( 18)
  gerrit_mac jobs: 362 ok: 300 ko: 53 fail ratio: 14.64% mean_ok: 56 ( 56) median_ok: 51 ( 51)
  gerrit_windows jobs: 375 ok: 303 ko: 56 fail ratio: 14.93% mean_ok: 57 (146) median_ok: 56 ( 85)
  gerrit_master_ml jobs: 480 ok: 253 ko: 198 fail ratio: 41.25% mean_ok: 162 (165) median_ok: 106 (107)
  gerrit_master jobs: 59 ok: 38 ko: 18 fail ratio: 30.51% mean_ok: 117 (120) median_ok: 73 ( 73)
  gerrit_master_seq jobs: 411 ok: 215 ko: 170 fail ratio: 41.36% mean_ok: 165 (170) median_ok: 114 (114)

  • tests that failed more than twice in last seven days:
    3 CppunitTest_sw_ooxmlexport21 gerrit_linux_gcc_release
    3 CppunitTest_sw_writerfilter_filters_test gerrit_linux_gcc_release
    5 UITest_sw_navigator gerrit_linux_clang_dbgutil
    7 CppunitTest_vcl_filters_test gerrit_linux_gcc_release
    8 aborted by jenkins job timeout gerrit_windows
    35 CppunitTest_svgio gerrit_linux_gcc_release
  • this week we had a broken test / mid-air-collision (Cloph)
    • fixes by Mike K & Xisco, thanks to them
  • gerrit upgrade caused some problems, now all good
    • git gc problem on the main build (not even starting the real builds)
  • macOS bot went bad, fixed.
  • one Windows bot goes offline quite frequently, may will replace with a VM instead

• process for external tarballs changed (Cloph)

  • now a repository in gerrit using git-LFS
  • instructions on how to use it in the repo’s readme:
    extern - Gitiles
    after submitting might take 5min until files are reachable via web
  • no changes to the download-URLs
  • also host moved to different machine
    → should me much faster to download now/better connectivity
  • follow the instructions carefully, then you don’t have to download GBs, just the metadata
  • great news, thanks a lot! (Stephan)
    • adds accountability to see who added which tarball, where

• What’s cooking (Miklos)

  • A11y update (Michael W)
    • gtk4 a11y: analysing “random” crashes, implement handling for relations
    • gtk3: occasionally broken a11y tree with Calc (tdf#160806)
    • a11y UNO API: plan to refine a bit to improve type-safety,
      maintenance, debugging experience (e.g. use enum instead of integer
      constants)
  • RTL/CTL/CJK update (Jonathan)
    • 49885 – sync custom breakiterator rules with icu originals breakiterator rule update
      • change in-flight, awaiting review
    • 61444 – Text layout broken across formatting changes (color, underline, etc.) text layout broken across formatting changes
      • in progress
  • Hyperlink tab removed from Character properties (Heiko)
    • 132253 – CHARACTER DIALOG: Drop hyperlink from character attributes
    • attributes “Unvisited/Visited Character Style Name” cannot be
      assigned to other styles than “Visited/Internet Link”
    • help update missing
  • build with wsl-as-helper but from within git-bash (Cloph)
    • https://gerrit.libreoffice.org/c/core/+/166343/comments/d24b20c5_73518b1b
      lists requirements (git-bash, strawberry-perl-portable, make, wsl-container
      capable of building a linux version)
    • works for Cloph, Stephan (arm64, even)
    • hope to land it on master soon (Cloph)

• QA update (Xisco)

  • UNCONFIRMED: 1173 (+5)

    • enhancements: 280 (-3)
    • needsUXEval: 10 (-7)
    • haveBackTrace: 10 (+0)
    • needsDevAdvice: 48 (+2)
    • documentation: 4 (+1)
    • android: 0 (+0)
    • iOS: 0 (+0)
    • Online: 9 (+0)

  • Most pressing bugs:
    New:

  None

  • New high severity bugs of the week:

  None

• QA stats (Stéphane)

  • Weekly Bug Summary
    +97 -2 (-106) overall)
    many thanks to the top bug squashers:
    QA Administrators 15
    Stéphane Guillou (stragu) 11
    Mike Kaganski 10
    Heiko Tietze 8
    Buovjaga 6
    Justin L 5
    Noel Grandin 5
    V Stuart Foote 5
    Xisco Faulí 5
    Adolfo Jayme Barrientos 3

  • top 10 bugs reporters:
    Xisco Faulí 6
    Stéphane Guillou (stragu) 5
    peter josvai 5
    Gabor Kelemen (allotropia) 4
    Telesto 4
    Regina Henschel 3
    Eyal Rozenberg 2
    Mike Kaganski 2
    Sam 2
    BikeHelmet 1

  • top 10 bugs fixers:
    Kaganski, Mike 8
    Grandin, Noel 5
    Xisco Fauli 5
    Adolfo Jayme Barrientos 3
    Heiko Tietze 3
    Justin Luth 3
    Balazs Varga 2
    Jim Raykowski 2
    Olivier Hallot 2
    Stéphane Guillou 2

  • top 10 bugs confirmers:
    Stéphane Guillou 12
    Ady 7
    Dieter 7
    Xisco Fauli 7
    m.a.riosv 7
    Heiko Tietze 6
    UNKNOWN 4
    Ilmari Lauhakangas 3
    Kaganski, Mike 3
    Robert Großkopf 3

• Bisected bugs open: keyword ‘bisected’

  • more accurate - down to a single commit.
  • Bug List: LibreOffice Bi-bisected

  done by:
     Raal                   4
     Xisco Fauli            4
     Stéphane Guillou       3
     Aron Budea             2
     Ilmari Lauhakangas     2
     Telesto                1
  

• Bibisected bugs open: keyword ‘bibisected’

  • Bug List: LibreOffice Bi-bisected

  done by:
     Raal                   4
     Xisco Fauli            4
     Stéphane Guillou       3
     Aron Budea             2
     Ilmari Lauhakangas     2
     Telesto                1
  

• all bugs tagged with ‘regression’

  • 1237(+1) bugs open of 13317(+15) total 23(+0) high prio.

    done by:
    Stéphane Guillou 3
    Xisco Fauli 3
    Ilmari Lauhakangas 2
    m.a.riosv 2
    Roman Kuznetsov 1
    Aron Budea 1
    Kaganski, Mike 1
    Robert Großkopf 1

• ~Component count net * high severity regressions

  • Bug List
    Writer - 15(-1)
    Calc - 3(+1)
    Impress - 2(+0)
    LibreOffice - 1(+0)
    UI - 1(+0)

  by OS:
  All - 18(+0)
  Linux - 3(+0)
  Mac OS X - 0(+0)
  Windows - 2(+0)

• ~Component count net * all regressions

  • Bug List
    Writer: other - 436(-1)
    Calc - 226(+1)
    Impress - 128(+1)
    Draw - 53(+0)
    LibreOffice - 52(-1)
    Writer: docx filter - 45(+0)
    Crashes - 41(-1)
    Base - 40(+0)
    UI - 37(+0)
    Borders - 35(+0)
    Writer: perf - 35(+0)
    Writer: other filter - 30(+0)
    Chart - 24(+0)
    Printing and PDF export - 24(+0)
    RTL - 23(+0)
    filters and storage - 22(+0)
    BASIC - 20(+1)
    Writer: doc filter - 16(+0)
    graphics stack - 12(+0)
    Formula Editor - 7(+0)
    framework - 3(+0)
    Extensions - 2(+0)
    sdk - 2(+0)
    Linguistic - 1(+0)