ESC meeting minutes: 2024-03-14

[vmiklos]

• Present:

  • Regina, Xisco, Stephan, Michael W, Heiko, Caolan, Miklos, Olivier, Michael S, Cloph

• Completed Action Items:

  • Dev certification: came up with an initial proposal for the current cycle (Miklos)

• Pending Action Items:

• Release Engineering update (Cloph)

  • 7.6: 7.6.6 RC2 next week
  • 24.2.2 RC2 next week
  • MAR update
    • enabled now for 24.0.0 → 24.1.1, seems to work
    • RC → final will be enabled; otherwise just final → next final
    • thanks a lot (Stephan)
    • does this mean end-users can already use this? (Xisco)
      • it’s experimental for 24.2, but yes (Cloph)
        • need to opt in via tools → options
      • on master, no longer experimental, but still need to opt in (Stephan)
        • for now, hardcoded to check once a week

• Documentation (Olivier)

  • New Help
    • Fixes in Windows build (A. Timar)
      +Helpcontent2
    • Fixes and updates (Pierre F, Stragu)
  • Guides
    • Calc & Writer guides published
    • Updates of guides in translations weblate soon.
  • Bugzilla Documentation statistics
    274(274) bugs open
  • Updates:
    BZ changes 1 week 1 month 3 months 12 months
    created 21(8) 48(9) 71(13) 228(2)
    commented 47(34) 105(24) 224(34) 909(25)
    resolved 8(5) 19(4) 30(5) 116(4)
  • top 10 contributors:
    Vernon, Stuart Foote made 36 changes in 1 month, and 81 changes in 1 year
    Olivier Hallot made 35 changes in 1 month, and 273 changes in 1 year
    Pierre F made 21 changes in 1 month, and 21 changes in 1 year
    Heiko Tietze made 21 changes in 1 month, and 104 changes in 1 year
    Stéphane Guillou made 20 changes in 1 month, and 279 changes in 1 year
    Adolfo Jayme Barrientos made 15 changes in 1 month, and 20 changes in 1 year
    Dione Maddern made 11 changes in 1 month, and 11 changes in 1 year
    UNKNOWN made 11 changes in 1 month, and 11 changes in 1 year
    Mac made 7 changes in 1 month, and 9 changes in 1 year
    Bogdan B made 6 changes in 1 month, and 53 changes in 1 year

• UX Update (Heiko)

  • Bugzilla (topicUI) statistics
    247(247) (topicUI) bugs open, 35(35) (needsUXEval) needs to be evaluated by the UXteam
  • Updates:
    BZ changes 1 week 1 month 3 months 12 months
    added 6(1) 14(4) 15(4) 26(2)
    commented 63(6) 226(24) 466(-9) 2025(-2)
    removed 0(0) 0(0) 1(0) 14(-1)
    resolved 6(0) 29(1) 77(-2) 318(0)
  • top 10 contributors:
    Heiko Tietze made 108 changes in 1 month, and 1207 changes in 1 year
    Stéphane Guillou made 59 changes in 1 month, and 635 changes in 1 year
    Vernon, Stuart Foote made 51 changes in 1 month, and 265 changes in 1 year
    Ady made 34 changes in 1 month, and 152 changes in 1 year
    Ilmari Lauhakangas made 25 changes in 1 month, and 185 changes in 1 year
    Bob Harvey made 12 changes in 1 month, and 13 changes in 1 year
    Eyal Rozenberg made 12 changes in 1 month, and 146 changes in 1 year
    Rafael Lima made 11 changes in 1 month, and 77 changes in 1 year
    Kaganski, Mike made 10 changes in 1 month, and 99 changes in 1 year
    Nabet, Julien made 10 changes in 1 month, and 27 changes in 1 year
  • [Bug 160185] Would like a width control for Web view in Writer (like in Google
    Docs’ Pageless view)
  • [Bug 160194] Add all 3 Spotlight commands (Paragraph Style, Character Style,
    Direct Formatting) to Style Inspector
  • [Bug 159906] A11Y sidebar: Too many issue reports about direct character
    formatting
  • [Bug 160167] Bullets and Numbering dialog: Selection label
  • [Bug 160114] ZOOM factor: make it change in all Writer instances (in all
    writer windows)
  • [Bug 160125] Standard Palette - Dark Blue 1 (from COL_DEFAULT_SHAPE_STROKE) is
    lighter than Blue
  • [Bug 157981] personal / custom dictionaries should be easily portable
    → + [Bug 159794] inconsistency in backspacing through indents
    • Zero ‘before text’ indent first before removing paragraph break
    • inconsistency sounds suspicious (Michael S)

• Crash Testing (Caolan)

  • 2(+0) import failure, 0(+0) export failures
  • Development/Crashtesting - The Document Foundation Wiki
  • 0 coverity issues
  • 5 ossfuzz issues
    • 1 crash (atypical crypto config), 1 OOM, 3 timeouts

• Crash Reporting (Xisco)

  • 7.6.4.1 39396(+2417)
  • 7.6.5.2 2110(+1158)
  • 24.2.0.3 11049(+1376)
  • 24.2.1.2 2245(+1594)

  • Reports for signature: ScOutputData::SetClipMarks(ScOutputData::OutputAreaParam &,ScCellInfo *,SvxCellHorJustify,__int64)

  • New in 24.2. Introduced by 1d2380516ac9871743c5a5455f0734d02be8eade

  • related to 129847 – ### indication of "cell too narrow" should additionally show "more content" red arrow

• Mentoring (Hossein)

  • Missing Hossein
    committer… 1 week 1 month 3 months 12 months
    open 64(-8) 136(-7) 138(-6) 138(-6)
    reviews 382(-44) 1550(12) 3766(56) 12054(-16)
    merged 255(-39) 1256(18) 3389(6) 12410(-72)
    abandoned 19(-4) 75(7) 179(7) 668(5)
    own commits 171(-29) 806(35) 2264(-29) 9375(-74)
    review commits 85(14) 358(37) 918(23) 3039(-11)
    contributor… 1 week 1 month 3 months 12 months
    open 29(-12) 69(-2) 71(-1) 71(-2)
    reviews 758(-130) 3148(26) 7964(-34) 29828(-268)
    merged 30(-2) 139(14) 358(-14) 1903(-49)
    abandoned 3(-42) 210(-9) 302(-4) 694(-5)
    own commits 47(10) 187(32) 415(31) 1069(16)
    review commits 0(0) 0(0) 0(0) 0(0)
    • easyHack statistics:
      needsDevEval 8(8) needsUXEval 1(1) cleanup_comments 326(326)
      total 409(409) assigned 26(26) open 349(349)
    • top 10 contributors:
      Kurt Nordback made 18 patches in 1 month, and 22 patches in 1 year
      Dr. David Alan Gilbert made 18 patches in 1 month, and 41 patches in 1 year
      Pierre F made 16 patches in 1 month, and 16 patches in 1 year
      Armin Le Grand (allotropia) made 12 patches in 1 month, and 85 patches in 1 year
      Stéphane Guillou made 10 patches in 1 month, and 62 patches in 1 year
      Dione Maddern made 8 patches in 1 month, and 24 patches in 1 year
      Ahmed Hamed made 6 patches in 1 month, and 6 patches in 1 year
      Luv Sharma made 5 patches in 1 month, and 15 patches in 1 year
      Weblate made 3 patches in 1 month, and 20 patches in 1 year
      Devansh Varshney made 3 patches in 1 month, and 4 patches in 1 year
    • top 10 reviewers:
      Vajna, Miklos made 170 review comments in 1 month, and 1068 in 1 year
      Caolán McNamara made 160 review comments in 1 month, and 1274 in 1 year
      Grandin, Noel made 126 review comments in 1 month, and 652 in 1 year
      Ilmari Lauhakangas made 92 review comments in 1 month, and 494 in 1 year
      Michael Stahl made 86 review comments in 1 month, and 984 in 1 year
      Thorsten Behrens made 84 review comments in 1 month, and 640 in 1 year
      Nabet, Julien made 78 review comments in 1 month, and 934 in 1 year
      Hossein made 74 review comments in 1 month, and 292 in 1 year
      Adolfo Jayme Barrientos made 68 review comments in 1 month, and 474 in 1 year
      Christian Lohmaier made 66 review comments in 1 month, and 346 in 1 year
    • Patches automatically abandoned:
      tdf#158108: Update to ICU 74.1 ( Taichi Haradaguchi )
      - https://gerrit.libreoffice.org/#/c/158749
      Enable uno API calls to affect updating links ( Håkon Hægland )
      - https://gerrit.libreoffice.org/#/c/161628
    • big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
      Adlair Cerecedo-Mendez
      Hassan Sajjad
      Jonah Janzen
      Teodora Balaj

• Outreachy (Ilmari)

• GSoC (Ilmari)

  • Google Summer of Code
  • Development/GSoC/2024 - The Document Foundation Wiki
  • till March 18: Potential participants discuss application ideas

• Commit Access

• Developer Certification (Stephan/Miklos/László/Gabriel)

  • resting since: 20 weeks (limit: 20 weeks)
  • have an initial proposal from Miklos + feedback from Stephan, needs more time

• Jenkins / CI update (Cloph)
  gerrit_android_aarch64 jobs: 165 ok: 151 ko: 11 fail ratio: 6.67% mean_ok: 9 ( 11) median_ok: 7 ( 8)
  gerrit_android_arm jobs: 164 ok: 158 ko: 5 fail ratio: 3.05% mean_ok: 10 ( 11) median_ok: 8 ( 8)
  gerrit_android_x86 jobs: 165 ok: 150 ko: 12 fail ratio: 7.27% mean_ok: 9 ( 11) median_ok: 8 ( 8)
  gerrit_android_x86_64 jobs: 164 ok: 159 ko: 4 fail ratio: 2.44% mean_ok: 10 ( 11) median_ok: 8 ( 8)
  gerrit_linux_clang_dbgutil jobs: 336 ok: 243 ko: 85 fail ratio: 25.30% mean_ok: 37 ( 38) median_ok: 35 ( 36)
  gerrit_linux_gcc_release jobs: 385 ok: 314 ko: 56 fail ratio: 14.55% mean_ok: 17 ( 18) median_ok: 14 ( 15)
  gerrit_mac jobs: 332 ok: 293 ko: 27 fail ratio: 8.13% mean_ok: 51 ( 51) median_ok: 48 ( 48)
  gerrit_windows jobs: 347 ok: 278 ko: 43 fail ratio: 12.39% mean_ok: 60 ( 96) median_ok: 55 ( 74)
  gerrit_master_ml jobs: 402 ok: 222 ko: 141 fail ratio: 35.07% mean_ok: 112 (113) median_ok: 98 ( 99)
  gerrit_master jobs: 52 ok: 27 ko: 18 fail ratio: 34.62% mean_ok: 102 (102) median_ok: 92 ( 92)
  gerrit_master_seq jobs: 350 ok: 195 ko: 123 fail ratio: 35.14% mean_ok: 113 (113) median_ok: 98 ( 98)

  • https://dev-www.libreoffice.org/tmp/gerrit_240314.html
  • tests that failed more than twice in last seven days
    3 CppunitTest_sw_layoutwriter2 gerrit_windows
    3 UITest_writer_tests2 gerrit_linux_clang_dbgutil
    4 CppunitTest_sw_ooxmlexport5 gerrit_linux_gcc_release
    5 CppunitTest_sw_ooxmlexport21 gerrit_linux_gcc_release
    7 CppunitTest_sw_a11y gerrit_windows
    7 JunitTest_sw_complex gerrit_linux_clang_dbgutil
    9 UITest_writer_tests8 gerrit_linux_clang_dbgutil
  • this week was good, nothing stands out (Cloph)
    • some “application failed to launch dialogs” problems, on Windows
    • bot is taken offline automatically, but then this reduces the build bandwidth

• What’s cooking (Miklos)

  • A11y update (Michael W)
    • gtk4: implement initial support for text attributes
    • Accerciser: Improvements for Gtk 4 apps merged upstream, plan to look into Wayland support
    • pending Gerrit change to port Java a11y test to C++:
      https://gerrit.libreoffice.org/c/core/+/164231
  • 3D shapes, extruded shapes (Regina)
    • currently looking at importing the material properties
    • would like to talk some 3D expert
      • Armin could be a candidate

• COOL Days 2024 (Miklos)

  • COOL Days 2024 - 8-10 April - Cambridge, UK - Collabora Office and Collabora Online 8th → 10th April
  • contributors can submit 5 mins talk proposals at https://eventyay.com/e/0512424d/cfs
  • LibreOffice Technology hackfest as part of it

• QA update (Xisco)

  • UNCONFIRMED: 1124 (-9)

    • enhancements: 280 (-1)
    • needsUXEval: 9 (+1)
    • haveBackTrace: 10 (+0)
    • needsDevAdvice: 46 (+1)
    • documentation: 6 (-2)
    • android: 0 (+0)
    • iOS: 0 (+0)
    • Online: 9 (+0)

  • Most pressing bugs:
    New:

  None

  Old:
     + Selection invisible in a11y High Contrast modes with SKIA/Raster, Skia/Vulkan unaffected
         + https://bugs.documentfoundation.org/show_bug.cgi?id=160036
         + bisected to Noel. Skia Upgrade (m116)
           + maybe a further upgrade would help
           + in theory could bisect skia as well (Caolan)
  Fixed:
     + CRASH: using ALT+RETURN twice
         + https://bugs.documentfoundation.org/show_bug.cgi?id=160095
         + Fixed. thanks to Julien
  

  • New high severity bugs of the week:

    • CRASH: undoing conditional format

      • 160149 – CRASH: undoing conditional format
      • bisected to Mike

    • UI. RTL: Horizontal scrolling for right-to-left Sheet moves in opposite direction (macOS and Linux)

      • 93352 – UI. RTL: Horizontal scrolling for right-to-left Sheet moves in opposite direction (macOS and Linux)
      • bibisected

• Copyright year in the about dialog (Xisco)

  • Recent bugreport → fixed by Julien on master

  • Should this be backported?

    • https://gerrit.libreoffice.org/c/core/+/164748

    • affects l10n strings (Cloph)

      • could be fixed, would be a better way

AI: file easy hack to move the year out of the about dialog l10n strings (Xisco)

• backport or not? (Xisco)
  • can take care of this to not break l10n strings (Cloph)
  • see value in picking it to living branches (Caolan)
    • if people want to do it, it’s logical
      => go ahead with backporting, linking the minutes in the gerrit change (all)
      AI: Cloph to comment on the gerrit change to inform Martin (Cloph)

• QA stats (Stéphane)

  • Current QA weekly focus: Hyperlinks meta. The Document Foundation Pad

  • Interesting consolidated/clarified bugs:

    • sd: Wrong hyperlink for object linked to target in document when exported to PDF: 100893 – Draw/Impress: Object hyperlinked to "Target in Document" results in wrong link (opens browser) in exported PDF
    • sd: Hyperlinked objects can’t be Ctrl + clicked until file is reloaded: 156159 – Hyperlinked objects in Draw can't be Ctrl + clicked to follow the link until file is reloaded

  • QA dashboard data updated: TDF QA Dashboard

  • Weekly Bug Summary
    +117 +7 (-110) overall)
    many thanks to the top bug squashers:
    QA Administrators 18
    Stéphane Guillou (stragu) 16
    Rafael Lima 7
    Adolfo Jayme Barrientos 5
    Heiko Tietze 5
    m_a_riosv 5
    Buovjaga 4
    Gabor Kelemen (allotropia) 4
    Balázs Varga (allotropia) 3
    Xisco Faulí 3

  • top 10 bugs reporters:
    peter josvai 7
    Rafael Lima 5
    Xisco Faulí 4
    Gabor Kelemen (allotropia) 3
    Jeff Fortin Tam 3
    Stéphane Guillou (stragu) 3
    V Stuart Foote 3
    Ian Eales 2
    J Johnson 2
    Justin L 2

  • top 10 bugs fixers:
    Adolfo Jayme Barrientos 5
    Balazs Varga 3
    Kelemen, Gabor 3
    Heiko Tietze 2
    Rafael Lima 2
    Telesto 2
    Thorsten Behrens (CIB) 2
    Xisco Fauli 2
    1
    David Gilbert 1

  • top 10 bugs confirmers:
    UNKNOWN 19
    Stéphane Guillou 17
    Dieter 11
    Ilmari Lauhakangas 5
    Nabet, Julien 5
    Raal 5
    Vernon, Stuart Foote 5
    Ady 4
    Heiko Tietze 4
    Rafael Lima 3

• Bisected bugs open: keyword ‘bisected’

  • more accurate - down to a single commit.
  • Bug List: LibreOffice Bi-bisected

  done by:
     Stéphane Guillou       5
     Raal                   2
     Xisco Fauli            2
  

• Bibisected bugs open: keyword ‘bibisected’

  • Bug List: LibreOffice Bi-bisected

  done by:
     Stéphane Guillou       5
     Raal                   2
     Xisco Fauli            2
  

• all bugs tagged with ‘regression’

  • 1245(-6) bugs open of 13246(+10) total 20(+0) high prio.

    done by:
    Xisco Fauli 2
    Ady 1
    Raal 1
    Robert Großkopf 1
    Stéphane Guillou 1
    Vernon, Stuart Foote 1

• ~Component count net * high severity regressions

  • Bug List
    Writer - 14(+1)
    LibreOffice - 2(+0)
    Calc - 1(+0)
    Impress - 1(+0)
    UI - 1(+0)
    Printing and PDF export - 0(-1)

  by OS:
  All - 14(+0)
  Linux - 5(+0)
  Mac OS X - 0(+0)
  Windows - 1(+0)

• ~Component count net * all regressions

  • Bug List
    Writer: other - 443(-3)
    Calc - 225(+2)
    Impress - 127(-1)
    LibreOffice - 55(+1)
    Draw - 52(+1)
    Crashes - 46(+0)
    Writer: docx filter - 45(+0)
    Base - 39(+0)
    UI - 37(+1)
    Borders - 36(+0)
    Writer: perf - 35(+0)
    Writer: other filter - 31(+0)
    Printing and PDF export - 25(-2)
    Chart - 24(+0)
    RTL - 23(+0)
    filters and storage - 22(-1)
    BASIC - 19(-1)
    Writer: doc filter - 16(+0)
    graphics stack - 12(+0)
    Formula Editor - 7(+0)
    framework - 3(+0)
    Extensions - 2(+0)
    sdk - 2(+0)
    Linguistic - 1(+0)