ESC meeting minutes: 2024-02-15

  • Present:

    • Olivier, Caolan, Cloph, Heiko, Hossein, Ilmari, Michael W, Regina, Stephan, Xisco, Miklos
  • Completed Action Items:

  • Pending Action Items:

  • Release Engineering update (Cloph)

  • Atticize gnu-make-lo.git (Thorsten)

    • see https://git.libreoffice.org/gnu-make-lo
    • suggest to retire this (Michael S)
      • probably nobody should use this these days
    • any impact on the way people build LO? (Hossein)
      • would only impact building LO 4.x or older (Michael S)
      • no impact otherwise
    • flag it as read-only + add description (Cloph)
      => no objections
      AI: Thorsten to take this further
  • Documentation (Olivier)

    • Helpcontent2

      • Housekeeping internal links (D. Maddern)
      • ScriptForge Help (A. Romedenne)
      • typos… (ohallot)
    • Guides

    • Bugzilla Documentation statistics
      282(282) bugs open

    • Updates:
      BZ changes 1 week 1 month 3 months 12 months
      created 9(1) 22(7) 42(5) 249(4)
      commented 20(8) 57(13) 159(4) 936(-2)
      resolved 3(1) 5(2) 15(2) 124(-1)

    • top 10 contributors:
      Vernon, Stuart Foote made 22 changes in 1 month, and 44 changes in 1 year
      Alain Romedenne made 10 changes in 1 month, and 13 changes in 1 year
      Stéphane Guillou made 10 changes in 1 month, and 274 changes in 1 year
      Olivier Hallot made 9 changes in 1 month, and 345 changes in 1 year
      Kaganski, Mike made 8 changes in 1 month, and 59 changes in 1 year
      Dan Dascalescu made 7 changes in 1 month, and 7 changes in 1 year
      UNKNOWN made 6 changes in 1 month, and 6 changes in 1 year
      Heiko Tietze made 5 changes in 1 month, and 96 changes in 1 year
      Ilmari Lauhakangas made 5 changes in 1 month, and 85 changes in 1 year
      Juan José González made 4 changes in 1 month, and 4 changes in 1 year

  • UX Update (Heiko)

    • Bugzilla (topicUI) statistics
      247(247) (topicUI) bugs open, 37(37) (needsUXEval) needs to be evaluated by the UXteam
    • Updates:
      BZ changes 1 week 1 month 3 months 12 months
      added 2(0) 5(0) 9(-3) 21(-4)
      commented 26(-51) 175(-8) 518(-16) 2046(-73)
      removed 0(0) 0(0) 2(0) 13(0)
      resolved 4(-11) 37(2) 77(0) 319(-7)
    • top 10 contributors:
      Heiko Tietze made 118 changes in 1 month, and 1236 changes in 1 year
      Stéphane Guillou made 49 changes in 1 month, and 613 changes in 1 year
      Vernon, Stuart Foote made 42 changes in 1 month, and 261 changes in 1 year
      Eyal Rozenberg made 18 changes in 1 month, and 187 changes in 1 year
      Rafael Lima made 16 changes in 1 month, and 105 changes in 1 year
      Ady made 14 changes in 1 month, and 120 changes in 1 year
      Telesto made 11 changes in 1 month, and 48 changes in 1 year
      Justin Luth made 10 changes in 1 month, and 124 changes in 1 year
      Németh, László made 8 changes in 1 month, and 22 changes in 1 year
      Akshay Warrier made 7 changes in 1 month, and 7 changes in 1 year
    • [Bug 159724] The “No Character Style” list entry should always be offered
      in the SB “Character Styles” content panel, even if only the “Applied
      Styles” is the selected UI mode
    • [Bug 159717] Lock file warning dialog promotes data disaster
    • [Bug 159711] The minimum Navigator sidebar width should be lower
    • [Bug 141776] Application shortcuts not working in Start Center after closing
      document (see comment 4)
    • [Bug 159652] Finding a way to join a suffix to the word immediately before it,
      using autocorrect function
      → + [Bug 159654] Enhancement Feature Request - Center Across Selection
      • missing ODF feature, round-trip issue with OOXML
      • Excel has this, obviously we drop it on roundtrip
      • believe it’s a bad feature (Heiko)
  • Crash Testing (Caolan)

    • 5(-7) import failure, 3(+1) export failures
    • 0 coverity issues
    • 3 Google / ossfuzz
      • no crashes, 3 timeouts
  • Crash Reporting (Xisco)

    • 7.6.3.2 7500(+463)
    • 7.6.4.1 27646(+3372)
    • 24.2.0.3 3115(+1942)
  • Mentoring (Hossein)

    • Reviewed submissions from newcomers on Gerrit
    • Build problem with latest Cygwin
      • Tested with different build parameters
      • Works with 1 paralell process
      • Had issues like that before
      • Ilmari also mailed the cygwin list
        • the discussion stalled there at the moment
        • Hossein tries to create a self-contained reproducer, no success so far
    • Call with 3 volunteer for start porting, 1 for finalizing his submission
      • SDK examples porting, from java to python

      • also java test porting to python or c++

        committer...   1 week    1 month     3 months     12 months
                open      83(-5)    138(-9)     141(-8)       141(-8)
             reviews     414(6)    1494(-86)   3534(30)     11954(-8)
              merged     261(25)   1144(-19)   3195(-42)    12463(63)
           abandoned      12(0)      52(0)      216(1)        654(5)
         own commits     149(10)    720(-35)   2297(-111)    9652(-22)
        

        review commits 58(19) 271(-29) 810(-2) 3061(9)
        contributor… 1 week 1 month 3 months 12 months
        open 40(-61) 267(-15) 274(-9) 275(-9)
        reviews 802(-16) 2864(-148) 7752(-166) 30380(-48)
        merged 22(5) 89(-1) 333(-5) 2092(-61)
        abandoned 4(-13) 39(-13) 148(2) 531(-13)
        own commits 26(8) 122(0) 293(20) 1030(13)
        review commits 0(0) 0(0) 0(0) 0(0)

      • easyHack statistics:
        needsDevEval 8(8) needsUXEval 1(1) cleanup_comments 325(325)
        total 411(411) assigned 23(23) open 355(355)

      • top 10 contributors:
        Dione Maddern made 14 patches in 1 month, and 18 patches in 1 year
        Armin Le Grand (allotropia) made 11 patches in 1 month, and 83 patches in 1 year
        Luv Sharma made 6 patches in 1 month, and 11 patches in 1 year
        Eli Schwartz made 5 patches in 1 month, and 5 patches in 1 year
        Akshay Warrier made 5 patches in 1 month, and 5 patches in 1 year
        Kira Tubo made 4 patches in 1 month, and 10 patches in 1 year
        Gökay Şatır made 4 patches in 1 month, and 4 patches in 1 year
        Weblate made 3 patches in 1 month, and 17 patches in 1 year
        Kurt Nordback made 3 patches in 1 month, and 4 patches in 1 year
        Méven Car made 3 patches in 1 month, and 3 patches in 1 year

      • top 10 reviewers:
        Caolán McNamara made 190 review comments in 1 month, and 1134 in 1 year
        Vajna, Miklos made 122 review comments in 1 month, and 976 in 1 year
        Michael Stahl made 118 review comments in 1 month, and 1054 in 1 year
        Xisco Fauli made 82 review comments in 1 month, and 788 in 1 year
        Ilmari Lauhakangas made 76 review comments in 1 month, and 452 in 1 year
        Thorsten Behrens made 74 review comments in 1 month, and 606 in 1 year
        Grandin, Noel made 64 review comments in 1 month, and 582 in 1 year
        Hossein made 64 review comments in 1 month, and 294 in 1 year
        Taichi Haradaguchi made 54 review comments in 1 month, and 106 in 1 year
        Christian Lohmaier made 52 review comments in 1 month, and 354 in 1 year

      • Patches automatically abandoned:
        SbRtl_IsNumeric returns false when given >1 parameter ( Ernesto Rendon )
        - https://gerrit.libreoffice.org/#/c/157475
        CppunitTest_desktop_lib: adjust asserts so this works again ( Caolán McNamara )
        - https://gerrit.libreoffice.org/#/c/159909
        tdf#112437 add a go to page spin button UNO control ( Jim Raykowski )
        - https://gerrit.libreoffice.org/#/c/160191
        tdf#157794 refactor Complex to use std::complex where possible ( Daniel Thomas )
        - https://gerrit.libreoffice.org/#/c/160394

      • big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
        Hubert Figuière (Collabora)
        Devansh Varshney
        Steven Casey

  • Outreachy (Ilmari)

    • work is ongoing & is on track.
    • next week is the last one for coding.
    • find in the sidebar for Writer – patch is pending review
    • several patches for the qt welding project
      • Michael W also helped with that
      • working on .ui parsing for qt
  • GSoC (Ilmari)

  • Commit Access

  • Developer Certification (Stephan/Miklos/László/Gabriel)

    • resting since: 17 weeks (limit: 20 weeks)
  • Jenkins / CI update (Cloph)
    gerrit_android_aarch64 jobs: 167 ok: 161 ko: 1 fail ratio: 0.60% mean_ok: 9 ( 12) median_ok: 6 ( 8)
    gerrit_android_arm jobs: 161 ok: 157 ko: 3 fail ratio: 1.86% mean_ok: 9 ( 12) median_ok: 6 ( 7)
    gerrit_android_x86 jobs: 167 ok: 161 ko: 1 fail ratio: 0.60% mean_ok: 9 ( 12) median_ok: 7 ( 8)
    gerrit_android_x86_64 jobs: 163 ok: 143 ko: 19 fail ratio: 11.66% mean_ok: 9 ( 13) median_ok: 6 ( 7)
    gerrit_linux_clang_dbgutil jobs: 345 ok: 251 ko: 87 fail ratio: 25.22% mean_ok: 40 ( 43) median_ok: 35 ( 41)
    gerrit_linux_gcc_release jobs: 443 ok: 319 ko: 109 fail ratio: 24.60% mean_ok: 17 ( 19) median_ok: 14 ( 15)
    gerrit_mac jobs: 331 ok: 297 ko: 24 fail ratio: 7.25% mean_ok: 50 ( 50) median_ok: 48 ( 48)
    gerrit_windows jobs: 342 ok: 257 ko: 69 fail ratio: 20.18% mean_ok: 60 ( 91) median_ok: 49 ( 50)
    gerrit_master_ml jobs: 468 ok: 192 ko: 248 fail ratio: 52.99% mean_ok: 108 (109) median_ok: 77 ( 79)
    gerrit_master jobs: 50 ok: 17 ko: 29 fail ratio: 58.00% mean_ok: 65 ( 65) median_ok: 58 ( 58)
    gerrit_master_seq jobs: 418 ok: 175 ko: 219 fail ratio: 52.39% mean_ok: 111 (112) median_ok: 80 ( 80)

    • https://dev-www.libreoffice.org/tmp/gerrit_240215.html
    • tests that failed more than twice in last seven days
      3 CppunitTest_framework_dispatch gerrit_windows
      3 CppunitTest_sw_uiwriter2 gerrit_linux_gcc_release
      3 CppunitTest_sw_uiwriter gerrit_linux_gcc_release
      3 JunitTest_sw_complex gerrit_linux_clang_dbgutil
      4 Killed by the kill-wrapper gerrit_linux_clang_dbgutil
      4 CppunitTest_vcl_pdfexport gerrit_linux_clang_dbgutil
      5 CppunitTest_sd_uimpress gerrit_mac
      5 CppunitTest_sw_layoutwriter2 gerrit_windows
      7 CppunitTest_sw_a11y gerrit_linux_gcc_release
      10 CppunitTest_sw_a11y gerrit_windows
      11 CppunitTest_test_a11y gerrit_windows
      21 aborted by jenkins job timeout gerrit_windows
      21 UITest_writer_tests7 gerrit_linux_clang_dbgutil
      • have a new problematic test: UITest_writer_tests7
        • patch in gerrit to move some tests around (Xisco)
          • it may or may not help
      • bots: Windows problem was specific with a single bot
        • the reason is not clear, possibly a reboot will help
      • 1 linux builder also had a problem: gcc build failed due to a dirty repo checkout
        • fixed
      • CppunitTest_sw_a11y failure (Xisco)
        • 2 tests were problematic only on Windows, only on the branch, disabled them
  • What’s cooking (Miklos)

  • COOL Days 2024 (Miklos)

  • QA update (Xisco)

    • UNCONFIRMED: 1127 (+24)

      • enhancements: 261 (+0)
      • needsUXEval: 5 (+2)
      • haveBackTrace: 9 (-1)
      • needsDevAdvice: 45 (+0)
      • documentation: 9 (+0)
      • android: 0 (+0)
      • iOS: 0 (+0)
      • Online: 10 (+0)
    • Most pressing bugs:
      New:

    None

    Fixed:
       + CRASH: Changing to edit mode
           + https://bugs.documentfoundation.org/show_bug.cgi?id=159707
           + already fixed, thanks to Julien
    
  • QA stats (Stéphane)

    • Weekly Bug Summary
      +103 +40 (-101) overall)
      many thanks to the top bug squashers:
      Heiko Tietze 9
      Telesto 9
      Mike Kaganski 7
      Buovjaga 5
      QA Administrators 5
      Michael Weghorn 4
      V Stuart Foote 4
      ady 4
      Julien Nabet 3
      Noel Grandin 3

    • top 10 bugs reporters:
      Telesto 6
      Gabor Kelemen (allotropia) 4
      Xisco Faulí 4
      Alain Romedenne 2
      David García 2
      Orwel 2
      Pit Zaclade 2
      Rafael Lima 2
      lvm 2
      Andy 1

    • top 10 bugs fixers:
      Heiko Tietze 4
      Grandin, Noel 3
      Weghorn, Michael 3
      Xisco Fauli 3
      Kaganski, Mike 2
      Kelemen, Gabor 2
      Michael Stahl 2
      Nabet, Julien 2
      1
      Ady 1

    • top 10 bugs confirmers:
      Dieter 11
      UNKNOWN 4
      Ady 4
      Vernon, Stuart Foote 4
      Weghorn, Michael 4
      m.a.riosv 4
      Kaganski, Mike 3
      Xisco Fauli 3
      Heiko Tietze 2
      Kelemen, Gabor 2

  • Bisected bugs open: keyword ‘bisected’

    done by:
       Raal                   6
       Xisco Fauli            2
       Kelemen, Gabor         1
       Weghorn, Michael       1
       Kaganski, Mike         1
    
  • Bibisected bugs open: keyword ‘bibisected’

    done by:
       Raal                   6
       Xisco Fauli            2
       Kelemen, Gabor         1
       Weghorn, Michael       1
       Camaleón               1
    
  • all bugs tagged with ‘regression’

    • 1257(-8) bugs open of 13194(+12) total 22(-2) high prio.

      done by:
      Xisco Fauli 3
      m.a.riosv 2
      Telesto 2
      Kelemen, Gabor 1
      Kaganski, Mike 1
      Camaleón 1
      Raal 1
      Henschel, Regina 1

  • ~Component count net * high severity regressions

    • Bug List
      Writer - 14(-1)
      Calc - 2(+0)
      LibreOffice - 2(+0)
      Impress - 1(+0)
      Printing and PDF export - 1(+0)
      UI - 1(+0)
      Formula Editor - 0(-1)

    by OS:
    All - 16(-1)
    Linux - 5(-1)
    Mac OS X - 0(+0)
    Windows - 1(+0)

  • ~Component count net * all regressions

    • Bug List
      Writer: other - 455(+0)
      Calc - 231(-2)
      Impress - 130(+0)
      LibreOffice - 54(-2)
      Crashes - 52(-2)
      Draw - 50(+0)
      Writer: docx filter - 45(+1)
      Base - 38(+0)
      UI - 36(+0)
      Borders - 35(+0)
      Writer: perf - 34(-1)
      Writer: other filter - 31(+0)
      Printing and PDF export - 26(+0)
      Chart - 23(+0)
      RTL - 23(+0)
      filters and storage - 21(+0)
      BASIC - 19(+0)
      Writer: doc filter - 16(+0)
      graphics stack - 11(+0)
      Formula Editor - 7(-1)
      framework - 3(-1)
      Extensions - 2(+0)
      sdk - 2(+0)
      Linguistic - 1(+0)