ESC meeting minutes: 2024-01-11

vmiklos · January 11, 2024, 3:45pm

Present:
- Heiko, Thorsten, Xisco, Caolan, Hossein, Ilmari, Eike, Michael W, Stephan, Stephane, Michael S (late), Miklos
Completed Action Items:
Pending Action Items:
Release Engineering update (Cloph)
- 7.6: 7.6.5 RC1 in 3 weeks
- 24.2: RC 2 this week
  - libreoffice-24-2-0 branch, needs +2 reviews
  - late features:
    - MSI custom action for MAR, waiting for Gerrit (Stephan)
      - all the code is in
      - generating the MAR updates for updates that are coming in the future
        
        not strictly necessary for the RC2
        
        will tag in the evening (Cloph)
  - please make sure not to break the string freeze
    - Armenian language pack was added
    - a previous non-localizable string was fixed
    - if breaking the freze would be needed, then at least please ping Cloph and Sophie!
Documentation (Olivier)
- New Help
  - CSS fix for Safari (Ilmari)
  - Improvements in Help Editor (Juan José Gonzales)
- Helcontents2
  - continue to review command acccess for several UI’s (ohallot)
  - Updates and fixes (stragu, S. Horacek)
  - New pages for SourceForge (R. Lima)
- Guides
  - progressing.
- Bugzilla Documentation statistics
  272(272) bugs open
- Updates:
  BZ changes 1 week 1 month 3 months 12 months
  created 3(0) 12(-2) 35(-4) 253(-2)
  commented 23(9) 69(9) 159(8) 974(7)
  resolved 2(-1) 8(0) 16(1) 135(0)
- top 10 contributors:
  Nabet, Julien made 14 changes in 1 month, and 42 changes in 1 year
  Faisal made 6 changes in 1 month, and 6 changes in 1 year
  Seth Chaiklin made 6 changes in 1 month, and 322 changes in 1 year
  Stéphane Guillou made 5 changes in 1 month, and 311 changes in 1 year
  libretist made 4 changes in 1 month, and 4 changes in 1 year
  nobu made 4 changes in 1 month, and 6 changes in 1 year
  Eivind Samseth made 3 changes in 1 month, and 3 changes in 1 year
  UNKNOWN made 3 changes in 1 month, and 4 changes in 1 year
  steve made 3 changes in 1 month, and 10 changes in 1 year
  Heiko Tietze made 2 changes in 1 month, and 104 changes in 1 year
UX Update (Heiko)
- Bugzilla (topicUI) statistics
  252(252) (topicUI) bugs open, 67(67) (needsUXEval) needs to be evaluated by the UXteam
- Updates:
  BZ changes 1 week 1 month 3 months 12 months
  added 12(7) 28(4) 36(8) 48(8)
  commented 61(44) 242(-16) 632(58) 2262(25)
  removed 0(0) 1(-1) 3(-1) 14(0)
  resolved 4(0) 21(-4) 74(1) 325(-6)
- top 10 contributors:
  Heiko Tietze made 129 changes in 1 month, and 1343 changes in 1 year
  Stéphane Guillou made 101 changes in 1 month, and 634 changes in 1 year
  Vernon, Stuart Foote made 35 changes in 1 month, and 312 changes in 1 year
  Eyal Rozenberg made 27 changes in 1 month, and 211 changes in 1 year
  Rafael Lima made 25 changes in 1 month, and 132 changes in 1 year
  Ilmari Lauhakangas made 20 changes in 1 month, and 227 changes in 1 year
  Dieter made 16 changes in 1 month, and 229 changes in 1 year
  Ady made 15 changes in 1 month, and 140 changes in 1 year
  m.a.riosv made 10 changes in 1 month, and 70 changes in 1 year
  Seth Chaiklin made 10 changes in 1 month, and 85 changes in 1 year
  → + [Bug 159120] Recent documents: Show only documents from the current module
  by default
  - Poll at LibreOffice Design: "LibreOffice shows documents from all modules (Wri…" - Fosstodon
- [Bug 158888] Not able to scroll up/down with the mouse cursor hovering above
  a text box form control
- [Bug 159099] Confusing term “Reset to Parent” in dialogs
- [Bug 159096] Comment indicator in Calc should be red, not magenta
- [Bug 158101] Disabled popup menu items are visible with non-gtk backend
- [Bug 159060] Formatting all cells in a sheet containing data will only apply
  formatting to cells that contain data, instead of applying to all cells
- [Bug 159073] Remove status bar ‘document modified’ indicator
  → + [Bug 159047] Calc: make possible Font spacing of formula results
  - editeng inside a cell allows this
  - but not for formula results → define this in ODF as well
    - no instant objection (Eike)
    - not sure such a text attribute can be stored on a formula cell, though
    - could work if you apply the character attribute on the formula result
  - Excel doesn’t allow this spacing, though
- [Bug 159040] provide easy UI to automatically apply digital signature when
  storing documents
- [Bug 158996] Floating table
Crash Testing (Caolan)
- 4(-31) import failure, 0(-14) export failures
  - Development/Crashtesting - The Document Foundation Wiki
  - all the ItemSet crashers are fixed, great.
- 130 coverity issues
- ossfuzz
  - 6 issues, 4 timeouts, 1 OOM, 1 apparent leak
  - xlsxfuzzer wasn’t doing much in the past, now working better
Crash Reporting (Xisco)
- 7.5.8.2 4018(+327)
- 7.5.9.2 1840(+673)
- 7.6.2.1 37137(+1682)
- 7.6.3.2 4855(+477)
- 7.6.4.1 9865(+2790)
- Most reported crash in 7.6.4
  - Reports for signature: static bool cppu::idefaultConstructElements(struct _sal_Sequence * *, struct _typelib_TypeDescriptionReference *, long, long, long)
  - 789a737ac92c4f2b0eb9820b99c43cc8253c8b29 “Remove DeleteItemOnIdlex” could fix it. Thanks to Armin.
  - Plan to backport it to 7.6 branch (Xisco)
- Not possible. Revert 57145acf9ec47c23e307b7a5c0029d21d937cc35 “simplify SfxItemDisruptor_Impl, just use Application::PostUserEvent” in libreoffice-7-6 instead (Xisco)
Mentoring (Hossein)
- Worked on ship LibreOfficeKit headers with LibreOffice
  - 149256 – Ship LibreOfficeKit headers and library files with the LibreOffice SDK community packages
    Prepared a draft blog post for LOK:
    Using LibreOfficeKit
    Using LibreOfficeKit - LibreOffice Development Blog
- can assume that an LOKit client take a libreoffice installation set as-is? (Hossein)
  - yes, as long as you’re on Linux (Miklos)
- FWIW I think we packaged these in fedora libreoffice with: https://src.fedoraproject.org/rpms/libreoffice/blob/rawhide/f/libreoffice.spec#_1425 (Caolan)
  committer… 1 week 1 month 3 months 12 months
  open 68(14) 131(-4) 134(-4) 134(-4)
  reviews 398(136) 1316(94) 3126(62) 11734(84)
  merged 256(24) 1090(12) 3111(7) 12435(58)
  abandoned 15(0) 62(-29) 222(7) 654(7)
  own commits 174(5) 727(-31) 2453(-15) 9767(15)
  review commits 81(32) 284(23) 741(23) 2943(11)
  contributor… 1 week 1 month 3 months 12 months
  open 47(23) 306(-4) 306(-5) 307(-5)
  reviews 756(96) 2900(-14) 7802(-12) 30552(-16)
  merged 17(-2) 105(-2) 400(-8) 2269(-47)
  abandoned 16(9) 53(11) 124(8) 530(1)
  own commits 20(-8) 125(1) 264(7) 1037(-2)
  review commits 0(0) 0(0) 0(0) 0(0)
  - easyHack statistics:
    needsDevEval 8(8) needsUXEval 1(1) cleanup_comments 322(322)
    total 409(409) assigned 22(22) open 356(356)
  - top 10 contributors:
    Stéphane Guillou made 15 patches in 1 month, and 56 patches in 1 year
    Armin Le Grand (allotropia) made 13 patches in 1 month, and 69 patches in 1 year
    Weblate made 10 patches in 1 month, and 14 patches in 1 year
    Srebotnjak, Martin made 5 patches in 1 month, and 15 patches in 1 year
    Matt K made 5 patches in 1 month, and 15 patches in 1 year
    Bogdan B made 5 patches in 1 month, and 20 patches in 1 year
    Luv Sharma made 5 patches in 1 month, and 5 patches in 1 year
    Juan José González made 4 patches in 1 month, and 4 patches in 1 year
    Sophia Schroeder made 4 patches in 1 month, and 50 patches in 1 year
    Darshan Upadhyay made 4 patches in 1 month, and 7 patches in 1 year
  - top 10 reviewers:
    Thorsten Behrens made 126 review comments in 1 month, and 604 in 1 year
    Xisco Fauli made 98 review comments in 1 month, and 808 in 1 year
    Vajna, Miklos made 96 review comments in 1 month, and 966 in 1 year
    Caolán McNamara made 96 review comments in 1 month, and 928 in 1 year
    Ilmari Lauhakangas made 78 review comments in 1 month, and 422 in 1 year
    Grandin, Noel made 70 review comments in 1 month, and 576 in 1 year
    Olivier Hallot made 70 review comments in 1 month, and 310 in 1 year
    Weghorn, Michael made 66 review comments in 1 month, and 292 in 1 year
    Kaganski, Mike made 66 review comments in 1 month, and 430 in 1 year
    Adolfo Jayme Barrientos made 62 review comments in 1 month, and 576 in 1 year
  - Patches automatically abandoned:
    SwFormatAnchor Take 3 ( Noel Grandin )
    - https://gerrit.libreoffice.org/#/c/141481
    reduce allocation cost in svx properties ( Noel Grandin )
    - https://gerrit.libreoffice.org/#/c/151222
    vcl: extract lcl_InitHbBuffer() ( Chris Sherlock )
    - https://gerrit.libreoffice.org/#/c/158713
    vcl: let ImplLayoutArgs process glyph items ( Chris Sherlock )
    - https://gerrit.libreoffice.org/#/c/158800
    vcl: migrate HarfBuzz processing into PopulateGlyphItems() ( Chris Sherlock )
    - https://gerrit.libreoffice.org/#/c/158802
    vcl: have FindScriptSubRuns() work on runs, not the cache that holds the runs ( Chris Sherlock )
    - https://gerrit.libreoffice.org/#/c/158918
    vcl: move vcl::text::Run and vcl::text::SubRun to own local headers ( Chris Sherlock )
    - https://gerrit.libreoffice.org/#/c/158922
    vcl: move FindScriptSubRuns() to ImplLayoutArgs ( Chris Sherlock )
    - https://gerrit.libreoffice.org/#/c/158923
    vcl: migrate lcl_InitHbBuffer() to be reusable ( Chris Sherlock )
    - https://gerrit.libreoffice.org/#/c/158924
    vcl: extract ImplLayoutArgs::PopulateFallbackRuns() ( Chris Sherlock )
    - https://gerrit.libreoffice.org/#/c/158925
    vcl: format GenericSalTextLayout.cxx ( Chris Sherlock )
    - https://gerrit.libreoffice.org/#/c/158933
    tdf#157250 SwNavigator: Improve handling of Headings with redlines ( Jim Raykowski )
    - https://gerrit.libreoffice.org/#/c/158964
    vcl: have ImplLayoutArgs::PrepareFallback() take SalTextLayoutGlyphs and level ( Chris Sherlock )
    - https://gerrit.libreoffice.org/#/c/158966
    introduce SalTextLayoutGlyphs::GetGlyphCount() ( Chris Sherlock )
    - https://gerrit.libreoffice.org/#/c/158967
    vcl: migrate PopulateGlyphItems() to LogicalFontInstance ( Chris Sherlock )
    - https://gerrit.libreoffice.org/#/c/158979
  - big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
    Ali Safaya
    Shachar Shemesh
    Nagy Tibor (allotropia)
    vivek javiya (Collabora)
Outreachy (Ilmari)
- work is onging & is on track.
GSoC (Ilmari)
- Organisation applications open 22 Jan
- We need way more ideas in GSoC Ideas - The Document Foundation Wiki
- 90 hour ideas are possible, but not mandatory to offer
- See also, if you would like to adopt an orphaned idea: Development/GSoC/Ideas without a mentor - The Document Foundation Wiki
- Have (at least) 2 project ideas (Heiko)
  - comments in the sidebar
  - libreoffice themes that makes it possible to overwrite the system colors
    among others to deal with the extreme contrast in dark mode
- this year you don’t have to be actually a student to apply (Ilmari)
- are we open for people who have OSS experience? (Hossein)
  - easy case: when the person is a student (Ilmari)
Commit Access
Developer Certification (Stephan/Miklos/László)
- resting since: 12 weeks (limit: 20 weeks)
Jenkins / CI update (Cloph)
gerrit_android_aarch64 jobs: 153 ok: 148 ko: 3 fail ratio: 1.96% mean_ok: 8 ( 10) median_ok: 6 ( 7)
gerrit_android_arm jobs: 151 ok: 148 ko: 3 fail ratio: 1.99% mean_ok: 8 ( 8) median_ok: 6 ( 6)
gerrit_android_x86 jobs: 153 ok: 147 ko: 3 fail ratio: 1.96% mean_ok: 8 ( 9) median_ok: 6 ( 6)
gerrit_android_x86_64 jobs: 151 ok: 150 ko: 1 fail ratio: 0.66% mean_ok: 9 ( 10) median_ok: 6 ( 7)
gerrit_linux_clang_dbgutil jobs: 308 ok: 270 ko: 34 fail ratio: 11.04% mean_ok: 33 ( 34) median_ok: 26 ( 27)
gerrit_linux_gcc_release jobs: 375 ok: 290 ko: 73 fail ratio: 19.47% mean_ok: 15 ( 16) median_ok: 13 ( 14)
gerrit_mac jobs: 305 ok: 282 ko: 14 fail ratio: 4.59% mean_ok: 47 ( 47) median_ok: 43 ( 43)
gerrit_windows jobs: 392 ok: 168 ko: 212 fail ratio: 54.08% mean_ok: 58 ( 71) median_ok: 49 ( 60)
gerrit_master_ml jobs: 465 ok: 153 ko: 289 fail ratio: 62.15% mean_ok: 85 ( 86) median_ok: 75 ( 75)
gerrit_master jobs: 37 ok: 10 ko: 21 fail ratio: 56.76% mean_ok: 62 ( 62) median_ok: 56 ( 56)
gerrit_master_seq jobs: 427 ok: 143 ko: 267 fail ratio: 62.53% mean_ok: 86 ( 87) median_ok: 76 ( 76)
- https://dev-www.libreoffice.org/tmp/gerrit_240111.html
- tests that failed more than twice in last seven days.
  3 CppunitTest_sc_uicalc2 gerrit_windows
  3 CppunitTest_sw_ooxmlimport gerrit_linux_gcc_release
  3 JunitTest_chart2_unoapi gerrit_linux_clang_dbgutil
  4 Killed by the kill-wrapper gerrit_linux_clang_dbgutil_branch
  13 CppunitTest_test_a11y gerrit_windows
  25 CppunitTest_sw_ooxmlexport10 gerrit_linux_gcc_release
  57 aborted by jenkins job timeout gerrit_windows
- this week was horrible (Cloph)
  - the Windows failures left & right
  - either firebird build fails or it times out
  - need to figure out how to handle this
  - at least the firebird build now has an auto-retry rule
- CppunitTest_sw_ooxmlexport10 failure, already fixed, thanks Caolan
- not clear what is the reason for the timeouts
  - either it’s a temporary problem or an issue that is not visible in the process list
  - reboot is a workaround, but…
What’s cooking (Miklos)
- IRC bot notification for the ESC call (Miklos)
  AI: could do it (Cloph)
- A11y update (Michael W)
  - looking into a lifecycle issue with ValueSet a11y
    - tdf#159089 / https://gerrit.libreoffice.org/c/core/+/161903
Win Daily build failing because of Firebird upgrade (Xisco)
- lo_daily_tb_win #1640 Console [Jenkins]
- it’s the same problem as with gerrit changes (Cloph)
QA update (Xisco)
- UNCONFIRMED: 1060 (-2)
  - enhancements: 250 (-6)
  - needsUXEval: 20 (+3)
  - haveBackTrace: 11 (-1)
  - needsDevAdvice: 39 (+3)
  - documentation: 4 (+0)
  - android: 1 (+1)
  - iOS: 0 (+0)
  - Online: 10 (+0)
- Most pressing bugs:
  New:
None
- New high severity bugs of the week:
  - FILEOPEN: RTF: Table imported incorrectly
    - 158982 – FILEOPEN: RTF: Table imported incorrectly
    - bisected to Oliver. Fix: https://gerrit.libreoffice.org/c/core/+/161824
  - Writer table formulas calculated incorrectly in merged cells when table splits over pages
    - 159027 – Writer table formulas calculated incorrectly in merged cells when table splits over pages
    - bisected to Lubos
QA stats (Stéphane)
- QA Dashboard data updated: TDF QA Dashboard
- (Grimoire) Dashboard restored recent data (thanks Cloph!): https://dashboard.documentfoundation.org
- Weekly summary: Weekly Bug Summary
  +100 +14 (-84) overall)
  many thanks to the top bug squashers:
  Stéphane Guillou (stragu) 12
  QA Administrators 9
  Julien Nabet 6
  Caolán McNamara 4
  László Németh 4
  Mike Kaganski 4
  Heiko Tietze 3
  Rafael Lima 3
  Gabor Kelemen (allotropia) 2
  Matt K 2
- top 10 bugs reporters:
  Gabor Kelemen (allotropia) 7
  Xisco Faulí 5
  Stéphane Guillou (stragu) 4
  László Németh 3
  Regina Henschel 3
  Telesto 2
  Vincent Boudry 2
  William Friedman 2
  nik 2
  Michael Meeks 1
- top 10 bugs fixers:
  Caolán McNamara 4
  Németh, László 4
  Nabet, Julien 3
  Heiko Tietze 2
  Kaganski, Mike 2
  Matt K 2
  Michael Stahl 2
  Olivier Hallot 2
  Rafael Lima 2
  Vajna, Miklos 2
- top 10 bugs confirmers:
  Stéphane Guillou 34
  m.a.riosv 12
  Heiko Tietze 6
  Xisco Fauli 6
  Nabet, Julien 4
  Ady 3
  Ilmari Lauhakangas 3
  Kaganski, Mike 3
  Németh, László 3
  Raal 3

Bisected bugs open: keyword ‘bisected’

more accurate - down to a single commit.
Bug List: LibreOffice Bi-bisected

done by:
   Stéphane Guillou       5
   Xisco Fauli            5
   Raal                   4
   Kelemen, Gabor         3
   Kaganski, Mike         1

Bibisected bugs open: keyword ‘bibisected’

Bug List: LibreOffice Bi-bisected

done by:
   Stéphane Guillou       5
   Raal                   4
   Xisco Fauli            4
   Kelemen, Gabor         3
   Ady                    1
   Németh, László         1
   Nabet, Julien          1

all bugs tagged with ‘regression’
- 1250(+5) bugs open of 13103(+20) total 22(+1) high prio.
  
  done by:
  Stéphane Guillou 5
  Xisco Fauli 4
  Kelemen, Gabor 3
  m.a.riosv 2
  Ady 1
  Kaganski, Mike 1
  Németh, László 1
  Raal 1
~Component count net * high severity regressions
- Bug List
  Writer - 15(+1)
  Calc - 2(+0)
  Impress - 2(+0)
  LibreOffice - 1(+0)
  UI - 1(+0)
by OS:
All - 16(+1)
Linux - 5(+0)
Mac OS X - 0(+0)
Windows - 1(+0)
~Component count net * all regressions
- Bug List
  Writer: other - 444(+4)
  Calc - 227(+0)
  Impress - 131(+1)
  Draw - 52(+0)
  Crashes - 50(+2)
  LibreOffice - 50(-2)
  Writer: docx filter - 43(+0)
  Base - 41(-1)
  UI - 39(+0)
  Borders - 35(+0)
  Writer: perf - 35(+0)
  Writer: other filter - 32(+0)
  Printing and PDF export - 27(+1)
  RTL - 25(+0)
  Chart - 24(+2)
  filters and storage - 21(+0)
  BASIC - 18(+0)
  Writer: doc filter - 16(+0)
  graphics stack - 12(+0)
  Formula Editor - 7(+0)
  framework - 5(+0)
  Extensions - 2(+0)
  sdk - 2(+0)
  Linguistic - 1(+0)