ESC meeting minutes: 2023-10-26

  • Present:

    • Caolan, Cloph, Heiko, Hossein, Ilmari, Xisco, Michael W, Stephan, Miklos, Eike, Michael S
  • Completed Action Items:

  • Pending Action Items:

    • Set up a daily tinderbox for the python-based windows installer (Cloph)
      [ hope to get to it in a week ]
  • Release Engineering update (Cloph)

  • Documentation (Olivier)

    • New Help

      • Improvements for accessibility (Ilmari)
    • Helpcontents2

      • Updates in nomenclature (ohallot, S. Chaiklin)
      • Review/updates on UI commands (ohallot)
      • Q: “Table Heading” or “Table Header”
        157920 – Terminology: "Table Header" or "Table Heading" ?
        • Calc goes with “Header”, Writer uses “Heading”
        • the bug has the input from Michael S already, agreeing with that (Miklos)
    • Guides

      • Progress in GS 7.6 (Rob Thornton)
      • Progress in Calc guides 7.6 (Steve Fanning)
    • Bugzilla Documentation statistics
      274(274) bugs open

    • Updates:
      BZ changes 1 week 1 month 3 months 12 months
      created 5(1) 25(5) 61(-5) 292(0)
      commented 9(0) 47(4) 182(-30) 1080(0)
      resolved 0(-2) 5(0) 23(-6) 156(-1)

    • top 10 contributors:
      Olivier Hallot made 16 changes in 1 month, and 436 changes in 1 year
      Ilmari Lauhakangas made 15 changes in 1 month, and 128 changes in 1 year
      Kaganski, Mike made 11 changes in 1 month, and 80 changes in 1 year
      Stéphane Guillou made 11 changes in 1 month, and 352 changes in 1 year
      Heiko Tietze made 4 changes in 1 month, and 111 changes in 1 year
      Xisco Fauli made 4 changes in 1 month, and 14 changes in 1 year
      aswath t made 2 changes in 1 month, and 7 changes in 1 year
      Rathke, Eike made 2 changes in 1 month, and 10 changes in 1 year
      Jérôme made 2 changes in 1 month, and 2 changes in 1 year
      Adolfo Jayme Barrientos made 1 changes in 1 month, and 22 changes in 1 year

  • UX Update (Heiko)

    • Bugzilla (topicUI) statistics
      254(254) (topicUI) bugs open, 57(57) (needsUXEval) needs to be evaluated by the UXteam
    • Updates:
      BZ changes 1 week 1 month 3 months 12 months
      added 7(6) 17(0) 19(0) 40(-2)
      commented 69(28) 183(42) 428(28) 2212(43)
      removed 0(-1) 2(0) 3(0) 19(-1)
      resolved 9(-2) 27(-3) 84(-2) 328(4)
    • top 10 contributors:
      Heiko Tietze made 112 changes in 1 month, and 1385 changes in 1 year
      Stéphane Guillou made 95 changes in 1 month, and 552 changes in 1 year
      Justin Luth made 25 changes in 1 month, and 120 changes in 1 year
      Eyal Rozenberg made 23 changes in 1 month, and 250 changes in 1 year
      Ilmari Lauhakangas made 21 changes in 1 month, and 232 changes in 1 year
      Bogdan B made 17 changes in 1 month, and 116 changes in 1 year
      Amin Irgaliev made 17 changes in 1 month, and 17 changes in 1 year
      Balazs Varga made 16 changes in 1 month, and 16 changes in 1 year
      Kelemen, Gabor made 16 changes in 1 month, and 22 changes in 1 year
      m.a.riosv made 15 changes in 1 month, and 84 changes in 1 year
    • [Bug 156988] Find cannot find superscripted or subscripted text
    • [Bug 154028] Difficult to change the language of everything in the document
    • [Bug 157908] Change “Evaluate” to “Include” in “Create Index or Table
      of Contents” section of TOC, Index, Bibliography Type tab
    • [Bug 157878] AUTOFILTER : Doesn’t work with 2 words like “CP” and “Mi-CP”
      or “MiCP”
      → + [Bug 157657] Make data validity case sensitive
      • the proposal is to change behavior here (Heiko)
        • would get us closer to the Excel way
    • [Bug 157882] The arrowhead control in the sidebar line section is difficult
      to notice
    • [Bug 157880] Can’t choose an icon when creating an OLE object
    • [Bug 157866] Toolbar dis/appearance must neither shift nor scale the
      slide display
      → + [Bug 39015] EDITING: drag-and-drop selection of (part) of hyperlink drags
      the hyperlink itself (comment 14)
      • propose to change: allow selection of part of a hyperlink
    • [Bug 157864] Introduce presentation and/or master color scheme support
    • [Bug 153919] Shift+resize aspect ratio not maintained for images
      → + [Bug 157828] Support selection of multiple comments
      • editeng now has some better style support since Maxim added that (Heiko)
      • would be nice to clear formatting for all comments → needs a way to be able to select all comments
      • select all text → implicitly “selects” all comments? (Miklos)
        • ideal to not touch the body text formatting (Heiko)
  • Crash Testing (Caolan)

    • 9(+3) import failure, 0(+0) export failures
      • one failure from using content controls for 1para block SDT from DOCX, Jaume is on it
    • 1 coverity issues
    • 3 ossfuzz issues, +2 crashes
      • fodt2pdf has found another crasher
  • Crash Reporting (Xisco)

    • 7.5.6.2 2674(+346) 2328
    • 7.5.7.1 1955(+765) 1190
    • 7.6.0.3 13851(+1051) 12800
    • 7.6.1.2 6778(+638) 6140
    • 7.6.2.1 7283(+2935) 4348

    Introduced by 2d43c34333076fad092f0cdc0f60f81580acdbee ? Miklos ?

  • Mentoring (Hossein)
    committer… 1 week 1 month 3 months 12 months
    open 104(52) 141(58) 172(30) 198(-1)
    reviews 408(76) 1154(168) 3290(-16) 11692(42)
    merged 294(50) 1048(139) 2981(32) 12812(61)
    abandoned 13(-11) 48(6) 161(5) 647(-4)
    own commits 232(55) 766(128) 2082(17) 9707(7)
    review commits 48(-16) 221(15) 605(-21) 3001(-36)
    contributor… 1 week 1 month 3 months 12 months
    open 69(28) 98(28) 122(19) 139(1)
    reviews 922(218) 2644(420) 7038(140) 30580(38)
    merged 20(4) 58(10) 181(3) 2018(-15)
    abandoned 2(-5) 26(-11) 212(1) 613(-6)
    own commits 19(-2) 75(1) 209(3) 1100(2)
    review commits 0(0) 0(0) 0(0) 0(0)

    • easyHack statistics:
      needsDevEval 8(8) needsUXEval 1(1) cleanup_comments 318(318)
      total 398(398) assigned 21(21) open 352(352)
    • top 10 contributors:
      Bogdan B made 5 patches in 1 month, and 100 patches in 1 year
      Sahil Gautam made 5 patches in 1 month, and 14 patches in 1 year
      Omkar Acharekar made 4 patches in 1 month, and 6 patches in 1 year
      Stéphane Guillou made 4 patches in 1 month, and 37 patches in 1 year
      Ankit Kumar Jaipuriar made 4 patches in 1 month, and 5 patches in 1 year
      Khushi Gautam made 3 patches in 1 month, and 3 patches in 1 year
      Hannah Meeks made 2 patches in 1 month, and 5 patches in 1 year
      Darshan Upadhyay made 2 patches in 1 month, and 3 patches in 1 year
      Priyadarshi, Apurva made 1 patches in 1 month, and 2 patches in 1 year
      Stéphane Guillou made 1 patches in 1 month, and 10 patches in 1 year
    • top 10 reviewers:
      Caolán McNamara made 166 review comments in 1 month, and 668 in 1 year
      Michael Stahl made 104 review comments in 1 month, and 1154 in 1 year
      Xisco Fauli made 100 review comments in 1 month, and 780 in 1 year
      Ilmari Lauhakangas made 98 review comments in 1 month, and 420 in 1 year
      Vajna, Miklos made 66 review comments in 1 month, and 892 in 1 year
      Nabet, Julien made 62 review comments in 1 month, and 968 in 1 year
      Kaganski, Mike made 60 review comments in 1 month, and 386 in 1 year
      Grandin, Noel made 60 review comments in 1 month, and 594 in 1 year
      Hossein made 50 review comments in 1 month, and 270 in 1 year
      Heiko Tietze made 34 review comments in 1 month, and 296 in 1 year
    • Patches automatically abandoned:
      Unit test for tdf46733: sw: don’t double-select column during deletecol ( Andrea Rosetti )
      - https://gerrit.libreoffice.org/#/c/146261
    • big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
      Aml-Hassan-Abd-El-hamid
      Willian Pessoa
      Alexandru-Costin Gheorghiu
  • Commit Access

    • None
  • Developer Certification (Stephan/Miklos/Thorsten/László)

    • resting since: 4 weeks (limit: 20 weeks)
  • Jenkins / CI update (Cloph)
    gerrit_android_aarch64 jobs: 175 ok: 167 ko: 2 fail ratio: 1.14% mean_ok: 7 ( 15) median_ok: 4 ( 13)
    gerrit_android_arm jobs: 174 ok: 172 ko: 2 fail ratio: 1.15% mean_ok: 7 ( 13) median_ok: 4 ( 8)
    gerrit_android_x86 jobs: 175 ok: 168 ko: 3 fail ratio: 1.71% mean_ok: 8 ( 15) median_ok: 5 ( 10)
    gerrit_android_x86_64 jobs: 174 ok: 171 ko: 2 fail ratio: 1.15% mean_ok: 7 ( 14) median_ok: 4 ( 9)
    gerrit_linux_clang_dbgutil jobs: 396 ok: 272 ko: 113 fail ratio: 28.54% mean_ok: 41 ( 47) median_ok: 36 ( 45)
    gerrit_linux_gcc_release jobs: 408 ok: 341 ko: 41 fail ratio: 10.05% mean_ok: 21 ( 27) median_ok: 17 ( 21)
    gerrit_mac jobs: 356 ok: 327 ko: 15 fail ratio: 4.21% mean_ok: 49 ( 49) median_ok: 44 ( 44)
    gerrit_windows jobs: 373 ok: 284 ko: 69 fail ratio: 18.50% mean_ok: 68 ( 88) median_ok: 70 ( 77)
    gerrit_master_ml jobs: 467 ok: 240 ko: 181 fail ratio: 38.76% mean_ok: 95 ( 95) median_ok: 80 ( 81)
    gerrit_master jobs: 76 ok: 42 ko: 27 fail ratio: 35.53% mean_ok: 73 ( 74) median_ok: 67 ( 68)
    gerrit_master_seq jobs: 389 ok: 198 ko: 154 fail ratio: 39.59% mean_ok: 98 ( 99) median_ok: 86 ( 86)

    • https://dev-www.libreoffice.org/tmp/gerrit_231026.html
    • tests that failed more than twice in last seven days:
      3 CppunitTest_svx_unit gerrit_windows
      3 CppunitTest_sw_mailmerge gerrit_windows
      3 JunitTest_chart2_unoapi gerrit_linux_clang_dbgutil
      4 UITest_calc_tests8 gerrit_linux_clang_dbgutil
      26 Killed by the kill-wrapper gerrit_linux_clang_dbgutil
      28 UITest_sw_navigator gerrit_linux_clang_dbgutil
    • in terms of test failures, unfortunately again high number of killed jobs + sw_navigator failures
    • apart from that, looks good
    • sw_navigator, changed to avoid oneprocess mode (Xisco)
      • restored some lost asserts
      • it seems it’s still problematic
      • it’s problematic for a different reason (Stephan)
        • fixed several tests on the Python side
        • Noel tried to fix it on the vcl side yesterday + today
        • suggest to not revert anything for now
        • it’s a timer problem, if it’s slow enough, then use-after-free happens
    • do we build SDK examples during CI on any platform? (Hossein)
      • yes, we do on Linux and macOS (Stephan)
      • if you have the build of “ODK” enabled
      • it’s a subsequentcheck, so ‘make check’ has it
      • ie. the jenkins linux-clang-dbgutil config has it
      • want it also on Windows (Hossein)
      • you need to configure the SDK there first (Stephan)
        • easy on Linux / macOS
        • harder on Windows → ignored that for now
        • feel free to look into it if you want
        • will take a look (Hossein)
  • What’s cooking (Miklos)

    • Multi-page floating tables in Writer, see tdf#157119 for details (Miklos)
    • A11y update (Michael W)
      • mostly looking into how text formatting is reported by screen readers and
        spelling dialog
      • not too documented, trying to clarify this with the various upstreams
    • ItemSet rework (Michael S)
      • current iteration: easy test failures are fixed, the harder ones still need fixing
    • More appealing feedback for search (none found, end of document…) (Heiko)
  • QA update (Xisco)

  • QA stats (Stéphane)

  • Bisected bugs open: keyword ‘bisected’

    done by:
       Stéphane Guillou       4
       Bogdan B               1
       Ilmari Lauhakangas     1
       Raal                   1
    
  • Bibisected bugs open: keyword ‘bibisected’

    done by:
       Stéphane Guillou       4
       Bogdan B               1
       Ilmari Lauhakangas     1
       Kaganski, Mike         1
    
  • all bugs tagged with ‘regression’

    • 1221(-6) bugs open of 12921(+10) total 16(+2) high prio.

      done by:
      Stéphane Guillou 5
      Bogdan B 1
      Ilmari Lauhakangas 1
      Kaganski, Mike 1

  • ~Component count net * high severity regressions

    • Bug List
      Writer - 10(+2)
      Calc - 3(+0)
      LibreOffice - 2(+0)
      UI - 1(+0)

    by OS:
    All - 11(+2)
    Linux - 3(+0)
    Mac OS X - 0(+0)
    Windows - 2(+0)

  • ~Component count net * all regressions

    • Bug List
      Writer: other - 424(-2)
      Calc - 223(+0)
      Impress - 138(+0)
      LibreOffice - 52(+1)
      Draw - 48(+0)
      Crashes - 44(+0)
      Base - 42(+0)
      Writer: docx filter - 41(-1)
      UI - 36(-1)
      Borders - 35(+0)
      Writer: other filter - 34(+1)
      Writer: perf - 33(-1)
      Printing and PDF export - 25(-1)
      RTL - 24(+0)
      Chart - 22(+0)
      filters and storage - 19(-1)
      BASIC - 17(+1)
      Writer: doc filter - 15(+0)
      graphics stack - 13(+0)
      Formula Editor - 5(+0)
      framework - 4(+0)
      Extensions - 2(+0)
      sdk - 2(+0)
      Linguistic - 1(+0)