ESC meeting minutes: 2023-10-19

[vmiklos]

• Present:

  • Hossein, Olivier, Cloph, Heiko, Ilmari, Michael W, Stephan, Caolan, Stephane, Xisco, Eike, Michael S, Miklos

• Completed Action Items:

• Pending Action Items:

  • Set up a daily tinderbox for the python-based windows installer (Cloph)

• Release Engineering update (Cloph)

  • 7.6 status: 7.6.3 rc1 in 2 weeks (+2 weeks: next rc)
  • 7.5 status: 7.5.8 rc2 in 1 week
  • 24.2: end of Nov, in week 47, first alpha
    • feature freeze in early Dec
    • see Release Plan 24.2 - The Document Foundation Wiki for details
    • might be some small shifts of 1-2 weeks in either direction

• Documentation (Olivier)

  • Helpcontents

    • Continuing update of UI and UNO help pages (ohallot)
    • Fixes by translators (S. Horacek, buovjaga)

  • Guides

    • Updates in Getting Started Guide (Rob Thornton, ohallot)
    • Updates in Calc Guide (S. Fanning)
    • Updates in Impress/Draw guides (P. Schofield)
    • Progress in guide sanitiy-check scripts (B. Antonio)

  • Bugzilla Documentation statistics
    272(272) bugs open

  • Updates:
    BZ changes 1 week 1 month 3 months 12 months
    created 4(-1) 20(-1) 66(-8) 292(-2)
    commented 9(0) 43(-3) 212(-25) 1080(-2)
    resolved 2(2) 5(-1) 29(-3) 157(-2)

  • top 10 contributors:
    Ilmari Lauhakangas made 15 changes in 1 month, and 125 changes in 1 year
    Stéphane Guillou made 14 changes in 1 month, and 352 changes in 1 year
    Olivier Hallot made 9 changes in 1 month, and 429 changes in 1 year
    Kaganski, Mike made 8 changes in 1 month, and 78 changes in 1 year
    aswath t made 7 changes in 1 month, and 7 changes in 1 year
    Xisco Fauli made 4 changes in 1 month, and 14 changes in 1 year
    Rathke, Eike made 2 changes in 1 month, and 10 changes in 1 year
    Elisabeth Dapper made 1 changes in 1 month, and 1 changes in 1 year
    MISY Nyias made 1 changes in 1 month, and 1 changes in 1 year
    wrigh made 1 changes in 1 month, and 1 changes in 1 year

• UX Update (Heiko)

  • Bugzilla (topicUI) statistics
    254(254) (topicUI) bugs open, 56(56) (needsUXEval) needs to be evaluated by the UXteam
  • Updates:
    BZ changes 1 week 1 month 3 months 12 months
    added 1(-18) 17(-9) 19(-13) 42(-14)
    commented 41(-21) 141(-68) 400(-74) 2169(-93)
    removed 1(0) 2(1) 3(1) 20(0)
    resolved 11(8) 30(4) 86(2) 324(5)
  • top 10 contributors:
    Heiko Tietze made 110 changes in 1 month, and 1364 changes in 1 year
    Stéphane Guillou made 87 changes in 1 month, and 532 changes in 1 year
    Ilmari Lauhakangas made 27 changes in 1 month, and 229 changes in 1 year
    Justin Luth made 22 changes in 1 month, and 114 changes in 1 year
    Eyal Rozenberg made 18 changes in 1 month, and 247 changes in 1 year
    Kelemen, Gabor made 18 changes in 1 month, and 24 changes in 1 year
    Bogdan B made 15 changes in 1 month, and 111 changes in 1 year
    Balazs Varga made 14 changes in 1 month, and 14 changes in 1 year
    Roman Kuznetsov made 6 changes in 1 month, and 123 changes in 1 year
    Dieter made 5 changes in 1 month, and 233 changes in 1 year
  • [Bug 157605] Table rows are split into several lines when copying the table
    from Writer to a plain text program
  • [Bug 157788] Saving the “Show navigation panel” setting for a device
  • [Bug 157747] Calc select all rows and columns corner should hint at its function
  • [Bug 157716] Rename “Language settings” to “Language and Locale”
  • [Bug 148023] Numbering list tooltips doesn’t show correct content for
    non-Latin locale
  • [Bug 157681] Add an opportunity to hide any file (but not to delete it) in
    master document like a slide in a presentation
  • [Bug 157420] Allow setting a default Date and Time subtype (fixed vs non-fixed)
    and format so they can be inserted with shortcuts
    → + [Bug 157649] Dialog button accelerators should work without Alt key on Windows
  • [Bug 157627] Paste number format only

• Crash Testing (Caolan)

  • 6(-6) import failure, 0(+0) export failures

    new run underway that includes mstahl’s latest fix

  • 1 coverity issues

    parse issue, some trickiness with std::pair and new _ustr (maybe)

  • 1 ossfuzz issue

    one timeout

• Crash Reporting (Xisco)

  • 7.5.6.2 2328 (+245)
  • 7.5.7.1 1190 (+371)
  • 7.6.0.3 12800 (+673)
  • 7.6.1.2 6140 (+394)
  • 7.6.2.1 4348 (+1292)

  Regressions / new in 7.6 branch

  • Reports for signature: SwNodeIndex::SwNodeIndex(SwNode *)

  • Reports for signature: static bool cppu::idefaultConstructElements(struct _sal_Sequence * *, struct _typelib_TypeDescriptionReference *, long, long, long)

  • Reports for signature: vcl::PDFWriterImpl::initStructureElement(long,vcl::PDFWriter::StructElement,std::basic_string_view<char16_t,std::char_traits<char16_t> >)

  • Introduced with 07d790ca473cd6e71f0343419b819fa6b485dc01?

• Mentoring (Hossein)
  committer… 1 week 1 month 3 months 12 months
  open 52(-9) 83(-16) 142(-15) 199(-17)
  reviews 332(18) 986(34) 3306(58) 11650(32)
  merged 244(18) 909(62) 2949(32) 12751(33)
  abandoned 24(18) 42(14) 156(15) 651(12)
  own commits 177(26) 638(64) 2065(28) 9700(-1)
  review commits 64(17) 206(32) 626(8) 3037(-13)
  contributor… 1 week 1 month 3 months 12 months
  open 41(22) 70(5) 103(5) 138(12)
  reviews 704(70) 2224(128) 6898(80) 30542(-10)
  merged 16(8) 48(8) 178(-7) 2033(-37)
  abandoned 7(2) 37(3) 211(7) 619(4)
  own commits 21(5) 74(8) 206(-2) 1098(-9)
  review commits 0(0) 0(0) 0(0) 0(0)

  • easyHack statistics:
    needsDevEval 8(8) needsUXEval 1(1) cleanup_comments 319(319)
    total 398(398) assigned 20(20) open 353(353)
  • top 10 contributors:
    Bogdan B made 6 patches in 1 month, and 100 patches in 1 year
    Stéphane Guillou made 6 patches in 1 month, and 37 patches in 1 year
    Ankit Kumar Jaipuriar made 5 patches in 1 month, and 5 patches in 1 year
    Priyadarshi, Apurva made 2 patches in 1 month, and 2 patches in 1 year
    Srebotnjak, Martin made 2 patches in 1 month, and 20 patches in 1 year
    Hannah Meeks made 2 patches in 1 month, and 5 patches in 1 year
    Omkar Acharekar made 2 patches in 1 month, and 6 patches in 1 year
    Darshan Upadhyay made 2 patches in 1 month, and 3 patches in 1 year
    Mihai Vasiliu made 2 patches in 1 month, and 2 patches in 1 year
    Khushi Gautam made 2 patches in 1 month, and 2 patches in 1 year
  • top 10 reviewers:
    Caolán McNamara made 142 review comments in 1 month, and 624 in 1 year
    Xisco Fauli made 110 review comments in 1 month, and 776 in 1 year
    Michael Stahl made 90 review comments in 1 month, and 1156 in 1 year
    Ilmari Lauhakangas made 80 review comments in 1 month, and 430 in 1 year
    Nabet, Julien made 54 review comments in 1 month, and 960 in 1 year
    Vajna, Miklos made 54 review comments in 1 month, and 898 in 1 year
    Grandin, Noel made 50 review comments in 1 month, and 584 in 1 year
    Kaganski, Mike made 46 review comments in 1 month, and 384 in 1 year
    Hossein made 34 review comments in 1 month, and 270 in 1 year
    Patrick Luby made 26 review comments in 1 month, and 86 in 1 year
  • big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
    Khushi Gautam dpskhu13108@gmail.com
    Federico Gallo
    Joel Puronaho
    Martin Gube
    Matthew Kogan (Epoq)
  • this week, tried to focus on finalize the submission / review of newcomers

    • review it faster

    • discussed with Ilmari

      • some of the easy hacks are suggested to many people

        • it’s good to have many details for such tasks / blog post

      • tried to make the UNO API error improvement easy hack easier to understand → describe it more, make it more obvious

      • UNO API error reporting - LibreOffice Development Blog

      • first it looks easy, then actually reproducing the exception throwing is harder

      • will expand on this & publish it later

      • hope this will be helpful

      • another easy hack that is related to picking data types instead of sal_uLong

        • needs explanation

        • it’s far from obvious what is the replacement

        • have some details to explain this, in a blog post

      • hope to finalize the blog post & publish it in the next few days

• Commit Access

  • None

• Developer Certification (Stephan/Miklos/Thorsten/László)

  • resting since: 3 weeks (limit: 20 weeks)

• Jenkins / CI update (Cloph)
  gerrit_android_aarch64 jobs: 149 ok: 142 ko: 1 fail ratio: 0.67% mean_ok: 11 ( 15) median_ok: 8 ( 12)
  gerrit_android_arm jobs: 148 ok: 142 ko: 4 fail ratio: 2.70% mean_ok: 12 ( 16) median_ok: 9 ( 12)
  gerrit_android_x86 jobs: 149 ok: 144 ko: 1 fail ratio: 0.67% mean_ok: 10 ( 14) median_ok: 7 ( 11)
  gerrit_android_x86_64 jobs: 149 ok: 145 ko: 3 fail ratio: 2.01% mean_ok: 13 ( 17) median_ok: 9 ( 12)
  gerrit_linux_clang_dbgutil jobs: 309 ok: 243 ko: 54 fail ratio: 17.48% mean_ok: 47 ( 50) median_ok: 41 ( 45)
  gerrit_linux_gcc_release jobs: 374 ok: 290 ko: 63 fail ratio: 16.84% mean_ok: 27 ( 30) median_ok: 19 ( 22)
  gerrit_mac jobs: 304 ok: 258 ko: 26 fail ratio: 8.55% mean_ok: 54 ( 54) median_ok: 46 ( 47)
  gerrit_windows jobs: 396 ok: 245 ko: 129 fail ratio: 32.58% mean_ok: 67 ( 76) median_ok: 64 ( 68)
  gerrit_master_ml jobs: 419 ok: 206 ko: 167 fail ratio: 39.86% mean_ok: 101 (101) median_ok: 95 ( 95)
  gerrit_master jobs: 39 ok: 25 ko: 10 fail ratio: 25.64% mean_ok: 85 ( 85) median_ok: 84 ( 84)
  gerrit_master_seq jobs: 376 ok: 181 ko: 153 fail ratio: 40.69% mean_ok: 103 (103) median_ok: 97 ( 97)

  • https://dev-www.libreoffice.org/tmp/gerrit_231019.html
  • tests that failed more than twice in last seven days
    3 CppunitTest_sc_subsequent_filters_test3 gerrit_windows
    3 CppunitTest_sw_mailmerge gerrit_windows
    4 Killed by the kill-wrapper gerrit_linux_clang_dbgutil
    4 Killed by the kill-wrapper gerrit_linux_clang_dbgutil_branch
    4 CppunitTest_editeng_core gerrit_linux_gcc_release
    4 CppunitTest_sw_ooxmlexport17 gerrit_mac
    5 CppunitTest_filter_svg gerrit_mac
    6 CppunitTest_sw_uiwriter6 gerrit_mac
    11 UITest_sw_navigator gerrit_linux_clang_dbgutil
  • this week was a good week (Cloph)
    • especially regarding the failures related to the kill wrapper
    • other failures: nothing to worry about, these mostly caught real breakage
    • filter_svg and sw_uiwriter6 are in this category
    • sw_navigator: more unstable parts are now disabled, thanks to Noel
      • wonder if these problems are caused by the one process execution (Xisco)
      • will give it a try and see if it helps

• What’s cooking (Miklos)

  • Multi-page floating tables in Writer, see tdf#157119 for details (Miklos)

    • overflow mechanism for columns (Heiko)
      • related bug: tdf#157301
      • WF’ed since possible with Calc
        • think Word doesn’t have this feature
        • think possible in ODF

  • JDK bump to 17 (Michael W)

    • all done by now
    • thanks to Cloph for updating some last builders

  • A11y update (Michael W)

    • Windows: switch a11y text attributes from custom ones to IAccessible2

      attributes and support spelling error reporting (tdf#157696)

      • original goal is reached, now looking at some smaller cornercases

      • fix for sporadic gtk3 a11y test failures:

        Diff - ca01deadcbc480b6e79618b227a2b73a61ecb7ff^! - core - Gitiles

  • ItemSet rework (Michael S)

    • next change is up on gerrit, Armin is debugging the detected problems

• QA update (Xisco)

  • UNCONFIRMED: 1053 (-44)

    • enhancements: 258 (-10)
    • needsUXEval: 8 (-15)
    • haveBackTrace: 10 (+0)
    • needsDevAdvice: 35 (-1)
    • documentation: 2 (+0)
    • android: 0 (+0)
    • iOS: 0 (+0)
    • Online: 11 (+0)

  • Most pressing bugs:
    New:

  • LibreOffice 7.6 stalls/crashes under Windows 11 with Norwegian locale when opening file dialog

      + https://bugs.documentfoundation.org/show_bug.cgi?id=157135
      + Windows update suspected https://bugs.documentfoundation.org/show_bug.cgi?id=157135#c19
      + it's also mentioned on Windows 10, but they also reported differences there, depends on the exact sub-version (Ilmari)
      + tried to test it with the reported locale, can't reproduce so far
      + the bugreport has some more details
      + also tested internal vs system file pickers (Ilmari)
    

  • New high severity bugs of the week:

    • [EPUB] SVG images are rendered duplicated

      • 119112 – [EPUB] SVG images are rendered duplicated
      • not a regression

    • Cross-reference a formula does not work since 7.6x

      • 157287 – Cross-reference a formula does not work since 7.6x
      • bisected to Matti
      • he’s working on a fix, thanks.

    • .uno:InsertTimeField and .uno:InsertDateField now insert variable time and date fields respectively instead the fixed variants, breaking macros

      • 157337 – .uno:InsertTimeField and .uno:InsertDateField now insert variable time and date fields respectively instead the fixed variants, breaking macros
      • revert submitted by Heiko: https://gerrit.libreoffice.org/c/core/+/158041
        • in the meantime some test started to depend on the new behavior (Heiko)
        • will investigate

• QA stats (Stéphane)

  • Interesting consolidated bugs of the week:

    • right-click on right half of last character in selection loses the selection (Writer): 111969 – right-click on right half of last character in selection loses the selection (Writer)
    • Character highlighting sometimes hides / cuts off adjacent glyphs / characters because it is drawn in front: 43643 – Character highlighting sometimes hides / cuts off adjacent glyphs / characters because it is drawn in front
    • 48015 – Option to export all pages / slides from Drawing / Presentation modules as bitmap (PNG, JPG...) “Option to export all pages / slides from Drawing / Presentation modules as bitmap (PNG, JPG…)”
      • similar to the “export presentation as svg”, but that’s not easy to use (not obvious all slides have to be selected prior)

  • QA Dashboard data updated: TDF QA Dashboard

    • Aggregate ranking integrates feedback from LibOCon

  • Weekly Bug Summary
    +115 -7 (-167) overall)
    many thanks to the top bug squashers:
    Stéphane Guillou (stragu) 29
    QA Administrators 26
    Buovjaga 21
    Heiko Tietze 11
    Mike Kaganski 11
    Justin L 9
    Werner Tietz 6
    m.a.riosv 5
    Kira Tubo 4
    Dieter 3

  • top 10 bugs reporters:
    Gerald Pfeifer 5
    Gabor Kelemen (allotropia) 4
    Tracey 3
    Xisco Faulí 3
    Amin Irgaliev 2
    Justin L 2
    Mike Kaganski 2
    Elmar 1
    Hector 1
    Michael Tsang 1

  • top 10 bugs fixers:
    Justin Luth 6
    Kaganski, Mike 4
    Grandin, Noel 3
    Jim Raykowski 3
    Németh, László 2
    Patrick Luby 2
    Rafael Lima 2
    Rathke, Eike 2
    Roman Kuznetsov 2
    Balazs Varga 1

  • top 10 bugs confirmers:
    Stéphane Guillou 36
    m.a.riosv 19
    Heiko Tietze 11
    Ilmari Lauhakangas 7
    Dieter 6
    Alex Thurgood 3
    Kira Tubo 3
    Nabet, Julien 3
    Raal 3
    Xisco Fauli 3

• Bisected bugs open: keyword ‘bisected’

  • more accurate - down to a single commit.
  • Bug List: LibreOffice Bi-bisected

  done by:
     Bogdan B               5
     Kira Tubo              5
     Stéphane Guillou       5
     Xisco Fauli            3
     Raal                   2
     Ilmari Lauhakangas     1
     Juan C. Sanz           1
     Kelemen, Gabor         1
  

• Bibisected bugs open: keyword ‘bibisected’

  • Bug List: LibreOffice Bi-bisected

  done by:
     Bogdan B               5
     Kira Tubo              5
     Stéphane Guillou       4
     Xisco Fauli            3
     Raal                   2
     Aron Budea             1
     Ilmari Lauhakangas     1
     Juan C. Sanz           1
     Kelemen, Gabor         1
  

• all bugs tagged with ‘regression’

  • 1227(-1) bugs open of 12911(+23) total 14(+0) high prio.

    done by:
    Stéphane Guillou 8
    Kira Tubo 6
    Xisco Fauli 4
    Raal 2
    Ilmari Lauhakangas 1
    phv 1
    m.a.riosv 1

• ~Component count net * high severity regressions

  • Bug List
    Writer - 8(+0)
    Calc - 3(+0)
    LibreOffice - 2(+0)
    UI - 1(+0)

  by OS:
  All - 9(+0)
  Linux - 3(+0)
  Mac OS X - 0(+0)
  Windows - 2(+0)

• ~Component count net * all regressions

  • Bug List
    Writer: other - 426(-3)
    Calc - 223(-1)
    Impress - 138(+1)
    LibreOffice - 51(-1)
    Draw - 48(+1)
    Crashes - 44(-1)
    Base - 42(+0)
    Writer: docx filter - 42(+0)
    UI - 37(+0)
    Borders - 35(+0)
    Writer: perf - 34(+0)
    Writer: other filter - 33(+1)
    Printing and PDF export - 26(+0)
    RTL - 24(+1)
    Chart - 22(+0)
    filters and storage - 20(+3)
    BASIC - 16(-1)
    Writer: doc filter - 15(+0)
    graphics stack - 13(+1)
    Formula Editor - 5(+0)
    framework - 4(+0)
    Extensions - 2(+0)
    sdk - 2(+0)
    Linguistic - 1(-1)