ESC meeting minutes: 2023-09-14

  • Present:

    • Gabriel, Heiko, Hossein, Ilmari, Khaled, Regina, Stephan, Miklos, Stephane, Olivier, Thorsten, Cloph, Michael S, Eike
  • Completed Action Items:

    • update the core.git README.md with the new Linux baseline (Cloph)
  • Pending Action Items:

    • Try gtk4 local builds, Qt6 local builds (Cloph)
  • Release Engineering update (Cloph)

    • 7.6 status: 7.6.2 rc1 in 1 week
      • 7.6.1 is announced as final
      • 7.6.2 rc2 in 3 weeks
    • 7.5 status: 7.5.7 rc1 in 4 weeks
      • plan to cut an additional point release in 2 weeks with just 1 RC
  • Documentation (Olivier)

    • Helpcontents2
      • Updates on UNO command in UI (ohallot)
      • fixes (stragu, B. Kosiorek, ohallot)
    • Guides
      • Work in progress.
    • Bugzilla Documentation statistics
      270(270) bugs open
    • Updates:
      BZ changes 1 week 1 month 3 months 12 months
      created 5(0) 18(1) 77(0) 298(-2)
      commented 18(5) 61(4) 261(10) 1105(1)
      resolved 0(-1) 5(0) 30(-2) 164(-3)
    • top 10 contributors:
      Olivier Hallot made 17 changes in 1 month, and 437 changes in 1 year
      Stéphane Guillou made 11 changes in 1 month, and 336 changes in 1 year
      Ilmari Lauhakangas made 9 changes in 1 month, and 111 changes in 1 year
      Heiko Tietze made 8 changes in 1 month, and 118 changes in 1 year
      Jim Avera made 5 changes in 1 month, and 5 changes in 1 year
      Kaganski, Mike made 5 changes in 1 month, and 77 changes in 1 year
      Seth Chaiklin made 5 changes in 1 month, and 306 changes in 1 year
      skierpage made 3 changes in 1 month, and 3 changes in 1 year
      steve made 3 changes in 1 month, and 14 changes in 1 year
      Mike Saunders made 3 changes in 1 month, and 4 changes in 1 year
  • UX Update (Heiko)

    • Bugzilla (topicUI) statistics
      264(264) (topicUI) bugs open, 60(60) (needsUXEval) needs to be evaluated by the UXteam
    • Updates:
      BZ changes 1 week 1 month 3 months 12 months
      added 6(-2) 15(0) 23(0) 51(-2)
      commented 73(12) 216(33) 475(25) 2380(-6)
      removed 0(0) 1(0) 2(0) 24(-3)
      resolved 10(1) 37(5) 87(7) 334(3)
    • top 10 contributors:
      Heiko Tietze made 137 changes in 1 month, and 1404 changes in 1 year
      Stéphane Guillou made 50 changes in 1 month, and 479 changes in 1 year
      Eyal Rozenberg made 30 changes in 1 month, and 317 changes in 1 year
      ady made 28 changes in 1 month, and 114 changes in 1 year
      Dieter made 25 changes in 1 month, and 257 changes in 1 year
      Bogdan B made 16 changes in 1 month, and 102 changes in 1 year
      Vernon, Stuart Foote made 16 changes in 1 month, and 404 changes in 1 year
      steve made 13 changes in 1 month, and 29 changes in 1 year
      Kaganski, Mike made 12 changes in 1 month, and 125 changes in 1 year
      Henschel, Regina made 11 changes in 1 month, and 44 changes in 1 year
    • [Bug 157208] “Find and Replace” dialog’s error notifications should be
      more noticeable, not an unformatted label in the middle
    • [Bug 156907] Writer on Mac confuses users when opening a document from
      a readonly location.
    • [Bug 156438] Apply heuristic for choosing visible language group tab when
      opening dialog
    • [Bug 156970] Revert 7.6 Style Box in Menu Bar to 7.5 Style Box in Menu Bar
    • [Bug 157178] Toolbars disappear
      → + [Bug 157038] Auto Spell Checker Prevents Cell Selection Right Click
    • [Bug 151557] Changing text direction with command .uno:ParaRightToLeft
      changes text alignment
    • [Bug 89914] UI: Bookmarks in Status Bar display differently when window
      not maximized
    • [Bug 156890] Spotlight colors hide expand/collapse arrows
      → + [Bug 157142] The formula input field and the selected cell field above the
      top of the spreadsheet should be populated at all times when the Calc
      window is available for viewing.
      + it’s all related to the input handler area, it’s module-based, not document-based (Eike)
    • removed some global options from the options dialog (Heiko)
      • removed it from the UI, the option is there, the advanced settings dialog still has it
  • Crash Testing (Caolan)

    • 13(+0) import failure, 0(+0) export failures
    • ??? coverity issues
    • Google / ossfuzz: ?? fuzzers active now
  • Crash Reporting (Xisco)

    • SalInstanceTreeView::get_drag_source()
    • Thanks to Caolán
  • Mentoring (Hossein)

    • Prepared USB sticks contents (VM/binary/source/doc) for the LibOCon 2023 workshop
    • Found a way to download/install VS modules (semi)automatically via a Layout file
      Use command-line parameters to install Visual Studio | Microsoft Learn
      • will update the wiki later (Hossein)
    • Finalized and published a blog post on dev blog
      Catalog and schema support for SQL functions - difficulty interesting EasyHack - LibreOffice Development Blog
      committer… 1 week 1 month 3 months 12 months
      open 73(-5) 125(4) 181(5) 228(7)
      reviews 370(-38) 1394(10) 3428(-48) 11562(28)
      merged 246(-45) 1064(4) 3324(-69) 12856(-9)
      abandoned 16(-8) 74(5) 148(-6) 656(2)
      own commits 183(-14) 733(29) 2188(26) 9962(-50)
      review commits 50(5) 226(14) 654(-8) 3082(7)
      contributor… 1 week 1 month 3 months 12 months
      open 26(9) 51(8) 80(12) 102(12)
      reviews 648(-72) 2824(36) 7632(-130) 31232(-144)
      merged 13(-5) 81(5) 214(-1) 2237(-65)
      abandoned 3(-5) 170(1) 189(2) 615(-3)
      own commits 13(0) 79(1) 212(-8) 1091(5)
      review commits 0(0) 0(0) 0(0) 0(0)
      • easyHack statistics:
        needsDevEval 8(8) needsUXEval 1(1) cleanup_comments 326(326)
        total 402(402) assigned 21(21) open 356(356)
      • top 10 contributors:
        Dipam Turkar made 26 patches in 1 month, and 48 patches in 1 year
        Armin Le Grand (allotropia) made 4 patches in 1 month, and 75 patches in 1 year
        Ahmed Eltokhy made 3 patches in 1 month, and 12 patches in 1 year
        Sahil Gautam made 3 patches in 1 month, and 8 patches in 1 year
        Dan Horák made 3 patches in 1 month, and 3 patches in 1 year
        Montane, Joan made 2 patches in 1 month, and 2 patches in 1 year
        NOGATA, Jun made 2 patches in 1 month, and 2 patches in 1 year
        Stéphane Guillou made 2 patches in 1 month, and 31 patches in 1 year
        Czeber László made 2 patches in 1 month, and 19 patches in 1 year
        Quentin PAGÈS made 2 patches in 1 month, and 2 patches in 1 year
      • top 10 reviewers:
        Caolán McNamara made 138 review comments in 1 month, and 478 in 1 year
        Thorsten Behrens made 132 review comments in 1 month, and 490 in 1 year
        Vajna, Miklos made 120 review comments in 1 month, and 882 in 1 year
        Nabet, Julien made 110 review comments in 1 month, and 970 in 1 year
        Vajngerl, Tomaž made 78 review comments in 1 month, and 434 in 1 year
        Michael Stahl made 78 review comments in 1 month, and 1156 in 1 year
        Kaganski, Mike made 68 review comments in 1 month, and 378 in 1 year
        Xisco Fauli made 68 review comments in 1 month, and 728 in 1 year
        Christian Lohmaier made 64 review comments in 1 month, and 404 in 1 year
        Ilmari Lauhakangas made 64 review comments in 1 month, and 382 in 1 year
      • Patches automatically abandoned:
        update hunspell dictionaries for Turkish language ( Ali Safaya )
        - https://gerrit.libreoffice.org/#/c/118649
        python3: upgrade to release 3.11.1 ( Taichi Haradaguchi )
        - https://gerrit.libreoffice.org/#/c/145054
      • big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
        Darshan Upadhyay (Collabora)
        Dung Saga
      • review bot adds reviewers even to gerrit changes for distro branches, could that be avoided? doesn’t look useful (Miklos)
        AI: ignore distro branches when adding reviewers (Xisco)
      • also changes get the reviewer from the original author, which doesn’t help for distro branches (Michael S)
        • looks like that’s a separate mechanism (Miklos)
  • GSoC (Ilmari/Thorsten)

    • done for this year (Ilmari)
    • almost :slight_smile: (Thorsten)
      • GSoC panel at the conference + blog post presenting the results
      • blog post will be published soon (Ilmari)
  • Outreachy (Ilmari)

  • Commit Access

  • Developer Certification (Stephan/Miklos/Thorsten/László)

    • resting since: 20 weeks (limit: 20 weeks)
    • Stephan reached out to some of them
  • Jenkins / CI update (Cloph)
    gerrit_android_aarch64 jobs: 138 ok: 137 ko: 1 fail ratio: 0.72% mean_ok: 7 ( 10) median_ok: 4 ( 6)
    gerrit_android_arm jobs: 139 ok: 137 ko: 1 fail ratio: 0.72% mean_ok: 6 ( 8) median_ok: 4 ( 6)
    gerrit_android_x86 jobs: 138 ok: 136 ko: 2 fail ratio: 1.45% mean_ok: 7 ( 10) median_ok: 4 ( 6)
    gerrit_android_x86_64 jobs: 139 ok: 137 ko: 1 fail ratio: 0.72% mean_ok: 6 ( 9) median_ok: 4 ( 6)
    gerrit_linux_clang_dbgutil jobs: 314 ok: 229 ko: 81 fail ratio: 25.80% mean_ok: 35 ( 36) median_ok: 34 ( 36)
    gerrit_linux_gcc_release jobs: 330 ok: 272 ko: 46 fail ratio: 13.94% mean_ok: 14 ( 16) median_ok: 13 ( 14)
    gerrit_mac jobs: 308 ok: 251 ko: 52 fail ratio: 16.88% mean_ok: 44 ( 44) median_ok: 41 ( 41)
    gerrit_windows jobs: 295 ok: 242 ko: 50 fail ratio: 16.95% mean_ok: 53 ( 56) median_ok: 47 ( 47)
    gerrit_master_ml jobs: 402 ok: 205 ko: 180 fail ratio: 44.78% mean_ok: 64 ( 64) median_ok: 60 ( 60)
    gerrit_master jobs: 34 ok: 20 ko: 12 fail ratio: 35.29% mean_ok: 49 ( 49) median_ok: 46 ( 46)
    gerrit_master_seq jobs: 357 ok: 185 ko: 158 fail ratio: 44.26% mean_ok: 65 ( 65) median_ok: 61 ( 61)

    • https://dev-www.libreoffice.org/tmp/gerrit_230914.html
    • tests that failed more than twice in last seven days
      data not plausible (stats miss build-agent info), need to check the stats generation scripts
      3 CppunitTest_sc_subsequent_filters_test4 gerrit_mac
      4 CppunitTest_chart2_uichart gerrit_linux_gcc_release
      4 CppunitTest_desktop_lib gerrit_linux_gcc_release
      4 CppunitTest_drawinglayer_processors gerrit_windows
      4 CppunitTest_sc_pivottable_filters_test gerrit_mac
      4 CppunitTest_sw_mailmerge gerrit_mac
      4 CppunitTest_sw_odfimport gerrit_linux_gcc_release
      4 CppunitTest_sw_ooxmlimport2 gerrit_linux_gcc_release
      4 CppunitTest_vcl_gtk3_a11y gerrit_linux_gcc_release
      4 UITest_math_demo gerrit_linux_clang_dbgutil
      5 CppunitTest_sw_ooxmlexport17 gerrit_mac
      6 CppunitTest_framework_dispatch gerrit_windows
      6 CppunitTest_starmath_qa_cppunit gerrit_windows
      6 UITest_calc_tests8 gerrit_linux_clang_dbgutil
      8 CppunitTest_vcl_gtk3_a11y gerrit_linux_clang_dbgutil
      8 CppunitTest_vcl_pdfexport gerrit_linux_gcc_release
      10 JunitTest_chart2_unoapi gerrit_linux_clang_dbgutil
      10 UITest_sw_fieldDialog gerrit_linux_clang_dbgutil
      18 Killed by the kill-wrapper gerrit_linux_clang_dbgutil
      35 Killed by the kill-wrapper gerrit_mac
      38 UITest_sw_navigator gerrit_linux_clang_dbgutil
      • Noel disabled some unstable navigator asserts here, should help for the next time
  • What’s cooking (Miklos)

    • C++20 (Stephan)
    • multi-page floating tables in Writer, see tdf#157119 for details (Miklos)
    • JDK bump to 17 (Michael W)
    • Right-to-left math layout and other Math improvements (Khaled)
      • continued worked on the visual editing mode
      • on by default now
      • the “source” editing mode is now hidden, so there is 1 edit window only
      • improving things for non-OpenSymbol cases
    • import of Word drawing canvas, that is wpc element (Regina)
      • made some progress
      • hit a principal problem: the drawingML and VML markup is not a superset of each other
      • see the mail just sent to the dev mailing list
    • Making MissingUnitTests more approachable for new devs (Ilmari)
      • hope to have it in the actual wiki soon
  • LibreOffice conference Bucharest 2023 (Gabriel)

    • almost finished with the preparations
    • will have 2 main rooms (workshop in parallel)
    • community section in Wed afternoon
    • main days: Thu → Sat (21st → 23rd)
    • Thu evening: dinner
    • Fri evening: hackfest
    • Gabriel will share info about the events in general
    • ask questions in the conf telegram group
    • also have a survival guide, focusing on how to reach the venue, shared by Mike
    • it’s worth having an ESC call in-person if possible (Thorsten)
      • it opens up the ESC and gives the opportunity for people to ask questions
      • it’s quite different to the usual schedule
      • good to have a wider perspective
      • best to ask the organizers to give us a timelost (Thorsten)
        AI: ask for a slot (Gabriel)
    • can schedule something (Gabriel)
  • QA update (Xisco)

    • UNCONFIRMED: 1168 (-34)

      • enhancements: 282 (+1)
      • needsUXEval: 8 (-3)
      • haveBackTrace: 12 (-1)
      • needsDevAdvice: 34 (-2)
      • documentation: 3 (+0)
      • android: 0 (+0)
      • iOS: 0 (+0)
      • Online: 11 (-1)
    • Most pressing bugs:
      New:

    None

  • QA stats (Stéphane)

    • Weekly Bug Summary
      +110 +0 (-129) overall)
      many thanks to the top bug squashers:
      Stéphane Guillou (stragu) 20
      Buovjaga 10
      QA Administrators 10
      Xisco Faulí 8
      Heiko Tietze 7
      Julien Nabet 7
      Michael Weghorn 5
      Mike Kaganski 5
      ⁨خالد حسني⁩ 5
      Justin L 4

    • top 10 bugs reporters:
      Jim Avera 5
      Jeff Fortin Tam 4
      Mike Kaganski 4
      Regina Henschel 4
      Xisco Faulí 4
      Gabor Kelemen (allotropia) 3
      Adrián L. 2
      Faisal 2
      NicolasC 2
      Rafael Lima 2

    • top 10 bugs fixers:
      Nabet, Julien 4
      Weghorn, Michael 4
      خالد حسني 4
      Stéphane Guillou 3
      Xisco Fauli 3
      Andreas Heinisch 2
      Caolán McNamara 2
      Grandin, Noel 2
      Heiko Tietze 2
      Kaganski, Mike 2

    • top 10 bugs confirmers:
      Stéphane Guillou 24
      Xisco Fauli 21
      Ilmari Lauhakangas 16
      m.a.riosv 11
      Heiko Tietze 6
      Dieter 5
      Nabet, Julien 4
      Faisal 3
      Kaganski, Mike 3
      Weghorn, Michael 3

  • Bisected bugs open: keyword ‘bisected’

    done by:
       Stéphane Guillou       6
       Xisco Fauli            4
       Kelemen, Gabor         2
       Ilmari Lauhakangas     1
       Justin Luth            1
       Weghorn, Michael       1
       Kaganski, Mike         1
       Raal                   1
    
  • Bibisected bugs open: keyword ‘bibisected’

    done by:
       Stéphane Guillou       6
       Xisco Fauli            4
       Kelemen, Gabor         2
       Ilmari Lauhakangas     1
       Justin Luth            1
       Weghorn, Michael       1
       Kaganski, Mike         1
       Raal                   1
    
  • all bugs tagged with ‘regression’

    • 1187(+10) bugs open of 12785(+29) total 14(+2) high prio.

      done by:
      Stéphane Guillou 8
      Xisco Fauli 4
      Kelemen, Gabor 2
      Kira Tubo 2
      m.a.riosv 2
      Andreas Heinisch 1
      Bogdan B 1
      Ilmari Lauhakangas 1
      Justin Luth 1
      Weghorn, Michael 1

  • ~Component count net * high severity regressions

    • Bug List
      Writer - 9(+1)
      Calc - 3(+0)
      LibreOffice - 1(+0)
      Printing and PDF export - 1(+1)

    by OS:
    All - 10(+2)
    Linux - 2(+0)
    Mac OS X - 0(+0)
    Windows - 2(+0)

  • ~Component count net * all regressions

    • Bug List
      Writer: other - 415(+7)
      Calc - 222(+4)
      Impress - 131(+2)
      LibreOffice - 49(-1)
      Crashes - 45(+0)
      Draw - 44(+0)
      Base - 42(+0)
      Writer: docx filter - 41(+0)
      Borders - 36(+2)
      Writer: perf - 33(+0)
      UI - 32(+0)
      Writer: other filter - 31(+0)
      Printing and PDF export - 24(+1)
      RTL - 23(+0)
      Chart - 22(+0)
      BASIC - 17(-1)
      filters and storage - 17(+1)
      Writer: doc filter - 15(+0)
      graphics stack - 12(-2)
      Formula Editor - 4(+0)
      framework - 4(+0)
      Extensions - 2(+0)
      sdk - 2(+0)
      Linguistic - 1(+0)