ESC meeting minutes: 2023-09-07

projects
#1

  • Present:

    • Caolan, Heiko, Hossein, Olivier, Cloph, Ilmari, Khaled, Michael W, Regina, Stephan, Miklos, Stephane, Thorsten, Gabriel, Xisco

  • Completed Action Items:

    • try to switch from clang to gcc for the CI ML job as an experiment (Cloph)

  • Pending Action Items:

    • Try gtk4 local builds, Qt6 local builds (Cloph)
    • update the core.git README.md with the new Linux baseline (Cloph)

  • Release Engineering update (Cloph)

    • 7.6 status: 7.6.1 rc2 was tagged yesterday, builds are in progress
    • 7.5 status:
      • 7.5.6 was announced as final earlier today
      • 7.5.7 in 5 weeks

  • Documentation (Olivier)

    • Helpcontents2

      • More housekeeping (ohallot)
        • orphan pages (no UNO command)
        • dual UNO commands
        • No HID binded to UNO command
        • no page for UNO command (404 error)
          • creating a page for these
          • if the command is not clear, then a warning on the incompleteness
          • could create a wiki page on the UNO commands that are known (Hossein)
          • the list is pretty large (Olivier)
      • Updates and fixes (S. Chaiklin, stragu)

    • Guides

      • Work in progress

    • Bugzilla Documentation statistics
      268(268) bugs open

    • Updates:
      BZ changes 1 week 1 month 3 months 12 months
      created 5(-3) 17(-12) 77(1) 300(-8)
      commented 13(-2) 57(-27) 251(4) 1104(4)
      resolved 1(0) 5(-7) 32(1) 167(-5)

    • top 10 contributors:
      Olivier Hallot made 21 changes in 1 month, and 443 changes in 1 year
      Stéphane Guillou made 10 changes in 1 month, and 329 changes in 1 year
      Heiko Tietze made 8 changes in 1 month, and 118 changes in 1 year
      Wolfgang Jäger made 6 changes in 1 month, and 6 changes in 1 year
      Seth Chaiklin made 5 changes in 1 month, and 306 changes in 1 year
      Ilmari Lauhakangas made 4 changes in 1 month, and 110 changes in 1 year
      Kaganski, Mike made 4 changes in 1 month, and 76 changes in 1 year
      Bogdan B made 3 changes in 1 month, and 225 changes in 1 year
      Leroy made 3 changes in 1 month, and 6 changes in 1 year
      skierpage made 3 changes in 1 month, and 3 changes in 1 year

  • UX Update (Heiko)

    • Bugzilla (topicUI) statistics
      264(264) (topicUI) bugs open, 61(61) (needsUXEval) needs to be evaluated by the UXteam
    • Updates:
      BZ changes 1 week 1 month 3 months 12 months
      added 8(0) 15(5) 23(1) 53(0)
      commented 61(-5) 183(11) 450(-10) 2386(-35)
      removed 0(0) 1(0) 2(-1) 27(0)
      resolved 9(3) 32(6) 80(2) 331(1)
    • top 10 contributors:
      Heiko Tietze made 122 changes in 1 month, and 1436 changes in 1 year
      Stéphane Guillou made 66 changes in 1 month, and 480 changes in 1 year
      Eyal Rozenberg made 65 changes in 1 month, and 358 changes in 1 year
      Dieter made 16 changes in 1 month, and 246 changes in 1 year
      Kaganski, Mike made 14 changes in 1 month, and 130 changes in 1 year
      Henschel, Regina made 14 changes in 1 month, and 47 changes in 1 year
      Leroy made 10 changes in 1 month, and 15 changes in 1 year
      Bogdan B made 9 changes in 1 month, and 95 changes in 1 year
      Davide made 9 changes in 1 month, and 13 changes in 1 year
      Seth Chaiklin made 9 changes in 1 month, and 77 changes in 1 year
    • [Bug 157116] Pre-calculating formulae as they are entered
    • [Bug 157114] The popup “Search Commands” should also search by submenu
      (such as Align Text, Track Changes)
    • [Bug 157098] No visual indication of non-character paragraph-style
      direct formatting
    • [Bug 157104] Support partial visibility of tracked changes (at least
      like MS Word)
    • [Bug 157105] Support tracking changes to style choices
    • [Bug 157081] Tabs in Ruler not showing correctly
    • [Bug 156804] Text inserted from autotext doesn’t show the set number of paragraph
    • [Bug 157052] When showing a changes bar for style changes, list them
      in a popup when hovering over it
    • [Bug 157025] List presets should include an option with a dash “-”
    • [Bug 152656] “Drawing Style” should be renamed “Drawing Object Style”
      or “Shape Style”
    • [Bug 157036] libreoffice portable V7.6 calc program can not achieve the
      following function insert->filed(date, sheet name, document_title)

  • Crash Testing (Caolan)

    • 13(-1) import failure, 0(+0) export failures
    • 0 coverity issues
    • 1 ossfuzz issue
      • one timeout

  • Crash Reporting (Xisco)

    => will see the effect of both in 7.6.2

    • Regression from 7.3

  • Mentoring (Hossein)

    • New draft blog post
      Catalog and schema support for SQL functions - difficulty interesting EasyHack
      Catalog and schema support for SQL functions - difficulty interesting EasyHack - LibreOffice Development Blog
    • Finalized and published 2 previous difficulty Interesting EasyHacks
    • Not all difficulty interesting EasyHack have code pointers
      • what to do with these?
      • the issue is there, but it’s not an easy hack this way
      • suggest to ask the person who added the flag (Heiko, Xisco)

        • plan: remove the tag + ask for “dev eval” + can be added back later with code pointers

        • will also ask the person adding the flag to provide the code pointer

          committer… 1 week 1 month 3 months 12 months
          open 78(9) 121(2) 176(-8) 221(-3)
          reviews 408(-110) 1384(-20) 3476(166) 11534(112)
          merged 291(21) 1060(-10) 3393(53) 12865(38)
          abandoned 24(7) 69(11) 154(11) 654(10)
          own commits 197(51) 704(35) 2162(62) 10012(-46)
          review commits 45(-35) 212(5) 662(18) 3075(-12)
          contributor… 1 week 1 month 3 months 12 months
          open 17(-3) 43(-5) 68(-7) 90(-6)
          reviews 720(-30) 2788(-56) 7762(24) 31376(-184)
          merged 18(-29) 76(5) 215(5) 2302(-87)
          abandoned 8(5) 169(6) 187(6) 618(2)
          own commits 13(-25) 78(3) 220(-2) 1086(-6)
          review commits 0(0) 0(0) 0(0) 0(0)

      • easyHack statistics:
        needsDevEval 8(8) needsUXEval 1(1) cleanup_comments 328(328)
        total 403(403) assigned 19(19) open 357(357)
      • top 10 contributors:
        Dipam Turkar made 26 patches in 1 month, and 48 patches in 1 year
        Sahil Gautam made 4 patches in 1 month, and 7 patches in 1 year
        Armin Le Grand (allotropia) made 4 patches in 1 month, and 76 patches in 1 year
        Ahmed Eltokhy made 3 patches in 1 month, and 12 patches in 1 year
        NOGATA, Jun made 2 patches in 1 month, and 2 patches in 1 year
        Stéphane Guillou made 2 patches in 1 month, and 29 patches in 1 year
        Czeber László made 2 patches in 1 month, and 19 patches in 1 year
        Quentin PAGÈS made 2 patches in 1 month, and 2 patches in 1 year
        Adam Seskunas made 2 patches in 1 month, and 2 patches in 1 year
        Ismael Olea made 2 patches in 1 month, and 2 patches in 1 year
      • top 10 reviewers:
        Caolán McNamara made 134 review comments in 1 month, and 458 in 1 year
        Vajna, Miklos made 126 review comments in 1 month, and 882 in 1 year
        Michael Stahl made 112 review comments in 1 month, and 1152 in 1 year
        Thorsten Behrens made 108 review comments in 1 month, and 468 in 1 year
        Nabet, Julien made 106 review comments in 1 month, and 976 in 1 year
        Vajngerl, Tomaž made 102 review comments in 1 month, and 430 in 1 year
        Kaganski, Mike made 76 review comments in 1 month, and 388 in 1 year
        Christian Lohmaier made 76 review comments in 1 month, and 432 in 1 year
        Xisco Fauli made 70 review comments in 1 month, and 762 in 1 year
        Grandin, Noel made 64 review comments in 1 month, and 588 in 1 year
      • big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
        Adam Fallon
        Adam Seskunas
        Bayram Çiçek
        Dan Horák
        Li Yang

  • GSoC (Ilmari/Thorsten)

  • Outreachy (Ilmari)

    • https://www.outreachy.org/ – Applied with two intern slots
    • Mentor sign up deadline September 29: looking for mentors
      • LibreOffice: Call for Outreachy mentors and volunteers
      • if you have time to mentor & idea: please speak up now
      • projects are marked for difficulty (Heiko)
        • what project can we offer for beginners?
      • document lots of UNO command, would that fit? (Hossein)
        • they don’t have to be programming (Ilmari)
      • something separate / extension could be nice as a first project (Hossein)
        • but there is no agreement that’s a good first step
    • Project timeline is Dec → March

  • Commit Access

  • Developer Certification (Stephan/Miklos/Thorsten/László)

    • resting since: 20 weeks (limit: 20 weeks)
    • Miklos did a bit of research who could be candidates
    • Stephan will reach out to some of them

  • Jenkins / CI update (Cloph)
    gerrit_android_aarch64 jobs: 133 ok: 131 ko: 0 fail ratio: 0.00% mean_ok: 6 ( 8) median_ok: 4 ( 4)
    gerrit_android_arm jobs: 134 ok: 132 ko: 0 fail ratio: 0.00% mean_ok: 7 ( 8) median_ok: 5 ( 6)
    gerrit_android_x86 jobs: 133 ok: 132 ko: 0 fail ratio: 0.00% mean_ok: 6 ( 7) median_ok: 4 ( 6)
    gerrit_android_x86_64 jobs: 134 ok: 132 ko: 0 fail ratio: 0.00% mean_ok: 6 ( 8) median_ok: 4 ( 6)
    gerrit_linux_clang_dbgutil jobs: 369 ok: 229 ko: 121 fail ratio: 32.79% mean_ok: 37 ( 38) median_ok: 31 ( 34)
    gerrit_linux_gcc_release jobs: 284 ok: 255 ko: 20 fail ratio: 7.04% mean_ok: 15 ( 16) median_ok: 13 ( 13)
    gerrit_mac jobs: 299 ok: 239 ko: 53 fail ratio: 17.73% mean_ok: 44 ( 45) median_ok: 41 ( 41)
    gerrit_windows jobs: 279 ok: 227 ko: 40 fail ratio: 14.34% mean_ok: 57 ( 64) median_ok: 47 ( 49)
    gerrit_master_ml jobs: 427 ok: 200 ko: 197 fail ratio: 46.14% mean_ok: 82 ( 82) median_ok: 73 ( 74)
    gerrit_master jobs: 43 ok: 19 ko: 18 fail ratio: 41.86% mean_ok: 57 ( 57) median_ok: 47 ( 47)
    gerrit_master_seq jobs: 381 ok: 181 ko: 176 fail ratio: 46.19% mean_ok: 84 ( 84) median_ok: 76 ( 76)

    • https://dev-www.libreoffice.org/tmp/gerrit_230907.html
    • test that failed more than twice in last seven days:
      4 CppunitTest_sw_ooxmlexport17 gerrit_mac
      4 JunitTest_starmath_unoapi gerrit_linux_clang_dbgutil
      4 PythonTest_pyuno_pytests_testcollections gerrit_linux_clang_dbgutil
      4 PythonTest_sw_python gerrit_linux_clang_dbgutil
      5 CppunitTest_chart2_import gerrit_mac
      6 Killed by the kill-wrapper gerrit_linux_clang_dbgutil_branch
      6 CppunitTest_sc_statistical_functions_test gerrit_windows
      6 CppunitTest_sw_mailmerge2 gerrit_windows
      6 CppunitTest_vcl_gtk3_a11y gerrit_linux_clang_dbgutil
      6 CppunitTest_vcl_gtk3_a11y gerrit_linux_gcc_release
      6 JunitTest_chart2_unoapi gerrit_linux_clang_dbgutil
      6 UITest_sw_fieldDialog gerrit_linux_clang_dbgutil
      7 CppunitTest_sc_pivottable_filters_test gerrit_mac
      8 UITest_calc_tests8 gerrit_linux_clang_dbgutil
      8 UITest_cui_tabpages gerrit_linux_clang_dbgutil

    → it seems it was introduced recently. ( first failure: Sep 01 )

    11 CppunitTest_framework_dispatch                gerrit_windows
28 Killed by the kill-wrapper                gerrit_linux_clang_dbgutil
34 UITest_math_demo                gerrit_linux_clang_dbgutil

    -> Should be fixed with ee187f6ed7873f3ebc1f845a4384a84713be1e9c. Thanks to Khaled

37 Killed by the kill-wrapper                gerrit_mac
38 UITest_sw_navigator                gerrit_linux_clang_dbgutil
-> it seems it was introduced recently. ( first failure: Aug 29 )
+ Noel disabled one of the failing asserts
    • looks bad, but the main problematic tests are already fixed (Cloph)
      • UITest_sw_navigator failure happens inside VMs only, interestingly
    • main problem: build gets stuck, that’s still unresolved (Cloph)
    • how much time is needed before a build is marked as “timed out”? (Hossein)
      • Gerrit Mac #153303 Console [Jenkins] says 1 test failed but it took 5-10 minutes to get marked as failed (Hossein)
      • that was a bug in the kill-wrapper handling (Cloph)
        → kill wrapper itself took too long to sample data, so it was terminated by the overall job’s timeout
      • fixed now
    • timeout is 20 mins to kill the build (when there is no output)
      • isn’t that too much? (Hossein)
      • hard to detect, we just look at the build output (Cloph)
      • would it be possible to add timestamps to the logs? (Hossein)
      • not sure if it’ll be really helpful (Cloph)
      • make -O makes the output not helpful for timestamps
      • it would be interesting to tune that timeout value (Hossein)
      • where to inject the timestamp? (Cloph)
        • build? jenkins? (Cloph)
        • whatever is the easist (Hossein)
          • Will research and report back (Hossein)
      • wasm builder is failing for a while now:
        lo_daily_tb_linux_wasm [Jenkins]
        error: ‘chart::AccessibleChartView’ is an incomplete type in file /home/jenkins/workspace/lo_gerrit/tb/src_wasm/chart2/source/controller/main/ChartController.cxx
        • it’s not reported to the mailing list? (Stephan)
          • yes, it’s silent for now (Cloph)
        • tb platform status – everything else is green (Miklos)

  • What’s cooking (Miklos)

    • C++20 (Stephan)

    • multi-page floating tables in Writer, see tdf#157119 for details (Miklos)

    • JDK bump to 17 (Michael W)

      • waiting for JDK 17 to be installed on builders

        • the Linux builders should have it installed by now

          • adapted distro-configs to use JDK 17:

    • https://gerrit.libreoffice.org/c/core/+/155377 → merged

    • but at least not all Windows builders have it:

        + https://gerrit.libreoffice.org/c/core/+/155827 -> pending

  + will check (Cloph)

    • Right-to-left math layout and other Math improvements (Khaled)

      • Patches landed on master
      • Visual/inline editing mode is now on by default with an option to turn it on/off
      • Fixed a few issues with visual editing

    • a11y (Michael W)

      • fixed various crashes (like tdf#156683, tdf#157092, tdf#157088)
      • made multi line edit accessible (used in update dialog, tdf#104833)
      • fix for issue with odd NVDA announcement in print dialog

    • import of Word drawing canvas, that is wpc element (Regina)
      https://gerrit.libreoffice.org/c/core/+/156629

      • started with the import of this
      • currently we use a fallback, which is VML → terrible :slight_smile:
      • e.g. theme colors, multi-color gradients, etc missing
      • wpc → should go via drawingML
      • problem is: our connectors are different from what PowerPoint has
      • ink is a bitmap in the fallback, but real markup in the primary case
        • no solution for that yet
        • ideas are welcome how to overcome this difficulty
      • feedback is appreciated

    • Making MissingUnitTests more approachable for new devs (Ilmari)

  • LibreOffice conference Bucharest 2023 (Gabriel)

    • in 2 weeks
    • last call for registration (Gabriel)
    • ~20 speakers didn’t register
      • if you travel to the conf, PLEASE register
      • how can we see if the registration happened? (Regina)
        • Gabriel can help with answering

  • QA update (Xisco)

    • UNCONFIRMED: 1202 (-24)

      • enhancements: 281 (-2)
      • needsUXEval: 11 (+0)
      • haveBackTrace: 13 (-2)
      • needsDevAdvice: 36 (+0)
      • documentation: 3 (-1)
      • android: 0 (-3)
      • iOS: 0 (+0)
      • Online: 12 (+0)

    • Most pressing bugs:
      New:

    None

    • New high severity bugs of the week:
      None

  • QA stats (Stéphane)

    • Some focus:

      • Calc bitmap export of selection
      • (future) chart styles / document themes

    • Updated data on Dashboard: TDF QA Dashboard

    • Monthly QA/Dev report: QA/Dev Report: August 2023 - LibreOffice QA Blog

    • Weekly summary: Weekly Bug Summary
      +110 +19 (-120) overall)
      many thanks to the top bug squashers:
      QA Administrators 13
      Buovjaga 10
      Heiko Tietze 9
      Stéphane Guillou (stragu) 9
      m.a.riosv 7
      Julien Nabet 6
      Samuel Mehrbrodt (allotropia) 6
      Michael Weghorn 4
      Dieter 3
      Sarper Akdemir (allotropia) 3

    • top 10 bugs reporters:
      Eyal Rozenberg 8
      Xisco Faulí 5
      Telesto 4
      Michael Weghorn 3
      Regina Henschel 3
      peter josvai 3
      steve 3
      Gabor Kelemen (allotropia) 2
      Heiko Tietze 2
      Hossein 2

    • top 10 bugs fixers:
      Samuel Mehrbrodt 4
      Nabet, Julien 3
      Sarper Akdemir 3
      Weghorn, Michael 3
      Czeber László 2
      Henschel, Regina 2
      Nagy Tibor 2
      Thorsten Behrens (CIB) 2
      Vajna, Miklos 2
      خالد حسني 2

    • top 10 bugs confirmers:
      Stéphane Guillou 20
      Ilmari Lauhakangas 15
      m.a.riosv 10
      Dieter 8
      Nabet, Julien 7
      Heiko Tietze 6
      Weghorn, Michael 6
      Xisco Fauli 6
      Kira Tubo 4
      Bogdan B 2

  • Bisected bugs open: keyword ‘bisected’

    done by:
   Xisco Fauli            5
   Stéphane Guillou       4
   Ilmari Lauhakangas     1
   Timur                  1

  • Bibisected bugs open: keyword ‘bibisected’

    done by:
   Xisco Fauli            5
   Stéphane Guillou       4
   Ilmari Lauhakangas     1
   Timur                  1

  • all bugs tagged with ‘regression’

    • 1177(+3) bugs open of 12756(+17) total 12(+1) high prio.

      done by:
      Stéphane Guillou 4
      Xisco Fauli 4
      Eyal Rozenberg 2
      Ilmari Lauhakangas 2
      Telesto 2
      Uwe Altmann 1

  • ~Component count net * high severity regressions

    • Bug List
      Writer - 8(+1)
      Calc - 3(+0)
      LibreOffice - 1(+0)

    by OS:
    All - 8(+1)
    Linux - 2(+0)
    Mac OS X - 0(+0)
    Windows - 2(+0)

  • ~Component count net * all regressions

    • Bug List
      Writer: other - 408(+4)
      Calc - 218(+2)
      Impress - 129(-4)
      LibreOffice - 50(+0)
      Crashes - 45(+2)
      Draw - 44(+0)
      Base - 42(+0)
      Writer: docx filter - 41(+0)
      Borders - 34(+0)
      Writer: perf - 33(+2)
      UI - 32(+0)
      Writer: other filter - 31(+0)
      Printing and PDF export - 23(+0)
      RTL - 23(+0)
      Chart - 22(+0)
      BASIC - 18(+0)
      filters and storage - 16(+0)
      Writer: doc filter - 15(+0)
      graphics stack - 14(+2)
      Formula Editor - 4(+0)
      framework - 4(+0)
      Extensions - 2(+0)
      sdk - 2(+0)
      Linguistic - 1(+0)

Impressum (Legal Info) | Datenschutzerklärung (Privacy Policy)   Content on this site is licensed under a Creative Commons Attribution Share Alike 3.0 license.